From nobody Mon Dec 1 22:07:23 2025 Received: from mail-yx1-f43.google.com (mail-yx1-f43.google.com [74.125.224.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7A2A546B5 for ; Sun, 30 Nov 2025 01:09:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.224.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764464966; cv=none; b=p1Y12NvomSM5Qat/6/z3FQ7dtoARUkbLoRAn1P+puGSGh1UR3H3Q3r9EpYczmoNPXAGkk2ZdVFYL5zAVaBlRZSqn5C4sI0X8nDssR2F41qntKnCDBJlVitti48cRavnlzsyCyjYfkZQKZJyvHqtPsznxdeKoUHrTKQKsW6/zytg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764464966; c=relaxed/simple; bh=ovLM5kWRoEjqgi9GmX6Q1RuQhiftLSg2AJn+QApLwrk=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=Nz0bgcFfiqvdKhOph1H1hNjA5Mxraz387lPh3EdNBBUO3BojDCq7yXRTv8+v6q+W+WEkJaAAgI3+1tbuMF5v2e5KIvHIhdYDLDScyLknSTiB/EHssIGI7/VQ73b6DzdHABPRThK+YE5KfyCszSHr/Ft8oKYwYVK5Bkiw8ZAqkLg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=soleen.com; spf=pass smtp.mailfrom=soleen.com; dkim=pass (2048-bit key) header.d=soleen.com header.i=@soleen.com header.b=R3iQIggO; arc=none smtp.client-ip=74.125.224.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=soleen.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=soleen.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=soleen.com header.i=@soleen.com header.b="R3iQIggO" Received: by mail-yx1-f43.google.com with SMTP id 956f58d0204a3-63f9beb2730so2294745d50.0 for ; Sat, 29 Nov 2025 17:09:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=soleen.com; s=google; t=1764464963; x=1765069763; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:from:to:cc:subject:date:message-id:reply-to; bh=BvMYQXO8j67HXrkaRo9OFr9r+KnzegXxYt4q7UonkDw=; b=R3iQIggOEdSDQ5mQQngJHTXEjAtJeLjxCPdmyTWAHgVyjocXVmxs2GYhaQSa+RewG2 vEx69H2hkSg2fTVCdz1QPAhxxlulEMYKLylMr1dTU5mJtjynAVhMuDJ6RouwuImdi77f M2zNPlcL0vZigzlOvYm3O8i04BM4zs9C8xXwc94b3PWClUWvXtPLsZ8KR34FrJbTbjZ2 jZlLic9BojSuQyeX+QLQE57Ki5BDTK5zjZ1s/NSlCzF8IPJGXxjtAXeLhop0BrLqR0xU t4vmFkGgtIvqDZbhiB4nP/w/63eTf8/u4dGW0flsYO3l6kc/liMhxhlk6EWrVljqvkS0 TvQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764464963; x=1765069763; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=BvMYQXO8j67HXrkaRo9OFr9r+KnzegXxYt4q7UonkDw=; b=GcN9yXxgeNjd8oljLNfSZZsMtexXoU1djbmze37/VJqwTG0iWBFopQH4qAf6AZb81f d+MNRTAEqKMB73vsaLvHCB7rxZgkOwrnaweByy+VD06Hb1xjeTy8PPpZg4lbA2hTNlBk N364WlrHzwea/etEpcyB6tczTQJxfQk1zhbjIfrCrGQGs0Oqrt+QUU5CRyDQ6O37ClCo nn0tTK7cGQuDjuYDsKr/W/9e/YejQVLWRAMfNyr8W0f53RMcZ/bYnmn1hecq+uiUMA5B mERbh3YtDT5KSVWIZE0oGMzuu9NWNnd9wOY+YgNZZkcguHbUIC8w6WAyFDlW/HBZw8rW ANRg== X-Forwarded-Encrypted: i=1; AJvYcCVtPeyMzVLrAYEWNBuFHf8tbZj7Auu+7Am7r2q19IVck3XY0BbzMY5HT82wWN7M2G/sB+EkCkApjOjgO4M=@vger.kernel.org X-Gm-Message-State: AOJu0YymQF+Wa7e28IN66B0zLFaM1hyq3micUhKOubywVCt1OgF1hzPj s+eUsYk5FI3eg8BjorjxqgEASnYFjrdtPhlLriSRsuYmfNs3RSIa8+cnLbgBoq7YZ8A= X-Gm-Gg: ASbGncvcVnZlnHB5RNhqzv0MuSzqGq4aLO0WDcSaJzZ/MakD10YzZUdYSFGd7eD8rTP 2VOisXh79c7H1GG0zvKx+SmQAmdeHDRjj2UnJKgbcpz1BHAsOzV4tzQR/WqlXSZZm30e0PYmSSN pHqNGCDjeVuablRvVKaWSFkCuUC8Jf/c/bNWXdhlc29mCY/0pXLwDGCEVFgl5twTAEIOaw3KMek UzvkbsupKUGrjGzpCw0fGFsHZxmSfZUNAnXm1kWGDzyFqFd2GyeMhC4Yttd33IYOMsB5xkv/DPA X8ZhdcNsEv/OXIJgB2Z43VpCB1bkwiHRCWvcc8v59aGWn5NQBHXLdIVhlvOgwlBeqE2iROedXyv lj6n6iXSIICvv30OKM4+soS/dobiY8M2SBAc6gzv7eDesxSWAhfxeP/ED/ciGwD9ei0ITTv+s6k D49YJ+j2b8DXuMmvZ+fJmjs2fxciPWCOKFLd3hkLDM5a5mNBxKUVRUXfdIc3UtvGkzWi7EZodee sUO/38= X-Google-Smtp-Source: AGHT+IHhN5Il8t4t/4h+oWd043jDfj2577ge+lbbM3cGbKuTj6uQ7eWbTy3xjWmJNk7Ya9h0mT4JOQ== X-Received: by 2002:a05:690e:10d2:b0:640:caa5:57be with SMTP id 956f58d0204a3-6432924ea93mr12230340d50.28.1764464963388; Sat, 29 Nov 2025 17:09:23 -0800 (PST) Received: from soleen.c.googlers.com.com (182.221.85.34.bc.googleusercontent.com. [34.85.221.182]) by smtp.gmail.com with ESMTPSA id 00721157ae682-78ad0d5fe26sm31189847b3.18.2025.11.29.17.09.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 29 Nov 2025 17:09:23 -0800 (PST) From: Pasha Tatashin To: pratyush@kernel.org, pasha.tatashin@soleen.com, rppt@kernel.org, dmatlack@google.com, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: [PATCH] liveupdate: luo_core: fix redundant bound check in luo_ioctl() Date: Sat, 29 Nov 2025 20:09:19 -0500 Message-ID: <20251130010919.1488230-1-pasha.tatashin@soleen.com> X-Mailer: git-send-email 2.52.0.487.g5c8c507ade-goog Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The kernel test robot reported a Smatch warning: kernel/liveupdate/luo_core.c:402 luo_ioctl() warn: unsigned 'nr' is never less than zero. This occurs because 'nr' is unsigned and LIVEUPDATE_CMD_BASE is currently defined as 0, making the check (nr < LIVEUPDATE_CMD_BASE) always false. Remove the explicit lower bound check. The logic remains correct because 'nr' is unsigned; if nr is less than LIVEUPDATE_CMD_BASE, the expression (nr - LIVEUPDATE_CMD_BASE) will wrap around to a large positive value. This will inevitably be larger than ARRAY_SIZE(luo_ioctl_ops) and be caught by the upper bound check. Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202511280300.6pvBmXUS-lkp@int= el.com/ Signed-off-by: Pasha Tatashin Reviewed-by: Mike Rapoport (Microsoft) Reviewed-by: Pratyush Yadav --- kernel/liveupdate/luo_core.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/kernel/liveupdate/luo_core.c b/kernel/liveupdate/luo_core.c index 69298d82f404..7a9ef16b37d8 100644 --- a/kernel/liveupdate/luo_core.c +++ b/kernel/liveupdate/luo_core.c @@ -404,10 +404,8 @@ static long luo_ioctl(struct file *filep, unsigned int= cmd, unsigned long arg) int err; =20 nr =3D _IOC_NR(cmd); - if (nr < LIVEUPDATE_CMD_BASE || - (nr - LIVEUPDATE_CMD_BASE) >=3D ARRAY_SIZE(luo_ioctl_ops)) { + if (nr - LIVEUPDATE_CMD_BASE >=3D ARRAY_SIZE(luo_ioctl_ops)) return -EINVAL; - } =20 ucmd.ubuffer =3D (void __user *)arg; err =3D get_user(ucmd.user_size, (u32 __user *)ucmd.ubuffer); base-commit: 7d31f578f3230f3b7b33b0930b08f9afd8429817 --=20 2.52.0.487.g5c8c507ade-goog