From nobody Mon Dec 1 22:36:24 2025 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B9D06279DAF for ; Sun, 30 Nov 2025 09:40:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764495643; cv=none; b=W/aBw2dbF28sDUz/ccO32oUoEibooLJsqqOjn2zkyP9fOi2HkyuEN5iV0AZz8TET6UNUfXIBm85dvVgIswMkOI63up2fANAeUFTZ0i30mZscGEYnUHfbKJj41aB9ugfKoj6OnwselKZRszOb0M07F4K7wtjXXhQrtcWnkozHYlo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764495643; c=relaxed/simple; bh=eEqg1+phgs6U320TCn+tVWykDOf0OmnD31WG+5KyRno=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Zm2mLUKXRIG9B1JkgCuxxt3o8B0FHJ1nQepvU1+ZPOlDNqAShd9Ov3K68aiAxAexylYmfGUgMAnXEjKaihK9O0BoF7BXGT0Qrv869iYDxLPLxAMtr7egkwgALgtPxw0IZNb2zg3v2na3wbClOaHEqPK72UcF0HyFdXKRB8cL1aI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=KLTWlXug; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Oj0oqSCI; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="KLTWlXug"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Oj0oqSCI" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5AU8ClEg826457 for ; Sun, 30 Nov 2025 09:40:41 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 4si5Ku7ae0XI6lLJKtqn54PXf6TC2YJqxM/TDKjqfMk=; b=KLTWlXug2c+JRdVJ EVrxEAlQO9wPl30LMupwan8IxGoqYx+LwaI6i9jV71QZz54+q+mjRJfIirD3OGQq h9I8+3FKlWjHPI5aPqIXDWz9hRpUo4WB5UpO4mgZL4EIfs56VNVMXa6iBW+ioxQu UA36LN2QNyRsP0aNgQKLB7zvrcd3SQKGNxTr22VoKf0V7/B8pARAPVTg9GXmeeM3 Lx8Mx+ObYdbrfqlqgq5ZUyzFhPhCBSY9Q6Lou/4pjw44L6otcX9yJiJCeCCBnRwp a2GCNLLpCi4CF2MhVvmI0P/uaXRGCejD/4K6RI2mktxbuVCqwHUqM5eVt+NoDsUz vC0haQ== Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4aqphfa6xv-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 30 Nov 2025 09:40:39 +0000 (GMT) Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-8824b00ee8bso43824816d6.0 for ; Sun, 30 Nov 2025 01:40:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1764495639; x=1765100439; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=4si5Ku7ae0XI6lLJKtqn54PXf6TC2YJqxM/TDKjqfMk=; b=Oj0oqSCIZbmscV2qmICtOzH0S78UHUM3nPj9Y0KrhluAbMcqbFRhG7RhJ2q+LDhzLZ 8B8BYY582R3C8GViLgCqEcPQxgy8hSFyYd3Nc7z0wNoUG35i0ftH0NBx3zFEMq9Wx2W2 lxjzfM/OV9gWmSJh2TN8l8xoF40jrMuo3Skq3AeFUwCN2HeIGpdTruny44wQEcFtaGtP 6tr6YrTxGGY201UnTb1Y+/SrXOkfl0HaSDy6wardUs49jfCW9Xx/Lt7z0cpo2+DjDJyT eXYT2PteHLuX1S9rX4f2dXdAiNbuRTsXRzzFzHjVh9ZExmqWhDsyzA1ItRWWkRNX4OIz BHhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764495639; x=1765100439; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=4si5Ku7ae0XI6lLJKtqn54PXf6TC2YJqxM/TDKjqfMk=; b=e4oViQIlw5amD3jPzCKTNzjYgXc57x3zhm6Ija0LtBDjQqpWds6zbw0VfL+Ny28S9R +8KiorDwsiG4CDcRRcGOSurV6chRY6FCcSThFh/QlUJYE6AJt1k5cfuol/RP55Vct/4s A+SyBZHZhmgRmizCkYpS/0Pm9zdjOasKiEZaG6HxuTIPGmleWSxQt0s+JvMkZeqoPdOM KCGFCjE8PxZu/Ixfa7XG15e8B7ygRLBHLCFy6TPOXFDxgDwBZYHviuXEUFIVeE0ZJTMB T4WpmfRN7Z38iLdf1LKOlzMcqkTvag0is3hBj1A8BVIseXyCc5eA5YVYGvhsCNpfphsy c/QQ== X-Forwarded-Encrypted: i=1; AJvYcCWV8nDOL9jfVh5FB/xGwBH5Dau6ZUW2BVZNOeoSA5FDdxe4Fym6f6c9jj+1CeHjs6YmT+d7eBsJCqoZj+Y=@vger.kernel.org X-Gm-Message-State: AOJu0YzCi/9eTy/ZfhTw8Zjfa0j3cLuMJLrc0Zt0oJNqCE13KKT6jk1i IfJZqhD+b7uEIvhwPmWg76VOACu+JqIZ2vImGyjIloK29c4QZBLxPYlKneNyrb6NIDAHJh+Uwxv KQ8iTqacZKdGaj8FaCZynnAZSNhigvmSU3EDVllwyWEC7xPWW1sjWkzW3VEfeHUqVyPw= X-Gm-Gg: ASbGncsOaTAm21JVJ39tZrrX68RCJarCfcTeH3/fr32uQIVup1hgwgJ7YZnRO6yT7q9 O62OJ0y2fZxsgYm6JhZsT8CQyt5Mu6rks95pmNn8/HAf811E87ZBLzk7G56xKmLnkhBnsPEZw7A QvlFMkLMhM/ovZXsQFvSZOJGToQub2R3UkbjZb3HQK1h9GywLfknTUkOARjjlrlyXBreZf9MIs8 WAicFldigbEyyVqZkO71AE5KQfuWxUPeabfSRZCvS/Vdt89CJwtPoaySu59VPkGTS2bnKBuIZl9 PwdBSECslFQh4qUI44adw3T80HJ2qFEiLf11VRA4yROv9bo5cw7z5DsZ1oonQQbICW1eckZuHsT VqgkmCk80x7oOROebNTNO4JcvjjdlSUB1oA== X-Received: by 2002:a05:622a:610:b0:4ec:f2a4:f27e with SMTP id d75a77b69052e-4efbda904c1mr243299201cf.51.1764495638606; Sun, 30 Nov 2025 01:40:38 -0800 (PST) X-Google-Smtp-Source: AGHT+IF60NCtETdQgE0nRxSw0dPRUhYK1ejtqPUVSei/Aay4OgrxJwZwbEMFuPpbrZl9i5dHEvsHIg== X-Received: by 2002:a05:622a:610:b0:4ec:f2a4:f27e with SMTP id d75a77b69052e-4efbda904c1mr243299011cf.51.1764495638158; Sun, 30 Nov 2025 01:40:38 -0800 (PST) Received: from [127.0.1.1] ([178.197.195.159]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b76f5a4b762sm906138566b.67.2025.11.30.01.40.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 30 Nov 2025 01:40:37 -0800 (PST) From: Krzysztof Kozlowski Date: Sun, 30 Nov 2025 10:40:25 +0100 Subject: [PATCH 3/4] ASoC: qcom: Constify GPR callback response data Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251130-asoc-apr-const-v1-3-d0833f3ed423@oss.qualcomm.com> References: <20251130-asoc-apr-const-v1-0-d0833f3ed423@oss.qualcomm.com> In-Reply-To: <20251130-asoc-apr-const-v1-0-d0833f3ed423@oss.qualcomm.com> To: Bjorn Andersson , Konrad Dybcio , Srinivas Kandagatla , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org, Krzysztof Kozlowski X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=3288; i=krzysztof.kozlowski@oss.qualcomm.com; h=from:subject:message-id; bh=eEqg1+phgs6U320TCn+tVWykDOf0OmnD31WG+5KyRno=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBpLBEOqv+D1KBbZU47aPwxQ88RXdrj7WGPpsuZP YCX1fpQEBSJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaSwRDgAKCRDBN2bmhouD 10s6D/9Xwyj6W0kNcdxFFVcPlPdWVGjn1omwqAzMpUO5Zn46FsvmGSDcuZVp5slBQxLLMYLHhUG /vxGr5nCQCLDtdVSKTa8BI5fq6/3An4QgaWqSBGe63QMqRlMeOfZQ6t2YltbtDt2jLX7GtRQYJ0 q3e8CudSKiAcGBR9+nyW1EMDPeIYuCcOPtLdG8AnWTuySvuKcDPHw0DeJsf1ZwLnczY9w+ejV1k jwRQUaYPnhkA0HzQFGObEXZQIbrYvfH2/WDb2cB2agk65sB/g0RvABy0DlwclnsXVmVulzN4Awp HPbE9FjEnmNoJxS1+lyUi8VSLlTKBbUmfpNzpU1UhBEHh3ep8caTUJQWY8VHk5ejRwaBT3o/L7y g6yGA28lLVzJ3dqWiZMaBrxwXgD5M5+TuhROErxX4m3TBC64t6hHNgMCP4hRjIuF0hZqkaZWrAJ YVhTzr3mKg/273pGyrYaE3JIURg0rSXNMcN0NWq3BAttRhg4lXPVDZvxsKtcky1enDhdhar574X 8uVwmEoyyQ0StMhtdDATyTDuiL+hDkQYrgu9ll/Z/RLBOrW8N7cHTdMGPbEIRF5+QF+TB6siiHd LiAZ5XI+sS/R1Gfe4nM/Bb+F6ltC+5geYKwflZTOliRn+Y5SPrPNrtpK8GlWCklNHp/Tz5KlDH9 k7tqUQRxwomozFg== X-Developer-Key: i=krzysztof.kozlowski@oss.qualcomm.com; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B X-Proofpoint-ORIG-GUID: o2H-8HZmBou0sKMUBrtoHmFLru07jJ0Y X-Authority-Analysis: v=2.4 cv=FvwIPmrq c=1 sm=1 tr=0 ts=692c1118 cx=c_pps a=UgVkIMxJMSkC9lv97toC5g==:117 a=FPK7cjBCgYbqzSTDLBmM0Q==:17 a=IkcTkHD0fZMA:10 a=6UeiqGixMTsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=hTGvNw3IVCQ4KxXpkFYA:9 a=QEXdDO2ut3YA:10 a=1HOtulTD9v-eNWfpl4qZ:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTMwMDA4MiBTYWx0ZWRfX7BN4On3H/WCN c32T4+7ygPHbnAQlILjF3wr9P2WBaNncFAOyN2kvy5tzIU5GNqk5JTrNbaSUpvzi9KjHW0tTn4+ OaePctlLeM5Cik7MLxQ/acuiy/vC/g3fe6iohgY3cgIf8N63Mv1GQDtgruQcimTwf8ImeaTm3+f ZHymV/OChY+gtvT7zdVtfBVShI08Y0uXSRAJocgYRz2Qtuo404mwK3028wvwNIjOEpdoCYHdqlG 6v847BiINpGwq5hGkuChQ9MKmc26ecKW5lU/26PNUe1v27VKyqbAgScKJEV8AjmkUN6Krt/4Rqi DTVj0TXC2du3Y+E5H0vhdNTYwgSmdxes2UeqwJzE7PbUQUNPOpSjWgew5QtgS4TwtcrEdMLAbQ/ 0L/F2pS6DfpAm3Ipfv3Bvm56TZs6DQ== X-Proofpoint-GUID: o2H-8HZmBou0sKMUBrtoHmFLru07jJ0Y X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-28_08,2025-11-27_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 adultscore=0 bulkscore=0 phishscore=0 lowpriorityscore=0 impostorscore=0 clxscore=1015 suspectscore=0 malwarescore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2511300082 GPR bus driver calls each GPR client callback with pointer to the GPR response packet. The callbacks are not suppose to modify that response packet, so make it a pointer to const to document that expectation explicitly. Signed-off-by: Krzysztof Kozlowski --- include/linux/soc/qcom/apr.h | 2 +- sound/soc/qcom/qdsp6/q6apm.c | 8 ++++---- sound/soc/qcom/qdsp6/q6prm.c | 4 ++-- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/include/linux/soc/qcom/apr.h b/include/linux/soc/qcom/apr.h index b16530f319ad..6e1b1202e818 100644 --- a/include/linux/soc/qcom/apr.h +++ b/include/linux/soc/qcom/apr.h @@ -122,7 +122,7 @@ struct gpr_ibasic_rsp_accepted_t { #define APR_SVC_MAJOR_VERSION(v) ((v >> 16) & 0xFF) #define APR_SVC_MINOR_VERSION(v) (v & 0xFF) =20 -typedef int (*gpr_port_cb) (struct gpr_resp_pkt *d, void *priv, int op); +typedef int (*gpr_port_cb) (const struct gpr_resp_pkt *d, void *priv, int = op); struct packet_router; struct pkt_router_svc { struct device *dev; diff --git a/sound/soc/qcom/qdsp6/q6apm.c b/sound/soc/qcom/qdsp6/q6apm.c index 94cc6376a367..cec135c53b99 100644 --- a/sound/soc/qcom/qdsp6/q6apm.c +++ b/sound/soc/qcom/qdsp6/q6apm.c @@ -487,14 +487,14 @@ int q6apm_get_hw_pointer(struct q6apm_graph *graph, i= nt dir) } EXPORT_SYMBOL_GPL(q6apm_get_hw_pointer); =20 -static int graph_callback(struct gpr_resp_pkt *data, void *priv, int op) +static int graph_callback(const struct gpr_resp_pkt *data, void *priv, int= op) { struct data_cmd_rsp_rd_sh_mem_ep_data_buffer_done_v2 *rd_done; struct data_cmd_rsp_wr_sh_mem_ep_data_buffer_done_v2 *done; struct apm_cmd_rsp_shared_mem_map_regions *rsp; struct gpr_ibasic_rsp_result_t *result; struct q6apm_graph *graph =3D priv; - struct gpr_hdr *hdr =3D &data->hdr; + const struct gpr_hdr *hdr =3D &data->hdr; struct device *dev =3D graph->dev; uint32_t client_event; phys_addr_t phys; @@ -761,13 +761,13 @@ struct audioreach_module *q6apm_find_module_by_mid(st= ruct q6apm_graph *graph, ui =20 } =20 -static int apm_callback(struct gpr_resp_pkt *data, void *priv, int op) +static int apm_callback(const struct gpr_resp_pkt *data, void *priv, int o= p) { gpr_device_t *gdev =3D priv; struct q6apm *apm =3D dev_get_drvdata(&gdev->dev); struct device *dev =3D &gdev->dev; struct gpr_ibasic_rsp_result_t *result; - struct gpr_hdr *hdr =3D &data->hdr; + const struct gpr_hdr *hdr =3D &data->hdr; =20 result =3D data->payload; =20 diff --git a/sound/soc/qcom/qdsp6/q6prm.c b/sound/soc/qcom/qdsp6/q6prm.c index 0b8fad0bc832..eaec6d211cf8 100644 --- a/sound/soc/qcom/qdsp6/q6prm.c +++ b/sound/soc/qcom/qdsp6/q6prm.c @@ -175,12 +175,12 @@ int q6prm_set_lpass_clock(struct device *dev, int clk= _id, int clk_attr, int clk_ } EXPORT_SYMBOL_GPL(q6prm_set_lpass_clock); =20 -static int prm_callback(struct gpr_resp_pkt *data, void *priv, int op) +static int prm_callback(const struct gpr_resp_pkt *data, void *priv, int o= p) { gpr_device_t *gdev =3D priv; struct q6prm *prm =3D dev_get_drvdata(&gdev->dev); struct gpr_ibasic_rsp_result_t *result; - struct gpr_hdr *hdr =3D &data->hdr; + const struct gpr_hdr *hdr =3D &data->hdr; =20 switch (hdr->opcode) { case PRM_CMD_RSP_REQUEST_HW_RSC: --=20 2.48.1