From nobody Mon Dec 1 22:05:07 2025 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9991420299B for ; Sun, 30 Nov 2025 09:40:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764495640; cv=none; b=janGFla5mVJLQijryapB3R8+RAtVcHG7Sjlmw/3TFNsv5FqZAW/Jv56GiLM7YzQORmfGm/YqKbt04WKUByI1FEUaVFUNkLX2ejOHhkoMPGx+ZAyYmThIrP3/qEeBSrkvw5zGV4dfgEe1qWEWyvzhmlNwWg+ysn5RYijwZfpNOPg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764495640; c=relaxed/simple; bh=71qYYx9iftjweAunr/mwC4ZiVQAkq9eNzA9+UCd09tw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=PkWsIDsr1Vi213AQur4EgYqmFUetxo1rTAjAeK+cUCtf1q4Z+1IDujrON+0Kw3UoJdBFmAb+2OgnvOZ3FEwapoQbQINKCstCCbSKhOUE4Q1PRkZ/wiXsDBMpJBH7jFb13LrjjMSyH6s4JaMH0Arlq9vUiQV4HIGDH+9OLrEccIs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ancLKMAn; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=cPrM3Xg6; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ancLKMAn"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="cPrM3Xg6" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5AU8kTDl1621669 for ; Sun, 30 Nov 2025 09:40:37 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= z5cCY9eEkhJa7MLHEHOwqSSHSnyOf2K4oo7zMaL/Tfs=; b=ancLKMAnt0vdD1yO v+MJ5Pc5EAC9qjnQGCKZUQqD+brYYvyfW7O1SxUO+sPyNDlcXovkW2+JA69RV+dv OPnPq/IcDSR3sGz9igRZPz/kxfL+0qnZaXgqgLLc38+OsRfhbeHq4AnoS2yY6xLL llWvAEjVBZXFGz3peB9t9qWwiNgWraYJHP/6K3xVmdOJ9hK0I1iTpnlx9A5H2j/a 1tiwOGYkZyJkumoafuu9Lu46RtqcoPTMJzlyjijY9I5K3fMn+PLcdLD4Q4I2z6ST QS84xc6pG6mws6IDRkkmJbTYMOWPc+2dPGAAkJwwRywWnHMCW+JGFAxuNeQ/MzM4 Cdxvrg== Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4aqqu623j4-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 30 Nov 2025 09:40:36 +0000 (GMT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-4ee0193a239so30887671cf.0 for ; Sun, 30 Nov 2025 01:40:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1764495636; x=1765100436; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=z5cCY9eEkhJa7MLHEHOwqSSHSnyOf2K4oo7zMaL/Tfs=; b=cPrM3Xg6OAJDJ5Ey9iczdODrKvH6ik5p+WdSaXFOwv+IwcP4zvDg3XXLREQRFA+CoO 93cI+6PHmSCQ+1sGz4JMINO1ua/IMQ/vTLpPp1BQwhO/A8sTunY+qvH68oeRJx9Z5BZB pn+MDzlCGARzJs+yuyP83pwq1c7/HEyq39C6oR+VKiXQ5p/+jBf+xpqDJA8Tb173Prxs dTG3vKnPGvTcOqUR8Dg+GeSX6FJhsOHlDIs89QsO2R9kCYdf3N/ZjRsGCd3HYHstvUoV VPrqOuMgc6xSvpnak94PzxS9MPHhxXG4gQc196eHGJkW0m+zrWsA4CeXAT2wz7BYW55S QVEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764495636; x=1765100436; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=z5cCY9eEkhJa7MLHEHOwqSSHSnyOf2K4oo7zMaL/Tfs=; b=bcRAaKKhwpb4Pf4TL7pPtHx1bPWUjifropM5NLkrUozaHwdvlwcBzXfrdgLq1JdWPl aZWmQb4Fgfvs+esL73o2F2mg/bn9KG12SAV07cDzsAECr1SIZza1j5wegVNUOnAi+Lhu YLohZHr9i9Yrd3UWK4iSw6cW4sJvjEP3y+h4Ecr0CZ2+4TfuKvS45riNPfvplU/T1lma bc4GdvGJjX0jPooR+/7/nULRXL+OO4MoZTXv4ASCzphL8qxL7Merz9tbAJQAjXm4WPWn MrmCSTKkfK/eQbEMiwodrEsUhdC4HLeM75sB4SnWiF2brFrX7doakGXvpU+97hWfbOeV cmfg== X-Forwarded-Encrypted: i=1; AJvYcCWHCKCvGOOt0DqaM47roLLcqWDEmvNImgSI0WSXWPVNnSUnumXYcjckM9fV0hXXgwPih9+krg9FwJLBjX0=@vger.kernel.org X-Gm-Message-State: AOJu0YwGyWVYi9leiXttpeo//E00DM+YDL7jOvEAH8jt9epudVxNQGsD tFKGaFipd7R1/9hE4dZYq8q/pV9GBlvt1ROXO8s6afOTEgfP6DOTvnQD9NwsdvMhK2aFX0hvxDL oc2b3nYorNK+CsiJB82pgdnvjJLIgxNa5zI3KnC2mMCpmniO9YQ09mhuyHWh3XSJ1gbbJGcNvxB w= X-Gm-Gg: ASbGncufmA9KHJ5ywHvsSlLbw2UtESjQjI1W/VrenHcdKpcsdg008VdxRN8ksTwoizk 0KBKgSPiUlegGso0nH6vweK4UHfIPybscBf5Afshi5nYqvnHC6/bg2pz8LYs1LA505sUnoxZz10 oPmB7+QHATjS/htTw7/NRhDuE+r8t58Gm5oL6naZ7kGG6V0wtBG8HmQn0K2lAo8aBAiiZFQ6zNk mymm+mEB8L1YSQgFGC2E6jpfuD87KMKO3Z7HHJ02aO6dbKh9XMY8m5NrhNcumJj/ZQE6wQ5ZFpw Oq+ktqV2NNYciFRKp8gTElD33wXKBFFA/yTNt73C/vmOljyD7eewuc6NE+sZfbLGH+lVwsFnIz4 bQtwDmxN6ZBKI4bL0nvXVkG6kxLaIwabNPQ== X-Received: by 2002:ac8:7fcf:0:b0:4ee:1dd0:5a40 with SMTP id d75a77b69052e-4efbdac30aamr270523051cf.59.1764495635679; Sun, 30 Nov 2025 01:40:35 -0800 (PST) X-Google-Smtp-Source: AGHT+IFB4mK9aqraUDpV9Vr481X5jKFhwQmW11TyEdvN8SijZD0eSdS30c/qQBsenHcdrIqr2FT6qQ== X-Received: by 2002:ac8:7fcf:0:b0:4ee:1dd0:5a40 with SMTP id d75a77b69052e-4efbdac30aamr270522851cf.59.1764495635238; Sun, 30 Nov 2025 01:40:35 -0800 (PST) Received: from [127.0.1.1] ([178.197.195.159]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b76f5a4b762sm906138566b.67.2025.11.30.01.40.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 30 Nov 2025 01:40:34 -0800 (PST) From: Krzysztof Kozlowski Date: Sun, 30 Nov 2025 10:40:23 +0100 Subject: [PATCH 1/4] ASoC: qcom: Constify APR callback response data Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251130-asoc-apr-const-v1-1-d0833f3ed423@oss.qualcomm.com> References: <20251130-asoc-apr-const-v1-0-d0833f3ed423@oss.qualcomm.com> In-Reply-To: <20251130-asoc-apr-const-v1-0-d0833f3ed423@oss.qualcomm.com> To: Bjorn Andersson , Konrad Dybcio , Srinivas Kandagatla , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org, Krzysztof Kozlowski X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=4542; i=krzysztof.kozlowski@oss.qualcomm.com; h=from:subject:message-id; bh=71qYYx9iftjweAunr/mwC4ZiVQAkq9eNzA9+UCd09tw=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBpLBEMiGJ1Nmqt4k4gxB2UaLE5/7py1Q36a3ZDO r+HNYrOwzGJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaSwRDAAKCRDBN2bmhouD 1+okD/46HW29ESF7881WXrPKr/Wlcs67Xztj/6UBWpwaJUXNV1K/vgkPVPgui4oOEndnwY8nWQe M7XLCDtQEk15EIVHNaFMgYHC/cBn0C7bgawIJ1tbuUquSSf0diMa1NZ4HFTsk0sUuozDt64f8iQ +TQWS1stEN4c0tXmYxgQJbFctuToHNre7UsK3gEMcLReqmShMVfSlIRFasSj1Mkps9FK7RaiQo0 EWq7Lzc7WrOx48Xu3ViOI6TAmENcdymVzcN6WVjIJHfJncR4nNmLsYG8SoClR34l3M2UqFAoGQU AHg04erbO7MaySDk56SQyavrXC6RONBRKQw+tgId335J9ky8pAUkxoNK4fjz9rjtDweLioeJg3V R+OVqRe8/GuaSI3PC0hFXVzq2ceBcGojUMIMVytbI2LLWRIBkTtaPxZBPhBpcDzJr9zN4izBp/l 2QS9H4BnA3HL0Pk/pv5Afwf2tPlz9D+Y79ZSAK4em27APKpdKaygCE2+WpzR25nayc2nSLCArEL W+WnWOUsB9EZEs7FmNYFlDKBVL9KrBceWjgo2AyLowe734SAekxwUVIjHuGkE3SGXcQBF8nOlhM lsBQqWW5o8+WRbRcS0wZ7OpWbt/790JjsQdUCC8R2MPAgM1dCEwp1VYyGev/2BD1L0dF020kQ0Q 3NFN6+7x7NuzsgQ== X-Developer-Key: i=krzysztof.kozlowski@oss.qualcomm.com; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B X-Proofpoint-GUID: quoYRBkGHoeTjCi2fokDLYCaoCR89BER X-Authority-Analysis: v=2.4 cv=CM0nnBrD c=1 sm=1 tr=0 ts=692c1115 cx=c_pps a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=FPK7cjBCgYbqzSTDLBmM0Q==:17 a=IkcTkHD0fZMA:10 a=6UeiqGixMTsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=lBgNFb7N2acfZoSAgXgA:9 a=QEXdDO2ut3YA:10 a=dawVfQjAaf238kedN5IG:22 X-Proofpoint-ORIG-GUID: quoYRBkGHoeTjCi2fokDLYCaoCR89BER X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTMwMDA4MiBTYWx0ZWRfX0m5J5bE9gRau bbyWZy5cOWHJJCv2TlV/rMs6WOfqaMl43e95pJYqzEFqT2diS5SzYmTthgNvlyELmMOlOLGSmak K1f0bcTRtZDtHDZQuzinEqyVNu2pIKCDea/4bZLJGVskTdb078f4udu44/B7w6cCIt9z5LD96WG 0kaWqpNmaa5KcAn1xcHjGysuPSCJaVs8KY/U43r/vn3QH3kMoeHRPk8d2QocxosvtScXhOr5PYP ji2txSP1k/UvhmcbKuBT8hf/9di/uMeU3YFuQuAOtlFj3W2oXt1uAzPpKcQrNRr6ARvz3XaONQv EuAgMlCrdEmlApFv0jZnBKaaLtXv9pnSiTcvZVfcxL4T4+v/8o+48Xqrs7OQmeZOFwYbChmh5iS VLPw0n/iiusipjoJI5fRuTeycBwkQw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-28_08,2025-11-27_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 suspectscore=0 clxscore=1015 phishscore=0 priorityscore=1501 bulkscore=0 spamscore=0 adultscore=0 lowpriorityscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2511300082 APR bus driver calls each APR client callback with pointer to the APR response packet. The callbacks are not suppose to modify that response packet, so make it a pointer to const to document that expectation explicitly. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Srinivas Kandagatla --- include/linux/soc/qcom/apr.h | 2 +- sound/soc/qcom/qdsp6/q6adm.c | 4 ++-- sound/soc/qcom/qdsp6/q6afe.c | 4 ++-- sound/soc/qcom/qdsp6/q6asm.c | 8 ++++---- sound/soc/qcom/qdsp6/q6core.c | 4 ++-- 5 files changed, 11 insertions(+), 11 deletions(-) diff --git a/include/linux/soc/qcom/apr.h b/include/linux/soc/qcom/apr.h index a532d1e4b1f4..35f44cd868cb 100644 --- a/include/linux/soc/qcom/apr.h +++ b/include/linux/soc/qcom/apr.h @@ -155,7 +155,7 @@ struct apr_driver { int (*probe)(struct apr_device *sl); void (*remove)(struct apr_device *sl); int (*callback)(struct apr_device *a, - struct apr_resp_pkt *d); + const struct apr_resp_pkt *d); int (*gpr_callback)(struct gpr_resp_pkt *d, void *data, int op); struct device_driver driver; const struct apr_device_id *id_table; diff --git a/sound/soc/qcom/qdsp6/q6adm.c b/sound/soc/qcom/qdsp6/q6adm.c index 0b8d06ec8b26..608ca0e41539 100644 --- a/sound/soc/qcom/qdsp6/q6adm.c +++ b/sound/soc/qcom/qdsp6/q6adm.c @@ -186,11 +186,11 @@ static void q6adm_free_copp(struct kref *ref) kfree(c); } =20 -static int q6adm_callback(struct apr_device *adev, struct apr_resp_pkt *da= ta) +static int q6adm_callback(struct apr_device *adev, const struct apr_resp_p= kt *data) { struct aprv2_ibasic_rsp_result_t *result =3D data->payload; int port_idx, copp_idx; - struct apr_hdr *hdr =3D &data->hdr; + const struct apr_hdr *hdr =3D &data->hdr; struct q6copp *copp; struct q6adm *adm =3D dev_get_drvdata(&adev->dev); =20 diff --git a/sound/soc/qcom/qdsp6/q6afe.c b/sound/soc/qcom/qdsp6/q6afe.c index 980851a12976..4f9f9a7277df 100644 --- a/sound/soc/qcom/qdsp6/q6afe.c +++ b/sound/soc/qcom/qdsp6/q6afe.c @@ -958,11 +958,11 @@ static struct q6afe_port *q6afe_find_port(struct q6af= e *afe, int token) return ret; } =20 -static int q6afe_callback(struct apr_device *adev, struct apr_resp_pkt *da= ta) +static int q6afe_callback(struct apr_device *adev, const struct apr_resp_p= kt *data) { struct q6afe *afe =3D dev_get_drvdata(&adev->dev); struct aprv2_ibasic_rsp_result_t *res; - struct apr_hdr *hdr =3D &data->hdr; + const struct apr_hdr *hdr =3D &data->hdr; struct q6afe_port *port; =20 if (!data->payload_size) diff --git a/sound/soc/qcom/qdsp6/q6asm.c b/sound/soc/qcom/qdsp6/q6asm.c index e7295b7b2461..df183b7a4019 100644 --- a/sound/soc/qcom/qdsp6/q6asm.c +++ b/sound/soc/qcom/qdsp6/q6asm.c @@ -599,12 +599,12 @@ int q6asm_get_hw_pointer(struct audio_client *ac, uns= igned int dir) EXPORT_SYMBOL_GPL(q6asm_get_hw_pointer); =20 static int32_t q6asm_stream_callback(struct apr_device *adev, - struct apr_resp_pkt *data, + const struct apr_resp_pkt *data, int session_id) { struct q6asm *q6asm =3D dev_get_drvdata(&adev->dev); struct aprv2_ibasic_rsp_result_t *result; - struct apr_hdr *hdr =3D &data->hdr; + const struct apr_hdr *hdr =3D &data->hdr; struct audio_port_data *port; struct audio_client *ac; uint32_t client_event =3D 0; @@ -744,13 +744,13 @@ static int32_t q6asm_stream_callback(struct apr_devic= e *adev, } =20 static int q6asm_srvc_callback(struct apr_device *adev, - struct apr_resp_pkt *data) + const struct apr_resp_pkt *data) { struct q6asm *q6asm =3D dev_get_drvdata(&adev->dev); struct aprv2_ibasic_rsp_result_t *result; struct audio_port_data *port; struct audio_client *ac =3D NULL; - struct apr_hdr *hdr =3D &data->hdr; + const struct apr_hdr *hdr =3D &data->hdr; struct q6asm *a; uint32_t sid =3D 0; uint32_t dir =3D 0; diff --git a/sound/soc/qcom/qdsp6/q6core.c b/sound/soc/qcom/qdsp6/q6core.c index 49cfb32cd209..51398199bff3 100644 --- a/sound/soc/qcom/qdsp6/q6core.c +++ b/sound/soc/qcom/qdsp6/q6core.c @@ -67,11 +67,11 @@ struct q6core { =20 static struct q6core *g_core; =20 -static int q6core_callback(struct apr_device *adev, struct apr_resp_pkt *d= ata) +static int q6core_callback(struct apr_device *adev, const struct apr_resp_= pkt *data) { struct q6core *core =3D dev_get_drvdata(&adev->dev); struct aprv2_ibasic_rsp_result_t *result; - struct apr_hdr *hdr =3D &data->hdr; + const struct apr_hdr *hdr =3D &data->hdr; =20 result =3D data->payload; switch (hdr->opcode) { --=20 2.48.1 From nobody Mon Dec 1 22:05:07 2025 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4957B274670 for ; Sun, 30 Nov 2025 09:40:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764495640; cv=none; b=gh0J8XtuQ5qdnbFB680MQF3Y31YXoAc4ZmvEUiVaQVib6wtbdnVNGgBkx/gMDnGXXh73aViHAAd5k7LnxuTBp3LWk+MYLHPVBknlPa5K2lRe5vI3yga1YK3Sq/f5DV9xnIvAY6G2+gitsIVIym/sSeavJ86GG9UUPQTJ4uClkq8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764495640; c=relaxed/simple; bh=3SP29oS4WDD9fql2RqVg08mXVFrMPmzg+PDsaDzu2MI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=FsZaUrsRGP1M5wJunmXy40R1H9/qo/b7mFS9Da7CSOQlwHKQnkEQUA/g5ULhoTca4ZawiBuKLXbnc+jh2qPwaCytiH2fmR4pEJ74h8lict69GZkfrGRMTPenEJsq7pvOegpkk8nf4qYHzwXJ0sswrrkBpg7zEuFMq1msJkvleV4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=VRYrWvjl; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Ri2eMI6O; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="VRYrWvjl"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Ri2eMI6O" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5AU6gYbE961093 for ; Sun, 30 Nov 2025 09:40:38 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 7LnLy7DgaQbYcB14XlWIt8iqM2VKNEwOxt8kaomKApw=; b=VRYrWvjlTURApKWS HNlXf2iJ76zSGPrJ4ppwkhfAeEnZGwhFSPGXdFmxobYWO/t8xaFpNnoaRid3RFfV Wz78C31VrwyHxeYg6M7/obfqjjBpxV6bGCJz1zNyFPkAIGTETG9ICoQYTpfUE/L3 qdFeLIm+6KgXIrDbG9inDjbvysdjrRtwD7SiNCm2c73DjjpSZK3mfJcrnsFd/LQw Zh8oEpPHvzcSQFzgFUMOVikY0gQ0UWDwTUSTaXuSbIwVIDjYyrIFtsrM+93eXpt8 MIZIOIMNYGckSgFnlTLLskSr6cmt3NuAFt7CuPczzPbNFatDnXemFsVj28IqaR37 5zs/6w== Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4aqyw5hda1-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 30 Nov 2025 09:40:37 +0000 (GMT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-4ed74ab4172so65241601cf.1 for ; Sun, 30 Nov 2025 01:40:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1764495637; x=1765100437; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=7LnLy7DgaQbYcB14XlWIt8iqM2VKNEwOxt8kaomKApw=; b=Ri2eMI6OZt2Ylmk+LT8rCS/PP5O2bGvK17xtRkYpcCIKVzFxtoFm/VdL4lzr4QJEfN /irxoIXpKOi7XNmOweqKhA/TUQSOglHtfC9/8F4zAXXu/5Sqdj2YWkjd2fB4CEaVu0co muk11kFjCqXt4iacOYKUOa/J3jzlfRUgewwsunlT/fKjG6HZju3EYyvI4hRiF6dWt1Je iTjiEbL55nYk28HeUZlhn5ckvgnc6rcVtGSkkp3UMSwULJGeH2E7I26uFxq88w0xiMjA CsV74Hpp3GjhS6o833vxSfTJSlT4uOEoqfHvfGGtD+WJll2C6v4ghwssOFqop5OWC1bd DXow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764495637; x=1765100437; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=7LnLy7DgaQbYcB14XlWIt8iqM2VKNEwOxt8kaomKApw=; b=vbPRGDQDLVWwNLhNUu74DDAeQhfTbrNcIChKeTddwdTiZHLa7t/uihZtKCQrnOVL2T /3vXaOWXV/tURjFBAWoI+ayRn8XKfUgyAe8Np8CjQstqhO+7dtbc6voxS251C5nubbg5 yN+YFbaNfcTsVgPtFepeZo6y9oPtC2d8e//t6d0lsU6gq35J/SOkiAQg0650NzRZwE2E ELHojF2NfiymgYeojZFn8yYLH2ecFy0JPkqRQoIimRju/6Se/eP6+/YxKIhSqGvW61td tD+LtUM61WBj8ylIzdCNHyVaVfQvqQlWmfxh9XjnxTvnUbEmd7FsjRs8O1OsFzraCLQD Jz0g== X-Forwarded-Encrypted: i=1; AJvYcCXdXvtuJPPXPe5DK299FRKbA7+/RoIDORnBL7fN9NY/1971K2GhjRvUnqZ4/Fvc0SXKuvLbY8nSDrgrB7c=@vger.kernel.org X-Gm-Message-State: AOJu0YylHRGRK+sXjk7kN/g9GUXj+WshUOYoR5tIXXZcKxE+fO9Wyjcz uanjbzkmco8rvlevaJ83JAXk6VuTemzSAB6by+bkDJ+tmHHYPGQoaTc1dvwG5qQl9TZltS3nTKU fYLviI0Es3r3Lhejqq50yiy7REIeMPzqSnm/Po2yfT6jlYCHhYWpxtE+uY5hyPz3TwL4= X-Gm-Gg: ASbGncvN5v1i3zFYWa5/R8ktRPkpHD7RF8eIdVHoqGhsCKuKCstl3AVRhuM3iQWH9wR rSGzJdE7GWQqcMetAMMyC6ZrbnuUmlZxpDMtsuYRaSECSQR3YaRazpS5YSxDSUYnVuvAwaDmh1C Ipar6pL7RjL4HQ/ddNgbfVnReWK2pR0PdB8cgs5UOwL1QYMBdFqzJx8p2tuozyM88VH1Y96dt5y w7KeBO8yKPziJ3AtnqlqOPDEQz8df8Hf3JFqEPhlzYPKRX7qv6yj0ePDp+4a0OvwJN6miuz9fWL A8+KL0/it00vqoJPJzNLNckGSojqb4AxZC4NURBRtpETSeASc5aC3bdn8T9xWATPx9fxY/DJ0/b iM/Cs9nXKrcmvS63oZQCx16xhYVR6a2r9QQ== X-Received: by 2002:a05:622a:490:b0:4ec:f2e1:483 with SMTP id d75a77b69052e-4ee5885307bmr454692101cf.26.1764495637107; Sun, 30 Nov 2025 01:40:37 -0800 (PST) X-Google-Smtp-Source: AGHT+IGxyl6ul8hGLNkm5K4ji7Epc07PbFSUjOMoJrnx4mzvE8PTssTpF3yFzOwFmyhK7jQRbnRzwQ== X-Received: by 2002:a05:622a:490:b0:4ec:f2e1:483 with SMTP id d75a77b69052e-4ee5885307bmr454691931cf.26.1764495636742; Sun, 30 Nov 2025 01:40:36 -0800 (PST) Received: from [127.0.1.1] ([178.197.195.159]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b76f5a4b762sm906138566b.67.2025.11.30.01.40.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 30 Nov 2025 01:40:36 -0800 (PST) From: Krzysztof Kozlowski Date: Sun, 30 Nov 2025 10:40:24 +0100 Subject: [PATCH 2/4] soc: qcom: apr: Use typedef for GPR callback member Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251130-asoc-apr-const-v1-2-d0833f3ed423@oss.qualcomm.com> References: <20251130-asoc-apr-const-v1-0-d0833f3ed423@oss.qualcomm.com> In-Reply-To: <20251130-asoc-apr-const-v1-0-d0833f3ed423@oss.qualcomm.com> To: Bjorn Andersson , Konrad Dybcio , Srinivas Kandagatla , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org, Krzysztof Kozlowski X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=911; i=krzysztof.kozlowski@oss.qualcomm.com; h=from:subject:message-id; bh=3SP29oS4WDD9fql2RqVg08mXVFrMPmzg+PDsaDzu2MI=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBpLBENFRpwTHSWqrCXitu7VBoDta9BiZfGEuSf3 wqMzp5MaDuJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaSwRDQAKCRDBN2bmhouD 16s7EACDqbcFfFMBVP/uMq12w2Cmtdt+a+7wJZKGJrR9DNYlxCgKpnRmugIcbyLDeDhq4wCfUKp sWfoPh3JFDRyYQfLGXWIalr4sz/dFrHYZbi06EC9M3qfyyKBEahoUxXJ+mODvjtHuQND2ukxj8J g52pG1YWj0JvazGah+ZmVUaFIrzK2utNqeajXwpzOwFtM7dpp61YAolDLIOAWXh0YkWzFWjAHhL 72hQAphAoiEpd/t4MRT1mrLjiUa/Wp7dQKiL08Z7Bj3BWHE4j+J9FJBnpROvirnRqJEJoR+f/AX BhzXgbZbFhl/qx9i/bXpu7n82m8/weBqs2bAJ+v4M5wcJyy5tZ6DhVayYTBTEDlazvTUD1G1PWC wRNbYRReTGhhuFCoKezyoZ7PKXACFmFBBD6Q06bxb3EXmmOefJuYijMRF9tbfFrNoxesgs+wKXI JQO28v6cCoaKYoHVeE1z+0hG6Vgyw9y4s3AkcJLFkq4EzN4uSox3jZYe/Qh/rtIf1lZJoXeGV7L Bad1U/QFpiLxlF6yrdnwZvFxHdeCCmKy9/MbHwbQPWOCVVft9A6SfNLm45FBTHy0Wig4EUOQ3Ex B7sZpMPM/C0myUoGhce8P43p5R6m1RGBTWjwFUh4GEqP13mIDh8aAIIYLoj+jEZzbvUZVys2GDY UHw+QlpEGFtkilA== X-Developer-Key: i=krzysztof.kozlowski@oss.qualcomm.com; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B X-Proofpoint-ORIG-GUID: xAahX6VpTg33FqeV9T0ZkB7EuVlCzntm X-Proofpoint-GUID: xAahX6VpTg33FqeV9T0ZkB7EuVlCzntm X-Authority-Analysis: v=2.4 cv=SoKdKfO0 c=1 sm=1 tr=0 ts=692c1116 cx=c_pps a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=FPK7cjBCgYbqzSTDLBmM0Q==:17 a=IkcTkHD0fZMA:10 a=6UeiqGixMTsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=MtUmYHKpnGPUIE9OMiMA:9 a=QEXdDO2ut3YA:10 a=dawVfQjAaf238kedN5IG:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTMwMDA4MiBTYWx0ZWRfX953p6JN2V+im dXjbOzXpBhDR1JPMIvEk+9aQ8c79lreUJ3IwozFpsLyu8DWzYnWrCJtl3ERX+Ac0U1vcXcTP2Tw JW5jmE1iz7HTYxOkMAs262hwU3Zfh3aHMLf2Ac49VWS/Bn6KlPUehTB9G0cg1h53Yjh+76yGB9P 6DktOJ/5IawX89WjXGqrMvO42NYx7Gqoehs8gkNN4l+coJeNN8tQ+CDkK40PplPxUbYLR7af7e1 4b5Yk1XLSrfe9w4WojitBkiIZLpSspikVEzNU6n+y6rfXgNmcSx7VFVf39RYDGHbMJpdOcwrGJR EA8bEXdnjPD3z9Fm1wKgc3gI8efuT6vs5F3FTk35UwEdOWhsghmB3AqrCPOAhqra49J/ewyC1HM kzdA6Lk5ejZxbP47ZsxYlTOEpFYe4A== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-28_08,2025-11-27_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 malwarescore=0 bulkscore=0 lowpriorityscore=0 adultscore=0 phishscore=0 priorityscore=1501 suspectscore=0 impostorscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2511300082 There is already a typedef for GPR callback used in 'struct pkt_router_svc', so use it also in 'struct apr_driver', because it is the same type - one is assigned to another in apr_device_probe(). Signed-off-by: Krzysztof Kozlowski Reviewed-by: Srinivas Kandagatla --- include/linux/soc/qcom/apr.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/soc/qcom/apr.h b/include/linux/soc/qcom/apr.h index 35f44cd868cb..b16530f319ad 100644 --- a/include/linux/soc/qcom/apr.h +++ b/include/linux/soc/qcom/apr.h @@ -156,7 +156,7 @@ struct apr_driver { void (*remove)(struct apr_device *sl); int (*callback)(struct apr_device *a, const struct apr_resp_pkt *d); - int (*gpr_callback)(struct gpr_resp_pkt *d, void *data, int op); + gpr_port_cb gpr_callback; struct device_driver driver; const struct apr_device_id *id_table; }; --=20 2.48.1 From nobody Mon Dec 1 22:05:07 2025 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B9D06279DAF for ; Sun, 30 Nov 2025 09:40:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764495643; cv=none; b=W/aBw2dbF28sDUz/ccO32oUoEibooLJsqqOjn2zkyP9fOi2HkyuEN5iV0AZz8TET6UNUfXIBm85dvVgIswMkOI63up2fANAeUFTZ0i30mZscGEYnUHfbKJj41aB9ugfKoj6OnwselKZRszOb0M07F4K7wtjXXhQrtcWnkozHYlo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764495643; c=relaxed/simple; bh=eEqg1+phgs6U320TCn+tVWykDOf0OmnD31WG+5KyRno=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Zm2mLUKXRIG9B1JkgCuxxt3o8B0FHJ1nQepvU1+ZPOlDNqAShd9Ov3K68aiAxAexylYmfGUgMAnXEjKaihK9O0BoF7BXGT0Qrv869iYDxLPLxAMtr7egkwgALgtPxw0IZNb2zg3v2na3wbClOaHEqPK72UcF0HyFdXKRB8cL1aI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=KLTWlXug; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Oj0oqSCI; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="KLTWlXug"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Oj0oqSCI" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5AU8ClEg826457 for ; Sun, 30 Nov 2025 09:40:41 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 4si5Ku7ae0XI6lLJKtqn54PXf6TC2YJqxM/TDKjqfMk=; b=KLTWlXug2c+JRdVJ EVrxEAlQO9wPl30LMupwan8IxGoqYx+LwaI6i9jV71QZz54+q+mjRJfIirD3OGQq h9I8+3FKlWjHPI5aPqIXDWz9hRpUo4WB5UpO4mgZL4EIfs56VNVMXa6iBW+ioxQu UA36LN2QNyRsP0aNgQKLB7zvrcd3SQKGNxTr22VoKf0V7/B8pARAPVTg9GXmeeM3 Lx8Mx+ObYdbrfqlqgq5ZUyzFhPhCBSY9Q6Lou/4pjw44L6otcX9yJiJCeCCBnRwp a2GCNLLpCi4CF2MhVvmI0P/uaXRGCejD/4K6RI2mktxbuVCqwHUqM5eVt+NoDsUz vC0haQ== Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4aqphfa6xv-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 30 Nov 2025 09:40:39 +0000 (GMT) Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-8824b00ee8bso43824816d6.0 for ; Sun, 30 Nov 2025 01:40:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1764495639; x=1765100439; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=4si5Ku7ae0XI6lLJKtqn54PXf6TC2YJqxM/TDKjqfMk=; b=Oj0oqSCIZbmscV2qmICtOzH0S78UHUM3nPj9Y0KrhluAbMcqbFRhG7RhJ2q+LDhzLZ 8B8BYY582R3C8GViLgCqEcPQxgy8hSFyYd3Nc7z0wNoUG35i0ftH0NBx3zFEMq9Wx2W2 lxjzfM/OV9gWmSJh2TN8l8xoF40jrMuo3Skq3AeFUwCN2HeIGpdTruny44wQEcFtaGtP 6tr6YrTxGGY201UnTb1Y+/SrXOkfl0HaSDy6wardUs49jfCW9Xx/Lt7z0cpo2+DjDJyT eXYT2PteHLuX1S9rX4f2dXdAiNbuRTsXRzzFzHjVh9ZExmqWhDsyzA1ItRWWkRNX4OIz BHhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764495639; x=1765100439; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=4si5Ku7ae0XI6lLJKtqn54PXf6TC2YJqxM/TDKjqfMk=; b=e4oViQIlw5amD3jPzCKTNzjYgXc57x3zhm6Ija0LtBDjQqpWds6zbw0VfL+Ny28S9R +8KiorDwsiG4CDcRRcGOSurV6chRY6FCcSThFh/QlUJYE6AJt1k5cfuol/RP55Vct/4s A+SyBZHZhmgRmizCkYpS/0Pm9zdjOasKiEZaG6HxuTIPGmleWSxQt0s+JvMkZeqoPdOM KCGFCjE8PxZu/Ixfa7XG15e8B7ygRLBHLCFy6TPOXFDxgDwBZYHviuXEUFIVeE0ZJTMB T4WpmfRN7Z38iLdf1LKOlzMcqkTvag0is3hBj1A8BVIseXyCc5eA5YVYGvhsCNpfphsy c/QQ== X-Forwarded-Encrypted: i=1; AJvYcCWV8nDOL9jfVh5FB/xGwBH5Dau6ZUW2BVZNOeoSA5FDdxe4Fym6f6c9jj+1CeHjs6YmT+d7eBsJCqoZj+Y=@vger.kernel.org X-Gm-Message-State: AOJu0YzCi/9eTy/ZfhTw8Zjfa0j3cLuMJLrc0Zt0oJNqCE13KKT6jk1i IfJZqhD+b7uEIvhwPmWg76VOACu+JqIZ2vImGyjIloK29c4QZBLxPYlKneNyrb6NIDAHJh+Uwxv KQ8iTqacZKdGaj8FaCZynnAZSNhigvmSU3EDVllwyWEC7xPWW1sjWkzW3VEfeHUqVyPw= X-Gm-Gg: ASbGncsOaTAm21JVJ39tZrrX68RCJarCfcTeH3/fr32uQIVup1hgwgJ7YZnRO6yT7q9 O62OJ0y2fZxsgYm6JhZsT8CQyt5Mu6rks95pmNn8/HAf811E87ZBLzk7G56xKmLnkhBnsPEZw7A QvlFMkLMhM/ovZXsQFvSZOJGToQub2R3UkbjZb3HQK1h9GywLfknTUkOARjjlrlyXBreZf9MIs8 WAicFldigbEyyVqZkO71AE5KQfuWxUPeabfSRZCvS/Vdt89CJwtPoaySu59VPkGTS2bnKBuIZl9 PwdBSECslFQh4qUI44adw3T80HJ2qFEiLf11VRA4yROv9bo5cw7z5DsZ1oonQQbICW1eckZuHsT VqgkmCk80x7oOROebNTNO4JcvjjdlSUB1oA== X-Received: by 2002:a05:622a:610:b0:4ec:f2a4:f27e with SMTP id d75a77b69052e-4efbda904c1mr243299201cf.51.1764495638606; Sun, 30 Nov 2025 01:40:38 -0800 (PST) X-Google-Smtp-Source: AGHT+IF60NCtETdQgE0nRxSw0dPRUhYK1ejtqPUVSei/Aay4OgrxJwZwbEMFuPpbrZl9i5dHEvsHIg== X-Received: by 2002:a05:622a:610:b0:4ec:f2a4:f27e with SMTP id d75a77b69052e-4efbda904c1mr243299011cf.51.1764495638158; Sun, 30 Nov 2025 01:40:38 -0800 (PST) Received: from [127.0.1.1] ([178.197.195.159]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b76f5a4b762sm906138566b.67.2025.11.30.01.40.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 30 Nov 2025 01:40:37 -0800 (PST) From: Krzysztof Kozlowski Date: Sun, 30 Nov 2025 10:40:25 +0100 Subject: [PATCH 3/4] ASoC: qcom: Constify GPR callback response data Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251130-asoc-apr-const-v1-3-d0833f3ed423@oss.qualcomm.com> References: <20251130-asoc-apr-const-v1-0-d0833f3ed423@oss.qualcomm.com> In-Reply-To: <20251130-asoc-apr-const-v1-0-d0833f3ed423@oss.qualcomm.com> To: Bjorn Andersson , Konrad Dybcio , Srinivas Kandagatla , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org, Krzysztof Kozlowski X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=3288; i=krzysztof.kozlowski@oss.qualcomm.com; h=from:subject:message-id; bh=eEqg1+phgs6U320TCn+tVWykDOf0OmnD31WG+5KyRno=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBpLBEOqv+D1KBbZU47aPwxQ88RXdrj7WGPpsuZP YCX1fpQEBSJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaSwRDgAKCRDBN2bmhouD 10s6D/9Xwyj6W0kNcdxFFVcPlPdWVGjn1omwqAzMpUO5Zn46FsvmGSDcuZVp5slBQxLLMYLHhUG /vxGr5nCQCLDtdVSKTa8BI5fq6/3An4QgaWqSBGe63QMqRlMeOfZQ6t2YltbtDt2jLX7GtRQYJ0 q3e8CudSKiAcGBR9+nyW1EMDPeIYuCcOPtLdG8AnWTuySvuKcDPHw0DeJsf1ZwLnczY9w+ejV1k jwRQUaYPnhkA0HzQFGObEXZQIbrYvfH2/WDb2cB2agk65sB/g0RvABy0DlwclnsXVmVulzN4Awp HPbE9FjEnmNoJxS1+lyUi8VSLlTKBbUmfpNzpU1UhBEHh3ep8caTUJQWY8VHk5ejRwaBT3o/L7y g6yGA28lLVzJ3dqWiZMaBrxwXgD5M5+TuhROErxX4m3TBC64t6hHNgMCP4hRjIuF0hZqkaZWrAJ YVhTzr3mKg/273pGyrYaE3JIURg0rSXNMcN0NWq3BAttRhg4lXPVDZvxsKtcky1enDhdhar574X 8uVwmEoyyQ0StMhtdDATyTDuiL+hDkQYrgu9ll/Z/RLBOrW8N7cHTdMGPbEIRF5+QF+TB6siiHd LiAZ5XI+sS/R1Gfe4nM/Bb+F6ltC+5geYKwflZTOliRn+Y5SPrPNrtpK8GlWCklNHp/Tz5KlDH9 k7tqUQRxwomozFg== X-Developer-Key: i=krzysztof.kozlowski@oss.qualcomm.com; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B X-Proofpoint-ORIG-GUID: o2H-8HZmBou0sKMUBrtoHmFLru07jJ0Y X-Authority-Analysis: v=2.4 cv=FvwIPmrq c=1 sm=1 tr=0 ts=692c1118 cx=c_pps a=UgVkIMxJMSkC9lv97toC5g==:117 a=FPK7cjBCgYbqzSTDLBmM0Q==:17 a=IkcTkHD0fZMA:10 a=6UeiqGixMTsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=hTGvNw3IVCQ4KxXpkFYA:9 a=QEXdDO2ut3YA:10 a=1HOtulTD9v-eNWfpl4qZ:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTMwMDA4MiBTYWx0ZWRfX7BN4On3H/WCN c32T4+7ygPHbnAQlILjF3wr9P2WBaNncFAOyN2kvy5tzIU5GNqk5JTrNbaSUpvzi9KjHW0tTn4+ OaePctlLeM5Cik7MLxQ/acuiy/vC/g3fe6iohgY3cgIf8N63Mv1GQDtgruQcimTwf8ImeaTm3+f ZHymV/OChY+gtvT7zdVtfBVShI08Y0uXSRAJocgYRz2Qtuo404mwK3028wvwNIjOEpdoCYHdqlG 6v847BiINpGwq5hGkuChQ9MKmc26ecKW5lU/26PNUe1v27VKyqbAgScKJEV8AjmkUN6Krt/4Rqi DTVj0TXC2du3Y+E5H0vhdNTYwgSmdxes2UeqwJzE7PbUQUNPOpSjWgew5QtgS4TwtcrEdMLAbQ/ 0L/F2pS6DfpAm3Ipfv3Bvm56TZs6DQ== X-Proofpoint-GUID: o2H-8HZmBou0sKMUBrtoHmFLru07jJ0Y X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-28_08,2025-11-27_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 adultscore=0 bulkscore=0 phishscore=0 lowpriorityscore=0 impostorscore=0 clxscore=1015 suspectscore=0 malwarescore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2511300082 GPR bus driver calls each GPR client callback with pointer to the GPR response packet. The callbacks are not suppose to modify that response packet, so make it a pointer to const to document that expectation explicitly. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Srinivas Kandagatla --- include/linux/soc/qcom/apr.h | 2 +- sound/soc/qcom/qdsp6/q6apm.c | 8 ++++---- sound/soc/qcom/qdsp6/q6prm.c | 4 ++-- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/include/linux/soc/qcom/apr.h b/include/linux/soc/qcom/apr.h index b16530f319ad..6e1b1202e818 100644 --- a/include/linux/soc/qcom/apr.h +++ b/include/linux/soc/qcom/apr.h @@ -122,7 +122,7 @@ struct gpr_ibasic_rsp_accepted_t { #define APR_SVC_MAJOR_VERSION(v) ((v >> 16) & 0xFF) #define APR_SVC_MINOR_VERSION(v) (v & 0xFF) =20 -typedef int (*gpr_port_cb) (struct gpr_resp_pkt *d, void *priv, int op); +typedef int (*gpr_port_cb) (const struct gpr_resp_pkt *d, void *priv, int = op); struct packet_router; struct pkt_router_svc { struct device *dev; diff --git a/sound/soc/qcom/qdsp6/q6apm.c b/sound/soc/qcom/qdsp6/q6apm.c index 94cc6376a367..cec135c53b99 100644 --- a/sound/soc/qcom/qdsp6/q6apm.c +++ b/sound/soc/qcom/qdsp6/q6apm.c @@ -487,14 +487,14 @@ int q6apm_get_hw_pointer(struct q6apm_graph *graph, i= nt dir) } EXPORT_SYMBOL_GPL(q6apm_get_hw_pointer); =20 -static int graph_callback(struct gpr_resp_pkt *data, void *priv, int op) +static int graph_callback(const struct gpr_resp_pkt *data, void *priv, int= op) { struct data_cmd_rsp_rd_sh_mem_ep_data_buffer_done_v2 *rd_done; struct data_cmd_rsp_wr_sh_mem_ep_data_buffer_done_v2 *done; struct apm_cmd_rsp_shared_mem_map_regions *rsp; struct gpr_ibasic_rsp_result_t *result; struct q6apm_graph *graph =3D priv; - struct gpr_hdr *hdr =3D &data->hdr; + const struct gpr_hdr *hdr =3D &data->hdr; struct device *dev =3D graph->dev; uint32_t client_event; phys_addr_t phys; @@ -761,13 +761,13 @@ struct audioreach_module *q6apm_find_module_by_mid(st= ruct q6apm_graph *graph, ui =20 } =20 -static int apm_callback(struct gpr_resp_pkt *data, void *priv, int op) +static int apm_callback(const struct gpr_resp_pkt *data, void *priv, int o= p) { gpr_device_t *gdev =3D priv; struct q6apm *apm =3D dev_get_drvdata(&gdev->dev); struct device *dev =3D &gdev->dev; struct gpr_ibasic_rsp_result_t *result; - struct gpr_hdr *hdr =3D &data->hdr; + const struct gpr_hdr *hdr =3D &data->hdr; =20 result =3D data->payload; =20 diff --git a/sound/soc/qcom/qdsp6/q6prm.c b/sound/soc/qcom/qdsp6/q6prm.c index 0b8fad0bc832..eaec6d211cf8 100644 --- a/sound/soc/qcom/qdsp6/q6prm.c +++ b/sound/soc/qcom/qdsp6/q6prm.c @@ -175,12 +175,12 @@ int q6prm_set_lpass_clock(struct device *dev, int clk= _id, int clk_attr, int clk_ } EXPORT_SYMBOL_GPL(q6prm_set_lpass_clock); =20 -static int prm_callback(struct gpr_resp_pkt *data, void *priv, int op) +static int prm_callback(const struct gpr_resp_pkt *data, void *priv, int o= p) { gpr_device_t *gdev =3D priv; struct q6prm *prm =3D dev_get_drvdata(&gdev->dev); struct gpr_ibasic_rsp_result_t *result; - struct gpr_hdr *hdr =3D &data->hdr; + const struct gpr_hdr *hdr =3D &data->hdr; =20 switch (hdr->opcode) { case PRM_CMD_RSP_REQUEST_HW_RSC: --=20 2.48.1 From nobody Mon Dec 1 22:05:07 2025 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C92EC278753 for ; Sun, 30 Nov 2025 09:40:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764495644; cv=none; b=uqZ5h8ydqQDKzj85btoVKMn9F1iGxHrcAN0eoq4m/NdUd8ORLT5N0ZrzdTVs2bs5mm7GctTq82dLhbp2/VdsyqkFa6sKEeRSn3yNyCzbSxLdcLad1jhgPh427PXOtzJqiLj+zHPATWtCewcLyzrEqJjpSsvVEUU7lAGfB5BALJk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764495644; c=relaxed/simple; bh=KoWSHnl/yUiVm9AF3KmqjJ41Ujm/tPcp34Hb73ZYxVs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Jktg1Z4pESQtmKU0rXl1dOJOmZEf+AM9uYXaoTLT8VUoyZWsN9/YR/c4QiYJ9DoR0uJnrSadGSJy2seW7kgQ/Ot/Futn6UEZ9EfizU43stQLa6Di98MfPKSZxXzLEtgjtgUOz9UEpa5OvoR30POkf3F6IJfP+uavkxkyyrIrf+8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=aNGLQkWR; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=IOhZ23L1; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="aNGLQkWR"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="IOhZ23L1" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5AU1lXEh390475 for ; Sun, 30 Nov 2025 09:40:41 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= mX5jFxQ2TYNAZrUrZcm773iTC0ebF7DRBRpALwPcSe0=; b=aNGLQkWRw1SXMX0I p340bNMjBGAwUc/8jsoEHRkcqEmDgPCtSWkUYCbiwdamLlpHQOkSDJZgarUXE9c4 RJ0jAyLXdk1w+VM49uV/Cx/1BgNjDhIp9UmWRJr/wWs41dnmgmbwOWDbMG1uRrgF PqxFor8LCkcLlWM00tI7jqDhfSLT+YFBN2K0iKpU4hKkC0zBsMFsNrNZSGmqbn1g Ov/OqC0OVbTqnBzSWdi81m4j44ZF09BpJKR9Q8oR9qsWx+OrMWRflkAjzEq4w1fV 9LVXpwkkg5SJ+23WIeiIujv0wbQmr/zmnkw45xdijb8tK41CejLDYgCzHotwi42k xeAlvg== Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4aqyw5hda6-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 30 Nov 2025 09:40:40 +0000 (GMT) Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-8823f71756dso36229976d6.3 for ; Sun, 30 Nov 2025 01:40:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1764495640; x=1765100440; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=mX5jFxQ2TYNAZrUrZcm773iTC0ebF7DRBRpALwPcSe0=; b=IOhZ23L1wLfCtbexJ8yzLX7Fo4h018XMm4gSvi7xag8X9BY62yJXLiqFwO8eiz5mct 2qeb3qvg9l0iNowf+V4WB/xX1CS6CA/fasvGaEA0lohBVU8K8ty7q+wVvCwP9WOD+guL ehyyjbH+bkksGS+0M16gGe9FRk3bSPIdFoZzytrrQ75sKHQgKPcizNT/NMaXSN5WqT89 BqrT6XTb2C8pD12QB0RfkLqZb+uLH0aptOcw86w1HkPPRS96H1K2sk34LfoWyg81xSSE 3CYR1KBX+nWEMEnz6iS/UHkuzBbfcjBtl7qUwg3/uehyHXGMhP1RSYKSwtobMdQkqsZk Sdxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764495640; x=1765100440; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=mX5jFxQ2TYNAZrUrZcm773iTC0ebF7DRBRpALwPcSe0=; b=TTfiE4OhPS2xj5xT0kOpJkHzgWBIWwhUSLkGDRaOTihub3jLel3mfh2w7R290dX81x VCG+7dOnNC2eFnSg7bKycnGVBiHUojFN2sVC3N26zyUqBEQTaKDT3RoneKs6jiSgCJ2G vlr2lO9D/lDpo/XAvRjh7V/hV9Mqj1A788Ux/4hImK/FnkuINmtzRr/InmORH2flimQr 4GfVq6bgicT2Wu2OY5UKNwyr3lNiwEmZDM1WucAJpciwcEDHh/M3T2/v4HbhI/6X2Exb B+dX1qFIruePOBE9+D6Do+g8Jway/awMM8vGySyGEVckHRwpSIQzZRDiXjIA4rXcWPJ6 bdlA== X-Forwarded-Encrypted: i=1; AJvYcCXDQ/YZUqn+tQ3Y7++1KTlbzzVFuCE9JnKCtfNI1YrTJFTI6LGeNBc1YniHf72u0mWu7DO9shvaZO/CEH8=@vger.kernel.org X-Gm-Message-State: AOJu0YyjirXpKrDgpYYJm5mayygCT1qOfGJRNYi6X5TVTmp72kk+cwx7 3aauJmgt2HNBNcXp7dIvWEw23Ep52pAAFyVKyDTztyvMcP5/QPEbKskgdyJVT+CNtvcTGWm30C7 BpljdmH7KTQ8eTfk6f+74msCfzkj4gR/VRRgK9fqpqx4J1iOL0zLXe//T2aRxt4eGdDw= X-Gm-Gg: ASbGncv8MxjcEzSjk6ylPfnFI1gQNVpO91gciUtb8GNsUlBm29ZL785QZzzYWSwF/Mi OTXEtMj6RlqGH5GSlVrstHD+gcMFyK7QzXdo3lDRXaer4on0T1QTAGbDFmgUprZu7YaIgcDvxna ZvF+ERydeFYFp0j4hy0bkveqqKVyGrSB1ZlGCxx3r6VVKMtAG5Hw9jd9gk4Tb8e54BNiLcKSr8D SeoK5efQjd/dUue5yGOpTXboiI5OXomEfpi5sdw6J/3kgp60T557tU0lGmNegZ08kuWC0QZjFyw 7x6xZN9vk4LK3C8UGqVtVwDui8ck3eM1LUPmm86q8EX5nWCpf5YebGYXuF0Tjd5IroLOZRdoSZt M8ULhssUh7kV0hgsH/hL6cX4D7UpLPeRJEg== X-Received: by 2002:ac8:5a08:0:b0:4ed:ddd9:141d with SMTP id d75a77b69052e-4efbd8f5159mr327963711cf.29.1764495640356; Sun, 30 Nov 2025 01:40:40 -0800 (PST) X-Google-Smtp-Source: AGHT+IEpJXs6UP2fRRY3T7xHT5fVT+8qcq/MZ3hF0wt7w2dgo8aliKvJ/waz72XUIdMqhDHLGVsiDw== X-Received: by 2002:ac8:5a08:0:b0:4ed:ddd9:141d with SMTP id d75a77b69052e-4efbd8f5159mr327963501cf.29.1764495639900; Sun, 30 Nov 2025 01:40:39 -0800 (PST) Received: from [127.0.1.1] ([178.197.195.159]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b76f5a4b762sm906138566b.67.2025.11.30.01.40.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 30 Nov 2025 01:40:39 -0800 (PST) From: Krzysztof Kozlowski Date: Sun, 30 Nov 2025 10:40:26 +0100 Subject: [PATCH 4/4] ASoC: qcom: Constify APR/GPR result structs Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251130-asoc-apr-const-v1-4-d0833f3ed423@oss.qualcomm.com> References: <20251130-asoc-apr-const-v1-0-d0833f3ed423@oss.qualcomm.com> In-Reply-To: <20251130-asoc-apr-const-v1-0-d0833f3ed423@oss.qualcomm.com> To: Bjorn Andersson , Konrad Dybcio , Srinivas Kandagatla , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org, Krzysztof Kozlowski X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=4051; i=krzysztof.kozlowski@oss.qualcomm.com; h=from:subject:message-id; bh=KoWSHnl/yUiVm9AF3KmqjJ41Ujm/tPcp34Hb73ZYxVs=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBpLBEPKSxL6OvVv/OF2tDgc3/UkapwLu7oFY+Tp fxQKHMFVBKJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaSwRDwAKCRDBN2bmhouD 14geD/4rXPdzppbnUjgLfDJYs3eDZfZXDe0kz/5+Bjxn6boJKZbZTUCi33+XD7t1nixIGMYi6bD GQcG9WfykXwmpBph9Gb0kDKtOo90iBzjnT/odEaa+MzmGtGdYs1CoPFUU/+77ozLIu9WeV0M5Yq 59Qr8mZCQI6EO9yw19hKBC8y+JSt6sQvLsqQjYssJA/Y2qxp6hhbEtsGT4JGrvnH6Ayqoc2JBTh MKIkxgw2hRCCIh4LXjgfOTph6LLru4I9OP1QFdJgn6y6z74Pzab9yEGf7/EpowwsboNHmOou4DO VKGp6LAxqOlxP9WIjAxAavzrIhoOw+zNGYl1NQum5lUAtnzn3omOtcX5vSotRanLIVFRw0XRtdZ aMbvoQCNksZL/oSPFXHof9LvOqKjd8vUJgP3s8eeOQVhtYpDCKTKemo6pMEHZNtpbL8zwJHzEcu CZN37rDnvthXsqVu9KB5lUL1+bHqH20iC3kK8Y0ziXBQhIBUtoH1ab3QvI+2sb0otuc9+GR2FSx xIsh7bT9xt8GwPr9cv+JnanI0jb8NXKtHCJjcHIFKGr6ivRwiRWwi8ZbwcHzrv59+autI/4TeF0 cJecJhv9+W7c27wY3nrVpqha1M5pjlfl3TxkdIJ8ZDwUWS+oMqz0PHx9TuH0M73TQZtdQQNCrSw nnN8A1CCvGYT/dA== X-Developer-Key: i=krzysztof.kozlowski@oss.qualcomm.com; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B X-Proofpoint-ORIG-GUID: hufHoYIzPMWq1ltb-uHPzxWCChA72Ayg X-Proofpoint-GUID: hufHoYIzPMWq1ltb-uHPzxWCChA72Ayg X-Authority-Analysis: v=2.4 cv=SoKdKfO0 c=1 sm=1 tr=0 ts=692c1119 cx=c_pps a=oc9J++0uMp73DTRD5QyR2A==:117 a=FPK7cjBCgYbqzSTDLBmM0Q==:17 a=IkcTkHD0fZMA:10 a=6UeiqGixMTsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=IPJxmXlkufg6yzWa_NIA:9 a=QEXdDO2ut3YA:10 a=iYH6xdkBrDN1Jqds4HTS:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTMwMDA4MiBTYWx0ZWRfXwEWn1bEwvIHa Pfdur6/bGHBnmnhDjIe2og7uQwYXURReb9+6BWM63w8uxfJ3IwEG6AD647fZ36XeK5BawXQfLPk l3dn3PhhUNWpBU4R02cS7197Jef8VeEiN68hAHWjzzTUaUXzIDqKCxET7jCkD5bpG4IuQKghJIg U9fiA0jrzahUoIPII3uwhrbDnw2cBbE4YAN3cYa+UmYbWVkGZxf6ltK47BMLmR85QQCEPB2IYy3 45YO3NM+1B3hBiuJ4fq9aLsBwVXv43cP/WEephgO7CeNayblO8u83Bs0gD24OJA2berF5KRrNSm EHn+1xZO1Ferirzp9LtToKKXuOMFuwQyMKxmi4LJVDrLyWPuNr2j3nmqUbTYjBSRFRS+hw8OGsu HvGUwo+GYXvrSeAw8sBmZUNBvlqGfw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-28_08,2025-11-27_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 malwarescore=0 bulkscore=0 lowpriorityscore=0 adultscore=0 phishscore=0 priorityscore=1501 suspectscore=0 impostorscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2511300082 APR and GPR callbacks receive pointer to const response packet which holds the response result. That result should not be modified by callback, so make it pointer to const for code safety. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Srinivas Kandagatla --- sound/soc/qcom/qdsp6/q6adm.c | 2 +- sound/soc/qcom/qdsp6/q6afe.c | 2 +- sound/soc/qcom/qdsp6/q6apm.c | 2 +- sound/soc/qcom/qdsp6/q6asm.c | 2 +- sound/soc/qcom/qdsp6/q6core.c | 2 +- sound/soc/qcom/qdsp6/q6prm.c | 2 +- 6 files changed, 6 insertions(+), 6 deletions(-) diff --git a/sound/soc/qcom/qdsp6/q6adm.c b/sound/soc/qcom/qdsp6/q6adm.c index 608ca0e41539..c415b3003030 100644 --- a/sound/soc/qcom/qdsp6/q6adm.c +++ b/sound/soc/qcom/qdsp6/q6adm.c @@ -188,7 +188,7 @@ static void q6adm_free_copp(struct kref *ref) =20 static int q6adm_callback(struct apr_device *adev, const struct apr_resp_p= kt *data) { - struct aprv2_ibasic_rsp_result_t *result =3D data->payload; + const struct aprv2_ibasic_rsp_result_t *result =3D data->payload; int port_idx, copp_idx; const struct apr_hdr *hdr =3D &data->hdr; struct q6copp *copp; diff --git a/sound/soc/qcom/qdsp6/q6afe.c b/sound/soc/qcom/qdsp6/q6afe.c index 4f9f9a7277df..51d73ad7f477 100644 --- a/sound/soc/qcom/qdsp6/q6afe.c +++ b/sound/soc/qcom/qdsp6/q6afe.c @@ -961,7 +961,7 @@ static struct q6afe_port *q6afe_find_port(struct q6afe = *afe, int token) static int q6afe_callback(struct apr_device *adev, const struct apr_resp_p= kt *data) { struct q6afe *afe =3D dev_get_drvdata(&adev->dev); - struct aprv2_ibasic_rsp_result_t *res; + const struct aprv2_ibasic_rsp_result_t *res; const struct apr_hdr *hdr =3D &data->hdr; struct q6afe_port *port; =20 diff --git a/sound/soc/qcom/qdsp6/q6apm.c b/sound/soc/qcom/qdsp6/q6apm.c index cec135c53b99..3b504e2a9173 100644 --- a/sound/soc/qcom/qdsp6/q6apm.c +++ b/sound/soc/qcom/qdsp6/q6apm.c @@ -492,7 +492,7 @@ static int graph_callback(const struct gpr_resp_pkt *da= ta, void *priv, int op) struct data_cmd_rsp_rd_sh_mem_ep_data_buffer_done_v2 *rd_done; struct data_cmd_rsp_wr_sh_mem_ep_data_buffer_done_v2 *done; struct apm_cmd_rsp_shared_mem_map_regions *rsp; - struct gpr_ibasic_rsp_result_t *result; + const struct gpr_ibasic_rsp_result_t *result; struct q6apm_graph *graph =3D priv; const struct gpr_hdr *hdr =3D &data->hdr; struct device *dev =3D graph->dev; diff --git a/sound/soc/qcom/qdsp6/q6asm.c b/sound/soc/qcom/qdsp6/q6asm.c index df183b7a4019..6f1667895262 100644 --- a/sound/soc/qcom/qdsp6/q6asm.c +++ b/sound/soc/qcom/qdsp6/q6asm.c @@ -603,7 +603,7 @@ static int32_t q6asm_stream_callback(struct apr_device = *adev, int session_id) { struct q6asm *q6asm =3D dev_get_drvdata(&adev->dev); - struct aprv2_ibasic_rsp_result_t *result; + const struct aprv2_ibasic_rsp_result_t *result; const struct apr_hdr *hdr =3D &data->hdr; struct audio_port_data *port; struct audio_client *ac; diff --git a/sound/soc/qcom/qdsp6/q6core.c b/sound/soc/qcom/qdsp6/q6core.c index 51398199bff3..f4939302b88a 100644 --- a/sound/soc/qcom/qdsp6/q6core.c +++ b/sound/soc/qcom/qdsp6/q6core.c @@ -70,7 +70,7 @@ static struct q6core *g_core; static int q6core_callback(struct apr_device *adev, const struct apr_resp_= pkt *data) { struct q6core *core =3D dev_get_drvdata(&adev->dev); - struct aprv2_ibasic_rsp_result_t *result; + const struct aprv2_ibasic_rsp_result_t *result; const struct apr_hdr *hdr =3D &data->hdr; =20 result =3D data->payload; diff --git a/sound/soc/qcom/qdsp6/q6prm.c b/sound/soc/qcom/qdsp6/q6prm.c index eaec6d211cf8..6d9834b5d16b 100644 --- a/sound/soc/qcom/qdsp6/q6prm.c +++ b/sound/soc/qcom/qdsp6/q6prm.c @@ -179,7 +179,7 @@ static int prm_callback(const struct gpr_resp_pkt *data= , void *priv, int op) { gpr_device_t *gdev =3D priv; struct q6prm *prm =3D dev_get_drvdata(&gdev->dev); - struct gpr_ibasic_rsp_result_t *result; + const struct gpr_ibasic_rsp_result_t *result; const struct gpr_hdr *hdr =3D &data->hdr; =20 switch (hdr->opcode) { --=20 2.48.1