From nobody Mon Dec 1 22:05:00 2025 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 340B58635D for ; Sat, 29 Nov 2025 18:26:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764440801; cv=none; b=r50fE4jE6GNlyf8J2i3C8W6yMJrcxcMqODaL9hXIox4Q4zMsfjabBBi9xuHsEyZKY6ayY9LsEwpvFOTXmm5XSm7BA98pI6H2AhBeY7+KDewPdvhkzGS3OyIlgNGMwI81iHzsnG82+hGJyf7xnPc22atZbTpWTD349XhH46EWB+k= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764440801; c=relaxed/simple; bh=FjR1mEntDRObhFwEuwXhUYzmEdGdSC5tkuVCgZxGZDw=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=KlUGDLcvRMrwgiENLpcUrD997y6KLwhXpSzEVRzhQNCobuhiyLceoXZPYQRTAijhLfSInOXnjmDzqvfRzTkERRk35CwJre8rl4fvngYFdTn7vt+E6lcqOnfcFpKh+OA/5QwJ7wGzLDISIwtqvqmTFeYU/SJTrz8NI7+Mk4Csj+Y= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=neVAk/po; arc=none smtp.client-ip=209.85.214.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="neVAk/po" Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-297dfb8a52dso4100135ad.0 for ; Sat, 29 Nov 2025 10:26:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764440799; x=1765045599; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=3JC72Qo3TOw1s9p+vntPcAPUKDQuPh5dqE0qtCY/uIg=; b=neVAk/poM+FjQYpmrmh8llX2yqbRLirruQKfNjFcXcIxwzs5at9ywBBKnxAyxcbJnT j1ci9fKbKlb2iCoKyLEQN8RSf1jxc4Qy48jL2Mn84yld84IZu1wwRVs0skhQnL+kwyE7 WcpVnK7iQMMTVfS60u+0t4IlhNt9zgxTofpqAbs74v6nXVfuL6jc1tDri0QeNn5TIjiJ J1z3mXiUi/tsCo1yJub4wW06KUK3yow2P5ZGx0tUdOEEjh9ag7M1hS5jwoO2in2bydLJ mf5QeT4H44aaegfUV1ytr+P7I4eF6c2yO2nt3jV/HIDq9xo2WDz0Q3NqZoL7PHSmm0AT +1EA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764440799; x=1765045599; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=3JC72Qo3TOw1s9p+vntPcAPUKDQuPh5dqE0qtCY/uIg=; b=MOv8coMOlrNff2X6Zvxk0ejAXFOLv+Hw9IENGCOj+v42vSz0lnx11S1qplisKoc1R4 reuv+a25UBexZJLWyLyF3MhvzO5xm5yU98dU9RceOpxi+KKxADo/EJYDVlKh0qI36H9w XGf/a5YdcN63+m17GDKREzLPvF7m1ODxatKlyn49sGY/QZXggHGmT9AUOV5SjKRUEJnR 2eBeJBN0rOH2d+bK6xUPcZSNjnlfT7dfsGi3jyC1Su3vEbR7hdQutz3QxzO3ruRj2Rop 3scJiB4XyjPMVWaK5CLWZ6n9J0XUdYLipxHSMtuPs2FRNzNMmgfvWb1YdLXPKMMyZsLR fSgA== X-Forwarded-Encrypted: i=1; AJvYcCXvPCLyT4kICGBC51eJicqeV6w8mGyHoNU6CImd2JJ0M/jad8NXTXjJbdQJZkprwyi4XpJ5N3+cPZhYytE=@vger.kernel.org X-Gm-Message-State: AOJu0YzmIXnB6HKFfPw1ZAcuOvgWx8sh9uKchDJykWvf72eZE42u0peB ibbr5VqWcHVXM20ylM21GuBeVWwU0AXf/QYiN0aXg4EijbJ2dCR0rv37 X-Gm-Gg: ASbGncuoX17UzU/3pq3exMKbRz4UDHketQblvRcFI3v2Zsd17ITVr1K3V9Yxn7HALij Fc8gEuzymsh49QcR5DLXHi0FGhCChzbc5DzvRFhfKPnlxNRAnhIiCTV+WHF9kP9Bx+zlEMp2ENh LkYvtjJBPk5oOVcMunj8SO6ZmjQtE5LmJt8CKtRhvkiAGwVJ0gGjKGtG7K96NAa3vuzchH6w2RS 0+USoQ5KCqsScN2yyKI5ermohuOcBZ5Ljyhbe5IArNCwGMKgerrnZ3Zswxc77o5GMvbLFTI6vCg 2hcr8HGBBQPh1gzLkQLvKROXSK5taBQ27KgGPZdBRTNKhG1XYimFelRwfiXvh2lvqb9zGk/8jEk o6EjF2r854hrLqoqgA6CkMpDSlpH5vjthwnnp1H069z3BZ4uYmy+lP1ALk0L2Yg1wd2++y4WFka ZxKO7xwAKsFcnoOsQ= X-Google-Smtp-Source: AGHT+IHFWCBKPxYkoDnGrX3Bcm9s9hshcjYoD0pvajZbvW2Kn2yTSUnpKDGOc1WjpWgPnlDwkvZVcQ== X-Received: by 2002:a05:6a20:a109:b0:345:42cb:50b8 with SMTP id adf61e73a8af0-3615437dbfdmr20262810637.8.1764440799603; Sat, 29 Nov 2025 10:26:39 -0800 (PST) Received: from morax ([2405:201:4039:48b0:c6f2:57d3:9f1d:7d73]) by smtp.googlemail.com with ESMTPSA id 41be03b00d2f7-be4fb248be1sm7796131a12.3.2025.11.29.10.26.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 29 Nov 2025 10:26:39 -0800 (PST) From: Aaditya Kansal To: sfrench@samba.org, pc@manguebit.org Cc: ronniesahlberg@gmail.com, sprasad@microsoft.com, tom@talpey.com, linux-cifs@vger.kernel.org, linux-kernel@vger.kernel.org, bharathsm@microsoft.com, skhan@linuxfoundation.org, david.hunter.linux@gmail.com, Aaditya Kansal Subject: [PATCH] smb: client: Remove incorrect TODO in cifs_mkdir() Date: Sat, 29 Nov 2025 23:56:23 +0530 Message-ID: <20251129182623.530415-1-aadityakansal390@gmail.com> X-Mailer: git-send-email 2.52.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Remove a TODO comment which suggested skipping the call to cifs_mkdir_qinfo() for SMB 2/3. This is incorrect because cifs_mkdir_qinfo() contains SMB 2/3 related code. Signed-off-by: Aaditya Kansal --- fs/smb/client/inode.c | 1 - 1 file changed, 1 deletion(-) diff --git a/fs/smb/client/inode.c b/fs/smb/client/inode.c index cac355364e43..20acbe88f1c3 100644 --- a/fs/smb/client/inode.c +++ b/fs/smb/client/inode.c @@ -2314,7 +2314,6 @@ struct dentry *cifs_mkdir(struct mnt_idmap *idmap, st= ruct inode *inode, goto mkdir_out; } =20 - /* TODO: skip this for smb2/smb3 */ rc =3D cifs_mkdir_qinfo(inode, direntry, mode, full_path, cifs_sb, tcon, xid); mkdir_out: --=20 2.52.0