From nobody Mon Dec 1 22:38:19 2025 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6D8B830F93A for ; Sat, 29 Nov 2025 16:43:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764434616; cv=none; b=KuSM7w1y0EluDvFVenGjVl3JfloCFWCCBE5M0lgWhMI0J1q29XQW4TMejQ+N/ouL+0FBZEud7EfeIP2bu1YaMT9tHV6dzUu3n/X1Wp1IlOT7tigYP65m5g3lVXflyuPSLDUf1bfdq1S8PIGqThsWcCim1ik31tPOJHz4GcU9Ep0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764434616; c=relaxed/simple; bh=Jyr2CHVhr92k//wyRYmvtRWJKSE0xW9i+OMuWE/VQ3E=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=t+lCDuNk13idCgyF/6gucIpjX0Sr/LNWEXik9fuBn2jZT/NO9BsKDcRkuyATCRmcseDXXnEpj9Gh8R0BqOnP0qKDSadkumeTWLW0G+vAkJIwlqjdYVDsRrNxRnL3Qat/ZhMNyL7LU6AIRlhCbnlAZPgObSQTEBUSYORsYnQ8UvE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=m77s565E; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="m77s565E" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-47118259fd8so24575465e9.3 for ; Sat, 29 Nov 2025 08:43:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764434611; x=1765039411; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=1laVFJ5J/2PogvGPArKDBntximPg68iaWIWh3V2PMC8=; b=m77s565EkotB4BJCJQBhXEToYm61Mb548kx8KAOur8XI9cBMIFz0ccOG8A1bkMhR3b 5PEzEqj2s6Jb2whhBZHncBXkrNZVP6HouqllVTw3ziWTV6I+ehlKWkLuGtGFSDF4u+FQ nCcAF4sqU9NnrBQMjZQJPmZNnRyhdGtK9jW6D5LigoZ36EvPs4AuAzFlUaSqYdPL9jxB Gt2XzZZFUeEl2LGb/enVROVp6NbsebuwUSenRGLc1erbSZ2mokwxZ8jghauzWodB3veR JK1puyZ0dCqwlnmHPSd3fqMdxooLvEMgtWZgneZ05Pj/KPGoOa2H8Z84jn4fulKo2PJC Ep8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764434611; x=1765039411; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=1laVFJ5J/2PogvGPArKDBntximPg68iaWIWh3V2PMC8=; b=Pe9IZgb0ZAPR5FHBAxCM5UVfBto1l9gKc5jrppvar1YmOd9yBPGMwYxNzXnB0vTQpI fiC8/UZtK1MPJKq/NwxEVi/hUMc7hS23jHqsCwi8/qEtdrBvKIByqG2WZXWSYCiLCel8 psNgp59LvQn48eLojpWE2N7iEUjDU3t32OM4HTP4rHei7chQxiR+exP9V94hrgLiJdxv 0DqZtmTX/NjNBYPtbfbPlGXnExlYQb7gZ4mWp6C2SobBdNExxSGEeWyOkRHMuFEoL6gz /ki4ZSTFzm8CAzeKlBIDq7UAN8InsawsY2Aal7HwIa0hhvb9+X6jkgxmXQ9mfTN0epPT FC+A== X-Forwarded-Encrypted: i=1; AJvYcCWe2L95rZM+azgvTqrVtnOXh6ApjR9KPtalPVyenBYAJRtAKGFltTIBZH9zijTVXD9BWrHCXhMneYe2WXI=@vger.kernel.org X-Gm-Message-State: AOJu0YxxsgbvpeV377pQiGsMIeP4WrcXPDfg8diY+YP18Ybbz3BLKhOd 6TUs0g0TihBbHOMFTPJdwWx3415hrFAzCYCp7BPiONyvZvnnpYPlM5Hz X-Gm-Gg: ASbGncvVa5J3wqFi8OeqTqDhW01L/ISuF/+vm8UlrCcVJ6KMu4JfXJdohVgomTKdZ3x 1Jf9WxWWziQbuJoLOueY7YRSe6MCrvqtbSMJO4iQnGWqMYtX5KryIgyHn54nUUXB4oY5IbbTrrb wypsgt8lz33QMSqvzSZLU0CExBY8sKW6QW66BJo+A1KKzPFDB4TbHcbnLFH4K7d+hNoiwrQlx2R FWzYm7caH1aFcWL4jyVaKOZWM52ug1sqnpbIvZ008sDYCQOFHCQBGomiZys3EXLlPOQkbDQqdBt icswRJKKKMb9FzUYdcCZmGxemwl1zzIzGRTU+zyiAqItyO38x4fntGN8iOsNsx9hPMbHVBN0SQD f/3ag38RDqM8SVfY/PRrwpf6rQVGpL+v2D4bLByypSv+cHbySYInNb6t8ufXYLhJJfRwSVYxN24 dUkdFyPx+DcTSqnBaNxYiQNDdpqFdoaE4BpcoIzKfNULTS6EQzvsMcQ+ql7zFQ6GAa4377Rz0m5 UekDVeBlpAGyHdj X-Google-Smtp-Source: AGHT+IFOOPMW+EuE+WoBWDENaBFiI9rdwCgXZ+oiJXrJkuUjq1n/4uLYNcYjwXAPQNmHWmA+/475eQ== X-Received: by 2002:a05:600c:c8c:b0:477:a9e:859a with SMTP id 5b1f17b1804b1-47904b1ad30mr172572825e9.22.1764434611363; Sat, 29 Nov 2025 08:43:31 -0800 (PST) Received: from localhost.localdomain (host86-162-200-138.range86-162.btcentralplus.com. [86.162.200.138]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42e1ca4078csm15970060f8f.29.2025.11.29.08.43.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 29 Nov 2025 08:43:30 -0800 (PST) From: Biju X-Google-Original-From: Biju To: Greg Kroah-Hartman , Jiri Slaby , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Geert Uytterhoeven , Magnus Damm Cc: Biju Das , Wolfram Sang , Lad Prabhakar , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, devicetree@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Biju Das Subject: [PATCH v5 04/17] serial: sh-sci: Drop checking port type for device file{create, remove} Date: Sat, 29 Nov 2025 16:43:00 +0000 Message-ID: <20251129164325.209213-5-biju.das.jz@bp.renesas.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251129164325.209213-1-biju.das.jz@bp.renesas.com> References: <20251129164325.209213-1-biju.das.jz@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Biju Das Ports that support FIFO has fifosize > 1. Replace checking the port type with fifosize for device file{create, remove}. Signed-off-by: Biju Das --- v4->v5: * Dropped checking port type for device file{create, remove} and instead started checking the fifosize. * Dropped sci_is_fifo_type() helper. * Updated commit header and description. v4: * New patch. --- drivers/tty/serial/sh-sci.c | 15 ++++----------- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/drivers/tty/serial/sh-sci.c b/drivers/tty/serial/sh-sci.c index 28d665a9861a..ff5459c449fb 100644 --- a/drivers/tty/serial/sh-sci.c +++ b/drivers/tty/serial/sh-sci.c @@ -3549,16 +3549,14 @@ static struct uart_driver sci_uart_driver =3D { static void sci_remove(struct platform_device *dev) { struct sci_port *s =3D platform_get_drvdata(dev); - unsigned int type =3D s->type; /* uart_remove_... clears it */ =20 sci_ports_in_use &=3D ~BIT(s->port.line); uart_remove_one_port(&sci_uart_driver, &s->port); =20 - if (s->port.fifosize > 1) + if (s->port.fifosize > 1) { device_remove_file(&dev->dev, &dev_attr_rx_fifo_trigger); - if (type =3D=3D PORT_SCIFA || type =3D=3D PORT_SCIFB || type =3D=3D PORT_= HSCIF || - type =3D=3D SCI_PORT_RSCI) device_remove_file(&dev->dev, &dev_attr_rx_fifo_timeout); + } } =20 static const struct sci_of_data of_sci_scif_sh2 =3D { @@ -3917,15 +3915,10 @@ static int sci_probe(struct platform_device *dev) ret =3D device_create_file(&dev->dev, &dev_attr_rx_fifo_trigger); if (ret) return ret; - } - if (sp->type =3D=3D PORT_SCIFA || sp->type =3D=3D PORT_SCIFB || - sp->type =3D=3D PORT_HSCIF || sp->type =3D=3D SCI_PORT_RSCI) { + ret =3D device_create_file(&dev->dev, &dev_attr_rx_fifo_timeout); if (ret) { - if (sp->port.fifosize > 1) { - device_remove_file(&dev->dev, - &dev_attr_rx_fifo_trigger); - } + device_remove_file(&dev->dev, &dev_attr_rx_fifo_trigger); return ret; } } --=20 2.43.0