From nobody Mon Dec 1 23:05:29 2025 Received: from mail-pf1-f170.google.com (mail-pf1-f170.google.com [209.85.210.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1AFCC275105 for ; Sat, 29 Nov 2025 09:01:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764406902; cv=none; b=g0tkm5Wj4RFovNfhwu7JrumgxuSQm5qQfF76fzOboH2CfMNsLkhZ7oAmjEOvD45obNTgo/GG5AhzhxaBHdfO4ZAo78SoezdnHgWixRUhyLVF3W0G/dKR5TCj3KnvfKTHaFyRQK7cWEib0Jid+ScZVe1q/gZlJese9GVVUOKT2io= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764406902; c=relaxed/simple; bh=JLIdNXPMejF737Jv1xzF5GicNRibkuRDb9iX4pmjoI8=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=EboZp8lCOqUSw5VTqMHEO77u9lA+mIHjih6QuILcCcWvk6REbwqVGl+/F+a/ArCFOnXeRO3p/HphkXSyGNV+Z0WxNOT3VUfNGi3VoPiKGv3/nfiUXrQ1w8+fUg7LuQrEheTs+QH+dYVZ5zym0owWbAEHrnV7BIW16bZJvJ6O3Wg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=KRn9SGir; arc=none smtp.client-ip=209.85.210.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KRn9SGir" Received: by mail-pf1-f170.google.com with SMTP id d2e1a72fcca58-7aad4823079so2259914b3a.0 for ; Sat, 29 Nov 2025 01:01:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764406900; x=1765011700; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=3B+NwUppxNtx5dO3GeNOAlGv3QVGc2Q+cteUdMRhiTw=; b=KRn9SGir2pBgh1mKiywJ7/hOt0zGejR1vm2MBrEsl9f98GNlgZ/GLGwsccVj/GsjQX WJaVuzCpvoMb/UJx1OOcLfeoU1A/jDTVXGHxrowGhucL/qEMCFP1gcKC54LawCmjQwvH 4LehKy4Y1P+381T+jI5VC/xbtgUkSPJ8vWy2Ve0ciJcUgnMJA+TeWj72zRDM22mSCA3+ HaVLwYO7KEArcs+UnmlxLk2MfYaOC13SfWk+mkQ4qx3hXXJpFEIUY1uGw5HMKKQv2vIJ hlgUAzJiWWPKKU6SZX/HM3Tc2Mts55PI6bwy4Ie6e3qKFW36wyCvXBwAwa2vzNj5MqbY FzTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764406900; x=1765011700; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=3B+NwUppxNtx5dO3GeNOAlGv3QVGc2Q+cteUdMRhiTw=; b=bsgSrrQA1Qy8aEjo6UTOHNGxT0kYQaB0oJTpQX20rKnwdjuLN6rGVhZOgt9A2ASU7o uxVCuiQ7CIzFB4PwWWqwv2o+br41AqAiM3rF/CBGrh14RIav3fGrYfakMe2r4vrwYVZ+ SzAaNf3HMAm5DJojXu7Q4LScT6Fa1Fy0dMFROflDg8ZKZOlNyan04CLJP9uNatJqWBkV rduDqkzJz2ifxhsbRbJoRgCqCiXAcwjg29VNSnX/4rEX5xTgRJ9Cy/uWX1rsAmJJiwYo ayLZq1B4Cdu8rbXARzgLbL7SAW2uYz/CDZkx9/0rYO0lixYywXV9jlkrsZoow3aWdFDA HWaA== X-Forwarded-Encrypted: i=1; AJvYcCXNaZJKWmCdPK9+7bhwVlbwjxs/vL3pZ4n5dU46ZK/WMlCE6aVR6tznpdhtwsSQNW8gqevs1H60aP8zZSc=@vger.kernel.org X-Gm-Message-State: AOJu0YzhLJNKzuDWzem8nCyZ5oAk69oGL7IN33/x1QnUAqufFFv70fcD W7MDe/gwnHMyKvUZRihlh10ziicQWxhpqTW4UEyRE+4ClbbYccQW6hoG X-Gm-Gg: ASbGncvEubYmYrORGa3/s2PnyeiBiNEHYwU4qfLYyB9UOHcmxbQ9iA91gjKl6l/UGPv CKl+JX0Lys9BRDBYh2nA9b5X5ZGm7mpybG4OYSlRpCmRVsUc60EZ7KTCRBxM6R+c1GZBmYVKsPZ wdAF3Z0ECIkY79kcvJCuvvJGH9g/cAhg+Pw1ybdDK9WO0R19ffpG6Cmgesm/LGFzExdCxbEyVdg VZK2Q0Icl2JMT8VcV/6xSoDci98O2Xt9/MaQN6vURK8qX6LIrBkoZturu8B5Y2Jzw9mJYyCIDDw 4gBu3LFgs1Ft5gSXl0lQ04zbHS7LVMzvU4gHZPip3Zs68wolCi0+A0njC1jPcmUU4tsQ/d30wc7 oZNRmkyy+NnWob9SdZlw9ClecvTabsjQbO00XOKoDHUUwy/KqlvscmSu+yEOkwKF9jgk/W4z3ic /PlBkjADMZExpdUMRcqT7fdjUrWC6KfBSih3+J X-Google-Smtp-Source: AGHT+IF9fpUjxnsoJ856uo76C4AbEbv+isvtq3QMxPEeI8s0lui+ms4Diwary4B5eKv1gtl0O4hKMQ== X-Received: by 2002:a05:7022:ec0d:b0:11b:9386:825b with SMTP id a92af1059eb24-11dc87b150cmr7316305c88.48.1764406900072; Sat, 29 Nov 2025 01:01:40 -0800 (PST) Received: from localhost.localdomain ([104.128.72.44]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-11dcae73bedsm28114394c88.0.2025.11.29.01.01.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 29 Nov 2025 01:01:39 -0800 (PST) From: zhangshida X-Google-Original-From: zhangshida To: Johannes.Thumshirn@wdc.com, hch@infradead.org, agruenba@redhat.com, ming.lei@redhat.com, hsiangkao@linux.alibaba.com, csander@purestorage.com Cc: linux-block@vger.kernel.org, linux-bcache@vger.kernel.org, nvdimm@lists.linux.dev, virtualization@lists.linux.dev, ntfs3@lists.linux.dev, linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org, zhangshida@kylinos.cn, starzhangzsd@gmail.com Subject: [PATCH v3 1/9] md: bcache: fix improper use of bi_end_io Date: Sat, 29 Nov 2025 17:01:14 +0800 Message-Id: <20251129090122.2457896-2-zhangshida@kylinos.cn> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20251129090122.2457896-1-zhangshida@kylinos.cn> References: <20251129090122.2457896-1-zhangshida@kylinos.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Shida Zhang Don't call bio->bi_end_io() directly. Use the bio_endio() helper function instead, which handles completion more safely and uniformly. Suggested-by: Christoph Hellwig Signed-off-by: Shida Zhang --- drivers/md/bcache/request.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/md/bcache/request.c b/drivers/md/bcache/request.c index af345dc6fde..82fdea7dea7 100644 --- a/drivers/md/bcache/request.c +++ b/drivers/md/bcache/request.c @@ -1104,7 +1104,7 @@ static void detached_dev_end_io(struct bio *bio) } =20 kfree(ddip); - bio->bi_end_io(bio); + bio_endio(bio); } =20 static void detached_dev_do_request(struct bcache_device *d, struct bio *b= io, @@ -1121,7 +1121,7 @@ static void detached_dev_do_request(struct bcache_dev= ice *d, struct bio *bio, ddip =3D kzalloc(sizeof(struct detached_dev_io_private), GFP_NOIO); if (!ddip) { bio->bi_status =3D BLK_STS_RESOURCE; - bio->bi_end_io(bio); + bio_endio(bio); return; } =20 @@ -1136,7 +1136,7 @@ static void detached_dev_do_request(struct bcache_dev= ice *d, struct bio *bio, =20 if ((bio_op(bio) =3D=3D REQ_OP_DISCARD) && !bdev_max_discard_sectors(dc->bdev)) - bio->bi_end_io(bio); + detached_dev_end_io(bio); else submit_bio_noacct(bio); } --=20 2.34.1