From nobody Mon Dec 1 23:06:23 2025 Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2977E78F3E for ; Sat, 29 Nov 2025 03:42:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764387763; cv=none; b=fw+1tAyVD72wcF42CpoMEKbDUq8uiPhDzaWkjrwl+9VTN2NGKW7BwnwV+kNnxIB2RlMj/xqPkvzwMHnfqaX1ll7dRzP6+crt89ykPTUthqIKszX4+BDcqZvRQBdN+Jr9Qd3H5PRhQtCTdmn6WDXtUwoOO8snl0VLb6RRKk7tNTE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764387763; c=relaxed/simple; bh=coXSfP5iPGP0DKvWU7gjkly+OWEx2e0tPwXLluGYykA=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=dXMPgY52h0Kl37l8S/AMsoeqQAGHfspCw/II2Xf3c6smC1vonqFNjpL7wRjJ8dyavN2pbu9ojgIyECDG0ZXlIFgNejFXHn95O4ImUGQL7pqzULhofZvOrFuRWgY6ekx1r0snuu0VnWcIeSB0k3beQE+BC9VQMHIcieDvbQl6Cp8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=CfxNUmzL; arc=none smtp.client-ip=209.85.210.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CfxNUmzL" Received: by mail-pf1-f174.google.com with SMTP id d2e1a72fcca58-7b89c1ce9easo2930638b3a.2 for ; Fri, 28 Nov 2025 19:42:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764387761; x=1764992561; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=zwwuqAjXyQwlWsKtZ5Jk1RCQQpe+aHMmcqGyV/n+5zo=; b=CfxNUmzL0tmVsNPtt6aRisBb10procnF/W7iN5DmEka66Dm4ncd0/bHeMLXIAbJ/Vn /7NUNKS1RcWs8N6Gs3+eJvpEqPWv7SqlEtY72tGSskFHoONAUEko6cOFJcLhp4UP6CR9 RQQtK92+g+J6HWXHVjIAqZg5d6ztyn5piUjhJoHgbyqzrEXCUMci5FdRTzClCEJnrxCz MBt/m0p0XDQntxMisVPA8ZXVhaMJrvEWB9A+9OUG+YLQlEsy77Yhxuspq6PCf6aWDE3D XbJkoumU2cfbE5LKfmkTITkVEXsh/xswX4Zistqhy+1fy+xz8aU2bIXGO1cBaI+HVi+3 OW6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764387761; x=1764992561; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=zwwuqAjXyQwlWsKtZ5Jk1RCQQpe+aHMmcqGyV/n+5zo=; b=DczkhlVxsXRAiPFlIdPnNnytO6zQyZvXcKpJslDc5v0nofWkFcvtbzY1uGYRXriKdh 0YcROjkbbJ2Zc9mRxc2NfSTtwZejVHDErD9I/xI5rly9wJA5B7Vu1dzuOIM95jZeYERS 2eFUbMU7xUbwOmSRaJn1R8vXrX8EsL66S7kuwUjus3G3NTifTb/d75k/EeHP8t9udBWQ 3BiJ+4dtitt9XkArviCJBfjZLnXvOGQulexGcRU0bH/DGFQsKgMGm19fM345D8iTAC/p 9rjVr25/ksdiN4MNJD7v4cLqyUC8ws4Rx9D2z6uUDWu9XvGHmhgy7EAtSaWVC1t4/250 nzaA== X-Forwarded-Encrypted: i=1; AJvYcCWE12wvdWYP2ucSH09bVpY2eT+vfgbQbwCiKRonLDbYFe3PpL+Ai8voVuPRRFPVnbRX69C8T2pG6fa3SJA=@vger.kernel.org X-Gm-Message-State: AOJu0YwTyPcgdpbddJZ28tvbEjdFVoL3vo9Zz7uPuqJod96//V+CkQMa eWXRIxlh3qiSnfZrVqwWl3QIGIlmZ1wzk1sjm4uDxVlAlEi77bU903AY X-Gm-Gg: ASbGncu9OYvNVuDkizm6xBFiswtRmWF/JOp93G4D09StsMeH8N/8Y97YqcgZ3rkO262 t2fE3C9OEwI4+dwzwEptesu3sOwHVRhQKDsrBMHJzL1Ws0OIkQKSKUQXs4PaqIIm3J4xxnmyh6g k7Txz2WyPednu25M6uhZWju++RQWRB478b4tnQwmOS1L7WD1fDgcVkpt4lvXoj1QlqudX5A4v2n 1FhcXZ+b88P7lVR2ZdGzEzL4Fb2ijKjky7dLIHo5B1pUSXapDIViO3+4lRPaLIJR4Bx0tMMkjYG NGVOpgz43XsMlMtXXsG0djlTnIya7HvM86cEJGl1dmBUUisiFlRbqyRLbDGW9CVdaXsbb9kbkbo rB60b4TJMebJSng0N8C4FTso6ke1pyRtH3gh07zWCA23YByqf7eaqm3274vbx2yG+xK/AC9boIJ zGF9MW7j5BM0Gbl7sUGmlfJgroXwH/n8E/S88= X-Google-Smtp-Source: AGHT+IEiQ6DpI97phaBc+ZBVNX65hiovuUDQNBEt3GfuthdkTrdaGVhbOIUr5+950kDrLtgYPzqSvw== X-Received: by 2002:a05:6a00:1803:b0:7b8:8185:c23b with SMTP id d2e1a72fcca58-7c58c7a631cmr30441891b3a.10.1764387761388; Fri, 28 Nov 2025 19:42:41 -0800 (PST) Received: from deepanshu-kernel-hacker.. ([2405:201:682f:389d:9cfe:b2cf:9d3f:f1f1]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7d15fcfd0cfsm6413100b3a.65.2025.11.28.19.42.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Nov 2025 19:42:40 -0800 (PST) From: Deepanshu Kartikey To: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, horms@kernel.org Cc: linux-hams@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Deepanshu Kartikey , syzbot+d7abc36bbbb6d7d40b58@syzkaller.appspotmail.com Subject: [PATCH] net: netrom: fix memory leak in nr_output() Date: Sat, 29 Nov 2025 09:12:32 +0530 Message-ID: <20251129034232.405203-1-kartikey406@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" When nr_output() fragments a large packet, it calls sock_alloc_send_skb() in a loop to allocate skbs for each fragment. If this allocation fails, the function returns without freeing the original skb that was passed in, causing a memory leak. Add the missing kfree_skb() call before returning on allocation failure. Reported-by: syzbot+d7abc36bbbb6d7d40b58@syzkaller.appspotmail.com Tested-by: syzbot+d7abc36bbbb6d7d40b58@syzkaller.appspotmail.com Closes: https://syzkaller.appspot.com/bug?extid=3Dd7abc36bbbb6d7d40b58 Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Signed-off-by: Deepanshu Kartikey --- net/netrom/nr_out.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/net/netrom/nr_out.c b/net/netrom/nr_out.c index 5e531394a724..2b3cbceb0b52 100644 --- a/net/netrom/nr_out.c +++ b/net/netrom/nr_out.c @@ -43,8 +42,11 @@ void nr_output(struct sock *sk, struct sk_buff *skb) frontlen =3D skb_headroom(skb); =20 while (skb->len > 0) { - if ((skbn =3D sock_alloc_send_skb(sk, frontlen + NR_MAX_PACKET_SIZE, 0,= &err)) =3D=3D NULL) skbn =3D sock_alloc_send_skb(sk, frontlen + NR_MAX_PACKET_SIZE, 0, &err); if (skbn =3D=3D NULL) { + kfree_skb(skb); return; + } =20 skb_reserve(skbn, frontlen); =20 --=20 2.43.0