From nobody Mon Dec 1 23:05:42 2025 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 465D530FC0A for ; Sat, 29 Nov 2025 13:18:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764422299; cv=none; b=YQ4wveTwNDLFcOb0RdLrMSd67cby4sDDemPjtucMisaBYdBaSR7D1LVdo+6Yo890EmJ5eB/6bfTut/JhJ5leZWMe7mIW3TDS203xA7IDcHvkUPHV6wRUbQdEx2pUkMC26+6Ic+pKi2FainiDf6hUd5BpzoL5SDGltky1msZjsoo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764422299; c=relaxed/simple; bh=exQ/yW6W3oFPrfMP4HI+spVKk10NGLuEbCbL4D1Pc5I=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=jcb5lM3JlqwHdQ4Q5IcSwSHc2OR9OoZ/RqfiAeyNKMotOfbCDTH9ipY94pwZB7QpoCXaipwqppDQBuvtb4No33ACxIsR5A/fLMCRiuBxfUQMMPpGqU0meRanQoW+0YjHpHr6Vh0w4mO7wMHNvkcuBrQAn4jTz+X10fDAx+6jU6o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=fNP+TS5t; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=NcWl0ZUC; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="fNP+TS5t"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="NcWl0ZUC" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5ATCeIe92794425 for ; Sat, 29 Nov 2025 13:18:11 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= uqOWIv7cuGi+zf6ysvS9UOkW7C7nCr+feFlHqhg/kcc=; b=fNP+TS5tkR2tGdXw VrmGtDkE8izfleAbFKWeYAmBDPvDopa+1maDpAga1AYOdWj02JH1xCyh4jHAN6H4 UEh+p8vCCUelOdCeR22X/3sH9/vYnZVM+ErCxH3pXHET3Nk0ccGWUwmHD1VIhPbC MGMkCoZdCE+qqLuOZSTOBrvajjpDNR+e6zIU2c7eJkrumAoc9CqzVqbtK1j/HD1L vaCwfCYI/fuQPAJiAHGrctQFCLOrveCSAgZA+8B7H1JOMb9YvhezzIRRZ+Ri/ois arDNtARUJ1KoMgIOhcGdGHZVSmm4mUl3ZiTkLg0dNpjQwj84FLLwBb7rmylYUTxZ R2c9Bw== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4aqs20rpps-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sat, 29 Nov 2025 13:18:11 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-8b52a20367fso522742285a.1 for ; Sat, 29 Nov 2025 05:18:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1764422290; x=1765027090; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=uqOWIv7cuGi+zf6ysvS9UOkW7C7nCr+feFlHqhg/kcc=; b=NcWl0ZUCmAokNlhV9ffjNrG6XGSlc8oR5tRhu/dNQHT0LrL7DkGSs1BZYOXLj89uOM jqX52r7KXwNQkqjh20HR1kX91FVYSe/kjk817d16t2srmqTnrhIa6cKPBxj7sccvGqOj k2VO5CCS3O+UDmI/HwyH8/vGeNCivQjgQi6XShHGo0+7gBwpWYf+j8X/q9oaVP7tVnOy KhN+SjBOF+F6DYbJfK2JeoKQKH/7uHABfmro9fIIB/yjGN6SV3Cd2zFurNpJgBnzWZGG 5xhq8yuVaSndttZK3leFyBAqDrDJkiGT2IbIBsMfT9KpAUXM9YS0q+z1+0pjPf7WriZQ s5vg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764422290; x=1765027090; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=uqOWIv7cuGi+zf6ysvS9UOkW7C7nCr+feFlHqhg/kcc=; b=fgLArTchlm/nMiDfW943+RluOgEvDI54W3Z3QDf6etts8xNq8b+IWyPza7iV8Dswow IskMLi9IZddQYGhGCfrAcmyaklgfajHzy0K01/3+RVsi9cP7nNv1WrQ8C4tVqGhr3oXJ W/rjcGq0IHmZM+9u1RKiBYk7jEfMl5ocof1ftw4NomXzKH6CQVF9H83CnHDeWat1+JXJ +3Yx8mHafCmiOP2shdkpGt4f8Bjt6yyzCf5OLbjUmmJXfR6Zsk9Rr9xaa+dyoLtoyyoe TE+KreZmBQntu9rmHZYdtf5mo+xm42nrLS1+TtvUzg2nbCOIBevn8t1arYuU5D+QyTbY SUiQ== X-Forwarded-Encrypted: i=1; AJvYcCXef7aKVn0AZhnXL2yIGso4Tko8JBBMFB0ypHnqUCQLPIFygRnMkXhXX+v9W90UiIKM//Nf7u7zSPLd240=@vger.kernel.org X-Gm-Message-State: AOJu0Yx7cNqJCpPMGMoh3mCbrtM7iAvVkOimQEu4QA98ys1sPpIvITay Ml2j59la0h1s1q5kZ6VR9LGB+vRoqErzQlruidpslNXhLurPF/fMeKhZlZXdMsWo13sjz3cMVk0 SB2f649k07C55ZL6qjUf/1ptm2KWYxBW2TAkmCKjN6vX/77J1y/OcKpWLK+KhPR/Aqb8= X-Gm-Gg: ASbGncvpkx5kKKi78hpy7rkkNuJjG965ClQvk6c6D05ztkjpHwB1qJNpvZFFPyFFRM3 0FIjtbVLdWCNf23n+gNceQRNyp1Sgkgv+xjsdNI6m7SR035QK3xR3lfe/Lasy1lFNF07Siq0jxW cinyowI90ORV10dUdD6rypt/K2EgZDRLWF1yzVRcblmUXJ1LeZYRDEkDlGbS6b3pwM5PZo0gyuV WehlLhxGbHaZggeThHJ/E+KK+2qMWnXpVuh3XeWc0UxLVATAiVQfwez5x4TdpKAxHuytyN1fxt0 CdrJx3ajoY5FQg9PsBT7z2H95i4EFpBWk9TZY9tVTHVlWbpwEmWGTY6ypNUS+4NaYQ7epq+gGrX sEBfcyv8FKKtC4N28uqCGnBG9m2NFKr74zA== X-Received: by 2002:a05:620a:2a03:b0:828:faae:b444 with SMTP id af79cd13be357-8b32ad1083bmr4884678785a.20.1764422289978; Sat, 29 Nov 2025 05:18:09 -0800 (PST) X-Google-Smtp-Source: AGHT+IG4lkIqGig4+ZGnJmui4QrJUzGkERmpZnJO5dkx5PRWlptxsWG94htFC/N53bln4MHSvlgMOA== X-Received: by 2002:a05:620a:2a03:b0:828:faae:b444 with SMTP id af79cd13be357-8b32ad1083bmr4884672185a.20.1764422289418; Sat, 29 Nov 2025 05:18:09 -0800 (PST) Received: from [127.0.1.1] ([178.197.195.159]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b76f5163903sm723233866b.7.2025.11.29.05.18.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 29 Nov 2025 05:18:08 -0800 (PST) From: Krzysztof Kozlowski Date: Sat, 29 Nov 2025 14:17:55 +0100 Subject: [PATCH 3/6] ASoC: qcom: q6apm: Fix confusing cleanup.h syntax Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251129-asoc-wrong-cleanup-h-can-people-stop-sending-this-without-reading-docs-v1-3-c38b06884e39@oss.qualcomm.com> References: <20251129-asoc-wrong-cleanup-h-can-people-stop-sending-this-without-reading-docs-v1-0-c38b06884e39@oss.qualcomm.com> In-Reply-To: <20251129-asoc-wrong-cleanup-h-can-people-stop-sending-this-without-reading-docs-v1-0-c38b06884e39@oss.qualcomm.com> To: Srinivas Kandagatla , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1924; i=krzysztof.kozlowski@oss.qualcomm.com; h=from:subject:message-id; bh=exQ/yW6W3oFPrfMP4HI+spVKk10NGLuEbCbL4D1Pc5I=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBpKvKIMZsFaLBHAEasSphZnnag2VVGDy+bICMru B1tmp5FYI2JAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaSryiAAKCRDBN2bmhouD 18sCEACRaKsEHFkmdS5a27kd2Q2I6Wl4PYVLFz9ZU6hmzMWHMRExBbZHVx/R+9LDqGWhW0ou/RD uu3rlm200VJ15DtesrM/DGnttq2WCm17gQEI0a0r5o35WLn56W5d73eatxm527w0iEWLZTrklGg qSZ0frlRI2Ljhh1cg5GpR0hCAqLXS1hEBvSRYRrNWn4kU/NZUKpozqz3Is8r3XZNBJR0f9lqlIF o6QdmtTU9RQj7h7N9j0K+zG0kSym3GtGAh7DKu5dU5jWxWrLPkdtYf67c0S3xo/qyijy1ixqC19 k/wv/lwBK3jL3NB8pAZjbEqdzwlwlM+2e62CLTOu3NULHpGyguAs9aPAoqhmKEDb7w2Vm7kvaVn tm9W4M86Bj9bgnxueGAaM+1goahU1G/7CoiM2PD/iSHcSZdwBkb7sojsjfIJduU+T7igm5KKZiQ iJBvJuNNOABQDOiyF1vWUx22fjmcabe+lBz5FrSDdwoU5+RVohBCpBNWu48mzxJg6Ft31iildGE YaXhK/yqDcZQ6Sp9evxPjdY/i3uAt0J1Zrs1YvZSU0tg62w44yffpuIgybTeppEyLS/MPMRG4C5 35QjvGExapOOFxJo+m9mZ6g3ohrybypJny0pxvRTXesdK/y4IKVW+HcPMvi1dnAo8FXiuGCtko0 fvbThPM4e61rP5w== X-Developer-Key: i=krzysztof.kozlowski@oss.qualcomm.com; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B X-Proofpoint-ORIG-GUID: uFW4hG2YgqsW17BwVEPcsvBg-Kb3IDCs X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTI5MDEwNiBTYWx0ZWRfX6qMaifSKAakw p3twRK2XNoAvOulkUU+Er/CqYSFVDY+ov7MHyuFMM5Xgfu3b9bbIQVT7Unfj2sCwR4N+2C6x55o 6h39Msa9Ir4Ex+UToxJhQP2FcQ47eJMbnDfUaO9anjRQk8ugJFGsVccWr+g/7eldc07OKTcHsgw feJbX85Ud/pokrVRrXfCikUTa+VlTTfPhRakDPAtNdDEja5dz2A56rTmb/AMzd41aaqKY0xMOui GkU/sxwDsda/gpesZnY1fAFvATSVRTUMt+UtpB2O/i7tvk2JyjbHOHIeB7EH9OeZI+2XdNSeI8Z 37trnkXz5UaTr9lsFJBH9pTFXvQkFSu+pRF9zcFcUXDSEdN9732rj+XLF9Ag3hvYRBj8CJDNUuS stC2f1/OUhHGMfH2jcYIA+MF8S0hpw== X-Proofpoint-GUID: uFW4hG2YgqsW17BwVEPcsvBg-Kb3IDCs X-Authority-Analysis: v=2.4 cv=EqXfbCcA c=1 sm=1 tr=0 ts=692af293 cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=FPK7cjBCgYbqzSTDLBmM0Q==:17 a=IkcTkHD0fZMA:10 a=6UeiqGixMTsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=ioz4TsFobKP2bM_RzkUA:9 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-28_08,2025-11-27_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 priorityscore=1501 suspectscore=0 bulkscore=0 lowpriorityscore=0 adultscore=0 spamscore=0 phishscore=0 malwarescore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2511290106 Commit 89cf2223ee7b ("ASoc: qcom: q6apm: Use automatic cleanup of kfree()") did not make the code simpler but more complicated. Already simple code of allocation and free, without any error paths, got now declaration with one constructor followed by another allocation, which is in contrary to explicit coding rules guiding cleanup.h: "Given that the "__free(...) =3D NULL" pattern for variables defined at the top of the function poses this potential interdependency problem the recommendation is to always define and assign variables in one statement and not group variable definitions at the top of the function when __free() is used." Code does not have a bug, but is less readable and uses discouraged coding practice, so fix that by moving declaration to the place of assignment. Signed-off-by: Krzysztof Kozlowski --- sound/soc/qcom/qdsp6/q6apm.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/sound/soc/qcom/qdsp6/q6apm.c b/sound/soc/qcom/qdsp6/q6apm.c index 94cc6376a367..4e5ad04ece50 100644 --- a/sound/soc/qcom/qdsp6/q6apm.c +++ b/sound/soc/qcom/qdsp6/q6apm.c @@ -259,7 +259,6 @@ int q6apm_unmap_memory_regions(struct q6apm_graph *grap= h, unsigned int dir) { struct apm_cmd_shared_mem_unmap_regions *cmd; struct audioreach_graph_data *data; - struct gpr_pkt *pkt __free(kfree) =3D NULL; int rc; =20 if (dir =3D=3D SNDRV_PCM_STREAM_PLAYBACK) @@ -270,8 +269,9 @@ int q6apm_unmap_memory_regions(struct q6apm_graph *grap= h, unsigned int dir) if (!data->mem_map_handle) return 0; =20 - pkt =3D audioreach_alloc_apm_pkt(sizeof(*cmd), APM_CMD_SHARED_MEM_UNMAP_R= EGIONS, dir, - graph->port->id); + struct gpr_pkt *pkt __free(kfree) =3D + audioreach_alloc_apm_pkt(sizeof(*cmd), APM_CMD_SHARED_MEM_UNMAP_REGIONS, + dir, graph->port->id); if (IS_ERR(pkt)) return PTR_ERR(pkt); =20 --=20 2.48.1