From nobody Mon Dec 1 22:04:07 2025 Received: from mail-ed1-f68.google.com (mail-ed1-f68.google.com [209.85.208.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1A6CA2D0C89 for ; Fri, 28 Nov 2025 17:48:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.68 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764352136; cv=none; b=otnSvSyWU0jchbDWNhB64REw24rS/IAouBm3Bx8NNloXOLTedtXKALhQkS2lOMH50Yl11ZYV2j73MC1CNewsMzgkZp97BXiWmzdpS0caq5pYQIzX1jvud+/9E6MGlNqLa4kp+47OyP+JvlmjUzWY+KHF0bWMit7s+VY3zAFbF0w= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764352136; c=relaxed/simple; bh=7HVMDoaN20YhFrjeqb00IcjcKaCYwEDzP0Q5ujVulXQ=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=ChDZ6mXteSFHVVpKlaz96qA+ZfTfdu72QdKqD62XhjgkkeWlFUQnjMBWLYmgvwlwPZxKNFha6T8RsrY9njuYtoxdqwbdQMv65OzH7m1BGciWRnlfgOHg0zJhnKh2CRDnBm1rkyaSKI9k9CEE8C16RxN/4YhealD6vxTwE8dyDlc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=CptPCQCb; arc=none smtp.client-ip=209.85.208.68 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CptPCQCb" Received: by mail-ed1-f68.google.com with SMTP id 4fb4d7f45d1cf-640860f97b5so3427944a12.2 for ; Fri, 28 Nov 2025 09:48:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764352133; x=1764956933; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=R+W5gOKvrPb0gok5bQ/OvKesKktbzAWVcFgy51PO4MI=; b=CptPCQCbwbczwL98it3/2zeDiGnC2uQ1KRi0xQ7mY7k0iEn4+bMxhD1Yvn7ZXHeOL/ 4NU95QCesPwq6qAYtkeF79JgaUcdsvCr4PrSg4L13YOt0q8p/nuv3+bA2c2uFn+uRpkb +ryemI5fXCqoRZtKvgeDC2Em805gOT6nXiI7hAfBjazuiIrFQwLj/M5tvWLC5gxbRohU M7MusiEukTr8RM4xkfSsXto4D6NJEXKsOWj7ArKy9d+dw9ewO/IE2zuotEz01rJSJ05R 2rgqEqjCrGZcIfhUMKpCY9OsfVlOeZM/TbMSJ//1QYHzVlz0frr2AyQadN0b7KNpan7G GQ3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764352133; x=1764956933; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=R+W5gOKvrPb0gok5bQ/OvKesKktbzAWVcFgy51PO4MI=; b=bTgCDpHiU8c815N+Zr7iCx0v4iY6azmTlvbVybzl2/ZN8EZ5O46T+jsi7+x8wsC3EY j0eu8SqB9lceCoP59U34Y9OmDk32ElRzZeFYJfGR0JL77JOWmCxaESD6jTNPD8MGmY1J OmIRXBjlB6Rv1Tsh5IQMB8wRLSKijvU86bSwbjXl3uTKu6JhzMNLgTkDQ5UXTHEPZrvz +BYlvmoQ2wnrJjsHIYppAuLxwhjHSSZ+qk2XlpSyTWb5ao13oy8oSVWMl6CFU5BUl2dL knNimRIj6GGizkkHnN2Uf6myGhhv2iU8gn3LNO5//OtcTU27k4e2eNmztnDnd8f5QHVb +YVg== X-Forwarded-Encrypted: i=1; AJvYcCVaHHGeBMstRqZAm9P9NbVxtbTC3UrOsa2nbEwjDEc8jvSM4G92XMSgKPsgF4D9Ium+WP/lDC2usQwNKwQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yy3eak+h9wE6biAnRgfHbq4VQAwBHGG5UHAPChFFBn3hdctnPK8 9LRkXPYp6LfO7qYfDolnyjVHW3Kufa0z7YEQfWV9YCjuDpSn7mlWtpsr X-Gm-Gg: ASbGncvc5oTCXw8oVPu4dAjyJxW+oolcMcLhyEpd7P8Pgf+Xn12XW3dg3GnKw9CWc+G sI66+v+cmw/f2XKvOA7Ey99DkUA+MLNzDdJJ+haZPYt/MrS19/mjNz4qCR0zcJY8aLRTFESxRB1 sZA2BDikKYw+pBG8+q+K8YyZhjJtlhDwe+ooJ2sBmYNSFwlZGwb2ZoOe+ZlSPrhvEe6NPjsltg8 Au6/kPrz74j+2St3uAmtauzon6gM/m9jnijgnxneMHwksyPvA76dVS+iDHZxsV9YSVtKqt1rCK7 myerqXvmOoBy58ANUWQM1hywwivkS6n2Nym5UK1HgpNLPZvzJd4ENvtlmxzJkIeZsiRKOQC3ST4 /QiPrpJteNVnFC27U1PiSimxEGJukK+XBc2/7cbPyEiByD7bxsRZgNk2TRZXbsfewoB6Jk7cP0n eTBsjFFHOjEKyHXsazIXDqYFEQXwXFG8ePYmQb5u805Hc5PwGLepH3wHFaRIP3aA== X-Google-Smtp-Source: AGHT+IE0PWRZLH8L2PdN8igQW7sen+hcXr7XzrBLRmRw9dCjU5BtxiVMv3i9wn/6cS0vUQP1r21zYg== X-Received: by 2002:a05:6402:1ed2:b0:640:8348:6a82 with SMTP id 4fb4d7f45d1cf-645eb7872afmr13424761a12.24.1764352133153; Fri, 28 Nov 2025 09:48:53 -0800 (PST) Received: from ubuntu-development (net-93-66-99-25.cust.vodafonedsl.it. [93.66.99.25]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-64750a90d14sm4933982a12.10.2025.11.28.09.48.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Nov 2025 09:48:52 -0800 (PST) From: Massimiliano Pellizzer To: clm@fb.com, dsterba@suse.com Cc: linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org, Massimiliano Pellizzer Subject: [PATCH] btrfs: remove dead assignment in prepare_one_folio() Date: Fri, 28 Nov 2025 17:47:55 +0000 Message-ID: <20251128174804.293605-1-mpellizzer.dev@gmail.com> X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In the error path of prepare_one_folio(), we assign ret =3D 0 before jumping to the again label to retry the operation. However, ret is immediately overwritten by ret =3D set_folio_extent_mapped(folio). The zero assignment is never observerd by any code path, therefore it can be safely removed. No functional change. Signed-off-by: Massimiliano Pellizzer --- fs/btrfs/file.c | 1 - 1 file changed, 1 deletion(-) diff --git a/fs/btrfs/file.c b/fs/btrfs/file.c index 7a501e73d880..7d875aa261d1 100644 --- a/fs/btrfs/file.c +++ b/fs/btrfs/file.c @@ -877,7 +877,6 @@ static noinline int prepare_one_folio(struct inode *ino= de, struct folio **folio_ /* The folio is already unlocked. */ folio_put(folio); if (!nowait && ret =3D=3D -EAGAIN) { - ret =3D 0; goto again; } return ret; --=20 2.51.0