From nobody Mon Dec 1 22:05:09 2025 Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DA30627934B for ; Fri, 28 Nov 2025 16:23:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764347034; cv=none; b=g9SFbDNf3pGsz2Do34xMTn+bwbXijvnbe6EAdtyNQxHsX5UFCaRTWz/Q1ObD3XIQ+rOj8H2dFYNPydFO/yZVtUj7b2oVA0FxxxQqIDxnWb7bZxA8aGUUEIDtug1Doj88unuQHRxW/DMG0b5JHOI46ckVLpWh0RNIWNNY0X44vQc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764347034; c=relaxed/simple; bh=8AJG5yBQKWcDE55dMkXjua1XYUKJh+EXVL9l65F7nDo=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=qcBpUyRnwfXbekZc3rEfwaK45fpMWrNllqEcCNj+XUZQzE+zb+zVEepnWbxuFkcXkUnRWCFVQs4FZBCJXlzKnrj5/ZY+0mYA0suy3hbnOQtGIpHZzRwYs68iDlYgcp7r3O8Nnyewczut7yoAK4TX1bDvJnUXS0lLCkimUUYBRMY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=V9Fs65e4; arc=none smtp.client-ip=209.85.216.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="V9Fs65e4" Received: by mail-pj1-f50.google.com with SMTP id 98e67ed59e1d1-3438d4ae152so2175297a91.1 for ; Fri, 28 Nov 2025 08:23:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764347032; x=1764951832; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=DYqWf7Ls1zY40ncijRlKULYV9gZmN8aGNLfyhjOpiow=; b=V9Fs65e4SKP+a3uiyWJiwjtuPZ+PIpUsMTVgFmIACgyoblqFvYyhdFKpbcHZ1Do1ao 4xZLTVTXSjjiYyLADP1B/6h1UsuyzxC36xUqIfu0NoyCOx2NgVZe7WIh5eqANq0eNE2z YPrXaXvChovVM3lmOpvaoN/wVFeu4U2M2WX2X+iAouSlkOCJ5DGCgXQI4lml3TtKJIZt Bno7XzwHDcV1tr4SzF0IDf6MetyhUOk13U2HH6wsXXYEp+oGkqt0q4hkrUm772rb5J8M LNWjMB+VJXPQYYrCy3u0YXkGs9YtQiams42gig6qxz9iJBlzm6rUDPCRbXY95fRp5TUR NRmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764347032; x=1764951832; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=DYqWf7Ls1zY40ncijRlKULYV9gZmN8aGNLfyhjOpiow=; b=ZdCYriHYx82/fiNoSpvdxcS9jmAvtJ0C4Nr2S64yvSRFtHi488PNKI5JdriFFt5WGV 2/qjjYvUGeAr4fKSQ9LqEs9/RmEVqq/nkr8LrTpjpJgoSB8ASKGPFUJDr+U22udg6COo 3WM6wvcNdmejLM4GGzuzYPc1mdalDXbp2vW8d6xSzQnv245RihSRy61kr9qmF+l4HKyj zCE3k3HMVAJoyQ0qq8XxAO7YsJx/YZRqr9KdkCOPDOQ+8kJY8u8i0PfFo+NxOe1ZodI2 e6ekGENDWfYzPaqAFgSrM/h26ZuiUl3gDS73PDpJjYXoLZKzZneVKWxCo3Zw8zUXrQeM jDrA== X-Forwarded-Encrypted: i=1; AJvYcCWr3n/BppcMdsbz/C0Y2JVi84G0r+gmuZe71MJ6D0kLUCwamm4+r5MW0lb18daYSH3/puMDeqk20Y0/8h8=@vger.kernel.org X-Gm-Message-State: AOJu0YyKAFxF01/oE82h8wDWxSzzyrekH8njUZBfuaSVkKVedMaSpiUM yE2EpArpvrU4wlC4kxOHzyyBi4nVprrbgBpY0YQdJZS2ydVoEXsv235o X-Gm-Gg: ASbGncvsMeJYgALlWqfmLmSZFQbFKD7TOH9/rng6hIHLltUMIt3+GipP484N+owsyTL LySOq2Pxt5Zw3x0VkrHEo4IwggIcXOqwnOPVQqV2t+I0DtHXpO6141StRCPQwlUu17fmCC+DitZ rY7wDVSWtl/ZvqvJycOR9MQfOYAULkMQlsJ/TFyJJNiQV69C2jVij9A0fAwlIrILL3NtGxLq0ls SZ8B4JmwYhtsauozUCwvxbShrHq0TmgG1yEa+iq5xbArQYUWJ5ZL1ACtf+rPTO6LkqFIjUm3xdy aPdXtPfBOw7ChVG2psvvAGVJOjYpo++88JVBqAragF5glPcD1Npctc5SGBJBVCiOJfFZ/dXElOT WUb7bksy5s1gikmLfbAXlAdRk4LVi6KSlsevEkBuP4m5H4b9z4fL76TufoQLpneNu11tFSV2nEW 1r1ZHQ/HL+lsOuW3PI6fG5Dm6QBxst3IrsCdljgZ14gJo7PPfmkQ5OfLylrW6eV2e0xCMsmtTYr cA= X-Google-Smtp-Source: AGHT+IH0A0s5mTjz9DmmYHjnCO3MTihjYmffYdYW00NMAmeSgGizWYLIMeWLhrh/KzSycZ+Knn6LuA== X-Received: by 2002:a17:90b:17d1:b0:313:1c7b:fc62 with SMTP id 98e67ed59e1d1-34733f2d167mr25371515a91.22.1764347031995; Fri, 28 Nov 2025 08:23:51 -0800 (PST) Received: from atharv-HP-Pavilion-x360-2-in-1-Laptop-14-ek1xxx.. ([103.216.213.160]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3477b732e5dsm5218978a91.10.2025.11.28.08.23.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Nov 2025 08:23:51 -0800 (PST) From: Atharv Dubey To: arnd@arndb.de, gregkh@linuxfoundation.org Cc: ojeda@kernel.org, alex.gaynor@gmail.com, boqun.feng@gmail.com, gary@garyguo.net, bjorn3_gh@protonmail.com, lossin@kernel.org, a.hindborg@kernel.org, aliceryhl@google.com, tmgross@umich.edu, dakr@kernel.org, rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, Atharv Dubey Subject: [PATCH] rust: miscdevice: use `pin_init::zeroed()` for C type initialization Date: Fri, 28 Nov 2025 21:53:37 +0530 Message-ID: <20251128162337.12082-1-atharvd440@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace manual zero-initialization using `MaybeUninit::zeroed().assume_init()` with `pin_init::zeroed()`. The `pin_init` helper provides a safer and clearer API for zero-initializing C structs without requiring an `unsafe` block. Link: https://github.com/Rust-for-Linux/linux/issues/1189 Signed-off-by: Atharv Dubey Suggested-by: Benno Lossin --- rust/kernel/miscdevice.rs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/rust/kernel/miscdevice.rs b/rust/kernel/miscdevice.rs index d698cddcb4a5..e168e9da8f4a 100644 --- a/rust/kernel/miscdevice.rs +++ b/rust/kernel/miscdevice.rs @@ -20,7 +20,7 @@ seq_file::SeqFile, types::{ForeignOwnable, Opaque}, }; -use core::{marker::PhantomData, mem::MaybeUninit, pin::Pin}; +use core::{marker::PhantomData, pin::Pin}; =20 /// Options for creating a misc device. #[derive(Copy, Clone)] @@ -33,7 +33,7 @@ impl MiscDeviceOptions { /// Create a raw `struct miscdev` ready for registration. pub const fn into_raw(self) -> bindings::miscdevice { // SAFETY: All zeros is valid for this C type. - let mut result: bindings::miscdevice =3D unsafe { MaybeUninit::zer= oed().assume_init() }; + let mut result: bindings::miscdevice =3D pin_init::zeroed(); result.minor =3D bindings::MISC_DYNAMIC_MINOR as ffi::c_int; result.name =3D crate::str::as_char_ptr_in_const_context(self.name= ); result.fops =3D MiscdeviceVTable::::build(); @@ -421,7 +421,7 @@ impl MiscdeviceVTable { None }, // SAFETY: All zeros is a valid value for `bindings::file_operatio= ns`. - ..unsafe { MaybeUninit::zeroed().assume_init() } + ..pin_init::zeroed() }; =20 const fn build() -> &'static bindings::file_operations { --=20 2.43.0