From nobody Mon Dec 1 22:05:00 2025 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C3D81257827 for ; Fri, 28 Nov 2025 15:30:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764343802; cv=none; b=vDD2n/eElIfAEq7z52YY72gJSmR5IXrSDyZ5vtqbGQd5yg19gnyzjwGfE9SDIjRGa1hnciBFpnYxBJQs4BmQBOsp2zRT7XuVBoWg3mal6mMRZ7m0fIpKPEWPGeEhPy936tqkeo0n7GQ8Mz5TU7MpJzImNGNJ0lqIrTuNje5A9Qs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764343802; c=relaxed/simple; bh=254QBeoL5Fe95P2NE9XyCG6i4ZeY8SK+NxCuQM/ifHE=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=CEPtryT2A6nWRTfzcEcakKCelWNqbrs40wMCWBxlqSia6sfMOCAHB8jQYQ3S6ZXw+p3rHaHALOtIlVxwxuIvDC5TmABEPqcaWi7rBUa4Tk1OjpC0V+AhZz2y4vYf5fT/hOxDgj4c1uZwc6712JD2cRdujSBcInzo7FrPceV2ldI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ENccGllH; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ENccGllH" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-4779ce2a624so18290005e9.2 for ; Fri, 28 Nov 2025 07:30:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764343799; x=1764948599; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=VLw1fb3J6TOMXR+L319Gr71N9pY3Ku2H8OfmHiEFvJ0=; b=ENccGllHX3i/BiH+ra5eQUemTf8SAU0V03OrUh3i2fetcBlkV+ffrYLBUx7RaSZi/Z dA22J/vs+neYR0JjYaBCw85gPLB/RAmNPV5G/732WEIMtvO7Iq0jC6RfBWk/NHyIsozu 7m5/WkdstlTTIdGxfa2MgQ30YA8vArXSd8J4nJWp7xdM/rPHBZ1OwYpdtKtXsTucgabx duXYXK1ENFlYemns9zkBqe+8Jg347+v1msF1sbK+mSVIL16XaHvxJN16soe9uaHqUAF6 P3KyLVsdt/uPSrLeALzeYqwfpDjeaC2NTGiN/co3DQL5LCy/5u+lOfQVAvl4mjHHA6tx ZgWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764343799; x=1764948599; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=VLw1fb3J6TOMXR+L319Gr71N9pY3Ku2H8OfmHiEFvJ0=; b=iM9UyIPvEQQ1Lnd/TWfduLJtb5V7qrkokUISIPD2U2XQJgqf4K3w+leHp2G85uYIYX VsOPbdTIde6FucLd3L9t967fVR5t8GnLEcj3zznwBwy3s3QhzC3R47lFLhy6/7cRjShr CnDpMerLI65ursNrIkeYheKY3ycPQUr7jZxFpTXvwaYXBMN93kWJimo8k1kEweBvMbOv 7IHX8++wVCkylMYFHDp5PVJwEkFsQGL+UUkec7Iau5iVeqGXYUJmgGoRykXQOfJpy785 +zD7tVPpoi8T7PmzUFXEzE0K5bn/qujkMn/XeJ/wJZE6BgN+IyWbJieA3ATPje19A2FI KHxg== X-Forwarded-Encrypted: i=1; AJvYcCXo0557Leb6s94PPZjCvwCXpl4n8j2EDQQN3igeQhKIkQt2G1SBMM7KNRPFNemVIke0+de5cfSsdvifr6U=@vger.kernel.org X-Gm-Message-State: AOJu0YzkbDqnxcLt/bg8xwSpD3FZfbqxYDROIKrHYhyUSaIweT+Gyh7f Kw47cgXfrsSyMJcPPiLHtqh8NIziIWYIA10prWuGyLw340NByi33ri3+ X-Gm-Gg: ASbGncv8/VISCBFnLje1UxhyZwvUQEdyTZ8W0OB+JoBLSWifbd2hzOQlq8mVoSXdp6i n9E4BPObEzIMGi7LPhRT+LrbNRRRaLetx0Y0iZjgt+xR7WtWW3wh8Ucvf7E7fJI/GvqBji/jdqk pQnFwaDAKK4UoDgu9NZ8FmA7nq8QCRxDyppyEtR8tSRIOCoMXIGuGTjB0mIJWRbchXXFBh3MLIb wOCU0ECsRDJWm5py09qE4eWmupFuMEAafTBRc6HzW6F/sD/YHtMYjRY+mn30x5fxddLqe7+tJrx 71GEKGU1hayslDpdWZ/OCq+61VEsvmuAR2A9chB41SuGeQgl7iOLXfIh+vM1mhVQWhaW+HvrYdq BYAloFQDLs5QBiFXNu1QqRdEuwf2un6hOptIooPe9iECy5ac8Ehbm+DGVq2nyhCfYBqC5BgO/RY bmxtk18XUzme4T9eXH X-Google-Smtp-Source: AGHT+IHe2ydxf6lPwxV90Ak4namhsLUQl+tCtqrEoRjIaTMZaOICDb5ou+adCoW/FagZ4VbtLlpaBg== X-Received: by 2002:a05:6000:2007:b0:42b:39ae:d096 with SMTP id ffacd0b85a97d-42e0f1d6672mr15202949f8f.10.1764343798869; Fri, 28 Nov 2025 07:29:58 -0800 (PST) Received: from gattout.local ([82.150.17.146]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42e1c5c30b8sm10296213f8f.7.2025.11.28.07.29.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Nov 2025 07:29:58 -0800 (PST) From: Amin GATTOUT To: vkoul@kernel.org, thomasandreatta2000@gmail.com Cc: dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, Amin GATTOUT Subject: [PATCH] shdmac: Remove misleading TODO comment in dmae_set_chcr Date: Fri, 28 Nov 2025 16:29:48 +0100 Message-ID: <20251128152947.304976-2-amin.gattout@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The comment suggested that the dmae_is_busy() check in dmae_set_chcr() is superfluous and could be removed. However, this check serves as an important safety net to prevent configuration of a DMA channel while it is active. Keeping it helps ensure transfer integrity and avoids unexpected hardware behavior in edge cases. Signed-off-by: Amin GATTOUT --- drivers/dma/sh/shdmac.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/dma/sh/shdmac.c b/drivers/dma/sh/shdmac.c index 603e15102e45..d0e0437ad916 100644 --- a/drivers/dma/sh/shdmac.c +++ b/drivers/dma/sh/shdmac.c @@ -243,7 +243,6 @@ static void dmae_init(struct sh_dmae_chan *sh_chan) =20 static int dmae_set_chcr(struct sh_dmae_chan *sh_chan, u32 val) { - /* If DMA is active, cannot set CHCR. TODO: remove this superfluous check= */ if (dmae_is_busy(sh_chan)) return -EBUSY; =20 --=20 2.43.0