From nobody Mon Dec 1 22:37:14 2025 Received: from mx0a-00128a01.pphosted.com (mx0a-00128a01.pphosted.com [148.163.135.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 43CC41A9F93; Fri, 28 Nov 2025 14:45:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.135.77 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764341131; cv=none; b=oOaU5yOuzQ8s9KnZS+ELbAeGX1kuYE0TM++BEuTApkH3on7UmS0kjO8sZYSp626YSxfUFmsymFlJkgwdR3kkPLOyEhztNkGjKUye3TlTtvCJMaZCt3OyvlUEsvxrAC3L/MYLLQoz8ZjwmmJnL2mftGzj7FH85Up35Ugra4HSgUo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764341131; c=relaxed/simple; bh=wUzItuozp3DqDKc+58vB2xGM56xJa2p7o/ogg260SLY=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=NA/ZFtkaZwnnbvo7fIUg+4xqgOkplF8iMKe8esOtFPJn1Bx7o43pKznASqLKQZymXe6y/8a8PCUyip2HztWpd3R9eF2/f3a/8UeaXcySt7ZBfnCMXF9BJKoU7H6LstI+4diiyvcf3PTunwsQepTIbHiR3ndfBd5zv5XpnocyhAs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=analog.com; spf=pass smtp.mailfrom=analog.com; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b=RssnllxR; arc=none smtp.client-ip=148.163.135.77 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=analog.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=analog.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b="RssnllxR" Received: from pps.filterd (m0167089.ppops.net [127.0.0.1]) by mx0a-00128a01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5AS9tUAT3943744; Fri, 28 Nov 2025 09:45:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=analog.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=DKIM; bh=+KB3Z t8ELYRAtYQyrCQBqRBUrU7iGXJyy/+bdj6EGUg=; b=RssnllxRfoBvx+it4bL50 nP2YNTv2FzWwEPR4IpJRxjO3jeOY2LXBV/TigyytVjO1XGiYv4gjlkti7B8LY/Pj +Wwmh1Nv+/zaUTV1WeBI3UCxz+RWT/GUFJktu1Y8+IgLk+EAnS9oHg5R58ZWUYFn 4YY2ufwdze6JwOBtRcZhYN/TMvSDAfYHwfb9ki4mBIlytkZt1ZTHtbwtBVHz1Fny FaCgPNg4EOUCu32QBT0J8vGYpZn2Ng2/kWZzCpejmGL+7EYJ902TNqqZmM5dh4QL /b/vTuLmmlmbgC23gQmFnuGhSJH3CVIWjQ1b+L48PgY7RGnD5d7X8s2HQQrAyO/p w== Received: from nwd2mta3.analog.com ([137.71.173.56]) by mx0a-00128a01.pphosted.com (PPS) with ESMTPS id 4aph60prjn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 28 Nov 2025 09:45:13 -0500 (EST) Received: from ASHBMBX9.ad.analog.com (ASHBMBX9.ad.analog.com [10.64.17.10]) by nwd2mta3.analog.com (8.14.7/8.14.7) with ESMTP id 5ASEjCTU026755 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 28 Nov 2025 09:45:12 -0500 Received: from ASHBMBX9.ad.analog.com (10.64.17.10) by ASHBMBX9.ad.analog.com (10.64.17.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1748.37; Fri, 28 Nov 2025 09:45:12 -0500 Received: from zeus.spd.analog.com (10.66.68.11) by ashbmbx9.ad.analog.com (10.64.17.10) with Microsoft SMTP Server id 15.2.1748.37 via Frontend Transport; Fri, 28 Nov 2025 09:45:12 -0500 Received: from HYB-b1tGeUj4GP1.ad.analog.com ([10.32.13.98]) by zeus.spd.analog.com (8.15.1/8.15.1) with ESMTP id 5ASEilHq011408; Fri, 28 Nov 2025 09:45:06 -0500 From: Antoniu Miclaus To: Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , , , CC: Antoniu Miclaus Subject: [PATCH v5 2/2] iio: amplifiers: adl8113: add driver support Date: Fri, 28 Nov 2025 16:44:11 +0200 Message-ID: <20251128144428.24450-3-antoniu.miclaus@analog.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251128144428.24450-1-antoniu.miclaus@analog.com> References: <20251128144428.24450-1-antoniu.miclaus@analog.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ADIRuleOP-NewSCL: Rule Triggered X-Proofpoint-GUID: WhJKHhNx5u_6myQyeJ0czklIFp4wNG2o X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTI4MDEwOCBTYWx0ZWRfXzPeoNl2cKR6l jfKOJTRxKZeIGCo79CnPC9xKdjZJaDWcHhU1qF6frcmMVL3exrZ1ZixaUNOEdipra0JiOHs2VR/ 9cnEQ982j6F4aHAqnfxdKFobaBtUxeAKl7srgg/WPIxazZS28KX2X5FFY6kPlnC8J+VSRnQXX4v Eik9bb0TGxFH+AKsTLvnt0aA4vRh2gtXdUgB9uU4NsJiXdLBA/u4bNY6/3eguzvQUT5/YTd3CO6 Sxa64QB6zy8hPrjnW9s8za+jFP4o/FvhnXtnZ50+dALZdjZzbi0m9pUp0mmO6ryjMT43pv+q3PV JloN+ecMmgFi3jZgH7c44YVjbFPFmbWiE7n/LFBn0jSCQJZy0GiBMwxZoLDerQMFnw8iMpt/FPp 4TFfzqBBIdxXge+VQhXPi82eZRPkXg== X-Authority-Analysis: v=2.4 cv=BN2+bVQG c=1 sm=1 tr=0 ts=6929b57a cx=c_pps a=PpDZqlmH/M8setHirZLBMw==:117 a=PpDZqlmH/M8setHirZLBMw==:17 a=6UeiqGixMTsA:10 a=VkNPw1HP01LnGYTKEx00:22 a=gAnH3GRIAAAA:8 a=hAzo1ZWYCqDvnDRTSZMA:9 X-Proofpoint-ORIG-GUID: WhJKHhNx5u_6myQyeJ0czklIFp4wNG2o X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-28_03,2025-11-27_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 suspectscore=0 spamscore=0 adultscore=0 lowpriorityscore=0 impostorscore=0 bulkscore=0 clxscore=1015 phishscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2511280108 Content-Type: text/plain; charset="utf-8" Add support for adl8113 10MHz to 12GHz Low Noise Amplifier with 10MHz to 14GHz bypass switches. Signed-off-by: Antoniu Miclaus --- Changes in v5: - Replace separate gpio_va and gpio_vb with gpio_descs array - Use devm_gpiod_get_array() instead of devm_gpiod_get() with validation - Update adl8113_set_path() to use bitmap and gpiod_set_array_value_canslee= p() - Change internal bypass gain from 0dB to -2dB (insertion loss) - Add INT_MIN gain value for unused external bypass paths (testing) - Fix error propagation in adl8113_write_raw() to return actual error code - Change duplicate gain error handling to use dev_err_probe() - Remove indexed and channel fields from IIO channel spec - Reorder supply names array (vss2 before vdd2) drivers/iio/amplifiers/Kconfig | 12 ++ drivers/iio/amplifiers/Makefile | 1 + drivers/iio/amplifiers/adl8113.c | 290 +++++++++++++++++++++++++++++++ 3 files changed, 303 insertions(+) create mode 100644 drivers/iio/amplifiers/adl8113.c diff --git a/drivers/iio/amplifiers/Kconfig b/drivers/iio/amplifiers/Kconfig index 55eb16b32f6c..a8a604863eed 100644 --- a/drivers/iio/amplifiers/Kconfig +++ b/drivers/iio/amplifiers/Kconfig @@ -36,6 +36,18 @@ config ADA4250 To compile this driver as a module, choose M here: the module will be called ada4250. =20 +config ADL8113 + tristate "Analog Devices ADL8113 Low Noise Amplifier" + depends on GPIOLIB + help + Say yes here to build support for Analog Devices ADL8113 Low Noise + Amplifier with integrated bypass switches. The device supports four + operation modes controlled by GPIO pins: internal amplifier, + internal bypass, and two external bypass modes. + + To compile this driver as a module, choose M here: the + module will be called adl8113. + config HMC425 tristate "Analog Devices HMC425A and similar GPIO Gain Amplifiers" depends on GPIOLIB diff --git a/drivers/iio/amplifiers/Makefile b/drivers/iio/amplifiers/Makef= ile index 2126331129cf..0a76443be1aa 100644 --- a/drivers/iio/amplifiers/Makefile +++ b/drivers/iio/amplifiers/Makefile @@ -6,4 +6,5 @@ # When adding new entries keep the list in alphabetical order obj-$(CONFIG_AD8366) +=3D ad8366.o obj-$(CONFIG_ADA4250) +=3D ada4250.o +obj-$(CONFIG_ADL8113) +=3D adl8113.o obj-$(CONFIG_HMC425) +=3D hmc425a.o diff --git a/drivers/iio/amplifiers/adl8113.c b/drivers/iio/amplifiers/adl8= 113.c new file mode 100644 index 000000000000..eed5fe69280b --- /dev/null +++ b/drivers/iio/amplifiers/adl8113.c @@ -0,0 +1,290 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * ADL8113 Low Noise Amplifier with integrated bypass switches + * + * Copyright 2025 Analog Devices Inc. + */ + +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include + +enum adl8113_signal_path { + ADL8113_INTERNAL_AMP, + ADL8113_INTERNAL_BYPASS, + ADL8113_EXTERNAL_A, + ADL8113_EXTERNAL_B, +}; + +struct adl8113_gain_config { + enum adl8113_signal_path path; + int gain_db; + int va; + int vb; +}; + +struct adl8113_state { + struct gpio_descs *gpios; + struct adl8113_gain_config *gain_configs; + int num_gain_configs; + enum adl8113_signal_path current_path; +}; + +static const char * const adl8113_supply_names[] =3D { + "vdd1", + "vss2", + "vdd2" +}; + +static int adl8113_set_path(struct adl8113_state *st, + enum adl8113_signal_path path) +{ + DECLARE_BITMAP(values, 2); + int ret; + + bitmap_zero(values, 2); + + /* Determine GPIO values based on signal path */ + switch (path) { + case ADL8113_INTERNAL_AMP: + /* va=3D0, vb=3D0 - already zero */ + break; + case ADL8113_INTERNAL_BYPASS: + /* va=3D1, vb=3D1 */ + __set_bit(0, values); + __set_bit(1, values); + break; + case ADL8113_EXTERNAL_A: + /* va=3D0, vb=3D1 */ + __set_bit(1, values); + break; + case ADL8113_EXTERNAL_B: + /* va=3D1, vb=3D0 */ + __set_bit(0, values); + break; + default: + return -EINVAL; + } + + ret =3D gpiod_set_array_value_cansleep(st->gpios->ndescs, st->gpios->desc, + st->gpios->info, values); + if (ret) + return ret; + + st->current_path =3D path; + return 0; +} + +static int adl8113_find_gain_config(struct adl8113_state *st, int gain_db) +{ + int i; + + for (i =3D 0; i < st->num_gain_configs; i++) { + if (st->gain_configs[i].gain_db =3D=3D gain_db) + return i; + } + return -EINVAL; +} + +static const struct iio_chan_spec adl8113_channels[] =3D { + { + .type =3D IIO_VOLTAGE, + .info_mask_shared_by_type =3D BIT(IIO_CHAN_INFO_HARDWAREGAIN), + }, +}; + +static int adl8113_read_raw(struct iio_dev *indio_dev, + struct iio_chan_spec const *chan, + int *val, int *val2, long mask) +{ + struct adl8113_state *st =3D iio_priv(indio_dev); + int i; + + switch (mask) { + case IIO_CHAN_INFO_HARDWAREGAIN: + /* Find current gain configuration */ + for (i =3D 0; i < st->num_gain_configs; i++) { + if (st->gain_configs[i].path =3D=3D st->current_path) { + *val =3D st->gain_configs[i].gain_db; + *val2 =3D 0; + return IIO_VAL_INT_PLUS_MICRO_DB; + } + } + return -EINVAL; + default: + return -EINVAL; + } +} + +static int adl8113_write_raw(struct iio_dev *indio_dev, + struct iio_chan_spec const *chan, + int val, int val2, long mask) +{ + struct adl8113_state *st =3D iio_priv(indio_dev); + int config_idx; + + switch (mask) { + case IIO_CHAN_INFO_HARDWAREGAIN: + if (val2 !=3D 0) + return -EINVAL; + + config_idx =3D adl8113_find_gain_config(st, val); + if (config_idx < 0) + return config_idx; + + return adl8113_set_path(st, st->gain_configs[config_idx].path); + default: + return -EINVAL; + } +} + +static const struct iio_info adl8113_info =3D { + .read_raw =3D adl8113_read_raw, + .write_raw =3D adl8113_write_raw, +}; + +static int adl8113_init_gain_configs(struct device *dev, struct adl8113_st= ate *st) +{ + int external_a_gain, external_b_gain, i =3D 0, j; + + /* + * Allocate for all 4 possible paths: + * - Internal amp and bypass (always present) + * - External bypass A and B (optional, or INT_MIN for testing) + */ + st->gain_configs =3D devm_kcalloc(dev, 4, + sizeof(*st->gain_configs), GFP_KERNEL); + if (!st->gain_configs) + return -ENOMEM; + + /* Always include internal amplifier (14dB) */ + st->gain_configs[i].path =3D ADL8113_INTERNAL_AMP; + st->gain_configs[i].gain_db =3D 14; + i++; + + /* Always include internal bypass (-2dB insertion loss) */ + st->gain_configs[i].path =3D ADL8113_INTERNAL_BYPASS; + st->gain_configs[i].gain_db =3D -2; + i++; + + /* Add external bypass A if configured */ + if (!device_property_read_u32(dev, "adi,external-bypass-a-gain-db", + &external_a_gain)) { + st->gain_configs[i].path =3D ADL8113_EXTERNAL_A; + st->gain_configs[i].gain_db =3D external_a_gain; + i++; + } + + /* Add external bypass B if configured */ + if (!device_property_read_u32(dev, "adi,external-bypass-b-gain-db", + &external_b_gain)) { + st->gain_configs[i].path =3D ADL8113_EXTERNAL_B; + st->gain_configs[i].gain_db =3D external_b_gain; + i++; + } + + /* + * If there's a free external bypass path, add one with INT_MIN gain + * to represent "nothing connected" for testing purposes + */ + if (!device_property_present(dev, "adi,external-bypass-a-gain-db")) { + st->gain_configs[i].path =3D ADL8113_EXTERNAL_A; + st->gain_configs[i].gain_db =3D INT_MIN; + i++; + } else if (!device_property_present(dev, "adi,external-bypass-b-gain-db")= ) { + st->gain_configs[i].path =3D ADL8113_EXTERNAL_B; + st->gain_configs[i].gain_db =3D INT_MIN; + i++; + } + + st->num_gain_configs =3D i; + + /* Check for duplicate gain values */ + for (i =3D 0; i < st->num_gain_configs - 1; i++) { + for (j =3D i + 1; j < st->num_gain_configs; j++) { + if (st->gain_configs[i].gain_db =3D=3D st->gain_configs[j].gain_db) + return dev_err_probe(dev, -EINVAL, + "Duplicate gain values not allowed: %d dB\n", + st->gain_configs[i].gain_db); + } + } + + return 0; +} + +static int adl8113_probe(struct platform_device *pdev) +{ + struct device *dev =3D &pdev->dev; + struct adl8113_state *st; + struct iio_dev *indio_dev; + int ret; + + indio_dev =3D devm_iio_device_alloc(dev, sizeof(*st)); + if (!indio_dev) + return -ENOMEM; + + st =3D iio_priv(indio_dev); + + st->gpios =3D devm_gpiod_get_array(dev, "ctrl", GPIOD_OUT_LOW); + if (IS_ERR(st->gpios)) + return dev_err_probe(dev, PTR_ERR(st->gpios), + "failed to get control GPIOs\n"); + + if (st->gpios->ndescs !=3D 2) + return dev_err_probe(dev, -EINVAL, + "expected 2 control GPIOs, got %d\n", + st->gpios->ndescs); + + ret =3D devm_regulator_bulk_get_enable(dev, + ARRAY_SIZE(adl8113_supply_names), + adl8113_supply_names); + if (ret) + return dev_err_probe(dev, ret, + "failed to get and enable supplies\n"); + + /* Initialize gain configurations from devicetree */ + ret =3D adl8113_init_gain_configs(dev, st); + if (ret) + return ret; + + /* Initialize to internal amplifier path (14dB) */ + ret =3D adl8113_set_path(st, ADL8113_INTERNAL_AMP); + if (ret) + return ret; + + indio_dev->info =3D &adl8113_info; + indio_dev->name =3D "adl8113"; + indio_dev->channels =3D adl8113_channels; + indio_dev->num_channels =3D ARRAY_SIZE(adl8113_channels); + + return devm_iio_device_register(dev, indio_dev); +} + +static const struct of_device_id adl8113_of_match[] =3D { + { .compatible =3D "adi,adl8113" }, + { } +}; +MODULE_DEVICE_TABLE(of, adl8113_of_match); + +static struct platform_driver adl8113_driver =3D { + .driver =3D { + .name =3D "adl8113", + .of_match_table =3D adl8113_of_match, + }, + .probe =3D adl8113_probe, +}; + +module_platform_driver(adl8113_driver); + +MODULE_AUTHOR("Antoniu Miclaus "); +MODULE_DESCRIPTION("Analog Devices ADL8113 Low Noise Amplifier"); +MODULE_LICENSE("GPL"); --=20 2.43.0