From nobody Mon Dec 1 22:05:14 2025 Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ECB3D3081DE for ; Fri, 28 Nov 2025 12:44:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764333846; cv=none; b=uzgqg0oysFIDf6G9x/cvkePff68fSHtUMteNJoDx6Vkf25IE9kTANZ/8VPvkIzfs1zIAIx//ZjvlJIDNo1eIl530U+sqKrrkh9HDiDZW7bwXJmKS9OaeQJVHLRj+oazM2TbbWpztnYFLXoqC6G5StJ8vzZyLM17F71TbEL553KI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764333846; c=relaxed/simple; bh=+JYkccohJPxtTxgjO0MmVJPCD7JdGHRBlF9twCxotsg=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=lQIlho1KhXlW+I2cbh4abU/J81DkBRbeJYggQ+3PiBAfegLpQsLXasn9H6z3a4ggrvyMC/XQiAGMkljRjtBCFKKfuQemORvTFq3zNwZUrqRVhIO61cOAgJs7X7KPUtA4E/j7NQqZuMqwekBbG14wvBhKFyunhH7x0zjyTfo3pds= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hBbTXaSy; arc=none smtp.client-ip=209.85.210.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hBbTXaSy" Received: by mail-pf1-f181.google.com with SMTP id d2e1a72fcca58-7bc248dc16aso1510837b3a.0 for ; Fri, 28 Nov 2025 04:44:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764333842; x=1764938642; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=g6/uSvuju5dWyLVdRy0T4vm/UMOcqMe/o27PlacpwM4=; b=hBbTXaSyjlTw8HEFVJn5/plEB0pOXymv8KcvHyRmjQm5ttBE8Nd5X97c3RmR5xSjFO bIitDex5TBZpds2fz2V5/WxVdxidDmYajTa094tT88uWAo8ugq4+DoA9bdYfvBX81Mlb sHt+hj4eSTaSwA0eU6F19uR+McAE/Nr62Tsy6SdRr5mUvEk0kU4ktlaZ0txsWFUXvuij tFQ+iz/vczsejHt36octw7amxakFDXh48ClcPPp8/KTfWoD7cXUDnuT9ava4A86P3adc khX0rAQqviL7t6Lmr+Fj4d4hM/+7L5t5/c0jTs0bsgA4oIMm4qBySRfxzx7lbqzHPKjl 470g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764333842; x=1764938642; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=g6/uSvuju5dWyLVdRy0T4vm/UMOcqMe/o27PlacpwM4=; b=mBrvXOiLDUk7CV4YTx06vHhcPMkV2qZpvehJ3PlowZx2VAQKtGX3eVY8imKFkcCD9G w2UZyL6wavXMfBn/w4BX3spqvBLPTF2g6tPl7/QcdDwKHBZ/4jZO59C3oX7xovB7QlBq ln0eYyw2EvQ73ofIHKceaEOeHGcuOHIgBZGAHAzCrBg0c+U52a2/oJtVrJ3Jtcv6BgVz nkAU5Ex8WzdUx8BxiAj+MF02CdQy6L8BWn0esjoV/9763YpB7BUuUrZ7euP4Q8HDUdZz 40qmGmgrydeEtbH/ykCtEQzOpI6elC3qlTPjBvxcSOZk74Bxx4Mh2lfR/9FE7s9SlzRV vz6Q== X-Forwarded-Encrypted: i=1; AJvYcCXlCdQCM4JZnM+SIWT6/0ULgwn8WJ/v/lPzQct10aPrx8X5le43LRb2d0j+3+6HhRWCeOz2VuSzI3fsbKE=@vger.kernel.org X-Gm-Message-State: AOJu0YybQ731XdngQDYgXkBPi/i71Bx40IdWK2HuUkPODGSmZthYz5tF Xv2iSN5oE+yBVQDiHGo/Bc9HRKKLAHzdHIKR0lIs2y1bzZUO2fL8aJM9 X-Gm-Gg: ASbGnctPVBzaCgoMSuqkPcJ7nPJWP68750fFpBPYxgqWQ7uDP71VkyVxk1eXokr+gLV G+QcQDQ9EZnRwejiOcvrjKc6JBBrIYFyXliODRR2v7rUawm6Haiwhc2AttLeZS613+uleTQp5Ao e7KPkcptYy0/9y4QnYU4Osouhv+eoYQ1q5lXehWoOjvtwjPcLM6JD4Or4unPB6ZvnzHp/XxD8iz OLmm5kjNtF4D/ObmIJb8QAlw9KoERMWnDgoYZSL1ScoMLioSRdVegZPvZvBQSNQNVCMw3y9GFC7 jsA/5qmzpWLMWhgHbMB+3aIq3O0AYY3JtxVb+z2eU9IxVgr6v9ypFgjfH1s68MB3Tt+0RI+HVyR oFlAeQEt6XmlnG50Q2+XYXVutOjw+RnwQ82rgKuZ8FCqgMNxIkv0Ub7mtE8IG/ddfnG25PtVk2W XzoTWo0UiuTyFd+TA4mnu4cgnCn8Byz7xYRw4XiEmkz5SxYC8J6YA0cd0eDp4FanGYW+pN X-Google-Smtp-Source: AGHT+IHnVGP8yrJTrTUzWQ3F5T6qXbi4UBMigIZNP3pQOi7ZqlFIIgzezyL6g3DHg4jAEFru+7lPSQ== X-Received: by 2002:a05:7022:221f:b0:11d:c22e:a131 with SMTP id a92af1059eb24-11dc22ea170mr6731615c88.3.1764333841703; Fri, 28 Nov 2025 04:44:01 -0800 (PST) Received: from 2045L.localdomain (7.sub-75-221-66.myvzw.com. [75.221.66.7]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-11dcb057cb0sm20974322c88.9.2025.11.28.04.43.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Nov 2025 04:44:01 -0800 (PST) From: Gui-Dong Han To: linux@roeck-us.net Cc: linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org, Gui-Dong Han , stable@vger.kernel.org Subject: [PATCH] hwmon: (max6620) Add locking to avoid TOCTOU Date: Fri, 28 Nov 2025 20:43:51 +0800 Message-ID: <20251128124351.3778-1-hanguidong02@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The function max6620_read checks shared data (tach and target) for zero before passing it to max6620_fan_tach_to_rpm, which uses it as a divisor. These accesses are currently lockless. If the data changes to zero between the check and the division, it causes a divide-by-zero error. Explicitly acquire the update lock around these checks and calculations to ensure the data remains stable, preventing Time-of-Check to Time-of-Use (TOCTOU) race conditions. This change also aligns the locking behavior with the hwmon_fan_alarm case, which already uses the update lock. Link: https://lore.kernel.org/all/CALbr=3DLYJ_ehtp53HXEVkSpYoub+XYSTU8Rg=3D= o1xxMJ8=3D5z8B-g@mail.gmail.com/ Fixes: e8ac01e5db32 ("hwmon: Add Maxim MAX6620 hardware monitoring driver") Cc: stable@vger.kernel.org Signed-off-by: Gui-Dong Han --- Based on the discussion in the link, I will submit a series of patches to address TOCTOU issues in the hwmon subsystem by converting macros to functions or adjusting locking where appropriate. --- drivers/hwmon/max6620.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/hwmon/max6620.c b/drivers/hwmon/max6620.c index 13201fb755c9..0dce2f5cb61b 100644 --- a/drivers/hwmon/max6620.c +++ b/drivers/hwmon/max6620.c @@ -290,20 +290,24 @@ max6620_read(struct device *dev, enum hwmon_sensor_ty= pes type, u32 attr, *val =3D max6620_fan_div_from_reg(data->fandyn[channel]); break; case hwmon_fan_input: + mutex_lock(&data->update_lock); if (data->tach[channel] =3D=3D 0) { *val =3D 0; } else { div =3D max6620_fan_div_from_reg(data->fandyn[channel]); *val =3D max6620_fan_tach_to_rpm(div, data->tach[channel]); } + mutex_unlock(&data->update_lock); break; case hwmon_fan_target: + mutex_lock(&data->update_lock); if (data->target[channel] =3D=3D 0) { *val =3D 0; } else { div =3D max6620_fan_div_from_reg(data->fandyn[channel]); *val =3D max6620_fan_tach_to_rpm(div, data->target[channel]); } + mutex_unlock(&data->update_lock); break; default: return -EOPNOTSUPP; --=20 2.43.0