From nobody Mon Dec 1 22:04:05 2025 Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BB24D30DEBC for ; Fri, 28 Nov 2025 12:38:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764333532; cv=none; b=eiQToGLqO3maJ0AaDMkclWWElPyEXJF1vZ4gcj5t5bPVO70tXlUxyLQq6YLmLPKitQuOS4pQWwb4HuhcWyAsjpBAc1ISYJIwWU4eB0s6za/rj8YqZmRUMD4dejD0S7fGXZkVB6rmysbealEhuvZJdwYyyYfeYcjdPRBRAOzEXvE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764333532; c=relaxed/simple; bh=/oucUdI4s6hMDaFfL69cWC2kmdkZHo8+wo/d7zs3NQI=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=kLDWtLT9M/krbW5tlOip2k+JSXnonJbD0Nd7IsiDHbkzR2OvZY3dUYRHAJxZ+6numFLf4JvKGx9hXbh+pEb7KrW7g3KldwMTfsePFkDWWmmqChVeQ02KyiSndYH+pzjPEAkk9ihl9wnheKHd6YKdhJlkGqiuwCWCXzpWwKotq+s= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=OfULMyxG; arc=none smtp.client-ip=209.85.210.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OfULMyxG" Received: by mail-pf1-f179.google.com with SMTP id d2e1a72fcca58-7ad1cd0db3bso1505678b3a.1 for ; Fri, 28 Nov 2025 04:38:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764333524; x=1764938324; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=+gmGE0zgXdosAgPn5zQUUbQPBAhgt9HdrlUFjfdvA8k=; b=OfULMyxGJCjnnRtkfIsLQG3xnIOBARjYNVF2vmJ/q1ZR5CuhY+rhqoTGM0SrFWG7z5 n4SOKS8Z6p4e29LGB3pR0yPxitVRVaEjnZdwiFpswd/7LuYo4ccogq+dvKoqDNdAA2Bm Qxok9JQoebCwfposwjpUDdo1t7CxJXhf2MlPFIVDIANmoibbXQC7oUSiaKB25W9PCuPo eVmiO3Pvy2+CVavwsKyUNJuus45PJ3si8ZEIwbgMSdCiQQvb5+3cGGU4h2vLSjfgxc8V evu/kiXj43n2J06QIWog+kxTLapRjbJqyP9XQamqN8r+AEkq968O0c9QlSTDJajd6kgE nn8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764333524; x=1764938324; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=+gmGE0zgXdosAgPn5zQUUbQPBAhgt9HdrlUFjfdvA8k=; b=bg7HoZupEN+17sj4kPhv8ZANy5HpUbrbYH5qGXkOUkLxtms2XrDBcFZGg11TSMYol7 usLcBUvCi73d/2YraEm08YDS2LJtavdkgXFZGoW3dgwEnwQZuvzwaaE6CKBfc+FfvWri 0PP6Jsy12bpkYQ1JK6wjbBs3IpN+bJYxgEABHHL3itDfl6OGem80dCPBHLfdOXaT4IoN dXICZa3QRPhIbfLNwxcP+n1Y8ex2KD809Ol8ZNbT9BZXN0+xEdopEgqjGyLWH4etWpfc llp35SRWBJ6AuNuqalBbKD2jWxcFB6ym6i9+dTDwK42e0veCSw4hMhaTXRyJGQ5MzpTN dmyQ== X-Forwarded-Encrypted: i=1; AJvYcCVfz4X28hTiPqF5A4hxUankWHy3SomLYQFfmXDU8XucKYNximO+33kEwDxHrXu+8duW6cuJoFWgSVmZ7Dg=@vger.kernel.org X-Gm-Message-State: AOJu0YzQBeVtBikm8W9CIgbwkoPy/oYgdsMvY9tMFiUDgqrBdkKIkVCP fkHV9YXhmDUdoJrhK5WsgTLPIr3xR1eNu0MThplXPew5L5yCI5EpGhnx X-Gm-Gg: ASbGncvKD5xwpCDyxgRHFCoTIWtrjmAeavmsU9+uJledOJeIP3wkEtCvDR8c4OkpJuP rTQIHhmk1FTzRCrR9DrFlvx+1tA6AiaMKki5GDx4kGxxKxY5+fU2O76yCaWS/fF5cfIPu1O8pdl 3IbssBDsGdcQT4IBS0QHXxJV7Y1om562kVDtPVM9tpaj08n3Ha1AXKpaRD7It/Bzh6N6tjIhs1W svQL8LE+sGqK/voL29M9q16P/Tc7OqG4DiDKJFQpmVDCewFQFGD+c74EE5iz+7BzozHWA9I6ZT5 yfbLpbvTPdhzQe6+pxMIw4gBl9A708grxh7S0BVDXwQzGpsJDxsP4lzae2ezY4ZSUeFIiNtHcno 6sOkLXyq9qZKziXtWmy1a7wXW666XB+vL5mMkjBwlxXRpApyaCTF3VPwQvsR+xFb+3XtSb1efsy SfctYlznaDSDvv8XGUyfvrIStH4lSaE2Qd4QyXXzc36lapdOPfX7gm5jJ3wzLc/A9On4Z5 X-Google-Smtp-Source: AGHT+IFYP75h55aKp41FxpTw5WUWy2Up5lb2YKqkFZzaSewuv7Yc1W4fIprqoqs4MCOOfVoM2+dg6w== X-Received: by 2002:a05:7022:2487:b0:119:e56b:98a1 with SMTP id a92af1059eb24-11cb3ecc3f2mr10394654c88.8.1764333524073; Fri, 28 Nov 2025 04:38:44 -0800 (PST) Received: from 2045L.localdomain (7.sub-75-221-66.myvzw.com. [75.221.66.7]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-11dcae73bedsm18301241c88.0.2025.11.28.04.38.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Nov 2025 04:38:43 -0800 (PST) From: Gui-Dong Han To: linux@roeck-us.net Cc: linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org, baijiaju1990@gmail.com, Gui-Dong Han , stable@vger.kernel.org Subject: [PATCH] hwmon: (w83l786ng) Convert macros to functions to avoid TOCTOU Date: Fri, 28 Nov 2025 20:38:16 +0800 Message-ID: <20251128123816.3670-1-hanguidong02@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The macros FAN_FROM_REG and TEMP_FROM_REG evaluate their arguments multiple times. When used in lockless contexts involving shared driver data, this causes Time-of-Check to Time-of-Use (TOCTOU) race conditions. Convert the macros to static functions. This guarantees that arguments are evaluated only once (pass-by-value), preventing the race conditions. Adhere to the principle of minimal changes by only converting macros that evaluate arguments multiple times and are used in lockless contexts. Link: https://lore.kernel.org/all/CALbr=3DLYJ_ehtp53HXEVkSpYoub+XYSTU8Rg=3D= o1xxMJ8=3D5z8B-g@mail.gmail.com/ Fixes: 85f03bccd6e0 ("hwmon: Add support for Winbond W83L786NG/NR") Cc: stable@vger.kernel.org Signed-off-by: Gui-Dong Han --- Based on the discussion in the link, I will submit a series of patches to address TOCTOU issues in the hwmon subsystem by converting macros to functions or adjusting locking where appropriate. --- drivers/hwmon/w83l786ng.c | 26 ++++++++++++++++++-------- 1 file changed, 18 insertions(+), 8 deletions(-) diff --git a/drivers/hwmon/w83l786ng.c b/drivers/hwmon/w83l786ng.c index 9b81bd406e05..1d9109ca1585 100644 --- a/drivers/hwmon/w83l786ng.c +++ b/drivers/hwmon/w83l786ng.c @@ -76,15 +76,25 @@ FAN_TO_REG(long rpm, int div) return clamp_val((1350000 + rpm * div / 2) / (rpm * div), 1, 254); } =20 -#define FAN_FROM_REG(val, div) ((val) =3D=3D 0 ? -1 : \ - ((val) =3D=3D 255 ? 0 : \ - 1350000 / ((val) * (div)))) +static int fan_from_reg(int val, int div) +{ + if (val =3D=3D 0) + return -1; + if (val =3D=3D 255) + return 0; + return 1350000 / (val * div); +} =20 /* for temp */ #define TEMP_TO_REG(val) (clamp_val(((val) < 0 ? (val) + 0x100 * 1000 \ : (val)) / 1000, 0, 0xff)) -#define TEMP_FROM_REG(val) (((val) & 0x80 ? \ - (val) - 0x100 : (val)) * 1000) + +static int temp_from_reg(int val) +{ + if (val & 0x80) + return (val - 0x100) * 1000; + return val * 1000; +} =20 /* * The analog voltage inputs have 8mV LSB. Since the sysfs output is @@ -280,7 +290,7 @@ static ssize_t show_##reg(struct device *dev, struct de= vice_attribute *attr, \ int nr =3D to_sensor_dev_attr(attr)->index; \ struct w83l786ng_data *data =3D w83l786ng_update_device(dev); \ return sprintf(buf, "%d\n", \ - FAN_FROM_REG(data->reg[nr], DIV_FROM_REG(data->fan_div[nr]))); \ + fan_from_reg(data->reg[nr], DIV_FROM_REG(data->fan_div[nr]))); \ } =20 show_fan_reg(fan); @@ -347,7 +357,7 @@ store_fan_div(struct device *dev, struct device_attribu= te *attr, =20 /* Save fan_min */ mutex_lock(&data->update_lock); - min =3D FAN_FROM_REG(data->fan_min[nr], DIV_FROM_REG(data->fan_div[nr])); + min =3D fan_from_reg(data->fan_min[nr], DIV_FROM_REG(data->fan_div[nr])); =20 data->fan_div[nr] =3D DIV_TO_REG(val); =20 @@ -409,7 +419,7 @@ show_temp(struct device *dev, struct device_attribute *= attr, char *buf) int nr =3D sensor_attr->nr; int index =3D sensor_attr->index; struct w83l786ng_data *data =3D w83l786ng_update_device(dev); - return sprintf(buf, "%d\n", TEMP_FROM_REG(data->temp[nr][index])); + return sprintf(buf, "%d\n", temp_from_reg(data->temp[nr][index])); } =20 static ssize_t --=20 2.43.0