From nobody Mon Dec 1 22:06:11 2025 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A3AEF280CFC for ; Fri, 28 Nov 2025 09:01:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764320476; cv=none; b=I696bq8M0zPWn1Rmz0k/dYA45bdtEEMC+CAuacF99kIvkk9wAr4Cu4uo3SxINCzO2DcJ3NvrGGUfRnDZpv2YUo7XRuNwTN2t/WNYyAPOhgO7TwJazjRAmBsvdC9Xvx6Pa6WZqGod/wyr1al4N2R0Tjxyfy5+bPZyzC9VF30yVqA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764320476; c=relaxed/simple; bh=qPt3JhignA5uuB7v1FF0p8D3VNdVS/qWJzKiGy9+sk0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=jxfwu3s0a1eApp9c83/AKXyQlTCIetQBRK/3Zo33IKzbNpAjnfCD7JvWY+8VsuVMdo/m29ZXyIRqc1bRjlhkdOdOJFSdj/fwYUbHkZFNcu358woSLUA5g7Q7SLgxkKOTSrNHACfATxdCeit74jUihdmUlNpCrbl7YSBIxr3Cs/U= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ZVrgSLAy; arc=none smtp.client-ip=209.85.214.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZVrgSLAy" Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-2984dfae0acso25461305ad.0 for ; Fri, 28 Nov 2025 01:01:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764320474; x=1764925274; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=fg0aB5riC4XIUxatKNUZFJeD2L29RPwxQrX9YqPg8Do=; b=ZVrgSLAyC0nAfbV5SnA2vlc9r7vRveEocrliIRHU6uvUg61JEKXvpaPWmIuWaRh/+y wysyHPI7ov5XwtmayW+pYrI1Tkcr+MVxgT2+08vTS4nnuEGfZS8oERpBw4v7++AVR0Tn 7DLd7JZdIiLBO1pdoAfot50Q6rjmg0JKFd73VStkEUvnew5VeUNtcQpbjYd+XFJwkd+t uwybwh3ErR+Ic/eZJoleQnyQLo0qxOqYRZeO8m1gJeBFAXiIzh9lW30perlavjNwwhXe HDaz0PIRaCBNomY3/P3pxiXRtcu8+g8BabyfGMLjL4jJIkSOme9iekgobqTie1zq/lXO vktQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764320474; x=1764925274; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=fg0aB5riC4XIUxatKNUZFJeD2L29RPwxQrX9YqPg8Do=; b=A6O7X7OwVym7Shp0AQJWHoa5nFtwA52+F0DMz5IUO/Qhg4cqa00X4PUrKJEnqRXJFA yfmet3a7RMaClvIy/ZYib2IBltoKUjNumOM8bMY/lJo9bsztfT0xAu0Kl1PPezWR//cF gsKCMUaMTYmY3Rf2npUgsTDJoUSXoJ1KIqO+T8RoEqZcDDa3Pkn+4J6LFoKLznWrfbq2 bybOdfIMV8pHK/Pu0M8ViVuhgu2gQcB4brru1gsWEfcgW9SzhEfuCQ+wpQ2QZjM21RRj JY50G+Igt7GT1hFYR2EySj6aMotOVQRfnxZG5aduHN2FeA/ucJyaxVshrwbzvknLC00I QrRQ== X-Forwarded-Encrypted: i=1; AJvYcCUp1ByWu0Uet7O2XhtJxXbOPzugMNZ02AzSTU8R0jnJrpoGEOz3rrHoohTyiAj42R82oV1gVmTytGCJ5kU=@vger.kernel.org X-Gm-Message-State: AOJu0Yygf+G3V5/6rGx/WmPovQE0KGz+LNHjFQQBkn4j8O3P3NXGr38G D/Zb/UTow7jQrewk5o0/K/59hOvBMFm7sgE4hYhM2Hvm7tw+VJB5wxRV X-Gm-Gg: ASbGncstNmcAXdfikuEHXS0af4C5Vn/hjxZE0/fW7wjDvpAc0cUGUuwyLxmVI9oIJFm Gt1fXYUnVP2I+MhQGske7xUVsL1pqvzyYcICkSrpjF4fimVUoocP2SndhiH1gjzYOApZGxqO/xW rPg+P+GHf+czz2fnr8PYkuOAaBTLZFHyDBwLYlSArUvq0qoKB46L+1UJuFxv1uFcZSPQ+5YEQzR QFQvLh8mVeQIqLz4XzQSGdPkSdpUJXaGp44trgHrq0iRro3joFD76pHftd1Uha3VJqoGlIlTqTU yhdoOCdZ1fo16Wc67oWElLK8pSjznPPYCGfw9VG0uiUbLxlwjVVnnFWp/NSfErcx5uoui1i8AKA Nlk5r83SW1WKdOSMCKdBlzP7uENq6YVOaLCD6SK2jsuHpV5SrXFKKYsVQBGd38Grgd+3HwFQ0jK P5kGXg5kH9UdMZjcm5RQIOovi4MIyv3xzoAILx6Z81iw== X-Google-Smtp-Source: AGHT+IFxWF2PEdV26ARDIpHKCRhHlG+atyCi1+Q7Cb+fsxxURJFv0QzlgLe7FEUK1Y5Tmc7pd0wGiA== X-Received: by 2002:a17:903:1108:b0:295:8da5:c634 with SMTP id d9443c01a7336-29baae422b7mr126947005ad.9.1764320473661; Fri, 28 Nov 2025 01:01:13 -0800 (PST) Received: from Dell-G15.SRMIST.EDU.IN ([104.28.225.171]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-29bce4703a9sm38955265ad.42.2025.11.28.01.01.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Nov 2025 01:01:13 -0800 (PST) From: Lalit Shankar Chowdhury To: brauner@kernel.org Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Lalit Shankar Chowdhury Subject: [PATCH] fs/efs: Remove redundant brelse() checks Date: Fri, 28 Nov 2025 09:01:02 +0000 Message-ID: <20251128090102.37515-1-lalitshankarch@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" brelse() already handles NULL arguments internally, so the explicit if (bh) checks are redundant. Signed-off-by: Lalit Shankar Chowdhury --- fs/efs/inode.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/fs/efs/inode.c b/fs/efs/inode.c index 462619e59766..cfc9b0d0334e 100644 --- a/fs/efs/inode.c +++ b/fs/efs/inode.c @@ -263,7 +263,7 @@ efs_block_t efs_map_block(struct inode *inode, efs_bloc= k_t block) { /* should never happen */ pr_err("couldn't find direct extent for indirect extent %d (block %u)\n= ", cur, block); - if (bh) brelse(bh); + brelse(bh); return 0; } =09 @@ -275,7 +275,7 @@ efs_block_t efs_map_block(struct inode *inode, efs_bloc= k_t block) { (EFS_BLOCKSIZE / sizeof(efs_extent)); =20 if (first || lastblock !=3D iblock) { - if (bh) brelse(bh); + brelse(bh); =20 bh =3D sb_bread(inode->i_sb, iblock); if (!bh) { @@ -296,17 +296,17 @@ efs_block_t efs_map_block(struct inode *inode, efs_bl= ock_t block) { if (ext.cooked.ex_magic !=3D 0) { pr_err("extent %d has bad magic number in block %d\n", cur, iblock); - if (bh) brelse(bh); + brelse(bh); return 0; } =20 if ((result =3D efs_extent_check(&ext, block, sb))) { - if (bh) brelse(bh); + brelse(bh); in->lastextent =3D cur; return result; } } - if (bh) brelse(bh); + brelse(bh); pr_err("%s() failed to map block %u (indir)\n", __func__, block); return 0; } =20 --=20 2.43.0