From nobody Mon Dec 1 22:03:57 2025 Received: from mail-ej1-f49.google.com (mail-ej1-f49.google.com [209.85.218.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7A56E2E8E0E for ; Fri, 28 Nov 2025 08:06:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764317213; cv=none; b=QltXAAr/XXAkR61UkvZuh7t/pMukXHhyjWvQuwz6VGedX0qg0B53kSljL8rwyUo4X/Bpf75MpINfYWALfU57vpIwiPqgjUV73dWL36BAlzFXvxDJ+RreKxpABTMb0gEEr7vPW2tnuyQixBJ7Q/Af8jn9L2snsp2GIj+6aCSTxOM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764317213; c=relaxed/simple; bh=dVGM7YzgCKLuuKDe4mee+rTwbCjC2sQraxKVJra6rhE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=S7zQLq7RAkwtMePeNVz3AhNpz3Fe5E6NIhjfu8c4/K6aGr3gdjJsfMLNntfLSCACZLzACWWT3H49Feo5XJAgy3boc3veKbQVgsffc6uCcQdbVyl6h29hj+WWIgOa8xrcpahbDkH+yZ4qKZauYAGJZnMizfk8Y84yjJzdwZyN6aU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=KvZRDNb5; arc=none smtp.client-ip=209.85.218.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KvZRDNb5" Received: by mail-ej1-f49.google.com with SMTP id a640c23a62f3a-b734fcbf1e3so67269766b.3 for ; Fri, 28 Nov 2025 00:06:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764317210; x=1764922010; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=pQd3PLzZ8AJbcv65jBMHGIJOzjOGRj9r3Be1kNVC/Ic=; b=KvZRDNb5irA94iilqxfownV+vH9M+4O80BC8bHlybQz8G9u4x1MI9O7FlAwg6AnoIn hXewKpbYIHX522tPwRv2NcIbyooJ1/7R2D5dBOkCmBnfCx+DJSnX6lx5zBVCRp9pTnJz Tlu93ZpcOQO0vgLxaa7n/MPMjX+xqAyUoM4sT0woZPK0gAmR4HfcFqrNh9EDNzQKmOZa XciFLp8NUDR4vNxDqJfZUMQLYd2x+9zTcYWBW0hbHQIcAiWmmBRSZOwd5u0bmtNRTLwl FRrUrJn9WzlPZS9ipmvG8O3GXYn7U/yFjoIRj+lqFijJn6xgtrz/7Zg5M0h3xKBL6f8g xf0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764317210; x=1764922010; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=pQd3PLzZ8AJbcv65jBMHGIJOzjOGRj9r3Be1kNVC/Ic=; b=R1bocb7VhiwPbV3enZqYuNQZM/he6uuE6EovzTjnW+tuH1gZPPYDpLRWPoDzVrWWmY yOeKte5SP1u3HA9GgGwMFUfgwo32PS5dpHDrxk/mSaKjRhO3d+rjlG+TC7zg2yKc6YVF jfUt4icxEk1rKrpnqlOhiDoSYIikvOqVUZIhR+WDataeiU//cQkMIWntQvHty29W1l/9 qhNmuC+BKtwKO1nGj1hCmU4oLKE/cUmbkyf97zNvpiPlhAt3npO4Kq8rHKxFSGjiQZ6A Zu+doiuy4RH2ezPUG50H3ZN07LzbtCvIBpeGttDdBXxYRwzepWTAzeldNM9BSuld3EOO UIIw== X-Forwarded-Encrypted: i=1; AJvYcCWsH1A8tZxB6yEdwHlFTaFyp5dRNDQWviyuNMbwxLUlbQPApoVFemIkuKtH7ISNIafT/5fS0WKmM8VvqFo=@vger.kernel.org X-Gm-Message-State: AOJu0Yx79XK/gZRWDxHk7UCIEcB3LmGYsr/vhGS0yaBWlXMM6sYPUj3H 0DHo+sfBttm2QYmWsEzQRAoeFHmNye0pZ8wsRDvlFDsh20UAd0DcLfpd X-Gm-Gg: ASbGncsxf65YQ9F9NtqIAcKS+Xo6V58VZ11rOn8L/yIYIzwylPaW4vv2rZFWUri7MEq roJlDt0ZDQ7bpDGDFSsJceoff7Bks/E2JEYRMndwL+xwvMqex9cjU6zMGVxcCSqM0ss36jdFswn YD8LsNURNmp4Z5QR6RrSOvwKR0D6xp1KIWXbIKxg2QVs+JIen43n3SCftdz0sVrKFRKhmxtUTLO nHekXJhwXvmgazLzSHyHD9Q544+OdpFHnKWSLNRzt8vuW0fiP0d2uLo/QuQ5eAnTxiWDHcUeALJ 9SAZLowvFjD5QnwJsMjbFhNpiDBdhFVFjIV4effGPlgbqVoBBcNWc4lwpgJbbnMYdCbDFv5l1gQ HK7vJEceze1tQR7RaXX0nQ0IDnsa+ybEE/HFAcAW9tqD7S2VKk6lPBHPEuh4jGM2Giz4/K/WY8J M5Qti2/Q9Ahuv7RY65c+n8iX8IKCOsAu47W+qoWaiqIm2SEnv8O5lyMEytVDjcksRfukzDaUhIO dxfJA== X-Google-Smtp-Source: AGHT+IEBGcglZmu8UrcQJT0JgBbFxWtKvu+DEkJonDsMZMH6PC17vDq/FnrusP+b1vwXSbsvChKoVg== X-Received: by 2002:a17:907:3e95:b0:b75:7b39:88bc with SMTP id a640c23a62f3a-b76718b286fmr3231326066b.58.1764317209502; Fri, 28 Nov 2025 00:06:49 -0800 (PST) Received: from localhost (dslb-002-205-018-238.002.205.pools.vodafone-ip.de. [2.205.18.238]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b76f5162d31sm385418766b.9.2025.11.28.00.06.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Nov 2025 00:06:49 -0800 (PST) From: Jonas Gorski To: Florian Fainelli , Andrew Lunn , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , =?UTF-8?q?=C3=81lvaro=20Fern=C3=A1ndez=20Rojas?= Cc: Florian Fainelli , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH net-next v2 7/7] net: dsa: b53: allow VID 0 for BCM5325/65 Date: Fri, 28 Nov 2025 09:06:25 +0100 Message-ID: <20251128080625.27181-8-jonas.gorski@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251128080625.27181-1-jonas.gorski@gmail.com> References: <20251128080625.27181-1-jonas.gorski@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Now that writing ARL entries works properly, we can actually use VID 0 as the default untagged VLAN for BCM5325 and BCM5365 as well. So use 0 as default PVID for all chips and do not reject VLAN 0 anymore, which we ignored since commit 45e9d59d3950 ("net: dsa: b53: do not allow to configure VLAN 0") anyway. Signed-off-by: Jonas Gorski --- * just let b53_default_pvid() return 0 instead of replacing its call everywhere * drop the explicit rejection of VID 0 for bcm5325/65 * reword and expand the commit message a bit drivers/net/dsa/b53/b53_common.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/net/dsa/b53/b53_common.c b/drivers/net/dsa/b53/b53_com= mon.c index ac995f36ed95..a1a177713d99 100644 --- a/drivers/net/dsa/b53/b53_common.c +++ b/drivers/net/dsa/b53/b53_common.c @@ -872,10 +872,7 @@ static void b53_enable_stp(struct b53_device *dev) =20 static u16 b53_default_pvid(struct b53_device *dev) { - if (is5325(dev) || is5365(dev)) - return 1; - else - return 0; + return 0; } =20 static bool b53_vlan_port_needs_forced_tagged(struct dsa_switch *ds, int p= ort) @@ -1699,9 +1696,6 @@ static int b53_vlan_prepare(struct dsa_switch *ds, in= t port, { struct b53_device *dev =3D ds->priv; =20 - if ((is5325(dev) || is5365(dev)) && vlan->vid =3D=3D 0) - return -EOPNOTSUPP; - /* Port 7 on 7278 connects to the ASP's UniMAC which is not capable of * receiving VLAN tagged frames at all, we can still allow the port to * be configured for egress untagged. --=20 2.43.0