From nobody Mon Dec 1 22:03:40 2025 Received: from mail-ej1-f52.google.com (mail-ej1-f52.google.com [209.85.218.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 078242E265A for ; Fri, 28 Nov 2025 08:06:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764317204; cv=none; b=EgvGpPdkygIcR+Cc32qmbeGog1cWnqPga8Xt2R4HwwA5FJMdxPMJAAwOHVEQtGZXKPnlEj69bp4mRCJHicv1HPUPtCdnR6aMnzCQ8/szfyuTpPgqNj/wHg54qYjbishKbImSMmPsDelTboRe5fkm4vuv/bWbhKGhEuJLofVgkb4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764317204; c=relaxed/simple; bh=ZXITNK4orXkHoe4Ya8LHW9gvkXoq8g5iqaLa1JHKtd4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=lbWSOkgnXM4PN9jZme/63DYwLkpRB+3KplIHbE6zeH+NBc26PwhTOlO/M8G+Ncd2dbQrtexDFiMNY0ijvKbTvPHQ6E77hL6I8Wqt6wbRLl8U10OmZW5z6OYxEUqfyRyAg0L58jKH99yGynD1dNj8PbK1UFtUE/7qBxlfSUjt/N0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=QWqegR3a; arc=none smtp.client-ip=209.85.218.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QWqegR3a" Received: by mail-ej1-f52.google.com with SMTP id a640c23a62f3a-b736d883ac4so66934066b.2 for ; Fri, 28 Nov 2025 00:06:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764317200; x=1764922000; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=R1e4QIL1rNUNQDu2qhKzyqa3i8lBjekJrTGYyrwgBzE=; b=QWqegR3aDJA36fNQa84X7lTB7SbZ+G39hJDv8Fs2zhCTvhcfwaLH9tRE5n3u4Rr0zf zoJ1e++hlEq+582FLhUh0q62/igugCkmnC5G18RuDuArrkiNt416FFT4lhxzw3ZgsN2Y vhZ4nHeDA3Cthr93ASYawmNfkKlNxEQffgWEunoptRsB/rKSpfAjL5Jb69XKvV2/HnXv AWVoNRkRF1vVJT6UN6nvVRJ442e4B5rKXbwW5WwP24ndgoW6GEo4QJgTvujuMbDGy8Sa asE8a/ozz5r7nsrce1D8VCFkkQLCdyI42zPZ4jE/F3lPcM1uoKRi8eBVVD0ClpdtRbQr jFkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764317200; x=1764922000; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=R1e4QIL1rNUNQDu2qhKzyqa3i8lBjekJrTGYyrwgBzE=; b=WceiJOgU6ZY2UME7jZaobZGQs8cOUCKKEBvL9f94AqJrb6hAu10J40zzKLv0QnaumN gQVQEsEbQoSXkSaMtom+ybrkx+JSFcih6LCSGT92pI5Gj8NOaNtv+jhuJ+BX85Slx/R5 jlJcyW6JbPEQFcjXoKCf6+6F/Xocqnx0MUyZKam/5I9s0IcCY/ydnrVblcfsX8zgsJse Na+eKL4ov/bI2Kwt/oQcN1QOV4Fw9VqzqHIsiq8Buam5rRI1fLGKjtj5jvXkAfM857Cb NgP/K966RPTksiEMk/fzLGC9stLK4PbwTMVlHXFAoVzg6yafQIm9YCWrgDWLXuY9r71f gCBg== X-Forwarded-Encrypted: i=1; AJvYcCW/hL817j2UQ06H9zhMHWldumqTdpqToD4kRUeb+kvnmAYNjI7ZQQB2J5DntglaZhpsXr6oTQ9pPrdqB/M=@vger.kernel.org X-Gm-Message-State: AOJu0YwAhb559bpNyyG2vCFtpD8GIX/LJuYxGZMduPRePcIhqY+G20sP Uz0kXXBPWJXH1wFoevNFfSrkirYkzscTsE066qZ4ZW33lSh0K35tH/56 X-Gm-Gg: ASbGncuGdFhI7SHpjIp/CCXsmZvHHkDz6TfnDUK34xkzXougY+iz9sgzWWqqTz1PfSo Y5YdwZROhNpgP+d3IcE6ET5PPfuvDcevu51QyyunNzAxGbWx6FF8Ztxw8NXKw/sDQMmT2Pg+uGa 784xtpevAiWsOVNfurdW6N8yvU62LhdWGCKufXx1cFOYuhiHTIcxPhuK7isPpfv8Cxn4yYZDvoQ 59bdEIgUYBACtCWzG/JjT9F2kK42veA4XKTHhv0IxpRZdPXOBHk29gNIYnZMNS5NHfr5DhBvuzZ kYivwLIQnB93EhRFtraByMHkJoNAn9s86bu1SM9KuGoqoKIVPjvOiZOGgG2stFd9iwWVvaGbDrn j8cfMSg6ua+X2TV8YOriKwhGlxFCmA/GQUiiI+vzm+vflHaIA66ZOooJmUfXn7SsadzkGT9Gg+r EODkS7lul7ZSs8hO86kJIbjE6X8ubBP8EaJji3DZTnX4EWBwzBgxZ8uB/3Dhb6yqOezm0= X-Google-Smtp-Source: AGHT+IEpICKNTFtLVeV5jlCF/yBTwDY+shAqVIBuvL4tQMNocGn61vvL7NPOKUZP43sOD3JS6+9YJQ== X-Received: by 2002:a17:907:1c28:b0:b73:3ced:2f59 with SMTP id a640c23a62f3a-b76715dcc1bmr3064602466b.27.1764317200109; Fri, 28 Nov 2025 00:06:40 -0800 (PST) Received: from localhost (dslb-002-205-018-238.002.205.pools.vodafone-ip.de. [2.205.18.238]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b76f5a4a652sm378485266b.65.2025.11.28.00.06.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Nov 2025 00:06:39 -0800 (PST) From: Jonas Gorski To: Florian Fainelli , Andrew Lunn , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , =?UTF-8?q?=C3=81lvaro=20Fern=C3=A1ndez=20Rojas?= Cc: Florian Fainelli , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH net-next v2 2/7] net: dsa: b53: fix extracting VID from entry for BCM5325/65 Date: Fri, 28 Nov 2025 09:06:20 +0100 Message-ID: <20251128080625.27181-3-jonas.gorski@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251128080625.27181-1-jonas.gorski@gmail.com> References: <20251128080625.27181-1-jonas.gorski@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable BCM5325/65's Entry register uses the highest three bits for VALID/STATIC/AGE, so shifting by 53 only will add these to b53_arl_entry::vid. So make sure to mask the vid value as well, to not get invalid VIDs. Fixes: c45655386e53 ("net: dsa: b53: add support for FDB operations on 5325= /5365") Reviewed-by: Florian Fainelli Tested-by: =C3=81lvaro Fern=C3=A1ndez Rojas Signed-off-by: Jonas Gorski --- v1 -> v2: * added Review tag from Florian * added Tested tag from =C3=81lvaro drivers/net/dsa/b53/b53_priv.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/dsa/b53/b53_priv.h b/drivers/net/dsa/b53/b53_priv.h index 2bfd0e7c95c9..3b22e817fb28 100644 --- a/drivers/net/dsa/b53/b53_priv.h +++ b/drivers/net/dsa/b53/b53_priv.h @@ -350,7 +350,7 @@ static inline void b53_arl_to_entry_25(struct b53_arl_e= ntry *ent, ent->is_age =3D !!(mac_vid & ARLTBL_AGE_25); ent->is_static =3D !!(mac_vid & ARLTBL_STATIC_25); u64_to_ether_addr(mac_vid, ent->mac); - ent->vid =3D mac_vid >> ARLTBL_VID_S_65; + ent->vid =3D (mac_vid >> ARLTBL_VID_S_65) & ARLTBL_VID_MASK_25; } =20 static inline void b53_arl_to_entry_89(struct b53_arl_entry *ent, --=20 2.43.0