From nobody Mon Dec 1 22:03:40 2025 Received: from mail-ej1-f44.google.com (mail-ej1-f44.google.com [209.85.218.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F3D342D47E4 for ; Fri, 28 Nov 2025 08:06:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764317201; cv=none; b=NvedatJFXxYV9bP5QvyGOEeDJ/v41yLW5CFG+bsp8HcRKuzDTjmOQcxWuFDrkZDP5ex3o3PdYTZ8+xzSTIjnx0bsAGXrmfPzXvKmTenS6cvey15jtZrE+islJXqFl+hvIRa5Xlq6ehPLuztoPpAHWblA+r+pptlnCay1wnnULjc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764317201; c=relaxed/simple; bh=VEDn59HYgwSpM5f6SpHVK4Qn6/wZXasQ2aEaJSrhMnI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=o7NCrSIeVaev4UqficV/4mkiP0x8zdsNp85qmEukfbuh6IdfU4sI9PMASIE4HOY0SzCDhP0RP3kAAr2Lx4XH84V/gxGdG2WavposkWhGi35FLho3Bm1nyB1LxidsXDNzaLEwwI2SihedRySlJo6ogaIyZKO3WYys1VKsR1Tw50A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=lA3yD3H7; arc=none smtp.client-ip=209.85.218.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lA3yD3H7" Received: by mail-ej1-f44.google.com with SMTP id a640c23a62f3a-b72bf7e703fso283225066b.2 for ; Fri, 28 Nov 2025 00:06:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764317198; x=1764921998; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=MCdEW5DYSpMlm0kBp+GwmfbQeNzwRoQFikLTDV4j5ys=; b=lA3yD3H7ee7FYQ6JtBKZjRz/l8MF5fuktU5hsdU7U1JsHPSrY17qKBHmUyAlCHVaQL yhKuGL4ji/jlgmatV/czm6CAoyyNeijl0B6ghzQ/WvmbgwkTlnU42Hwh1/JVz959qhEE pUjbyWWkMzO9XWwQlTDSCzwCBHmR4C+JCW0VQUky5qYp4OcqHLa+a0mwfD4QCkKFfeH7 MYAGUvWen2Ah4v1KFTJR89BOfBFlEGbeMHsyo7ZQl45f3akdMcYFLaUef2MRQkNExNZO n4t7iyoZoVW4/ZOAHVFx0j8E+3ELmLidP1+3c92kqmeILdfkH91l7caacwgJccOAeWZU Mu9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764317198; x=1764921998; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=MCdEW5DYSpMlm0kBp+GwmfbQeNzwRoQFikLTDV4j5ys=; b=KVguMpvSiBHb1I1FZhn/Hd7dnLWldcGDtTNgHAqGIBwSJMKjBlobkwSsVbX7cGXCfY bBd3QSFcjo4QUPoMApyHkHpgVIH3sgWB2DyFzhmUWo5jDo1Xq9lS2Zf/FH70anqBvwVU zDbH/ystjqpTyPDnueAK84saffU+03QEnKgIGi2nOOYL27xGJpBBwICEsI+YmcIEItAH 4qkLWdOxgAThs1FoDli3gNc80zKu9TYcMGJoVBcegbrtPEKWDxdkUaPhBNI9JUnkLIg7 tNTGOd1Y5bCy9Zn9Eq7n4/zeSILKb8X0fxdeDwWZY+LIKTqd5DPPIQbupck9w/EDrOTs kBNQ== X-Forwarded-Encrypted: i=1; AJvYcCWbN+qfyAX5nYV/j4QOu4gXlvLvvu3SjQ/m/QusxuypS0gvjsl3XJngnWE7EXj5SVuM7SaWL6BecsDf4Jw=@vger.kernel.org X-Gm-Message-State: AOJu0YxYbJ4yw3uHsT1RnWCH3KorQDOHKjIdGZ+orP/hYfR6PgEbjbzH H9UDzpKDruxhy6QBaf+5VbWMmz+cstrg/S+frO+scHPYw9lCuBeRuXJG X-Gm-Gg: ASbGncttXLxIzS8Kmmd4Non+ovQ2zf36piEMsno1GeaxlWZDm+AWNn6CNKiyB6DzsRm 35rTt3+yGlQdWLukxuPPja/VVN7w2VBtS0m9DyWIQv+Z23LlaENAh61DTpSHnFEULgt/y7/rg0x +7mqVkbd3SKzEWG6G5fOSVGw1PRjyvhXAwDfh7t0F5ZR/rrKCoAqVfJnn3wBJlhXT3QRnbRBfLz SzRCNfIcGusgjA/LechQt/Ci2O3ROaId/KNLb86OQV2fPOfJNqinbZnbhywmroY+Gqk5maFd7yz FyjiAfe1+vxPH1DsZaXNp9WE25ycllR0H9J4VymRB3knxU43voVqku03kufyqV317i2Gz7IwYWd w9T9q6OkdA8O5IHqqkTnnBUsEtraTKeiKN+hmpS7XPe12BtDlLaRSaWe4ZTmwG6cVTdWeRNFi4z PGST1feYPEprI0g1pA9z8GftgiKrOUuC/l8eP+8b/oZalJapVxJTnlwy5lRjX30XRUYQ8= X-Google-Smtp-Source: AGHT+IH+UVopUS2x7a795UVxoRCFv7mI1dfXMhCfhcbrk4IUDks2nQnPlAxE/Mp4oB+QM8OFgVwuyw== X-Received: by 2002:a17:907:72c9:b0:b72:9d0b:def4 with SMTP id a640c23a62f3a-b76716fcbaemr3251164166b.18.1764317198097; Fri, 28 Nov 2025 00:06:38 -0800 (PST) Received: from localhost (dslb-002-205-018-238.002.205.pools.vodafone-ip.de. [2.205.18.238]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b76f5a7afb4sm374880866b.70.2025.11.28.00.06.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Nov 2025 00:06:37 -0800 (PST) From: Jonas Gorski To: Florian Fainelli , Andrew Lunn , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , =?UTF-8?q?=C3=81lvaro=20Fern=C3=A1ndez=20Rojas?= Cc: Florian Fainelli , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH net-next v2 1/7] net: dsa: b53: fix VLAN_ID_IDX write size for BCM5325/65 Date: Fri, 28 Nov 2025 09:06:19 +0100 Message-ID: <20251128080625.27181-2-jonas.gorski@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251128080625.27181-1-jonas.gorski@gmail.com> References: <20251128080625.27181-1-jonas.gorski@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Since BCM5325 and BCM5365 only support up to 256 VLANs, the VLAN_ID_IDX register is only 8 bit wide, not 16 bit, so use an appropriate accessor. Fixes: c45655386e53 ("net: dsa: b53: add support for FDB operations on 5325= /5365") Reviewed-by: Florian Fainelli Tested-by: =C3=81lvaro Fern=C3=A1ndez Rojas Signed-off-by: Jonas Gorski --- v1 -> v2: * added Review tag from Florian * added Tested tag from =C3=81lvaro drivers/net/dsa/b53/b53_common.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/net/dsa/b53/b53_common.c b/drivers/net/dsa/b53/b53_com= mon.c index 72c85cd34a4e..7f24d2d8f938 100644 --- a/drivers/net/dsa/b53/b53_common.c +++ b/drivers/net/dsa/b53/b53_common.c @@ -1966,8 +1966,12 @@ static int b53_arl_op(struct b53_device *dev, int op= , int port, =20 /* Perform a read for the given MAC and VID */ b53_write48(dev, B53_ARLIO_PAGE, B53_MAC_ADDR_IDX, mac); - if (!is5325m(dev)) - b53_write16(dev, B53_ARLIO_PAGE, B53_VLAN_ID_IDX, vid); + if (!is5325m(dev)) { + if (is5325(dev) || is5365(dev)) + b53_write8(dev, B53_ARLIO_PAGE, B53_VLAN_ID_IDX, vid); + else + b53_write16(dev, B53_ARLIO_PAGE, B53_VLAN_ID_IDX, vid); + } =20 /* Issue a read operation for this MAC */ ret =3D b53_arl_rw_op(dev, 1); --=20 2.43.0