From nobody Mon Dec 1 22:02:14 2025 Received: from BN1PR04CU002.outbound.protection.outlook.com (mail-eastus2azon11020111.outbound.protection.outlook.com [52.101.56.111]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B3DCE2D4B6D for ; Fri, 28 Nov 2025 07:55:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.56.111 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764316549; cv=fail; b=AKiTbcelteyKH62ID7y5rjWMYBo1AOCZhwTc/isSF4Thk03xlApOV4bqZL3TKx1G9vHkImK6NnqerrRU9rDyKjcglWY460wyKdzRFVH3ov5KhhhtfOiKkY8aI3hGavTlV61FA8ghB1f2sOajHnmrNHxc/B9romQ5lKIXVoNpJn4= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764316549; c=relaxed/simple; bh=s6KddVXtoK1I5xxFaWnADOzpiJhtDnUQ4g/Js9iF/54=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=pFwM+6NC0Syt1aFF0d1skGh4x5Gf0Zyb227t3oQmYdNe8LoGP0Ik6vTFPJ2i4E4FNBfEv1fDTiYp9z7Rf7jHL31yHS9FvmwvKKHSXA3lB31zH6fqgi/7rQG2tgdpO31N3Ua8KzgMMbh5TnE9sBXtdkuj//OCtxLpsPnD2x0WI3M= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=os.amperecomputing.com; spf=pass smtp.mailfrom=os.amperecomputing.com; dkim=pass (1024-bit key) header.d=os.amperecomputing.com header.i=@os.amperecomputing.com header.b=nrmGLKpV; arc=fail smtp.client-ip=52.101.56.111 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=os.amperecomputing.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=os.amperecomputing.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=os.amperecomputing.com header.i=@os.amperecomputing.com header.b="nrmGLKpV" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=c0JQ/YdXpp8XXZ9DLi9mfe+waBq5nKWasmoq4ixl0OrOTCLGelyCOlWc3AaKFxbxt1l9k167hvkFGQ/9mTVa1QfrS+tVNhoQG8bKa9ZNGKs9/6rtvrtIKYVcs0bGYIbzsWMtwexSKCGSaS5SSurs0nvaa02gJtUlFxMy7tJtsjMCjlUqiFVN/MY4V1b+50mEyhgwMX8w4MZy7tOUmQZk8hEueCKe4MU8ecJ7b9XVjbsylvCNH/JGTDwrNE/opBThKki7TSMZAgk18EhDP0WXpIbFzB40VVw7Th3j47yo8Vneyt4/Lzu7x4c9xU8qprYL/wwK7WTiWUR3cjpU4o56Kg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lsNEkpa3tbi5Yr/LALcFR83PloNzs9jggJkBhYphaC8=; b=W74ZLeIstvUyVWC37l1Lifks8D84c24cdGbHNRJ1nOkabtm8bGk7RonYo5S3PmlABXh5xa0w6Q/PgHMSNbPAitcrUcEOphdXC7J29/2a3z9Ze271aDNocYsDXkiHY0AdCtdUSYPm/NSSOmChHAP+/xjZIrXIVP4U15hcLzaVzoBgL7eKvpZfHXPr/eK+ckUVOn1oez4RRwLNBcsVHy66VaW9yh+lseTHIvi/vrT0/7H7agnBLXDR+GiYrWoQaBKCS1Cx/tPcfSAuPiIZx8XH2m7TgVlLiKXAgXd0MklMWnLK/0i5zzk/j2LuMEouInzME0GL+hkDVj2ZeaE3Xop90Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=os.amperecomputing.com; dkim=pass header.d=os.amperecomputing.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=os.amperecomputing.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lsNEkpa3tbi5Yr/LALcFR83PloNzs9jggJkBhYphaC8=; b=nrmGLKpVySDoyqGyjXqQsG5b962vpaEcyiojaE7roI67fMy81dDG6xPAfg/jv1Xypb/wwtAoWc1Xr5jSlLWF7uNVkkZaUIu0p0KRJ5IVfj7+OT/Npi/anjHaacrYUb1swjN6J/ntdrJk4eKYV13IXacZd2vIi0H+ovakBJbddFs= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=os.amperecomputing.com; Received: from PH0PR01MB7975.prod.exchangelabs.com (2603:10b6:510:26d::15) by SA1PR01MB6544.prod.exchangelabs.com (2603:10b6:806:1ab::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9366.17; Fri, 28 Nov 2025 07:55:45 +0000 Received: from PH0PR01MB7975.prod.exchangelabs.com ([fe80::6926:a627:118e:8050]) by PH0PR01MB7975.prod.exchangelabs.com ([fe80::6926:a627:118e:8050%4]) with mapi id 15.20.9366.012; Fri, 28 Nov 2025 07:55:45 +0000 From: Huang Shijie To: mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org Cc: patches@amperecomputing.com, cl@linux.com, Shubhang@os.amperecomputing.com, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, linux-kernel@vger.kernel.org, vschneid@redhat.com, vineethr@linux.ibm.com, kprateek.nayak@amd.com, Huang Shijie Subject: [PATCH v4 1/2] sched/fair: set rq->idle_stamp at the end of the sched_balance_newidle Date: Fri, 28 Nov 2025 15:54:53 +0800 Message-Id: <20251128075454.676765-2-shijie@os.amperecomputing.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20251128075454.676765-1-shijie@os.amperecomputing.com> References: <20251128075454.676765-1-shijie@os.amperecomputing.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SI2PR02CA0027.apcprd02.prod.outlook.com (2603:1096:4:195::14) To PH0PR01MB7975.prod.exchangelabs.com (2603:10b6:510:26d::15) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR01MB7975:EE_|SA1PR01MB6544:EE_ X-MS-Office365-Filtering-Correlation-Id: 407b05f2-6326-43e5-c60f-08de2e53891d X-MS-Exchange-AtpMessageProperties: SA X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|52116014|7416014|376014|366016|1800799024|38350700014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?L+ANeB48kQV5Oml7Xixwfc5+C0ymwjUaFFHWnmq2AgnE8BjN9UZPU4W3K8lh?= =?us-ascii?Q?PdcaXBp4qc8n6duefHAgDYMX0VaxJck5piegNL97+qeKwIj7YD22Q8Ot/LyF?= =?us-ascii?Q?t1IPHNtisndC/Ssd6Ief7zOjBgejjrWcA1Cl5+OTOjpp921S5KGWlYGVYDrx?= =?us-ascii?Q?Ke9SGJL95CnlI6GySltt7elSJFpG6IJCtlXOQPGw55Ct3AkiUPoMA6PGVzj4?= =?us-ascii?Q?1BZXMTUETwimAvwFLIx3aj8g9ArQq1E/xOBkqs1LsRskpLaQna30rS+hWK1S?= =?us-ascii?Q?Yu01/h3jwdyMYDU5OS63drnSDnLCR0uzmWwCVs/cntsrXA1/TWujd+OmGNUX?= =?us-ascii?Q?EjxozmWHqvEw7FtsLply3N/e8AjDUcQpEd/yF+SgrI4c6scDfwYa1T3Uwj7Z?= =?us-ascii?Q?EJmpiG5UahZGdPuTPC5j/l+oOIkH86rrkqIOskSJKfdtqiUdDBLsS0I+u6Nw?= =?us-ascii?Q?Fx51cGrL5jS1BkwMUFsq5UBrbBYXEib4GCaL8D1XOivyWy53bFxenlPV2MyP?= =?us-ascii?Q?1RPVb0WIU8d92qOmS4St5hWJP4El4f5CvMq6wtR6Uun8AMhfN3f/pUyL0sqS?= =?us-ascii?Q?rllda3mh/MfxHWKAtM5YzsTOMTrPhOLDqNMEqTKbbDxKQ3OTmT1D21378Rx9?= =?us-ascii?Q?YCXesmO6/BtN60aalU4fp4iO0uvgAURGBnaep9RttlKbM0xWBig1Icjre4i6?= =?us-ascii?Q?5kmDfviABaibG98dHps8dP0IIIhEbLczrkQclyJwmxKlilnxNzK6KO0s5lq6?= =?us-ascii?Q?OppB+OVoxZxd3oYdtE23tabdSXmeK6RFnp5uAZDUxXzCvO6hDzeAdN6XRNRa?= =?us-ascii?Q?kTezE/p0CpPj0G7AOuJEQHe9cMnZgfvQYrZBt1kIGXSke5eHgADgrBLxgShh?= =?us-ascii?Q?tW2a9spzwSUvCWtlWQlLounou16f77ZcotYaVqyYityfjIj9BsAgbU74PCMw?= =?us-ascii?Q?XhwdcOaVsYc+droGygHXUCmWnB3Jsjol34R35O4wSKmmR4kvbu3WiFzlIfcC?= =?us-ascii?Q?m1PxOYmfMU7cPMXZX6l7PaN+ZCf0IWdOB9hOOgPliL4hSWzI65EF19Ep2Ml4?= =?us-ascii?Q?zV+1b3wzRrgvDv7h7NP2JPIP7H8VrAOhaND5in5kyY4Xj+YApg0mpyLG9Wpv?= =?us-ascii?Q?4aTmATWetLDcx6z0rCLAJbjeytJ7t71xphQ+ltHDg22wOcRasheq9A9TWvwR?= =?us-ascii?Q?kDAZxFeoGgdjLb/75S0bLPtD1Zhwekt0sDeKROfkhofbnfvet26ARrMpBue+?= =?us-ascii?Q?J893w3Q1dyxe4gondYOanneq91CH6QeZmBWBEvqwc/VFY/riXQI0JGQNpK4f?= =?us-ascii?Q?C8DkvCZ9Xs714oFVrHg7k2sYDp7tinhmyniX7NzcZiUi1FSrlhyRTqLbaiI0?= =?us-ascii?Q?WHkFoOvDyKmNf8nPaZv7KP2rb3MnHtU64oVsjNj5IB1EjemdTWUpxLSdEZRG?= =?us-ascii?Q?RTUNFiZhP/ugioKOCtXgXqX7ho6U+sN/vDbDhHT4Nfm9mcj9qPVbmfDKKv4z?= =?us-ascii?Q?PGUyCN4SLcO+gd7P0sa6E71hTRU6NMYaUNsh?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR01MB7975.prod.exchangelabs.com;PTR:;CAT:NONE;SFS:(13230040)(52116014)(7416014)(376014)(366016)(1800799024)(38350700014);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?8fQPAhdjeZZsLW0ZPPh/ap5D18QGulT4c93bp/fggY6Hd+Br9y5ORxhohnxG?= =?us-ascii?Q?xX/nm6rJYAtVl3OQhb0c6Rvy9tJFb5OAYY7cElEfO4cOiPpT6pYyoW85GeTq?= =?us-ascii?Q?Z4mq4J0YKw6mk8tCGa+sXEd1an7S0g6WHid6R06yZSY6XZJS+y1VBeEra+kn?= =?us-ascii?Q?EtZGpvRs8J/qQ3JHwz52pfDQIC1KwhttJxn2VtFEAwhtcfrTlaC0+jxmS7fo?= =?us-ascii?Q?IhRfaZfMeN1WKLizfL5kqCJ4O8B6o9YddQbkP/kAFkBGMEs03rbd+BB0t+RT?= =?us-ascii?Q?b0cnID0Phlk/OwrYOpjA0BJC459zQ/FBYD3m7T1K0UIVXPaB+C08+czrtVEO?= =?us-ascii?Q?y9ZFjPgQgMIQfiFJMnHkLTciIhO7W4cL1Qqsf7c7fYEXk0qnJcCkvv30Glbp?= =?us-ascii?Q?+xDLhKSucpBzLOnuJV6j2B9pibpIwbpX5+ociOGEjbxP0SgQh0A/dITQvwn9?= =?us-ascii?Q?onyFS3bcuQu429/C32Dbt+BA33O2n+VhyAk/luNtOHm6x/vBogXY+hVP3xPS?= =?us-ascii?Q?Iwmhdu3OBMNGi9hMNO1jfceGC1hUd17OnZOxMWP2qRTkBVenefLluSkSeQaV?= =?us-ascii?Q?b6BWAOunG77qRq6lkIqUCu+byN58h/uerNEJyG0R+fcCDiICOOQDJCAFFSFA?= =?us-ascii?Q?RO5LErDJpdJpd1mxbkG85ndw9d37zTvzmz3TqQdHIfOzBGmEYpXBiHjr+8XJ?= =?us-ascii?Q?4Hiu/yBEKQeaiIZ0Df1Cezp8mL5XJODd+rzoaHtGQG9DjFApAmB+ASLXbbn1?= =?us-ascii?Q?RIW2R//TYCyMRRWU6qH6x2uVw/OLVYKHyTn62Nu0EtmQf2q8cCF0eiZzClLe?= =?us-ascii?Q?317OPOd2/4lD3/nDq4vacK4lI2LYEjqqT2nDGs5v6XbFS+VRhbtTdVMuIiTu?= =?us-ascii?Q?YYl8cnLHAM4l+tOv8b2NgIMMHe9CukP2SWlEugf9t4yUwl/aqOqUJkqHg5Gm?= =?us-ascii?Q?+1AXmwE0tm6H5ehty1mbFDGLSaPBMeYg4SjJJL/Qht/xArEtwtwcQMMCbOdc?= =?us-ascii?Q?OcQag8s6aGPhBWBq7MleIY23JgtzpMidbLphpXcTW4+OnS4awnZslGKI4qUf?= =?us-ascii?Q?iIGawpYvdy67Y2exMPxBM9pRrt+hC5pf8vVDgoTkff0c9knvEV6T22f1vI7J?= =?us-ascii?Q?YydFGfa8MyfYugVFB6tk5gFibOa/DD1X38CP4+yKffC6tMYepT/DazMiZGCd?= =?us-ascii?Q?TbbeAvDThPTlAbxXSaCZuM6ofNVo0j84GOmumREI58uPO+L+AhxFYsfp0hda?= =?us-ascii?Q?fDUyVcRHCULIvdBfE/tDjv4R8RiquwOVptndDY3Lr59yVPjcsDOR6edm7bxU?= =?us-ascii?Q?s7X+Zfdqye80J1vm3oJJpNkUkKlHaPaL2BNOVjslxVKEI/ro2xcMuMgMR28E?= =?us-ascii?Q?Z+KX9/HWSlOAKOTVC4RtIXTgRz56gVkodr1o/jrx61Rcpyi+RI7jYSOHOPVI?= =?us-ascii?Q?ZtYvU8SWHiP13oIPMz2b0DZMt2GxUIVF7qPh6I65fs3vhdnImgqG1M42Mf3k?= =?us-ascii?Q?KlsbwfKTSS8tDZ+tZEYRm1iEuFkTc02JQAKVaj4vjSvSvNXSNvCvzDSP45IG?= =?us-ascii?Q?a4bCgU73XGcdg+TvBiZhMbxySiz64u7h9ozomBi8uH6GulLpZduzkt2Vxnde?= =?us-ascii?Q?KwBkYaBiMpHiS0kka/Hx1bM=3D?= X-OriginatorOrg: os.amperecomputing.com X-MS-Exchange-CrossTenant-Network-Message-Id: 407b05f2-6326-43e5-c60f-08de2e53891d X-MS-Exchange-CrossTenant-AuthSource: PH0PR01MB7975.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Nov 2025 07:55:45.4481 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: f30xurCACKg/tcgrF6rynplB/20bVTuYAjKbD2T8/8WHdJ/wXUtkkdkGDDB6ntCQx7Y1zhQRmXc4wftsgh9AGsUPCmtBqK8aLqA54GaS4sn/4c8DWdl17BxS6AKKyp4Q X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR01MB6544 Content-Type: text/plain; charset="utf-8" Save the idle_stamp at the beginning of sched_balance_newidle(), if it cannot pull any task, set it for rq->idle_stamp. This patch does not change the logic of rq->idle_stamp. Signed-off-by: Huang Shijie --- kernel/sched/fair.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 769d7b7990df..c1a8fa043156 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -12862,6 +12862,7 @@ static int sched_balance_newidle(struct rq *this_rq= , struct rq_flags *rf) u64 t0, t1, curr_cost =3D 0; struct sched_domain *sd; int pulled_task =3D 0; + u64 idle_stamp; =20 update_misfit_status(NULL, this_rq); =20 @@ -12877,7 +12878,9 @@ static int sched_balance_newidle(struct rq *this_rq= , struct rq_flags *rf) * for CPU_NEWLY_IDLE, such that we measure the this duration * as idle time. */ - this_rq->idle_stamp =3D rq_clock(this_rq); + idle_stamp =3D rq_clock(this_rq); + + this_rq->idle_stamp =3D 0; =20 /* * Do not pull tasks towards !active CPUs... @@ -12989,10 +12992,11 @@ static int sched_balance_newidle(struct rq *this_= rq, struct rq_flags *rf) if (time_after(this_rq->next_balance, next_balance)) this_rq->next_balance =3D next_balance; =20 - if (pulled_task) - this_rq->idle_stamp =3D 0; - else + if (!pulled_task) { + /* Set it here on purpose. */ + this_rq->idle_stamp =3D idle_stamp; nohz_newidle_balance(this_rq); + } =20 rq_repin_lock(this_rq, rf); =20 --=20 2.40.1