From nobody Mon Dec 1 21:30:52 2025 Received: from mail-ed1-f42.google.com (mail-ed1-f42.google.com [209.85.208.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A26F42144C7 for ; Fri, 28 Nov 2025 07:25:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764314760; cv=none; b=TzkPkzamhI1Nm0Hc4300gMCmyfYMZJ6r7H0oMlGfOGJoE5sIh0T1H8YSXZ9iW3QrlJtCCiiErnlhYFfR+swkmyxU6RJ4So3/YyNUZ5UspKqkwPM5CXAjWzs/foSnHniP/AplJ8lMqe3XzXqrwbIBxnlqdcHyivay3uPVedgmmmo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764314760; c=relaxed/simple; bh=+SmCRWTrlc0r2OwCSIE8ha9a6EvaxxlPeScFrc4xL88=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=lU2fNHF273uUccoEDEFU8AQ9Dt1ECUkCaaWm40Pbb1rP/yCWqmkaVz1NvwFF8iGwUge/Ev/4w7RvXPdd6j8ZOWo9xvB2cFkplTtKXWrcZ/ia7Iqx1JEJBUiJTBd9lzx607B3FIfnh2YCSRMNshcUtotxTkSub+sjkczHDF1MCfE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Zh8nQMYx; arc=none smtp.client-ip=209.85.208.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Zh8nQMYx" Received: by mail-ed1-f42.google.com with SMTP id 4fb4d7f45d1cf-640aa1445c3so2461870a12.1 for ; Thu, 27 Nov 2025 23:25:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764314757; x=1764919557; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=JPascdlztEnoaiHOFCNuou/ryBuA+8aO9E9qYmSrJSQ=; b=Zh8nQMYxAdqfTik7fM0FWmDOKLordzcMdQ5j370cCJUqoA+G5GOcB/dvfz9sA3kHfo uL/FMjFuLbTPGkwbjhED8WjebkAr75kky5dojiw+qK5WFEEegZsRX18RjNiFhri5tU5h 4+TwuqvEUaVq4bB4RnC2YlSk58vy29JUeyR5F+QYzgGxxzUvTLJSA7rh0GUJwO3n+PJW bc7Lufhu00q6x61V77u7hW4RmCYUJW2c1ffEz3nzgI37eERVHHip/s7Cjy2Q77P/F0gg NCiYLGyDI76Nbj8OyALr8qe+HY8IR/WfY5cdqFkfNIS9KxWpFdPx7XqcbvBABlwG8yu0 Ac2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764314757; x=1764919557; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=JPascdlztEnoaiHOFCNuou/ryBuA+8aO9E9qYmSrJSQ=; b=Bsv9P2iV6MQjpJjzrInQZuRmS6AHfLhoXuDWTOmjS+4pekdaQxtcTFBDC/NTmj7Ldt n/iRl4C8iZktQ5n8bgEzOIaL0kCIhTRNdGQR5EyiiSx3N8HePPVKKEkIk4gV/BJZxzs1 x+i1z3SY9Z1WwgO/lhoGmkVbDfG3Y1Di/ToDJVqhchTxa6WsipEoRh2XQSnPsmN3MAQo +fh5TS9ZhUsWyEHF9/sPTs60p5AL/tTaJ2iIwOs6ObxF9A0x8DsFT4hCethC/rE1CohT oNJAUi/v4Ta/M1T3IyTlFbE+07N1LC72mFFjSAokYZ1Vu1/6PhhjNojLclH5dO4tAcS5 0dgA== X-Forwarded-Encrypted: i=1; AJvYcCXNyfzCFSRbxM7hCCsc0bgP/hsRYdd8HhEtLB9W81lHucGA7KyDZhUHyv2+xaeUmJGabaeqgHkl9ELiuVY=@vger.kernel.org X-Gm-Message-State: AOJu0Yzpxgtsu+en+jcJOVB3JGx8s8I71OPwDtOEZi88NCjPgHunfi5B wTRQuAg4KJs9uLOMx22P/AWm/wGxoPzjT8ritFFhfhiK5SxOBe2Fd91b X-Gm-Gg: ASbGncvXXZK+jMEowfUqSMUc4a0Mx3wOONk+LlvwhVTIA3u5nCsaOsgw2YpvnVkoiQq ZT802vxJaUVJ+WH4eo54H1khPC+agddzG9mvB5WsQIJAXsWvDDnYuhp+llgXUYLJnjhgm3ICpRM BcdxDqh0hhClnuqdtwdUZ3taj33cCK0oqfcWi4BZIwlYPDgMvmG8GMyKpGLG+xLSjyXLZAJ4RnV TIYAcKxTa/TkMl4e6qUVwm1wDv5VUAZHwzryanZb63+7XsOe6NU0KX9Q2f/ueVJYTFOVg6ygXrD 5OBP/gGujg585Thv2mGwVAi+WxNKys/XPul2BEAOODsSUZgf/bYfgwC4lYQDnZ9znslnFime5GE drAnDbzRFw6KPHqim3WyF5RJju/vOX8D+nHip1mUR7JKl7GC0o//VRj5xnEfpxeYeTFQ0OqCfHB +gIt62z4dwlHPx8kVjcYyXxQ== X-Google-Smtp-Source: AGHT+IH4lAPY8fQ+r4Wk44TmuRdi25uLpSvjBglMgf1DY7m+zdaalgYzcXk9fjkz1+w5Tljp1kYB5w== X-Received: by 2002:a17:907:2da8:b0:b72:d8da:7aac with SMTP id a640c23a62f3a-b7671a2a2f4mr2992193166b.56.1764314756676; Thu, 27 Nov 2025 23:25:56 -0800 (PST) Received: from localhost.localdomain ([46.10.223.24]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b76f59aece0sm363772466b.32.2025.11.27.23.25.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Nov 2025 23:25:56 -0800 (PST) From: "Nikola Z. Ivanov" To: jiri@resnulli.us, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, skhan@linuxfoundation.org, david.hunter.linux@gmail.com, khalid@kernel.org, linux-kernel-mentees@lists.linuxfoundation.org, "Nikola Z. Ivanov" Subject: [PATCH net-next] team: Add matching error label for failed action Date: Fri, 28 Nov 2025 09:25:44 +0200 Message-ID: <20251128072544.223645-1-zlatistiv@gmail.com> X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Follow the "action" - "err_action" pairing of labels found across the source code of team net device. Currently in team_port_add the err_set_slave_promisc label is reused for exiting on error when setting allmulti level of the new slave. Signed-off-by: Nikola Z. Ivanov Reviewed-by: Jiri Pirko Reviewed-by: Simon Horman --- Related discussion: https://lore.kernel.org/netdev/admyw5vnd3hup26xew7yxfwqo4ypr5sfb3esk7spv4jx= 3yqpxu@g47iffagagah/ drivers/net/team/team_core.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/team/team_core.c b/drivers/net/team/team_core.c index 0a41d2b45d8c..4d5c9ae8f221 100644 --- a/drivers/net/team/team_core.c +++ b/drivers/net/team/team_core.c @@ -1231,7 +1231,7 @@ static int team_port_add(struct team *team, struct ne= t_device *port_dev, if (err) { if (dev->flags & IFF_PROMISC) dev_set_promiscuity(port_dev, -1); - goto err_set_slave_promisc; + goto err_set_slave_allmulti; } } =20 @@ -1258,6 +1258,7 @@ static int team_port_add(struct team *team, struct ne= t_device *port_dev, return 0; =20 err_set_dev_type: +err_set_slave_allmulti: err_set_slave_promisc: __team_option_inst_del_port(team, port); =20 --=20 2.51.0