From nobody Mon Dec 1 22:37:07 2025 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D81D62D3A7B for ; Fri, 28 Nov 2025 05:05:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764306357; cv=none; b=maBw9y/B6Ah2XiOs1xLmaJcAoROJrNOV8TQ17gBRk8j39rog56x8kv5uqTT3hVe54Nt95FfOqub2OM+PticQH20Dx6sgtnfRlftVfr/UidA8jzJtqztcxC6LeIym+jzGsq8sWkwe8Hmpk+21JuyLdd2hQ1ku2GdZ+aP4vnHbfJ8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764306357; c=relaxed/simple; bh=DsrVqkzoOh91LhP+OVCHGfehP1lnEGNGugMDlR9RqUk=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=hq7HhF6MTmqF7az0B/+bzPDOO73JO7H36odURLb4DHIvIgFmfhmjB7TUhLYVvYLdRrvysg9AsS3gs0b2KS5jdlyErh0IFvG0OidwPBW+r+sI3BqNAjDTFWHVcMrWAR7TdsuCn9Nzwisbm7wjD5L8e5TosRJ5kMh7txy25r0MKNc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ay8Gv1OI; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=C4wvaGxd; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ay8Gv1OI"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="C4wvaGxd" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5AS532go3763480 for ; Fri, 28 Nov 2025 05:05:54 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=F84JmaDZwv5 YExecCbKuY9iZ3gotWGmX8OZPfkyrBJI=; b=ay8Gv1OIytR9x6lsHI9YxhB6nqB N4oTwgVW/C5wzE6ZxEcwgaKDN5uqjrHuUehUjRMNZA4gxfvzfYARUraa7JlpU+L+ lcHOBAnd5/5Mc8z1+3GiLr5E8uHLXFs4DkNkxHubGNXDOMlYYsJR7SH6AXAZ5NvM AjaUBDOTv4uLsyEak8e4/pNgtD6hjHDKsn9LWR9ZwAE4cwrp1+Dpoo8+epT/sYhk hcGsuWPAgJcg9bBIb7cTWvjBsbwBoABQL2LlxZehItE2PUJT4YwVMnt+L/ZZgTZ6 0xYG9Q+MiUY0NLUzckuAo+X60x0V/4gzYBtxPee6KpEtkI2+SvYqm/CWGfg== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4aq58fg079-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 28 Nov 2025 05:05:54 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-297df52c960so27960035ad.1 for ; Thu, 27 Nov 2025 21:05:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1764306354; x=1764911154; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=F84JmaDZwv5YExecCbKuY9iZ3gotWGmX8OZPfkyrBJI=; b=C4wvaGxd5qX4xtHMW5ipS0RpHX49K793fu/YCjX597MY/SE9PpyBXcmEU7kBGnG6Jg mtjJ1x2PKsgg6ZSej9OyLLFCqbiiBH/JQXZUQpeKIZfiK3FJBnC3gzjQbu2EtTSUsAvw hOnqzU+bjwPQmcpIAaECTIz1lZFMJj1I4co9opVwiS6yBAnAkU6nT57AUODtXvL/gLI4 uc7peDW+yg4rYm0izim6ZRZYS4pv8jdfoAWb2uuBQzVeDRPD3J6SW9Pi4b/aBkXTobnO K3uGJQH+pp1pfF2a4Q923BjZfgBgPcs3uA9yJ6G4+2iBf6HsawSh5oLEDKSl9d2/BLY4 e26w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764306354; x=1764911154; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=F84JmaDZwv5YExecCbKuY9iZ3gotWGmX8OZPfkyrBJI=; b=Y0lYHBhvtu8kjb42LIkDyDMwV4hHureu81qugYVlRu0rglBhixch+LzYydqVdTT6GF YkWIFmmoWwH8WbIguloRNScSplOhbFXJ68KCBfIwIscENgnSnxnw/Gum2g+BhoCmGMgW PXa75+EOCi9BeSmkuihw5UAg7KX9Htocc4uWe5wRAuIaB1qAXF8lHJTb9+0mEj2OTTvN dPP+0OdSkZVaUQZdwevjIeP7hWx8G1ur5xKTrEZHIXqvkif49iVyVZ2fW/kkZuc8CZ5f 5pmqc6XRHQI3p3yf60jmkpKvoHKMSis+WhiY4dbcNZJzNeNHdPeVtDco5zI3VJ00CIhk N9eA== X-Forwarded-Encrypted: i=1; AJvYcCWMswCv38MI6mytYJWshXQCn4eRWxytIUaR4LvMd7f8V1RcElB32KvaGmUpASWHZwhpHC1WdlCw05uVIFE=@vger.kernel.org X-Gm-Message-State: AOJu0YzdCXPoKM9oeUGn4FpD9w8urFFnneQ/WFV6MXOZtFvpAxJZyY0u OZjVNJuGMW8DgzWJyBH8dWXR/C3SEjDp+AOiPnHXZbj72pvDq3wS9boBeI4kWWb8fh4bYLUfS2m xNwTsSsd8+sMmRs4LOF/UKRoVZYbOchwDSDvzoaw+22dQVrva5reUk+aTGNKoN4oEww4= X-Gm-Gg: ASbGnctsVh/TLZOGi2V9dn4s+BE+JKOVLA8W8ekrP+4QDRz2/g8GQUk5QaM1ynr5+Mt Ok2cBahIBTn/0zJ8XYZztOMD0YDUtQDJ/EmVR0VdL+vfwbcoXZudJR4zjzPnU6z+uBHXI/VKglk yXmJtK/jDN79lQn9hNO+r4RBzFiPCMNUpLQK2AU+Ik0+pOP6Jqzh5frZzrp+iqEt0Wv6nFtHl8Q a8Cy1dw2NVS0CtYiXAaKPJP3ll181pZls3BTKBhmlzumVWPIaWH5R3IoZvScihqDvItAO8YHJBj W9z+6kYSutokdxFf7LgSRZcuSabducHQy3KTLOwAlokV1+QSdGVbsoTAP3I3zra2udVB064gxz9 Y9vU9ah64VoCVnKds33Dbb9jy/LngSl7sGXp9MHnZBg== X-Received: by 2002:a17:903:2c10:b0:298:42ba:c437 with SMTP id d9443c01a7336-29b6bf75998mr276868745ad.50.1764306353541; Thu, 27 Nov 2025 21:05:53 -0800 (PST) X-Google-Smtp-Source: AGHT+IFx+ZM65ovnezE/50mkowLC52WseDJJY7+kJipd677+JzTFJsFEqOV99JXJDXZ6jJ+ICtzGLQ== X-Received: by 2002:a17:903:2c10:b0:298:42ba:c437 with SMTP id d9443c01a7336-29b6bf75998mr276868425ad.50.1764306353085; Thu, 27 Nov 2025 21:05:53 -0800 (PST) Received: from hu-ekangupt-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-29bceb40276sm31952075ad.73.2025.11.27.21.05.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Nov 2025 21:05:52 -0800 (PST) From: Ekansh Gupta To: srini@kernel.org, linux-arm-msm@vger.kernel.org Cc: gregkh@linuxfoundation.org, quic_bkumar@quicinc.com, linux-kernel@vger.kernel.org, quic_chennak@quicinc.com, dri-devel@lists.freedesktop.org, arnd@arndb.de, dmitry.baryshkov@oss.qualcomm.com Subject: [PATCH v4 4/4] misc: fastrpc: Add polling mode support for fastRPC driver Date: Fri, 28 Nov 2025 10:35:34 +0530 Message-Id: <20251128050534.437755-5-ekansh.gupta@oss.qualcomm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20251128050534.437755-1-ekansh.gupta@oss.qualcomm.com> References: <20251128050534.437755-1-ekansh.gupta@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-GUID: SZlXBYXNQuows08L9GbrrUwLxn6nuXT8 X-Proofpoint-ORIG-GUID: SZlXBYXNQuows08L9GbrrUwLxn6nuXT8 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTI4MDAzNCBTYWx0ZWRfX3Fr+Sa+nhECk dSbV/j2S9dcJv0SQn38sFnrsojcpsWD1bPM1vC21mxaW2FtuRBy/Vn7kgdyHvcjmDP23hW2NJue nCms/do+FuxB7cal0y1N6VE4IXr40WCV4Fr5+FFDJmK88vpABQFoIHId/E+qo8BA7TLtn0cTvr+ HcQ+XDh/36lTzUlWV10liOnl/OxDIkeOj1jiI2u0bZgaRvlwurAEpPRc5K8CHEJzrg27lBGzJh6 ExNEbmHcijWGXiI7K5L4uNyf5XqxMfguPsHOgzwuaQ9kXC/sCNXVcORbBEXJuJLF8t6CjaQUY0h 86+lAifBRb4HEKsa2FTX7TNS+onhOOjQyyByLPc8HtkJ9CZ1kxa5Yk3eTPBNULDpj82vr0TT3Rf ZykcYwMaMXsQPsaUpEZAhez/LE4Z9w== X-Authority-Analysis: v=2.4 cv=E6DAZKdl c=1 sm=1 tr=0 ts=69292db2 cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=6UeiqGixMTsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=TEHdEMHTk_fMHrPBF0kA:9 a=1OuFwYUASf3TG4hYMiVC:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-25_02,2025-11-27_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 suspectscore=0 phishscore=0 adultscore=0 lowpriorityscore=0 spamscore=0 clxscore=1015 impostorscore=0 priorityscore=1501 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2511280034 Content-Type: text/plain; charset="utf-8" For any remote call to DSP, after sending an invocation message, fastRPC driver waits for glink response and during this time the CPU can go into low power modes. This adds latency to overall fastrpc call as CPU wakeup and scheduling latencies are included. Add polling mode support with which fastRPC driver will poll continuously on a memory after sending a message to remote subsystem which will eliminate CPU wakeup and scheduling latencies and reduce fastRPC overhead. Poll mode can be enabled by user by using FASTRPC_IOCTL_SET_OPTION ioctl request with FASTRPC_POLL_MODE request id. Signed-off-by: Ekansh Gupta --- drivers/misc/fastrpc.c | 139 ++++++++++++++++++++++++++++++++++-- include/uapi/misc/fastrpc.h | 9 +++ 2 files changed, 141 insertions(+), 7 deletions(-) diff --git a/drivers/misc/fastrpc.c b/drivers/misc/fastrpc.c index 222ff15e04bd..d95d31d27b82 100644 --- a/drivers/misc/fastrpc.c +++ b/drivers/misc/fastrpc.c @@ -22,6 +22,8 @@ #include #include #include +#include +#include #include =20 #define ADSP_DOMAIN_ID (0) @@ -38,6 +40,7 @@ #define FASTRPC_CTX_MAX (256) #define FASTRPC_INIT_HANDLE 1 #define FASTRPC_DSP_UTILITIES_HANDLE 2 +#define FASTRPC_MAX_STATIC_HANDLE (20) #define FASTRPC_CTXID_MASK GENMASK(15, 8) #define INIT_FILELEN_MAX (2 * 1024 * 1024) #define INIT_FILE_NAMELEN_MAX (128) @@ -106,6 +109,12 @@ =20 #define miscdev_to_fdevice(d) container_of(d, struct fastrpc_device, miscd= ev) =20 +/* Poll response number from remote processor for call completion */ +#define FASTRPC_POLL_RESPONSE (0xdecaf) + +/* Polling mode timeout limit */ +#define FASTRPC_POLL_MAX_TIMEOUT_US (10000) + struct fastrpc_phy_page { u64 addr; /* physical address */ u64 size; /* size of contiguous region */ @@ -236,8 +245,14 @@ struct fastrpc_invoke_ctx { u32 sc; u64 *fdlist; u32 *crc; + /* Poll memory that DSP updates */ + u32 *poll; u64 ctxid; u64 msg_sz; + /* work done status flag */ + bool is_work_done; + /* process updates poll memory instead of glink response */ + bool is_polled; struct kref refcount; struct list_head node; /* list of ctxs */ struct completion work; @@ -301,6 +316,8 @@ struct fastrpc_user { int client_id; int pd; bool is_secure_dev; + /* Flags poll mode state */ + bool poll_mode; /* Lock for lists */ spinlock_t lock; /* lock for allocations */ @@ -894,7 +911,8 @@ static int fastrpc_get_meta_size(struct fastrpc_invoke_= ctx *ctx) sizeof(struct fastrpc_invoke_buf) + sizeof(struct fastrpc_phy_page)) * ctx->nscalars + sizeof(u64) * FASTRPC_MAX_FDLIST + - sizeof(u32) * FASTRPC_MAX_CRCLIST; + sizeof(u32) * FASTRPC_MAX_CRCLIST + + sizeof(u32); =20 return size; } @@ -990,6 +1008,7 @@ static int fastrpc_get_args(u32 kernel, struct fastrpc= _invoke_ctx *ctx) list =3D fastrpc_invoke_buf_start(rpra, ctx->nscalars); pages =3D fastrpc_phy_page_start(list, ctx->nscalars); ctx->fdlist =3D (u64 *)(pages + ctx->nscalars); + ctx->poll =3D (u32 *)(ctx->fdlist + FASTRPC_MAX_FDLIST + FASTRPC_MAX_CRCL= IST); args =3D (uintptr_t)ctx->buf->virt + metalen; rlen =3D pkt_size - metalen; ctx->rpra =3D rpra; @@ -1158,6 +1177,75 @@ static int fastrpc_invoke_send(struct fastrpc_sessio= n_ctx *sctx, =20 } =20 +static inline u32 fastrpc_poll_op(void *p) +{ + struct fastrpc_invoke_ctx *ctx =3D p; + + dma_rmb(); + return READ_ONCE(*ctx->poll); +} + +static int poll_for_remote_response(struct fastrpc_invoke_ctx *ctx) +{ + u32 val; + int ret; + + /* + * Poll until DSP writes FASTRPC_POLL_RESPONSE into *ctx->poll + * or until another path marks the work done. + */ + ret =3D read_poll_timeout_atomic(fastrpc_poll_op, val, + (val =3D=3D FASTRPC_POLL_RESPONSE) || + ctx->is_work_done, 1, + FASTRPC_POLL_MAX_TIMEOUT_US, false, ctx); + + if (!ret && val =3D=3D FASTRPC_POLL_RESPONSE) { + ctx->is_work_done =3D true; + ctx->retval =3D 0; + } + + if (ret =3D=3D -ETIMEDOUT) + ret =3D -EIO; + + return ret; +} + +static inline int fastrpc_wait_for_response(struct fastrpc_invoke_ctx *ctx, + u32 kernel) +{ + int err =3D 0; + + if (kernel) { + if (!wait_for_completion_timeout(&ctx->work, 10 * HZ)) + err =3D -ETIMEDOUT; + } else { + err =3D wait_for_completion_interruptible(&ctx->work); + } + + return err; +} + +static int fastrpc_wait_for_completion(struct fastrpc_invoke_ctx *ctx, + u32 kernel) +{ + int err; + + do { + if (ctx->is_polled) { + err =3D poll_for_remote_response(ctx); + /* If polling timed out, move to normal response mode */ + if (err) + ctx->is_polled =3D false; + } else { + err =3D fastrpc_wait_for_response(ctx, kernel); + if (err) + return err; + } + } while (!ctx->is_work_done); + + return err; +} + static int fastrpc_internal_invoke(struct fastrpc_user *fl, u32 kernel, u32 handle, u32 sc, struct fastrpc_invoke_args *args) @@ -1193,16 +1281,25 @@ static int fastrpc_internal_invoke(struct fastrpc_u= ser *fl, u32 kernel, if (err) goto bail; =20 - if (kernel) { - if (!wait_for_completion_timeout(&ctx->work, 10 * HZ)) - err =3D -ETIMEDOUT; - } else { - err =3D wait_for_completion_interruptible(&ctx->work); - } + /* + * Set message context as polled if the call is for a user PD + * dynamic module and user has enabled poll mode. + */ + if (handle > FASTRPC_MAX_STATIC_HANDLE && fl->pd =3D=3D USER_PD && + fl->poll_mode) + ctx->is_polled =3D true; + + err =3D fastrpc_wait_for_completion(ctx, kernel); =20 if (err) goto bail; =20 + if (!ctx->is_work_done) { + err =3D -ETIMEDOUT; + dev_dbg(fl->sctx->dev, "Invalid workdone state for handle 0x%x, sc 0x%x\= n", + handle, sc); + goto bail; + } /* make sure that all memory writes by DSP are seen by CPU */ dma_rmb(); /* populate all the output buffers with results */ @@ -1780,6 +1877,30 @@ static int fastrpc_get_info_from_kernel(struct fastr= pc_ioctl_capability *cap, return 0; } =20 +static int fastrpc_set_option(struct fastrpc_user *fl, char __user *argp) +{ + struct fastrpc_ioctl_set_option opt =3D {0}; + int i; + + if (copy_from_user(&opt, argp, sizeof(opt))) + return -EFAULT; + + for (i =3D 0; i < ARRAY_SIZE(opt.reserved); i++) { + if (opt.reserved[i] !=3D 0) + return -EINVAL; + } + + if (opt.req !=3D FASTRPC_POLL_MODE) + return -EINVAL; + + if (opt.value) + fl->poll_mode =3D true; + else + fl->poll_mode =3D false; + + return 0; +} + static int fastrpc_get_dsp_info(struct fastrpc_user *fl, char __user *argp) { struct fastrpc_ioctl_capability cap =3D {0}; @@ -2134,6 +2255,9 @@ static long fastrpc_device_ioctl(struct file *file, u= nsigned int cmd, case FASTRPC_IOCTL_MEM_UNMAP: err =3D fastrpc_req_mem_unmap(fl, argp); break; + case FASTRPC_IOCTL_SET_OPTION: + err =3D fastrpc_set_option(fl, argp); + break; case FASTRPC_IOCTL_GET_DSP_INFO: err =3D fastrpc_get_dsp_info(fl, argp); break; @@ -2465,6 +2589,7 @@ static int fastrpc_rpmsg_callback(struct rpmsg_device= *rpdev, void *data, =20 ctx->retval =3D rsp->retval; complete(&ctx->work); + ctx->is_work_done =3D true; =20 /* * The DMA buffer associated with the context cannot be freed in diff --git a/include/uapi/misc/fastrpc.h b/include/uapi/misc/fastrpc.h index c6e2925f47e6..3207c42fb318 100644 --- a/include/uapi/misc/fastrpc.h +++ b/include/uapi/misc/fastrpc.h @@ -16,6 +16,7 @@ #define FASTRPC_IOCTL_INIT_CREATE_STATIC _IOWR('R', 9, struct fastrpc_init= _create_static) #define FASTRPC_IOCTL_MEM_MAP _IOWR('R', 10, struct fastrpc_mem_map) #define FASTRPC_IOCTL_MEM_UNMAP _IOWR('R', 11, struct fastrpc_mem_unmap) +#define FASTRPC_IOCTL_SET_OPTION _IOWR('R', 12, struct fastrpc_ioctl_set_o= ption) #define FASTRPC_IOCTL_GET_DSP_INFO _IOWR('R', 13, struct fastrpc_ioctl_cap= ability) =20 /** @@ -66,6 +67,8 @@ enum fastrpc_proc_attr { =20 /* Fastrpc attribute for memory protection of buffers */ #define FASTRPC_ATTR_SECUREMAP (1) +/* Set option request ID to enable poll mode */ +#define FASTRPC_POLL_MODE (1) =20 struct fastrpc_invoke_args { __u64 ptr; @@ -133,6 +136,12 @@ struct fastrpc_mem_unmap { __s32 reserved[5]; }; =20 +struct fastrpc_ioctl_set_option { + __u32 req; /* request id */ + __u32 value; /* value */ + __s32 reserved[6]; +}; + struct fastrpc_ioctl_capability { __u32 unused; /* deprecated, ignored by the kernel */ __u32 attribute_id; --=20 2.34.1