From nobody Mon Dec 1 21:32:50 2025 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A060729C321 for ; Fri, 28 Nov 2025 05:05:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764306347; cv=none; b=gIXi671uQdB0frCdnRHpJYXq/2n6V345EdKB1cJJ1LCTxvRxcOCM4x5kOL8qTcqasakegaPi6pJoukw82o+Kt56qIVVTuzJjS+UHPREO5/PDYJ3rvX4B79LKx6KeX+a+VieSNjsywJqssiUNRXfgQs2N9xVcCIzVeraL9mppENg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764306347; c=relaxed/simple; bh=OdLtVtiwW1xAkEP1Tuk8yBW78hA3TuPbGrqvdFREa1Y=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=DdlkJ6n+cdbPY/ty2OpHR9FKHCohNGPMqEFjpIDY4v2RZOYYCKFOEkqDnCeLg2+ZxgQJ93PtjDDByt+FZk6sLTdcsL3qj3BwO9JRVdatEuLAXE+J1/2aPYj1OjEukmet04RE+6vrARCLyHW3ApJPRrv7QATf9VCctLEhzdHNC5w= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=GYN6muF5; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=K+alVQn4; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="GYN6muF5"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="K+alVQn4" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5ARNP62I2491990 for ; Fri, 28 Nov 2025 05:05:44 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=p+hWMKFKc2m VbzgviX4dn/1pRPQOpQtDu/1ysXFdpkk=; b=GYN6muF56IcEBaCOcGXR6byt6YR Y0ew8MqWafkQ7uJ0pbFwllIyJ1Vc47RqKBivVopa0Cer1+Yx0sc72Rqv4IRG9BE6 8/vR7mzyyyMZ8uNt5BQlqJxi2df1aZc4QRMrUNrn3qX/B88DwVIkaF5cZBOXVRZU JCOsaYLudUvomInjPYB3Jkp3+ROA5qZiv8lnlocQZO5dheonS6SO85H4Wr40d1CO 5It7KaZ417v4PX285eMadyVUugauh2KWeU75S4uVdOYzYzeKg7ZhE5ROVf8wrKN2 /AMhya4fsRhQnPRF3U352x/CzoMypw/gvXxxh6pMBNWK5InKcnP9Rov6qpQ== Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4apm61t8ju-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 28 Nov 2025 05:05:44 +0000 (GMT) Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-297df52c960so27957565ad.1 for ; Thu, 27 Nov 2025 21:05:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1764306343; x=1764911143; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=p+hWMKFKc2mVbzgviX4dn/1pRPQOpQtDu/1ysXFdpkk=; b=K+alVQn4rmv/JctN4Vtjbmy00DqJ0cNaalUcaTN5SHfHVPY9oo1Ugp4+I4xeDUtimP yyUq4p2dXLg8xAdqHGNCbrUpHw8WkjZ8YOPSdWDJTefMM0PU1YfJ/VBbroWMIE5j48mR F5tMiWP6oMkvSIrBMJ1GCbN1ffSFSNkKiMFoNuHQ8koa6BuRY2SmDgDJkRUMzSvA6FvT wLqxAHZd1MDeYIlwvcLOoj2Jto0toGfhe2ax7scPMB9jsOzb4FiR9a3szyYSNlaog4vj 6mv6elG9HrdPegFjA4uhzSkfW4WNgp6X7SCb6oHyFKU00CWUMzlyGhhq/jbE+mNWuSQJ 51vA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764306343; x=1764911143; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=p+hWMKFKc2mVbzgviX4dn/1pRPQOpQtDu/1ysXFdpkk=; b=umc/sa0Za4M4Rldaa5vwqYxuR5TbSHgg6zuQqVbELG7YGZgoKq1H4xCYtuxe3Qnge/ eqIQ7NJcf9hNRkFnre3I702p1qk0DN7lzvonyAQ5bhdT8HMFuY+IuPUwQKKramrtXXJf Y9+3VDzQton9AjkDDDqqEPWwUYk0EylCh9a1Rbr5pAmIeFW6yzk0tP4ClVoqQNnej1zS Zai9xhXtgbfwMSYS5tXy3HQ6n6j/U5lbMXn1JiS7sek/WOUT/NHc4xGE+Gcpf2LXJJHV KqFedlEb3xHPgCrAlrhicyxHy7v2/7l//Xi5j0DKwcXsgvGMdzYoCVYE2GsVD9P/DSua 7iBA== X-Forwarded-Encrypted: i=1; AJvYcCXwG1H64+b2LqL9tNIbGUpp9kKFCGM2VO3bS7fnOQoXDl5nQJGf+LrAUAedPIreYcm3j5K+N/WbxpC+QXk=@vger.kernel.org X-Gm-Message-State: AOJu0Yzf27unsc0jjDIigsZB25bAqpvEWU4rHB7tWSe41ia2MmmcMW5n +XQ3w+HKNi3yds7V462+D1ZPAaQTLD/r7dgLUlFqiXMLEEfQF8F9HtBCI4//e43xr3lL0rvO49A SF0WDC5F2PZJB1lpy9k3l3eqRSMgNoSRgaOrxI95zbJNfseuCDc2PiIbVf2tzzM7HbZk= X-Gm-Gg: ASbGncux4FqJ9A5GXZJEnDUVdZOO1BIH9wSRHHnPvAHQ3u2uMt6mmZ91Bgm+H9zawBR 8oLFfnz6zDrnw/jQWqIJuX1MC16Y/IvubqZSsbOCS4GO093vR8yvtjAuWzl2U1HoCZwOr5o1eyO /aRIqpZzsdQO0Wj+sKm3HS5wG6/+L75SgAQRqMYmuPXzXpQpm9M2QQoWh3ZvmF+76AWr8LyLmU6 KvhzampcgRze9obApFqZ5PZgmJiCus19SGTEFAJZ0I4gWuovI2W0zcq9EQeR9ShhZcY+M5M7UYM tQl9/iCcdWFOzA+ckuQtJBO6pjh0qoRtWcZJ+5NYypvmZrn1j6zzl+2l5YqPNO+dFLCXSWogXcT M+Dgnot2VZwOf90KUpgpbMl4/GQIx9cexgTF5pdx/Jw== X-Received: by 2002:a17:903:8cb:b0:295:70b1:edc8 with SMTP id d9443c01a7336-29b6be917a2mr313234445ad.2.1764306343275; Thu, 27 Nov 2025 21:05:43 -0800 (PST) X-Google-Smtp-Source: AGHT+IGttVcxC48I1qXIGJ8pQYFoTXX/seoyTogxzon7pZSukIpd1r+O3xQjxLuzCwzZDbvVHZOVGA== X-Received: by 2002:a17:903:8cb:b0:295:70b1:edc8 with SMTP id d9443c01a7336-29b6be917a2mr313234025ad.2.1764306342721; Thu, 27 Nov 2025 21:05:42 -0800 (PST) Received: from hu-ekangupt-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-29bceb40276sm31952075ad.73.2025.11.27.21.05.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Nov 2025 21:05:42 -0800 (PST) From: Ekansh Gupta To: srini@kernel.org, linux-arm-msm@vger.kernel.org Cc: gregkh@linuxfoundation.org, quic_bkumar@quicinc.com, linux-kernel@vger.kernel.org, quic_chennak@quicinc.com, dri-devel@lists.freedesktop.org, arnd@arndb.de, dmitry.baryshkov@oss.qualcomm.com Subject: [PATCH v4 1/4] misc: fastrpc: Move fdlist to invoke context structure Date: Fri, 28 Nov 2025 10:35:31 +0530 Message-Id: <20251128050534.437755-2-ekansh.gupta@oss.qualcomm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20251128050534.437755-1-ekansh.gupta@oss.qualcomm.com> References: <20251128050534.437755-1-ekansh.gupta@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-GUID: -AXX9OCcDxY0bMLiag4AukqWK3t9qEAR X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTI4MDAzNSBTYWx0ZWRfX2VXOUmriqPLL wkOny1OGD0+b8r6sPVRSnCqLVUpMxy0I9qOS6OrvaAc7byEQEIHMELLX4NECzUxnzary76HkcZQ DAJeJhSAtEGCF4ePSaP28dilNbxJPp8h6OPvFAGs6cPaT6Rm4Z+g5YUr453g2U/INZZFYeTx3Wy zilQImlCpVe8V7mttxFvSinPY0m4vshFs90Mtob0alKP6vLbLCuxUO5q2qPL5DuYIawJnFOwMBm zc1uiyjGFBjMt5Kt0Z2sya1SdZaIgn/DtMxdfEivXeovAir9QTHatotYRwt6bNGlLu17zWQGc8Y dGWKdowrQMRHTE5KEGt+8ytCloGT9ceUF6YK5PFD/T0E1yCMjNQ4ofntchd53yzhnRBBN7vMKp1 NR1TiA0KuAC/lUbv2+ePUsuV0gHEwA== X-Proofpoint-ORIG-GUID: -AXX9OCcDxY0bMLiag4AukqWK3t9qEAR X-Authority-Analysis: v=2.4 cv=IciKmGqa c=1 sm=1 tr=0 ts=69292da8 cx=c_pps a=IZJwPbhc+fLeJZngyXXI0A==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=6UeiqGixMTsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=hRzSbfjIAxXVlyYcgJ4A:9 a=uG9DUKGECoFWVXl0Dc02:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-25_02,2025-11-27_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 lowpriorityscore=0 clxscore=1015 impostorscore=0 priorityscore=1501 bulkscore=0 adultscore=0 spamscore=0 malwarescore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2511280035 Content-Type: text/plain; charset="utf-8" The fdlist is currently part of the meta buffer, computed during put_args. This leads to code duplication when preparing and reading critical meta buffer contents used by the FastRPC driver. Move fdlist to the invoke context structure to improve maintainability and reduce redundancy. This centralizes its handling and simplifies meta buffer preparation and reading logic. Signed-off-by: Ekansh Gupta --- drivers/misc/fastrpc.c | 16 +++++----------- 1 file changed, 5 insertions(+), 11 deletions(-) diff --git a/drivers/misc/fastrpc.c b/drivers/misc/fastrpc.c index ee652ef01534..679cd8997a00 100644 --- a/drivers/misc/fastrpc.c +++ b/drivers/misc/fastrpc.c @@ -233,6 +233,7 @@ struct fastrpc_invoke_ctx { int pid; int client_id; u32 sc; + u64 *fdlist; u32 *crc; u64 ctxid; u64 msg_sz; @@ -987,6 +988,7 @@ static int fastrpc_get_args(u32 kernel, struct fastrpc_= invoke_ctx *ctx) rpra =3D ctx->buf->virt; list =3D fastrpc_invoke_buf_start(rpra, ctx->nscalars); pages =3D fastrpc_phy_page_start(list, ctx->nscalars); + ctx->fdlist =3D (u64 *)(pages + ctx->nscalars); args =3D (uintptr_t)ctx->buf->virt + metalen; rlen =3D pkt_size - metalen; ctx->rpra =3D rpra; @@ -1089,18 +1091,10 @@ static int fastrpc_put_args(struct fastrpc_invoke_c= tx *ctx, union fastrpc_remote_arg *rpra =3D ctx->rpra; struct fastrpc_user *fl =3D ctx->fl; struct fastrpc_map *mmap =3D NULL; - struct fastrpc_invoke_buf *list; - struct fastrpc_phy_page *pages; - u64 *fdlist; - int i, inbufs, outbufs, handles; + int i, inbufs; int ret =3D 0; =20 inbufs =3D REMOTE_SCALARS_INBUFS(ctx->sc); - outbufs =3D REMOTE_SCALARS_OUTBUFS(ctx->sc); - handles =3D REMOTE_SCALARS_INHANDLES(ctx->sc) + REMOTE_SCALARS_OUTHANDLES= (ctx->sc); - list =3D fastrpc_invoke_buf_start(rpra, ctx->nscalars); - pages =3D fastrpc_phy_page_start(list, ctx->nscalars); - fdlist =3D (uint64_t *)(pages + inbufs + outbufs + handles); =20 for (i =3D inbufs; i < ctx->nbufs; ++i) { if (!ctx->maps[i]) { @@ -1122,9 +1116,9 @@ static int fastrpc_put_args(struct fastrpc_invoke_ctx= *ctx, cleanup_fdlist: /* Clean up fdlist which is updated by DSP */ for (i =3D 0; i < FASTRPC_MAX_FDLIST; i++) { - if (!fdlist[i]) + if (!ctx->fdlist[i]) break; - if (!fastrpc_map_lookup(fl, (int)fdlist[i], &mmap)) + if (!fastrpc_map_lookup(fl, (int)ctx->fdlist[i], &mmap)) fastrpc_map_put(mmap); } =20 --=20 2.34.1 From nobody Mon Dec 1 21:32:50 2025 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9EBDC2C237C for ; Fri, 28 Nov 2025 05:05:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764306351; cv=none; b=ksS8LEHw8UkzTw80y/scb7UJokZaHaDhpkhDxnDstHxMytTxwYJUvixNOuFdrE4r9oDLovJlHqX98TKBzSQ+FWlJqLBMZ6J1zhPu1vztD0AJ3hadRLAzJ4IIFsmWt2HByZwJDYMtOp/9a9Qa225i77LpAJNGLQXfMqxTHZlB3R4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764306351; c=relaxed/simple; bh=MHn+V6TRZoHpB/IKHPrGSV0ycKamLtaH9inFw5f2g5Y=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Q1XA8FfIP+ITRYJcfxHnGXlIJvEXd3nNF9s928mXjSSiAn+jkr9AALWf/eQnP2a196SaF89JkLnG4qGu8JsSo5LMr+QDWIdOREEsE2qcTAFer/SBlM5BnIcFWtSGmIjmioy/pgMo8RcjpZpfN41Z3PDvQ2c+gEYbNMtwkbUB7Og= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=bNyAr8uO; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=J9gy9m5H; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="bNyAr8uO"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="J9gy9m5H" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5ARLP21W1940063 for ; Fri, 28 Nov 2025 05:05:48 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=44twYS2j8pu ef9SPj0m2ACmUVD52vfoicRaqJwTY5UY=; b=bNyAr8uO7bts12AzHYKQ8z/cNfl z5T6xsO4+YmfTg/HZ0048u/vEk73rflpzjqeyZ9vX4XHSYlnJlZJqgEYCsBGlT7e XSbbqLcZb2FtKVTfef8U02Z3eaIoSfagEUpK3OV7q0t3uE7x33/jEfxU+4IIGcpp 3ymZe5MPTx+Q5lZYaNWNM9B94tnt1U26IazZmrUs3neMe04OEi+E5Hk8dvGeO6p4 dWIGorrhRF7bvnW0mAY5TT7fq+0Ho+g5rzpkPO26Q+JMjYXUmUyofzwF3sA1odcB aOrSj6dc+5u/9e9VQ/xCkZJFgl5TzWeFvlWY+6PbuOFoQ2tQpQRIfoIE+4g== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4apnud9x70-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 28 Nov 2025 05:05:47 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-297ddb3c707so11726405ad.2 for ; Thu, 27 Nov 2025 21:05:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1764306346; x=1764911146; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=44twYS2j8puef9SPj0m2ACmUVD52vfoicRaqJwTY5UY=; b=J9gy9m5HQY4FEU2XCPDpbyrF32WHNQx+a7mOfNk389Rg49JEhq3own+dF0Oq1M/uM1 +TZ/qxboJo5IWklfo77HvGbCPL08YOYowRtXVe41vkwkfCqNia0wWkVUVCuVKK1Usa2N 6tng8/4LTxT8ZYvItAxxgBJk5aBiAAl5YjTxmJ7ZhUewMqETHAYDEY8XVhu2RZMSNN9k 5NLeFLMshl7UHSOKFtuMQYcOyTKNDHMHLvPU+jYMkLOhYgExXrV0ZykdqAHK8J4S37N9 s9l2vgbsTLPHxM4qpMjLyBd0MZY2QYOe1iUXDvsnf/B0lYfazE4UxxHbyFei7JbqR3uX vBvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764306346; x=1764911146; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=44twYS2j8puef9SPj0m2ACmUVD52vfoicRaqJwTY5UY=; b=eZNA+tL7Yyl7tzpCeezBp67P/zq5KIpm2S+V+RbamQVrJySSC3z5f7MIoKQAyB94qD 85mY+117pp8k3eSQE0oTXqDrAnEx+NKs7oz6DAxhk4V8tZvLmvjmeu9TLJGH9aBYrmem piXYDDBiXDoUcQprqt8QHEVT7kz7qSVxJ/rVBl0d+aXBuC82az9ZolfFq5YV5ajiB+HD DD2ITKLOmYSG3hRkkCVCRaH9LFcedlDWmU6gSsfA+RC73YueByiYyoPy4w47lRJWl55i foVZDrhjii7wqwP5JiTTzqxTCa2E6gu7VPBxIZxc0BEwDl6wUTVZqft7Hf7M/lKXj3vk fFmQ== X-Forwarded-Encrypted: i=1; AJvYcCW/y7s4IO0YNPHLGY7v5sdtsTnrIiwuH6wpcmfZQmGw2wxJPoYNwYeDw3sesOEuUqmQ34/8GBgppKitBTk=@vger.kernel.org X-Gm-Message-State: AOJu0YzcIL3AUumhcRXyy9K2EzL0cTHn2j/22bFmE+xr72yxhjyu/+x4 HigeuDk/4997qZnVMg3jblw2JFTRyCoUDc5MRhjH6FIi+JHRhV1m0vn8cSAFs5Jj7fb7CiM3rfw GFs6kbPW5PaMdKIY+F9zxa/IcomMWG2Cb5wgqgF0CMxMxQFhOG7/Dpzx+fZJq81/6EvI= X-Gm-Gg: ASbGncsE+w3BYVhls7gsiLKt9TvAA8v3LZQfYUCfeonCwwXzSNVAgXImiIg1KOQ/1pE gV6ORo1jeFFOXE1etwZyr4gxZRcd3pyKHFY9eDnavRhHuCwQHzmHOgxybKYWzwQNjdm7OcfM1Dz Jk4LOe2m7EPzXTCMkMA3K63ap6fxbuVsONkyjenKPqTLqa6KMkD4ECaYtBXrKPlLwgcIrSScDzK 6lJKTZxDU8TTePlZrPaX6Xp7aY5t3qxCKn0SE793ZVHcyPTFUaP/wVFdE17vqdsqvekyB3ah2MW OlUffTI6Y8z316e+MDcDwMHTlUkwazzCCZVI4mFz2ccxUFvc8TIF3uL36/9n+ZUUSEe85jLrse8 BmpWtHAXPJuGqOJjvBlqBD95KVMdPTs/BE6U5LgjlKw== X-Received: by 2002:a17:903:4b4b:b0:298:35c:c313 with SMTP id d9443c01a7336-29bab30b2c3mr152791235ad.61.1764306346587; Thu, 27 Nov 2025 21:05:46 -0800 (PST) X-Google-Smtp-Source: AGHT+IE5vU/dXx4v3KW0plfFY8OrOYCD0CU/vAR1V5h3oXplPI2SFfGWsGEiYMb5j54hJMtNg3yK0w== X-Received: by 2002:a17:903:4b4b:b0:298:35c:c313 with SMTP id d9443c01a7336-29bab30b2c3mr152790925ad.61.1764306346126; Thu, 27 Nov 2025 21:05:46 -0800 (PST) Received: from hu-ekangupt-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-29bceb40276sm31952075ad.73.2025.11.27.21.05.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Nov 2025 21:05:45 -0800 (PST) From: Ekansh Gupta To: srini@kernel.org, linux-arm-msm@vger.kernel.org Cc: gregkh@linuxfoundation.org, quic_bkumar@quicinc.com, linux-kernel@vger.kernel.org, quic_chennak@quicinc.com, dri-devel@lists.freedesktop.org, arnd@arndb.de, dmitry.baryshkov@oss.qualcomm.com Subject: [PATCH v4 2/4] misc: fastrpc: Replace hardcoded ctxid mask with GENMASK Date: Fri, 28 Nov 2025 10:35:32 +0530 Message-Id: <20251128050534.437755-3-ekansh.gupta@oss.qualcomm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20251128050534.437755-1-ekansh.gupta@oss.qualcomm.com> References: <20251128050534.437755-1-ekansh.gupta@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-GUID: W4DrqX02FHqskZrKq2Uf6MFKoI7BPnCV X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTI4MDAzNSBTYWx0ZWRfX94/oCdrngyg2 3/z3nCctk/fZLBNop4CX/+ig2JZEfPmKVoSGkjgTF2zmD6HaSNH8CJ/+MOciwyyBS+RiT5jB+KE l9lsLPwuMe0BEun96S3GYy9MKlzg8emy+bx2w0JssEXcAqnCr517lqKmORRee2FoGsfo4KMyR0X FqgapK6qslyINog3gV4SPz1ESgCv+pJp+r2yvMz/hX7KUD77H5RGmC6h6sEX2C1VSqhNi/5I1vJ QlwJY6pBn7+0mehLU5JOXRbjyfjuURXTnL9MCZHEfY7MbNvnVasgrNqxXa4SqxnBAM3jyieyBU9 Re+HSqQAg0tYVEBsL/q0cMIoisvBqQnnlLzoJ078Z3lwWzuYBTvMHR2eU+hlfbBsS5QHcQWu8u2 FcijPEK4NxyvzhGGzOrDrnc9WFC0Cg== X-Proofpoint-ORIG-GUID: W4DrqX02FHqskZrKq2Uf6MFKoI7BPnCV X-Authority-Analysis: v=2.4 cv=MKNtWcZl c=1 sm=1 tr=0 ts=69292dac cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=6UeiqGixMTsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=mhgHPu3uRlbtNExDwEMA:9 a=1OuFwYUASf3TG4hYMiVC:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-25_02,2025-11-27_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 adultscore=0 clxscore=1015 phishscore=0 lowpriorityscore=0 spamscore=0 suspectscore=0 malwarescore=0 impostorscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2511280035 Content-Type: text/plain; charset="utf-8" Replace the hardcoded context ID mask (0xFF0) with GENMASK(11, 4) to improve readability and follow kernel bitfield conventions. Use FIELD_PREP and FIELD_GET instead of manual shifts for setting and extracting ctxid values. Signed-off-by: Ekansh Gupta --- drivers/misc/fastrpc.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/misc/fastrpc.c b/drivers/misc/fastrpc.c index 679cd8997a00..f7fb44a8e9c0 100644 --- a/drivers/misc/fastrpc.c +++ b/drivers/misc/fastrpc.c @@ -22,6 +22,7 @@ #include #include #include +#include =20 #define ADSP_DOMAIN_ID (0) #define MDSP_DOMAIN_ID (1) @@ -37,7 +38,7 @@ #define FASTRPC_CTX_MAX (256) #define FASTRPC_INIT_HANDLE 1 #define FASTRPC_DSP_UTILITIES_HANDLE 2 -#define FASTRPC_CTXID_MASK (0xFF0) +#define FASTRPC_CTXID_MASK GENMASK(11, 4) #define INIT_FILELEN_MAX (2 * 1024 * 1024) #define INIT_FILE_NAMELEN_MAX (128) #define FASTRPC_DEVICE_NAME "fastrpc" @@ -489,7 +490,7 @@ static void fastrpc_context_free(struct kref *ref) fastrpc_buf_free(ctx->buf); =20 spin_lock_irqsave(&cctx->lock, flags); - idr_remove(&cctx->ctx_idr, ctx->ctxid >> 4); + idr_remove(&cctx->ctx_idr, FIELD_GET(FASTRPC_CTXID_MASK, ctx->ctxid)); spin_unlock_irqrestore(&cctx->lock, flags); =20 kfree(ctx->maps); @@ -625,7 +626,7 @@ static struct fastrpc_invoke_ctx *fastrpc_context_alloc( spin_unlock_irqrestore(&cctx->lock, flags); goto err_idr; } - ctx->ctxid =3D ret << 4; + ctx->ctxid =3D FIELD_PREP(FASTRPC_CTXID_MASK, ret); spin_unlock_irqrestore(&cctx->lock, flags); =20 kref_init(&ctx->refcount); @@ -2451,7 +2452,7 @@ static int fastrpc_rpmsg_callback(struct rpmsg_device= *rpdev, void *data, if (len < sizeof(*rsp)) return -EINVAL; =20 - ctxid =3D ((rsp->ctx & FASTRPC_CTXID_MASK) >> 4); + ctxid =3D FIELD_GET(FASTRPC_CTXID_MASK, rsp->ctx); =20 spin_lock_irqsave(&cctx->lock, flags); ctx =3D idr_find(&cctx->ctx_idr, ctxid); --=20 2.34.1 From nobody Mon Dec 1 21:32:50 2025 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7191B2D0C61 for ; Fri, 28 Nov 2025 05:05:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764306353; cv=none; b=IjIfVoTbie5mB0ixCCOj+aIjTV0GRLJIH3Qttpc+Wx/h6WSNPomkMEoAlM0rmhL3eAMytfkADprVmhEuJecp20CcpH+wc5PrWpQ5rzedIKTHL/2dfRG2vmwCv8mEmSTuWXQ5RszhnM9lSft2WnNKtfGG6cEFG3qSyWqpjT4n/Fg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764306353; c=relaxed/simple; bh=799JKmMxCZfstgdgvJldNL7XrhQ7fKae0ffYtfrqUh0=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Q5xNbI/f8t1ylvmWDLyoW2D/OnHgS1n2NOLkzoXFnSgSglLZD/XJPkeAd4qPp+UwSQZHSMDnbtcQsG1YlfkU7aRLZT+wiQdqe60DH5HdHCdLQfLyBwjCfgtbr01qlVdfbnQLVGZu7IFCcDpeHoCE9zH5YLtuCK7Xof/7aUqsahA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ln56N1Vl; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=A1/MPn/y; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ln56N1Vl"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="A1/MPn/y" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5ARMkfVI2101582 for ; Fri, 28 Nov 2025 05:05:51 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=Hu64amW9A5E UX9Pnd9zYE8WBf7r6f1Os8itmx4PIfI4=; b=ln56N1Vlnp0qbxqXBTRX0VQLx/b dPkeEpeLCuamqXnIGjWgly5bImd5S7g1HzlCTeoPAx9onS6NFWu7///bL1QpE7uk HXdsLfWgitXzlqZcx8hxiymTuYIYptVGUlMMnKi95XnDUtxyeaSoOHn2X/imrXmq 3j4recWWflpwkKzalHsluJ/NHMrCCFGSLx/koTlJgHNVgqF7l0u+ha9alTPGRdR4 eSdnDSKGXEG4oynDD0Kz+IQ02+xVHk1TFgIxMZuOPKkJPnDxnNSMVYZEFF/xYKby mf+rep1T3NubnQ1eCei5DzdM/U4utErSCz9CwOO00wS0zqzSjs+l3UnTnqQ== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4apnud9x7q-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 28 Nov 2025 05:05:51 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-297f48e81b8so20586335ad.0 for ; Thu, 27 Nov 2025 21:05:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1764306350; x=1764911150; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Hu64amW9A5EUX9Pnd9zYE8WBf7r6f1Os8itmx4PIfI4=; b=A1/MPn/ynDZDDc4PtYM6PpE6ilCFN35pNtIlRDkXwlWZ+wjbgwQpqsxIkOhGrBNLbQ LlODZWYULUQt53dE64HvMNdcB36qYVOk29UkmtXfU98tVZkAwor3kRazsNtZmZAQOEoc fUNRLLS+j1nqkjVrIwW+9qN5TmF5cDfB41NXxlvnY+YJTYmnom0hqrHz9QWSVcGaxSii cy+qt/1WGhX8EQu5kEbwXp3kWyXp4EOQMBlQyXqZDDV9v/Z7aIepzoWW1EbbwcZarLFN ubRC7mVGADGzmARsksD1dKbTRUPLqDeoyQVKf/EHWyUGqtIlVoP04ixl21vKgQizLkoT jFTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764306350; x=1764911150; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Hu64amW9A5EUX9Pnd9zYE8WBf7r6f1Os8itmx4PIfI4=; b=K6G4hHqRtfyP9Ox6kjJ0VLT7Vvdb7c5SUyIFILJ6SYZcxiVhaKTUleGutlCjoSxTMk uMW9J8eXJRdbZrNRpnxzwh9voONfPCKeWiiYpAE2X68Lr0JVRK3bpw7/VB2rw+Rs8lxr TG7fPrTID67QY2QzPx0tUyb3s0YAHkOO+aAZy0TnVAyskts8ikkG4LVtCxiYPFldUHs8 SR02WeYpeKD5/63IVpSWgvcXrXXlElKc8mH0A4QPpaiD90wMbF4vEQqa1WqQvsXNOFh3 TbDe6xYY8Tl3Hy+tU7YwzV/rJfSGcB2fhM3UICW3MfZbVamC+pXMvU7sIEsoMj1SALgo +nug== X-Forwarded-Encrypted: i=1; AJvYcCXHMlbEJZiYGawd0AK1znoVnW2BmkkiHPyXzNKQ0IC/eV20vAZs0IOrpFmFtdEahtqnsCW3saspxwx0WyQ=@vger.kernel.org X-Gm-Message-State: AOJu0YwA8GYbRHEN0glk3nt6/yOkMr/ew16wZXpNAo9+zSLD9wCtJVpx c+3qFzlteFddI6OSXNPWYL0lOmXgNWFYmHDyNA4tvBLcGulXr4UEtkgxTFb5QnrB7jSNZeLCVR0 GvSuyqiMg8/r2wWvHa8VDx1FZlt5SNuJXXWRMoy/OHnIwhkjUs4awT/Yp63krMP8ag8o= X-Gm-Gg: ASbGncvoQLTlzd8Ja+SGw9Tu6oYqC+X3mCRVdM3oD4EhJERKMn3GrPXQ3tLDTIzM1Rj J3OQsXXZYgUvOTACF70ZJuUPScuyMy91Lmbd8OUJ1apXKbhDy7/JjCQ17tJ8b1S/86izheYdPc+ FnV4pLtpNzH5VnFkIKXmYBI1btxDHIz1clzwS/kRJtS7U+Z9HuuSCPPqmg+BuEIr5NJb2lZNQZX qtnzmqt9KdOysRqC3679wk7JGD9nX9lyujheNOTQ6ZGShyXgnSIUaAhuYXj8ignJ9UHwK8vumnG eO7cIXCspJMT7scUatKuZdqS5QcWRT6AYi25XpdNQ/EwBsu+27UjuR5ftULlfybBTd17hTx4RdL DOfw8lorqyykqoGSzeZtydeW9mRv/fEhtA8mOyUGDFA== X-Received: by 2002:a17:903:166e:b0:299:dc97:a6c9 with SMTP id d9443c01a7336-29b5e3b6b04mr292120575ad.20.1764306350180; Thu, 27 Nov 2025 21:05:50 -0800 (PST) X-Google-Smtp-Source: AGHT+IFnZPuuDoNqGww8zARhrgAh0/9U9koXPe5CLxH+oUCH41mNlEOVmh+iC6IejsR9qbfAwOOBrw== X-Received: by 2002:a17:903:166e:b0:299:dc97:a6c9 with SMTP id d9443c01a7336-29b5e3b6b04mr292120265ad.20.1764306349517; Thu, 27 Nov 2025 21:05:49 -0800 (PST) Received: from hu-ekangupt-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-29bceb40276sm31952075ad.73.2025.11.27.21.05.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Nov 2025 21:05:49 -0800 (PST) From: Ekansh Gupta To: srini@kernel.org, linux-arm-msm@vger.kernel.org Cc: gregkh@linuxfoundation.org, quic_bkumar@quicinc.com, linux-kernel@vger.kernel.org, quic_chennak@quicinc.com, dri-devel@lists.freedesktop.org, arnd@arndb.de, dmitry.baryshkov@oss.qualcomm.com Subject: [PATCH v4 3/4] misc: fastrpc: Expand context ID mask for DSP polling mode support Date: Fri, 28 Nov 2025 10:35:33 +0530 Message-Id: <20251128050534.437755-4-ekansh.gupta@oss.qualcomm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20251128050534.437755-1-ekansh.gupta@oss.qualcomm.com> References: <20251128050534.437755-1-ekansh.gupta@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-GUID: UvBmq6M4lyv7arRqCwaCLgz5XFAuMUzW X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTI4MDAzNSBTYWx0ZWRfX7lGfU39BWLAg ry0FTiEw591fot0WgY1CoGg06huI2FUiXOXFbIsP6LNOwNUiFba/qAZg7UMI0KXxJ1OK55p6O+5 R88HKSaRzhIEDB015rQUb6JIzx0WyrIGG3OjYUj5pieXqgsYKq74IYMGcrEtJYQUVWglGX6lRG1 dYAsE0I7JLV1eKMv2h+F93iA2BoxF7WOlUCB5MrmxD88a21e8dg5inoF0bGqjSYBcryGHirYygP /ErMq97V42Lh1afaTzbPG/JnsQSfiwJ1rhLvHb3b/ydWaAaZ4msjlAVm02SZft/jX0TFs+Qpc6G YokKmD1Y1N2pnxMZoa/6XdXANgUBghLS4VEvTHNkrbwoUjvq33J2CStrA2nkOiJDMi2P29ya98q DAaG4xrX44OTe+pZv5kdf9am7EsMcA== X-Proofpoint-ORIG-GUID: UvBmq6M4lyv7arRqCwaCLgz5XFAuMUzW X-Authority-Analysis: v=2.4 cv=MKNtWcZl c=1 sm=1 tr=0 ts=69292daf cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=6UeiqGixMTsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=ou9iVbgrfxuWbo8UQ_4A:9 a=1OuFwYUASf3TG4hYMiVC:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-25_02,2025-11-27_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 adultscore=0 clxscore=1015 phishscore=0 lowpriorityscore=0 spamscore=0 suspectscore=0 malwarescore=0 impostorscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2511280035 Content-Type: text/plain; charset="utf-8" Current FastRPC message context uses a 12-bit mask where the upper 8 bits represent the context ID from idr_alloc_cyclic and the lower 4 bits represent the PD type. This layout works for normal FastRPC calls but fails for polling mode because DSP expects a 16-bit context with an additional async mode bit. To enable polling mode support from DSP(DSP writes to poll memory), DSP expects a 16-bit context where the upper 8 bits are context ID, the lower 4 bits are PD type and the 5th bit from the end denotes async mode(not yet upstreamed). If this bit is set, DSP disables polling. With the current design, odd context IDs set this bit, causing DSP to skip poll memory updates. Update the context mask to ensure a hole which won't get populated, ensuring polling mode works as expected. This is not a bug and the change is added to support polling mode. Signed-off-by: Ekansh Gupta --- drivers/misc/fastrpc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/misc/fastrpc.c b/drivers/misc/fastrpc.c index f7fb44a8e9c0..222ff15e04bd 100644 --- a/drivers/misc/fastrpc.c +++ b/drivers/misc/fastrpc.c @@ -38,7 +38,7 @@ #define FASTRPC_CTX_MAX (256) #define FASTRPC_INIT_HANDLE 1 #define FASTRPC_DSP_UTILITIES_HANDLE 2 -#define FASTRPC_CTXID_MASK GENMASK(11, 4) +#define FASTRPC_CTXID_MASK GENMASK(15, 8) #define INIT_FILELEN_MAX (2 * 1024 * 1024) #define INIT_FILE_NAMELEN_MAX (128) #define FASTRPC_DEVICE_NAME "fastrpc" --=20 2.34.1 From nobody Mon Dec 1 21:32:50 2025 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D81D62D3A7B for ; Fri, 28 Nov 2025 05:05:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764306357; cv=none; b=maBw9y/B6Ah2XiOs1xLmaJcAoROJrNOV8TQ17gBRk8j39rog56x8kv5uqTT3hVe54Nt95FfOqub2OM+PticQH20Dx6sgtnfRlftVfr/UidA8jzJtqztcxC6LeIym+jzGsq8sWkwe8Hmpk+21JuyLdd2hQ1ku2GdZ+aP4vnHbfJ8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764306357; c=relaxed/simple; bh=DsrVqkzoOh91LhP+OVCHGfehP1lnEGNGugMDlR9RqUk=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=hq7HhF6MTmqF7az0B/+bzPDOO73JO7H36odURLb4DHIvIgFmfhmjB7TUhLYVvYLdRrvysg9AsS3gs0b2KS5jdlyErh0IFvG0OidwPBW+r+sI3BqNAjDTFWHVcMrWAR7TdsuCn9Nzwisbm7wjD5L8e5TosRJ5kMh7txy25r0MKNc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ay8Gv1OI; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=C4wvaGxd; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ay8Gv1OI"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="C4wvaGxd" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5AS532go3763480 for ; Fri, 28 Nov 2025 05:05:54 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=F84JmaDZwv5 YExecCbKuY9iZ3gotWGmX8OZPfkyrBJI=; b=ay8Gv1OIytR9x6lsHI9YxhB6nqB N4oTwgVW/C5wzE6ZxEcwgaKDN5uqjrHuUehUjRMNZA4gxfvzfYARUraa7JlpU+L+ lcHOBAnd5/5Mc8z1+3GiLr5E8uHLXFs4DkNkxHubGNXDOMlYYsJR7SH6AXAZ5NvM AjaUBDOTv4uLsyEak8e4/pNgtD6hjHDKsn9LWR9ZwAE4cwrp1+Dpoo8+epT/sYhk hcGsuWPAgJcg9bBIb7cTWvjBsbwBoABQL2LlxZehItE2PUJT4YwVMnt+L/ZZgTZ6 0xYG9Q+MiUY0NLUzckuAo+X60x0V/4gzYBtxPee6KpEtkI2+SvYqm/CWGfg== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4aq58fg079-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 28 Nov 2025 05:05:54 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-297df52c960so27960035ad.1 for ; Thu, 27 Nov 2025 21:05:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1764306354; x=1764911154; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=F84JmaDZwv5YExecCbKuY9iZ3gotWGmX8OZPfkyrBJI=; b=C4wvaGxd5qX4xtHMW5ipS0RpHX49K793fu/YCjX597MY/SE9PpyBXcmEU7kBGnG6Jg mtjJ1x2PKsgg6ZSej9OyLLFCqbiiBH/JQXZUQpeKIZfiK3FJBnC3gzjQbu2EtTSUsAvw hOnqzU+bjwPQmcpIAaECTIz1lZFMJj1I4co9opVwiS6yBAnAkU6nT57AUODtXvL/gLI4 uc7peDW+yg4rYm0izim6ZRZYS4pv8jdfoAWb2uuBQzVeDRPD3J6SW9Pi4b/aBkXTobnO K3uGJQH+pp1pfF2a4Q923BjZfgBgPcs3uA9yJ6G4+2iBf6HsawSh5oLEDKSl9d2/BLY4 e26w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764306354; x=1764911154; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=F84JmaDZwv5YExecCbKuY9iZ3gotWGmX8OZPfkyrBJI=; b=Y0lYHBhvtu8kjb42LIkDyDMwV4hHureu81qugYVlRu0rglBhixch+LzYydqVdTT6GF YkWIFmmoWwH8WbIguloRNScSplOhbFXJ68KCBfIwIscENgnSnxnw/Gum2g+BhoCmGMgW PXa75+EOCi9BeSmkuihw5UAg7KX9Htocc4uWe5wRAuIaB1qAXF8lHJTb9+0mEj2OTTvN dPP+0OdSkZVaUQZdwevjIeP7hWx8G1ur5xKTrEZHIXqvkif49iVyVZ2fW/kkZuc8CZ5f 5pmqc6XRHQI3p3yf60jmkpKvoHKMSis+WhiY4dbcNZJzNeNHdPeVtDco5zI3VJ00CIhk N9eA== X-Forwarded-Encrypted: i=1; AJvYcCWMswCv38MI6mytYJWshXQCn4eRWxytIUaR4LvMd7f8V1RcElB32KvaGmUpASWHZwhpHC1WdlCw05uVIFE=@vger.kernel.org X-Gm-Message-State: AOJu0YzdCXPoKM9oeUGn4FpD9w8urFFnneQ/WFV6MXOZtFvpAxJZyY0u OZjVNJuGMW8DgzWJyBH8dWXR/C3SEjDp+AOiPnHXZbj72pvDq3wS9boBeI4kWWb8fh4bYLUfS2m xNwTsSsd8+sMmRs4LOF/UKRoVZYbOchwDSDvzoaw+22dQVrva5reUk+aTGNKoN4oEww4= X-Gm-Gg: ASbGnctsVh/TLZOGi2V9dn4s+BE+JKOVLA8W8ekrP+4QDRz2/g8GQUk5QaM1ynr5+Mt Ok2cBahIBTn/0zJ8XYZztOMD0YDUtQDJ/EmVR0VdL+vfwbcoXZudJR4zjzPnU6z+uBHXI/VKglk yXmJtK/jDN79lQn9hNO+r4RBzFiPCMNUpLQK2AU+Ik0+pOP6Jqzh5frZzrp+iqEt0Wv6nFtHl8Q a8Cy1dw2NVS0CtYiXAaKPJP3ll181pZls3BTKBhmlzumVWPIaWH5R3IoZvScihqDvItAO8YHJBj W9z+6kYSutokdxFf7LgSRZcuSabducHQy3KTLOwAlokV1+QSdGVbsoTAP3I3zra2udVB064gxz9 Y9vU9ah64VoCVnKds33Dbb9jy/LngSl7sGXp9MHnZBg== X-Received: by 2002:a17:903:2c10:b0:298:42ba:c437 with SMTP id d9443c01a7336-29b6bf75998mr276868745ad.50.1764306353541; Thu, 27 Nov 2025 21:05:53 -0800 (PST) X-Google-Smtp-Source: AGHT+IFx+ZM65ovnezE/50mkowLC52WseDJJY7+kJipd677+JzTFJsFEqOV99JXJDXZ6jJ+ICtzGLQ== X-Received: by 2002:a17:903:2c10:b0:298:42ba:c437 with SMTP id d9443c01a7336-29b6bf75998mr276868425ad.50.1764306353085; Thu, 27 Nov 2025 21:05:53 -0800 (PST) Received: from hu-ekangupt-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-29bceb40276sm31952075ad.73.2025.11.27.21.05.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Nov 2025 21:05:52 -0800 (PST) From: Ekansh Gupta To: srini@kernel.org, linux-arm-msm@vger.kernel.org Cc: gregkh@linuxfoundation.org, quic_bkumar@quicinc.com, linux-kernel@vger.kernel.org, quic_chennak@quicinc.com, dri-devel@lists.freedesktop.org, arnd@arndb.de, dmitry.baryshkov@oss.qualcomm.com Subject: [PATCH v4 4/4] misc: fastrpc: Add polling mode support for fastRPC driver Date: Fri, 28 Nov 2025 10:35:34 +0530 Message-Id: <20251128050534.437755-5-ekansh.gupta@oss.qualcomm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20251128050534.437755-1-ekansh.gupta@oss.qualcomm.com> References: <20251128050534.437755-1-ekansh.gupta@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-GUID: SZlXBYXNQuows08L9GbrrUwLxn6nuXT8 X-Proofpoint-ORIG-GUID: SZlXBYXNQuows08L9GbrrUwLxn6nuXT8 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTI4MDAzNCBTYWx0ZWRfX3Fr+Sa+nhECk dSbV/j2S9dcJv0SQn38sFnrsojcpsWD1bPM1vC21mxaW2FtuRBy/Vn7kgdyHvcjmDP23hW2NJue nCms/do+FuxB7cal0y1N6VE4IXr40WCV4Fr5+FFDJmK88vpABQFoIHId/E+qo8BA7TLtn0cTvr+ HcQ+XDh/36lTzUlWV10liOnl/OxDIkeOj1jiI2u0bZgaRvlwurAEpPRc5K8CHEJzrg27lBGzJh6 ExNEbmHcijWGXiI7K5L4uNyf5XqxMfguPsHOgzwuaQ9kXC/sCNXVcORbBEXJuJLF8t6CjaQUY0h 86+lAifBRb4HEKsa2FTX7TNS+onhOOjQyyByLPc8HtkJ9CZ1kxa5Yk3eTPBNULDpj82vr0TT3Rf ZykcYwMaMXsQPsaUpEZAhez/LE4Z9w== X-Authority-Analysis: v=2.4 cv=E6DAZKdl c=1 sm=1 tr=0 ts=69292db2 cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=6UeiqGixMTsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=TEHdEMHTk_fMHrPBF0kA:9 a=1OuFwYUASf3TG4hYMiVC:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-25_02,2025-11-27_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 suspectscore=0 phishscore=0 adultscore=0 lowpriorityscore=0 spamscore=0 clxscore=1015 impostorscore=0 priorityscore=1501 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2511280034 Content-Type: text/plain; charset="utf-8" For any remote call to DSP, after sending an invocation message, fastRPC driver waits for glink response and during this time the CPU can go into low power modes. This adds latency to overall fastrpc call as CPU wakeup and scheduling latencies are included. Add polling mode support with which fastRPC driver will poll continuously on a memory after sending a message to remote subsystem which will eliminate CPU wakeup and scheduling latencies and reduce fastRPC overhead. Poll mode can be enabled by user by using FASTRPC_IOCTL_SET_OPTION ioctl request with FASTRPC_POLL_MODE request id. Signed-off-by: Ekansh Gupta --- drivers/misc/fastrpc.c | 139 ++++++++++++++++++++++++++++++++++-- include/uapi/misc/fastrpc.h | 9 +++ 2 files changed, 141 insertions(+), 7 deletions(-) diff --git a/drivers/misc/fastrpc.c b/drivers/misc/fastrpc.c index 222ff15e04bd..d95d31d27b82 100644 --- a/drivers/misc/fastrpc.c +++ b/drivers/misc/fastrpc.c @@ -22,6 +22,8 @@ #include #include #include +#include +#include #include =20 #define ADSP_DOMAIN_ID (0) @@ -38,6 +40,7 @@ #define FASTRPC_CTX_MAX (256) #define FASTRPC_INIT_HANDLE 1 #define FASTRPC_DSP_UTILITIES_HANDLE 2 +#define FASTRPC_MAX_STATIC_HANDLE (20) #define FASTRPC_CTXID_MASK GENMASK(15, 8) #define INIT_FILELEN_MAX (2 * 1024 * 1024) #define INIT_FILE_NAMELEN_MAX (128) @@ -106,6 +109,12 @@ =20 #define miscdev_to_fdevice(d) container_of(d, struct fastrpc_device, miscd= ev) =20 +/* Poll response number from remote processor for call completion */ +#define FASTRPC_POLL_RESPONSE (0xdecaf) + +/* Polling mode timeout limit */ +#define FASTRPC_POLL_MAX_TIMEOUT_US (10000) + struct fastrpc_phy_page { u64 addr; /* physical address */ u64 size; /* size of contiguous region */ @@ -236,8 +245,14 @@ struct fastrpc_invoke_ctx { u32 sc; u64 *fdlist; u32 *crc; + /* Poll memory that DSP updates */ + u32 *poll; u64 ctxid; u64 msg_sz; + /* work done status flag */ + bool is_work_done; + /* process updates poll memory instead of glink response */ + bool is_polled; struct kref refcount; struct list_head node; /* list of ctxs */ struct completion work; @@ -301,6 +316,8 @@ struct fastrpc_user { int client_id; int pd; bool is_secure_dev; + /* Flags poll mode state */ + bool poll_mode; /* Lock for lists */ spinlock_t lock; /* lock for allocations */ @@ -894,7 +911,8 @@ static int fastrpc_get_meta_size(struct fastrpc_invoke_= ctx *ctx) sizeof(struct fastrpc_invoke_buf) + sizeof(struct fastrpc_phy_page)) * ctx->nscalars + sizeof(u64) * FASTRPC_MAX_FDLIST + - sizeof(u32) * FASTRPC_MAX_CRCLIST; + sizeof(u32) * FASTRPC_MAX_CRCLIST + + sizeof(u32); =20 return size; } @@ -990,6 +1008,7 @@ static int fastrpc_get_args(u32 kernel, struct fastrpc= _invoke_ctx *ctx) list =3D fastrpc_invoke_buf_start(rpra, ctx->nscalars); pages =3D fastrpc_phy_page_start(list, ctx->nscalars); ctx->fdlist =3D (u64 *)(pages + ctx->nscalars); + ctx->poll =3D (u32 *)(ctx->fdlist + FASTRPC_MAX_FDLIST + FASTRPC_MAX_CRCL= IST); args =3D (uintptr_t)ctx->buf->virt + metalen; rlen =3D pkt_size - metalen; ctx->rpra =3D rpra; @@ -1158,6 +1177,75 @@ static int fastrpc_invoke_send(struct fastrpc_sessio= n_ctx *sctx, =20 } =20 +static inline u32 fastrpc_poll_op(void *p) +{ + struct fastrpc_invoke_ctx *ctx =3D p; + + dma_rmb(); + return READ_ONCE(*ctx->poll); +} + +static int poll_for_remote_response(struct fastrpc_invoke_ctx *ctx) +{ + u32 val; + int ret; + + /* + * Poll until DSP writes FASTRPC_POLL_RESPONSE into *ctx->poll + * or until another path marks the work done. + */ + ret =3D read_poll_timeout_atomic(fastrpc_poll_op, val, + (val =3D=3D FASTRPC_POLL_RESPONSE) || + ctx->is_work_done, 1, + FASTRPC_POLL_MAX_TIMEOUT_US, false, ctx); + + if (!ret && val =3D=3D FASTRPC_POLL_RESPONSE) { + ctx->is_work_done =3D true; + ctx->retval =3D 0; + } + + if (ret =3D=3D -ETIMEDOUT) + ret =3D -EIO; + + return ret; +} + +static inline int fastrpc_wait_for_response(struct fastrpc_invoke_ctx *ctx, + u32 kernel) +{ + int err =3D 0; + + if (kernel) { + if (!wait_for_completion_timeout(&ctx->work, 10 * HZ)) + err =3D -ETIMEDOUT; + } else { + err =3D wait_for_completion_interruptible(&ctx->work); + } + + return err; +} + +static int fastrpc_wait_for_completion(struct fastrpc_invoke_ctx *ctx, + u32 kernel) +{ + int err; + + do { + if (ctx->is_polled) { + err =3D poll_for_remote_response(ctx); + /* If polling timed out, move to normal response mode */ + if (err) + ctx->is_polled =3D false; + } else { + err =3D fastrpc_wait_for_response(ctx, kernel); + if (err) + return err; + } + } while (!ctx->is_work_done); + + return err; +} + static int fastrpc_internal_invoke(struct fastrpc_user *fl, u32 kernel, u32 handle, u32 sc, struct fastrpc_invoke_args *args) @@ -1193,16 +1281,25 @@ static int fastrpc_internal_invoke(struct fastrpc_u= ser *fl, u32 kernel, if (err) goto bail; =20 - if (kernel) { - if (!wait_for_completion_timeout(&ctx->work, 10 * HZ)) - err =3D -ETIMEDOUT; - } else { - err =3D wait_for_completion_interruptible(&ctx->work); - } + /* + * Set message context as polled if the call is for a user PD + * dynamic module and user has enabled poll mode. + */ + if (handle > FASTRPC_MAX_STATIC_HANDLE && fl->pd =3D=3D USER_PD && + fl->poll_mode) + ctx->is_polled =3D true; + + err =3D fastrpc_wait_for_completion(ctx, kernel); =20 if (err) goto bail; =20 + if (!ctx->is_work_done) { + err =3D -ETIMEDOUT; + dev_dbg(fl->sctx->dev, "Invalid workdone state for handle 0x%x, sc 0x%x\= n", + handle, sc); + goto bail; + } /* make sure that all memory writes by DSP are seen by CPU */ dma_rmb(); /* populate all the output buffers with results */ @@ -1780,6 +1877,30 @@ static int fastrpc_get_info_from_kernel(struct fastr= pc_ioctl_capability *cap, return 0; } =20 +static int fastrpc_set_option(struct fastrpc_user *fl, char __user *argp) +{ + struct fastrpc_ioctl_set_option opt =3D {0}; + int i; + + if (copy_from_user(&opt, argp, sizeof(opt))) + return -EFAULT; + + for (i =3D 0; i < ARRAY_SIZE(opt.reserved); i++) { + if (opt.reserved[i] !=3D 0) + return -EINVAL; + } + + if (opt.req !=3D FASTRPC_POLL_MODE) + return -EINVAL; + + if (opt.value) + fl->poll_mode =3D true; + else + fl->poll_mode =3D false; + + return 0; +} + static int fastrpc_get_dsp_info(struct fastrpc_user *fl, char __user *argp) { struct fastrpc_ioctl_capability cap =3D {0}; @@ -2134,6 +2255,9 @@ static long fastrpc_device_ioctl(struct file *file, u= nsigned int cmd, case FASTRPC_IOCTL_MEM_UNMAP: err =3D fastrpc_req_mem_unmap(fl, argp); break; + case FASTRPC_IOCTL_SET_OPTION: + err =3D fastrpc_set_option(fl, argp); + break; case FASTRPC_IOCTL_GET_DSP_INFO: err =3D fastrpc_get_dsp_info(fl, argp); break; @@ -2465,6 +2589,7 @@ static int fastrpc_rpmsg_callback(struct rpmsg_device= *rpdev, void *data, =20 ctx->retval =3D rsp->retval; complete(&ctx->work); + ctx->is_work_done =3D true; =20 /* * The DMA buffer associated with the context cannot be freed in diff --git a/include/uapi/misc/fastrpc.h b/include/uapi/misc/fastrpc.h index c6e2925f47e6..3207c42fb318 100644 --- a/include/uapi/misc/fastrpc.h +++ b/include/uapi/misc/fastrpc.h @@ -16,6 +16,7 @@ #define FASTRPC_IOCTL_INIT_CREATE_STATIC _IOWR('R', 9, struct fastrpc_init= _create_static) #define FASTRPC_IOCTL_MEM_MAP _IOWR('R', 10, struct fastrpc_mem_map) #define FASTRPC_IOCTL_MEM_UNMAP _IOWR('R', 11, struct fastrpc_mem_unmap) +#define FASTRPC_IOCTL_SET_OPTION _IOWR('R', 12, struct fastrpc_ioctl_set_o= ption) #define FASTRPC_IOCTL_GET_DSP_INFO _IOWR('R', 13, struct fastrpc_ioctl_cap= ability) =20 /** @@ -66,6 +67,8 @@ enum fastrpc_proc_attr { =20 /* Fastrpc attribute for memory protection of buffers */ #define FASTRPC_ATTR_SECUREMAP (1) +/* Set option request ID to enable poll mode */ +#define FASTRPC_POLL_MODE (1) =20 struct fastrpc_invoke_args { __u64 ptr; @@ -133,6 +136,12 @@ struct fastrpc_mem_unmap { __s32 reserved[5]; }; =20 +struct fastrpc_ioctl_set_option { + __u32 req; /* request id */ + __u32 value; /* value */ + __s32 reserved[6]; +}; + struct fastrpc_ioctl_capability { __u32 unused; /* deprecated, ignored by the kernel */ __u32 attribute_id; --=20 2.34.1