From nobody Mon Dec 1 22:02:39 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4B73C23DEB6 for ; Fri, 28 Nov 2025 01:23:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764293003; cv=none; b=rt5LD8QeT7UkHpt94gx1hm9Xpfw1AFPevkrlPJ3DrWUCTWiBQ3q9/mSguVSKRM0H4CPdEY0O5ViQSCDiiIWmfC+oQ9m7OkIsieB7QY8O39afFy+8NGJM1WqYBsrtNJbzEta5dbVxq5/PiAcBs83vkpfS0YiSbxI7CdmhpZqnz88= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764293003; c=relaxed/simple; bh=apq05GGh9TDvr8Z54lwXs6RPXreVP+Ey59iwwM/ZS3Q=; h=Message-ID:Date:From:To:Cc:Subject:References:MIME-Version: Content-Type; b=deKqTp3Em+XGqDdm0tppzNH97rLqZU7Pn1PHsax54VifVov5etq1P7Cv4SF/rXa0AYuJaf5CpObd4m/eB2LX8EsJf5qpcfT844T0InSuMCrDwcM6+5v11crpPOoaJNcWXs60YnHVL0LEg9IrtZzYCUxmNJtrhf/7jGfshPmr+mY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=SP0dxIuO; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="SP0dxIuO" Received: by smtp.kernel.org (Postfix) with ESMTPSA id CF424C4CEF8; Fri, 28 Nov 2025 01:23:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1764293002; bh=apq05GGh9TDvr8Z54lwXs6RPXreVP+Ey59iwwM/ZS3Q=; h=Date:From:To:Cc:Subject:References:From; b=SP0dxIuOoyIJrYSmB06iUrW8tqgJWsP+A+R4yi18S7KXhbbFZPhQrlsMJRMwCUrMd 0zy8yTDduShOnUe16xyoFNJn05w7Z0yTpGFiiq4zmxOg87dBDaAam8uMrkGnEpGTOx UwikLxjxbQSyR6AVl4IkbRfwa1V5SpPA8JUupNXQv8yhmyN1dwnPeyt7d23px1VulQ FKlR3vT1J13P3gShEP2eQAcSOoOGWjtvFHLJ9CAByirmNdYSt0qsHrB3rB4ksm3Nn5 1ykHPCUODCkaKGMF4Ji6pD8bfBk23DD1sGj83Ubu7Plin2U9UWIFKaghGGyx8fMtYM x64QuWCYwEwkw== Received: from rostedt by gandalf with local (Exim 4.98.2) (envelope-from ) id 1vOnDY-00000006ghk-1xes; Thu, 27 Nov 2025 20:24:12 -0500 Message-ID: <20251128012412.322648554@kernel.org> User-Agent: quilt/0.68 Date: Thu, 27 Nov 2025 20:23:40 -0500 From: Steven Rostedt To: linux-kernel@vger.kernel.org Cc: Masami Hiramatsu , Mark Rutland , Mathieu Desnoyers , Andrew Morton , Tom Zanussi Subject: [for-next][PATCH 09/13] tracing: Use strim() in trigger_process_regex() instead of skip_spaces() References: <20251128012331.307010654@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Steven Rostedt The function trigger_process_regex() is called by a few functions, where only one calls strim() on the buffer passed to it. That leaves the other functions not trimming the end of the buffer passed in and making it a little inconsistent. Remove the strim() from event_trigger_regex_write() and have trigger_process_regex() use strim() instead of skip_spaces(). The buff variable is not passed in as const, so it can be modified. Cc: Mark Rutland Cc: Mathieu Desnoyers Cc: Andrew Morton Cc: Tom Zanussi Link: https://patch.msgid.link/20251125214032.323747707@kernel.org Acked-by: Masami Hiramatsu (Google) Signed-off-by: Steven Rostedt (Google) --- kernel/trace/trace_events_trigger.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/kernel/trace/trace_events_trigger.c b/kernel/trace/trace_event= s_trigger.c index 3b97c242b795..96aad82b1628 100644 --- a/kernel/trace/trace_events_trigger.c +++ b/kernel/trace/trace_events_trigger.c @@ -308,7 +308,8 @@ int trigger_process_regex(struct trace_event_file *file= , char *buff) char *command, *next; struct event_command *p; =20 - next =3D buff =3D skip_spaces(buff); + next =3D buff =3D strim(buff); + command =3D strsep(&next, ": \t"); if (next) { next =3D skip_spaces(next); @@ -345,8 +346,6 @@ static ssize_t event_trigger_regex_write(struct file *f= ile, if (IS_ERR(buf)) return PTR_ERR(buf); =20 - strim(buf); - guard(mutex)(&event_mutex); =20 event_file =3D event_file_file(file); --=20 2.51.0