From nobody Mon Dec 1 22:04:03 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0546521CC5C for ; Fri, 28 Nov 2025 01:23:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764293002; cv=none; b=CH7Sv/QavQpUhhKnZRE7VuqF45fLmeQCSNkCZAoc2v2PWYli0XPOB9A6Sm3n9vQzaQ7nM7qK1vM4RTK98kXviSANRapaRMssRrEtBFysPdwMhTNX2OoGwuN9hHXm3r8GyVEYO2O7re8GJ5KdGowdN8h537LcMRmltE4tR0dityc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764293002; c=relaxed/simple; bh=S+MskiV/zrS55QB/Edarm+k8j9TT1qdsef/gvvfP9do=; h=Message-ID:Date:From:To:Cc:Subject:References:MIME-Version: Content-Type; b=NvMTRyJI3Qy57pmpyT0nluhVAjepeiY3Sb/ev4ZO6ZVfCv3Uzb+LuJ/hDx2beOZxsqsIZiEsaov724s9ysI9Dupl6UrcF91vc62xKWBgsSTYfOGxKOM0dGFLpLfvOkz6qERy4QHpWUhaCTmFiytnM/aAWJQF0YPn9dgR/9NTS3Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=DTJMj8ro; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="DTJMj8ro" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 93F3AC16AAE; Fri, 28 Nov 2025 01:23:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1764293001; bh=S+MskiV/zrS55QB/Edarm+k8j9TT1qdsef/gvvfP9do=; h=Date:From:To:Cc:Subject:References:From; b=DTJMj8rooUo42O8nXxQQ0B7cZpjHcqrYhGVHvFi8yzcH4QI/7r01rxLu707+xo74F +T4cp/5lG1jqW8bI42fmf/za54CAgCVsfdEk8tDPfON+ZLMXaz198fIB8oH0Hlzglm kHDOgU5F9RP/5zfwazTuvbs+GaNXLm0l7MLIxJ967Orz4zfyHKqhG0hBMLrmLmCgJd 2iWGqK5FyYtrnRIE+IYEGaepwJtYndSEkd1hledch0bLVj/k9Z8i75R9Kvc0hT66qN 2iq6GSpBk8bZ19uwbkh+Rsl1RWH78k1BktWWooSGJkEx8qwK9SWiX1R7qTXJHxdfQS z2QrDjpkk+WSA== Received: from rostedt by gandalf with local (Exim 4.98.2) (envelope-from ) id 1vOnDX-00000006geJ-1Dly; Thu, 27 Nov 2025 20:24:11 -0500 Message-ID: <20251128012411.146707328@kernel.org> User-Agent: quilt/0.68 Date: Thu, 27 Nov 2025 20:23:33 -0500 From: Steven Rostedt To: linux-kernel@vger.kernel.org Cc: Masami Hiramatsu , Mark Rutland , Mathieu Desnoyers , Andrew Morton , Andy Shevchenko Subject: [for-next][PATCH 02/13] tracing: Remove unused variable in tracing_trace_options_show() References: <20251128012331.307010654@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Steven Rostedt The flags and opts used in tracing_trace_options_show() now come directly from the trace array "current_trace_flags" and not the current_trace. The variable "trace" was still being assigned to tr->current_trace but never used. This caused a warning in clang. Cc: Masami Hiramatsu Cc: Mathieu Desnoyers Link: https://patch.msgid.link/20251117120637.43ef995d@gandalf.local.home Reported-by: Andy Shevchenko Tested-by: Andy Shevchenko Closes: https://lore.kernel.org/all/aRtHWXzYa8ijUIDa@black.igk.intel.com/ Fixes: 428add559b692 ("tracing: Have tracer option be instance specific") Signed-off-by: Steven Rostedt (Google) --- kernel/trace/trace.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c index 8ae95800592d..59cd4ed8af6d 100644 --- a/kernel/trace/trace.c +++ b/kernel/trace/trace.c @@ -5167,7 +5167,6 @@ static int tracing_trace_options_show(struct seq_file= *m, void *v) struct tracer_opt *trace_opts; struct trace_array *tr =3D m->private; struct tracer_flags *flags; - struct tracer *trace; u32 tracer_flags; int i; =20 @@ -5184,8 +5183,6 @@ static int tracing_trace_options_show(struct seq_file= *m, void *v) if (!flags || !flags->opts) return 0; =20 - trace =3D tr->current_trace; - tracer_flags =3D flags->val; trace_opts =3D flags->opts; =20 --=20 2.51.0