From nobody Mon Dec 1 22:00:25 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D5D9511713 for ; Fri, 28 Nov 2025 01:23:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764293001; cv=none; b=GjOOTWveT6r6i0vcEPK7BV1Ydfr7SMZWTp0mMETbnh+ItgEs6UVM14opke3TlsPoLh8ogdNj4UE1jb+V+AAbRlSDdXhxR0lYb+5RkTrNSCDryn01VkSAi4qt7iF4gDGmBs2OKNi33eq6qnjo5CrqUToZ1hKuIMzP+3T3rm6F6/w= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764293001; c=relaxed/simple; bh=/x/FszfOq3lcLNrmXXc3bHvYgFMAygzmK9V0fMZH1I4=; h=Message-ID:Date:From:To:Cc:Subject:References:MIME-Version: Content-Type; b=YbhRqT/yrALOEjpDwKzhERRKlAwxETcqcwLBYusVIaqgYkX8NbX7XYonf55YoOOtmxECjpt4eRBjaubZpfqE3+FN83gZUSpKHDfDDQ9JgovjiCyYjxfKti7WTzPuPG64BgxRbL310QJ57DneQXmuHxIwvccSgEaphLbIZuStq3A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=j39Cuvbr; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="j39Cuvbr" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 75E21C4CEF8; Fri, 28 Nov 2025 01:23:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1764293001; bh=/x/FszfOq3lcLNrmXXc3bHvYgFMAygzmK9V0fMZH1I4=; h=Date:From:To:Cc:Subject:References:From; b=j39CuvbrMqamh7I6NHyjdH86XlTxqlw+1CxXOKfpnuhJR3HOXFWC86OOkwfMMGap6 eEF6lLW/pGQyf+gzTozYpbqpBHGc0xDC4h6MRf3gmz5YjJHoWEJRGiKTaOn7R6nh4o I7d5+Hlo7qU8z7oV05KtWImDACMZ+tDcy6oILgUGMAtVF6wvnMKFwhJgjlzdgX+Olv J6r2wSgsFgY/nBOr0JHCTuoJpt4tkCXiEB6AtKogiguEjld9wOvU29SC+6QdJjBBqd Hw4p4LP4ncW4jMpK4eWkwL4fmIlunHfdRWDl1Nwvw+qUTE2tkMLeYj5utzYs4gh7G3 a+YnLd1AOhRTQ== Received: from rostedt by gandalf with local (Exim 4.98.2) (envelope-from ) id 1vOnDX-00000006gdo-0Wrg; Thu, 27 Nov 2025 20:24:11 -0500 Message-ID: <20251128012410.977157422@kernel.org> User-Agent: quilt/0.68 Date: Thu, 27 Nov 2025 20:23:32 -0500 From: Steven Rostedt To: linux-kernel@vger.kernel.org Cc: Masami Hiramatsu , Mark Rutland , Mathieu Desnoyers , Andrew Morton , Dan Carpenter Subject: [for-next][PATCH 01/13] fgraph: Make fgraph_no_sleep_time signed References: <20251128012331.307010654@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Steven Rostedt The variable fgraph_no_sleep_time changed from being a boolean to being a counter. A check is made to make sure that it never goes below zero. But the variable being unsigned makes the check always fail even if it does go below zero. Make the variable a signed int so that checking it going below zero still works. Cc: Masami Hiramatsu Cc: Mathieu Desnoyers Link: https://patch.msgid.link/20251125104751.4c9c7f28@gandalf.local.home Fixes: 5abb6ccb58f0 ("tracing: Have function graph tracer option sleep-time= be per instance") Reported-by: Dan Carpenter Closes: https://lore.kernel.org/all/aR1yRQxDmlfLZzoo@stanley.mountain/ Signed-off-by: Steven Rostedt (Google) --- kernel/trace/trace.h | 2 +- kernel/trace/trace_functions_graph.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel/trace/trace.h b/kernel/trace/trace.h index 58be6d741d72..da5d9527ebd6 100644 --- a/kernel/trace/trace.h +++ b/kernel/trace/trace.h @@ -1113,7 +1113,7 @@ static inline void ftrace_graph_addr_finish(struct fg= raph_ops *gops, struct ftra #endif /* CONFIG_DYNAMIC_FTRACE */ =20 extern unsigned int fgraph_max_depth; -extern unsigned int fgraph_no_sleep_time; +extern int fgraph_no_sleep_time; extern bool fprofile_no_sleep_time; =20 static inline bool diff --git a/kernel/trace/trace_functions_graph.c b/kernel/trace/trace_func= tions_graph.c index 44d5dc5031e2..d0513cfcd936 100644 --- a/kernel/trace/trace_functions_graph.c +++ b/kernel/trace/trace_functions_graph.c @@ -20,7 +20,7 @@ static int ftrace_graph_skip_irqs; =20 /* Do not record function time when task is sleeping */ -unsigned int fgraph_no_sleep_time; +int fgraph_no_sleep_time; =20 struct fgraph_cpu_data { pid_t last_pid; --=20 2.51.0