From nobody Mon Dec 1 22:38:59 2025 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 97D442E8DE5 for ; Fri, 28 Nov 2025 08:40:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764319218; cv=none; b=Io409j11llsWw6S2HeFvqwbgfmwzJ7OOz2WJElxhCmHxg/c7W0FdIFnqoHwrGBMFJfzMCT2RBkxogbrK0N7u10S6SvZMc4WLg3VxIjimOnTUw2Edz66CjVJWnpx3BqJMtqIHa0XKy/froLvz2uJZwRW5hfbf4JjW9kEjGjLlNJo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764319218; c=relaxed/simple; bh=4m3eSCxxytd3/9ULrzWMXUlBCzfX/0w0UNwcUeemTBg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=hJsVDJZ6Bac6wkzw/FCnZI6kQ6AMQJ4VS56XiCji9mWFax2wgD9S07uRkofwMGO1h5JoebPqVoNa1S4OzO5YUlMk7kQpJ8XDrL53wOiYE6Vs69+c+MMhBMUg8XPTszlmEn4GzckpgB9Jdqsq8ziIDp519Xf9BGtB9bNgSGb9nTw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=cMqJPVC0; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=FOU3kNNL; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="cMqJPVC0"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="FOU3kNNL" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5AS8Nu413123322 for ; Fri, 28 Nov 2025 08:40:16 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= tNJ+LEhWT70faj1LvFJVUChOAyLj23F8IPQ1qe4AelM=; b=cMqJPVC0P1AYmG5N NqSDSnDMGD98V8YBzIhWWz8XosyyEHW1idRNonqZtV9EFUMsyLT5eRxl8PRC+s5M QKTUjJO+k8davh689pmlAEQUEWVBTj8vWyKZaNQxZNldaPAKbiC4ksa3cEhvG/iz VdcWYMUYKyrWt68IXMacKHx8+uYfgbMfqUrhWWpy2j2MdqVQmkhSJt9nkTjDMAHq CDBkEjbqW6QVyYuORDd1wn73UvSfwhkH4Q5aEv3j/4uP7eTk+tLixa6GwCCyZAFt kr/YAr6otq9MGn/h8svycqRqTb6nKluEeT14KnZI8NJj0TUoVrYRoQHGaPK/d7f1 F3/NrA== Received: from mail-pg1-f198.google.com (mail-pg1-f198.google.com [209.85.215.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4aq58ugj30-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 28 Nov 2025 08:40:15 +0000 (GMT) Received: by mail-pg1-f198.google.com with SMTP id 41be03b00d2f7-b99763210e5so2720417a12.3 for ; Fri, 28 Nov 2025 00:40:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1764319215; x=1764924015; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=tNJ+LEhWT70faj1LvFJVUChOAyLj23F8IPQ1qe4AelM=; b=FOU3kNNLatGd4jvQoM1JcqnxNfLkhxImm2KntGltAaf7d+hnX+lA5dV3sZp5/jSDK/ iOJKWlr7eBDqQOerArlkjssDoxbTmN9B7bKrBssQKhxlmULJXYfBQ8SZ87Jcisx7lt1l V/YM0qyE8JvA+sNn7qyB8/XPgBhgaaIddDkweiIFBnDzcPzhnzyR6+zQOFiS121WQyIR YJBJr5RgpO3r/x/QT47wZHlfximrRkSLkT5XkPPp7Vrfa+MuNgDRLgwj6TaogVKZQij9 0A576Xw6uEF78jqArpc5d0VsJAESTXpNiIkkCNDD0KAy6Anq9bdDwUQ3jBDKn2gUs3TO 8Vdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764319215; x=1764924015; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=tNJ+LEhWT70faj1LvFJVUChOAyLj23F8IPQ1qe4AelM=; b=f1XutShOApHSP0uE3yQzEWBYshSyldAFWKeVegdl+ziGlrCtmSy//nLNCUWM89uuxe 26jc3YK4ZwY4IG8xO+sOd76QZwE8ao6GAWem50QyMz0PHgWiMoVQmArULWydejJ4XnP8 l8pMscnpdxhqzbPoDbNjMBxiLWA5aex7zuAE3LbNCEoKpXEKXUCWEsMkA8PYmSIFXBh6 6Bq0dnxvkI44AbF+4Rn5OpCHyKVjCqLkIYN8uT6mRnYTcTLpEXoQjuya1IxzQUtEIjOB 1BqkY9QBL0ZjLo7n1SRadCgVlZsmR9o8FXKznCl9jmL+ybOSYmDDLARrPDQDY0bpHWkk Z3aA== X-Forwarded-Encrypted: i=1; AJvYcCVsfhTJLX4leQG2MqSm3wTGASO4gubQixkUEpNTfpyA60kE5Stu7epr1cgJpL6y3AhMLxd4MHen55yv1Xo=@vger.kernel.org X-Gm-Message-State: AOJu0Yz/synxgcFqo9JgPwiMiDWQqcORrRnoXQdkBZ5W/HJDCjFbfHPv Bhd/eC24gqxjB5Dlp4F+FICywDIVfeQB3tX4Vi8x+DFVrIm3GZVofGAKjvydsdCkFpPDIDZQVPh wNVsssFoNAiAtRmritHOq3cCgOjHT3OHIWmF7pFgK/vFXAglN+ZwI84iM/xGQOoRaigg= X-Gm-Gg: ASbGncuo15em4+3hW2LSykqMyMHQVBIeZtq5mwpIQkMZS3xJLZDnh09NPiAj4VMFl/2 gLdEDU7RSveQ2SQGnQ9tb+paAF0y/FYdk0Vk+2JoLVhpFQpFWdiq0mC9M+tDagbhKN/kmkrh+EP CAVlM4oSo7C9yqGqEo28vIo+lxYQ5sdTmJJ4h2vpEP257Ym0iRuG3obedBtqlHUXvjiUD+fgbWJ cLWC08NFi1EKEOnbVKqCHURlbA0WAqME/hNSsslvVicNv3zf7XAA41ItXa7TJFKSf0cY8ZL/F0R raLOQSqUE4b1n2/rpYiwPXnizPjdmjV57OTwoOLuLTalm2spn9hVAG6f6InAAoVlDsd8k6q2+eH 5v4ogb3kRUxsPvt/GqphG2tPy4BynGq9c4C/bMCoB/3LSscxUSwoc X-Received: by 2002:a05:7300:bc0b:b0:2a4:3593:6472 with SMTP id 5a478bee46e88-2a7192e5cb2mr17064707eec.34.1764319215182; Fri, 28 Nov 2025 00:40:15 -0800 (PST) X-Google-Smtp-Source: AGHT+IEXPQpamY2fDlIkuiT3ygR+MdZL1pAWcFiFrbesihBz0rPgNOyBAxYPw5kV+1l5Eqsw/N7AVA== X-Received: by 2002:a05:7300:bc0b:b0:2a4:3593:6472 with SMTP id 5a478bee46e88-2a7192e5cb2mr17064681eec.34.1764319214613; Fri, 28 Nov 2025 00:40:14 -0800 (PST) Received: from hu-luoj-lv.qualcomm.com (Global_NAT1.qualcomm.com. [129.46.96.20]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2a96560986csm21895872eec.2.2025.11.28.00.40.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Nov 2025 00:40:14 -0800 (PST) From: Luo Jie Date: Fri, 28 Nov 2025 00:40:11 -0800 Subject: [PATCH 1/5] clk: qcom: cmnpll: Account for reference clock divider Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251128-qcom_ipq5332_cmnpll-v1-1-55127ba85613@oss.qualcomm.com> References: <20251128-qcom_ipq5332_cmnpll-v1-0-55127ba85613@oss.qualcomm.com> In-Reply-To: <20251128-qcom_ipq5332_cmnpll-v1-0-55127ba85613@oss.qualcomm.com> To: Bjorn Andersson , Michael Turquette , Stephen Boyd , Konrad Dybcio , Luo Jie , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, quic_kkumarcs@quicinc.com, quic_linchen@quicinc.com, quic_leiwei@quicinc.com, quic_pavir@quicinc.com, quic_suruchia@quicinc.com, Luo Jie X-Mailer: b4 0.15-dev-47773 X-Developer-Signature: v=1; a=ed25519-sha256; t=1764319213; l=1996; i=jie.luo@oss.qualcomm.com; s=20251128; h=from:subject:message-id; bh=4m3eSCxxytd3/9ULrzWMXUlBCzfX/0w0UNwcUeemTBg=; b=sp9K5nJf6Csi0yduFV2qnisYcsLERB8DNuCWdugfeV1u8aXcCG72IMAaMNgwlv5Xal8Fjv6Rb oOigt/zrEf8DMPASksXGEK2/ZB/UicqyzwC0PfVhL8u3gIIgJ8d9NYe X-Developer-Key: i=jie.luo@oss.qualcomm.com; a=ed25519; pk=gSsYMDakxtd6UDFYDdA9y9yjIs5Etp5GK/3DoXWPyS0= X-Proofpoint-GUID: 6Niv_MBv0F8vckFo-EiVi5ahsev17NXv X-Authority-Analysis: v=2.4 cv=UKvQ3Sfy c=1 sm=1 tr=0 ts=69295fef cx=c_pps a=Qgeoaf8Lrialg5Z894R3/Q==:117 a=ouPCqIW2jiPt+lZRy3xVPw==:17 a=IkcTkHD0fZMA:10 a=6UeiqGixMTsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=S55vJYNB7fQppqqD1sAA:9 a=QEXdDO2ut3YA:10 a=x9snwWr2DeNwDh03kgHS:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTI4MDA2MiBTYWx0ZWRfX/x9Pze0yUgDR 5T4spMc64M08fG3bB8eTiVDqz3nGa8KJTzXmuxqJXVfUljyuWqGpB6QByccTYOaMM34rngqFcQk rme77p2a4uYtBvXRyJ8+m5qTO2ud0U8jwCSePwxieGeDmdk/iFOCBx3qpWD5u8jCC9PGPh0MqTk K2t94qjZCDfcsXUSVx8YE6qEATrt2aI88kv4o/bhaO6MBNREiWFJlGggxMUoWvIlTsbf9vjNzwy uxMcNRlACZkJ97N0XsICpOQ86+Ji6sh4AlfqLx3Y5xl2/NXbsWzIhIaKHDz7SrVO0mlv3XxVjmG NRMqcV8qUnzjvRXTdQ47hdKfIoumxkUQOR0UwWCvM6jULIIn+bfmriEQKNjLBKz1KJr/wCfrzlA iLKT1FP3daNlv7jBppzBWNR7NNL6Yg== X-Proofpoint-ORIG-GUID: 6Niv_MBv0F8vckFo-EiVi5ahsev17NXv X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-28_03,2025-11-27_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 phishscore=0 priorityscore=1501 impostorscore=0 suspectscore=0 lowpriorityscore=0 adultscore=0 clxscore=1015 spamscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2511280062 The clk_cmn_pll_recalc_rate() function must account for the reference clock divider programmed in CMN_PLL_REFCLK_CONFIG. Without this fix, platforms with a reference divider other than 1 calculate incorrect CMN PLL rates. For example, on IPQ5332 where the reference divider is 2, the computed rate becomes twice the actual output. Read CMN_PLL_REFCLK_DIV and divide the parent rate by this value before applying the 2 * FACTOR scaling. This yields the correct rate calculation: rate =3D (parent_rate / ref_div) * 2 * factor. Maintain backward compatibility with earlier platforms (e.g. IPQ9574, IPQ5424, IPQ5018) that use ref_div =3D 1. Fixes: f81715a4c87c ("clk: qcom: Add CMN PLL clock controller driver for IP= Q SoC") Signed-off-by: Luo Jie --- drivers/clk/qcom/ipq-cmn-pll.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/clk/qcom/ipq-cmn-pll.c b/drivers/clk/qcom/ipq-cmn-pll.c index dafbf5732048..c6180116e1fc 100644 --- a/drivers/clk/qcom/ipq-cmn-pll.c +++ b/drivers/clk/qcom/ipq-cmn-pll.c @@ -185,7 +185,7 @@ static unsigned long clk_cmn_pll_recalc_rate(struct clk= _hw *hw, unsigned long parent_rate) { struct clk_cmn_pll *cmn_pll =3D to_clk_cmn_pll(hw); - u32 val, factor; + u32 val, factor, ref_div; =20 /* * The value of CMN_PLL_DIVIDER_CTRL_FACTOR is automatically adjusted @@ -193,8 +193,15 @@ static unsigned long clk_cmn_pll_recalc_rate(struct cl= k_hw *hw, */ regmap_read(cmn_pll->regmap, CMN_PLL_DIVIDER_CTRL, &val); factor =3D FIELD_GET(CMN_PLL_DIVIDER_CTRL_FACTOR, val); + if (unlikely(factor =3D=3D 0)) + factor =3D 1; =20 - return parent_rate * 2 * factor; + regmap_read(cmn_pll->regmap, CMN_PLL_REFCLK_CONFIG, &val); + ref_div =3D FIELD_GET(CMN_PLL_REFCLK_DIV, val); + if (unlikely(ref_div =3D=3D 0)) + ref_div =3D 1; + + return div_u64((u64)parent_rate * 2 * factor, ref_div); } =20 static int clk_cmn_pll_determine_rate(struct clk_hw *hw, --=20 2.43.0