From nobody Mon Dec 1 21:31:22 2025 Received: from BL2PR02CU003.outbound.protection.outlook.com (mail-eastusazon11011010.outbound.protection.outlook.com [52.101.52.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EAE8226FD86; Fri, 28 Nov 2025 02:11:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.52.10 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764295917; cv=fail; b=DgOLf7CmWvM7sAhz2KPa0OVFDLQH3vSy6STRZup95YkmDTcLWZxIVxZ+Maj8YkqnowK0lNwg9JGn0Gd119gxfXJu1DgGkNdGK9DCUwzEnkQ98QE6onJG9DN0IxxHp9+mBy+j8xxHsYhM9LEYXdDaM7bbaI4XO2tDzCJexTVUgJg= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764295917; c=relaxed/simple; bh=HyYlm9tMddocBa9zhzwC5KDiV8ER81V+JWBZ1DYR1tk=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=iBDD/9fRembpe5fEls512XyYGlDIRoYvj+Vnr5EGXFDGu6JX5mtWxb83OESMCRWI3kba5Y6oRHmqq2etNebSlONOwxLgluN8WUhXripBhq+MstA33T8MV5uYzpFQibbKHAC5RUNDb4KKFt6v9NpdI4faKP5UEPaaFvRmE34WSrc= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=KeIa1lbT; arc=fail smtp.client-ip=52.101.52.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="KeIa1lbT" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=cyKqkk+epyb3AAIEML1WxgVM8cavnMkYGewgvyvRXmEHTmsMBBJsAxs44As4AQwT27FoIWD2EOXeSdC4SUnZ6cyjhBn5xYMB8Lsotaf8mPQaAsPg90HJC2q6sCRgcO6z7I2GG2PTqS1QOeynu24R9x4PnymZHI7FpwPkQzJQTyfATLATfpOXaPnmBTobZ00OokcuRxfuEiJ7Dp0vEHUIifptsmOFjV5QVEpctZiwSDkousDqV4gMCAke88rzkGc2LU/+xYkgNpj21C2g3i0a2Svlvt3oIN5taMmuE7YpDiIUUdhGHXg3DUzKSWKvjcJxjh62lE1Via7ezcAwTX7+Bw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8OGeC8vZ6/8hbxtcjKUxGJIrXtZrtJ+kbfVvR4EtkBI=; b=MH5aKWYGSScigrRT0mloR5hSRNBvVQl9lgIk+NMtLV2LJVX+TjM+cabdi1r5AkVBIBJYZVZxieAqgiesN15FLnvXmWKHhxXBXjTv0yUrG4mB0Rth9optG5uxd9UHHJW3Upe4gefeOblvqY8mB/MCElNYaFNMoFUV10nV91B1Tvse68vaqiEXfvs+ajyemAT1U9oTJkwkZyyud9ALs2wXmLFK5rW0twHc/Jxhm74xuGDk8rqmzRps+EImM9xrfIULU4YGmTKCS6Dse/NpXrE1r6Ig6DuKsJsDS6kIOZ+YYSm10tlvYSi5tFZFOENfairAyTgQ9RKGXklPUXyKdrJyiA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8OGeC8vZ6/8hbxtcjKUxGJIrXtZrtJ+kbfVvR4EtkBI=; b=KeIa1lbTDMJYbwBV0yiwTzxlNm+dgMgzffee8+Bnf2s9o7jXeFMLndPMK16ymi85S5/C8T3rJHAopU9mrHe9lSukuV5vk9I2TQ6cnUs1WQD5ovlntrAIRab7zdwUO3XFxRb25uAHiSS4UKMzLs6AooJkzJFR1DHo074DqP68Z94dVlRgWb3F3f/pJRV+eV22jLUArVKrB4tK9U/ZHDWyUouS2Jh3LYw4AVI1zWVjOZj/dvrAKR2MxFXYDQy1bfsjVT6ell21Ezq6S06HQk2EcZf6e7sTsUJvxbpJuoj6KQembFKovk2vV4E2OgTnvYBy4o4FzHSYZqe4bn13NPPx4Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from CH2PR12MB3990.namprd12.prod.outlook.com (2603:10b6:610:28::18) by BL3PR12MB6617.namprd12.prod.outlook.com (2603:10b6:208:38c::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9366.14; Fri, 28 Nov 2025 02:11:53 +0000 Received: from CH2PR12MB3990.namprd12.prod.outlook.com ([fe80::7de1:4fe5:8ead:5989]) by CH2PR12MB3990.namprd12.prod.outlook.com ([fe80::7de1:4fe5:8ead:5989%6]) with mapi id 15.20.9366.012; Fri, 28 Nov 2025 02:11:53 +0000 From: Alexandre Courbot Date: Fri, 28 Nov 2025 11:11:37 +0900 Subject: [PATCH v2 1/7] rust: build_assert: add instructions for use with function arguments Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251128-io-build-assert-v2-1-a9ea9ce7d45d@nvidia.com> References: <20251128-io-build-assert-v2-0-a9ea9ce7d45d@nvidia.com> In-Reply-To: <20251128-io-build-assert-v2-0-a9ea9ce7d45d@nvidia.com> To: Danilo Krummrich , Alice Ryhl , Daniel Almeida , Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Trevor Gross , "Rafael J. Wysocki" , Viresh Kumar , Will Deacon , Peter Zijlstra , Mark Rutland Cc: rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Alexandre Courbot X-Mailer: b4 0.14.3 X-ClientProxiedBy: TYCPR01CA0097.jpnprd01.prod.outlook.com (2603:1096:405:4::13) To CH2PR12MB3990.namprd12.prod.outlook.com (2603:10b6:610:28::18) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB3990:EE_|BL3PR12MB6617:EE_ X-MS-Office365-Filtering-Correlation-Id: c0bcd419-d89d-4f87-14ce-08de2e237f7c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|7416014|366016|10070799003|921020; X-Microsoft-Antispam-Message-Info: =?utf-8?B?U2kzd1dIVklVYmJoWkZjWnJqZ1kzVmlsYVB0YzVUTFZYSXZpRU1BcnFYWkM5?= =?utf-8?B?UzQ5MHYwL3dDcnB0WkxTTDV6NzZFdGVaTkdKTzRYR1ExL3JzUVY4M0pXdjJm?= =?utf-8?B?NFI5WjRvMlFZekF0Uy8xdjM4WlZOeWFwaWh3RVY0K0NGSnM5TzJ6eERPRXJR?= =?utf-8?B?MlNGQzUvWis0VFBWU2U0VGloaXRuUVkyRnFOOXA5ZjVJbitpQjlnczJrTXRU?= =?utf-8?B?YnpmY2xGV05xR21OR0ZKZVplTi90YndCcDVYaVlrR1JvcVVrYU5NU0N0R3Nt?= =?utf-8?B?UW5TR2tIOXpHV2RQZVUvOE1Gbjdjb25hVWhSUy9wTWQyeGh1NEMyWWhTZmpz?= =?utf-8?B?M0pvT3NYNkY0R1hEN2RQd2MrcDVTTjJpZ29xTXYrU1Z2SExXSjR2Mk9rbkFz?= =?utf-8?B?TS90S1NmcEYyYnVQNm1LUldDbVNHUzZBNkNia1dNT3ladUlveklXU0dIYTdl?= =?utf-8?B?Ny9sS2tFb25md3p1MHlCeGhQbGw1bGRpWW9VYktheVYwTXh5RmQweWhJc1BI?= =?utf-8?B?UGZiVGE0aFBpWjRoUXFSZk9aS1kzR0Z3elhLKzFiR3BLSTBEeFowdzFVVGpP?= =?utf-8?B?cWtDaGtXaDRyU21IQTUzMmFabUQ2VlpLMm9aMURLZTRRODgxdjJuMEtNZ2dv?= =?utf-8?B?ZmxuYUdrVlQza2ovdlJmQnplK1FIclc3L1IzOUVqRHE5a21Zb1NlV0JzQTB4?= =?utf-8?B?bW5NWHRMR3FxWVk5QlJBSkZTVnFXclI2VkIveUp4Y3lHMlE3SXRaTUVicWs2?= =?utf-8?B?NklGZS9FK2tuTThFUUE4ZXdQdVBxWmk1c2loY2RBRlVpVFBGZGkxL1BjZU10?= =?utf-8?B?Q1J1WXlKdGd3dzdDM0QxbWJvQklGYjcrL20reEVXZk9UQXV4dDR0c0hYb0ND?= =?utf-8?B?aWt1bkZzNnRCMFhkcTQyMURHc3JrdlhIUjh4dFo5VWNOZWZRSkpuVFBUWThp?= =?utf-8?B?bWt1NjVLeVlPVlp3cjRsVDdYalhtMzBhdSt2aWlUcXgxUmRBdFUyN2IwSXRL?= =?utf-8?B?UG1YWThEUHRvRW45SXE2WTI4ZGc1MURLdzNTWm1zN24yM1FabytWblhmanFT?= =?utf-8?B?VjVOREhyQ29pNG84Y3I3VkhrNjdCZEtMOEJZSFR4Z0xrQWlmN3BlbEdwODdj?= =?utf-8?B?MEJQQnFXT3grRmpQUDY3c1dteUUyTGdmYWx0MENmUXVRTXVXc0JTM3VRUDVZ?= =?utf-8?B?Q0xjQjYvekkrNGxBVGFEZS8wUUxTcUVwTlBoa3NvbW9LdGxYSVZTRVFZbThu?= =?utf-8?B?SjhSeEVJc0JMbENMNTZ0cFFYSzVCTkMybXlaTllKdUtaUXlJRm82dVdjSmVV?= =?utf-8?B?OFZ2Y1lhTW1uMWJqc2JnV1lXbVZhK0VpNUJic1k3VW9wVHdKT3N1T0lGMHNs?= =?utf-8?B?OWNvanFOOVNTZGU0VGtBdTFtbVZIN2NRRkpkckFnOXBrenhWL2FUcFg0UXV6?= =?utf-8?B?NWg5MVlwaEZxVTlPc1I4d1Z3bExCc2s1eEgyUFh5K1pkNjFLWHN1VHlNdTRs?= =?utf-8?B?ZUdRV0RHRG55bnhIRTFkSzFJQmVtSGR5c3JOWnRwMk5iN2xhcGlJTVM2N3lW?= =?utf-8?B?Qm8zTlk1VVVIMDRHTWVCRG5iSDlraGlLVWd6cjNOUWNORlJQMEVvM082bHJq?= =?utf-8?B?eEcxVk1aQS9NV1F1UENhcmhMZEpFR0dNa0NzVUlCVm1naXVnTHhOeEJrRG5L?= =?utf-8?B?SmFPdW41Y2kzbFBzUlRJU2c3S28vWWtWaEhpZVBwRW9lOU9FbUdNZUVReGdO?= =?utf-8?B?UndaT1hDVGIzZ1gyelptMSs3RFBuRlRPZUZxeFE2S0xOcXJxUHVFSDZWdDZi?= =?utf-8?B?NUlhcjhlMm5BM21wb084VElhOFU5OFN2N1BUYzFkWGlWeWV0YmtaS1gxYjM3?= =?utf-8?B?ZGRSM1FpSDljVUVwdzBhV0hkR0orcGNzNHZYb21ZZVRQVUZSMEh3TnZpQkxm?= =?utf-8?B?V0JLMnAwMnFucGh3eXpIL0hjR2VlVTFudnZMcCtqUUNOekIvSEZkYndHbXpl?= =?utf-8?Q?4XnMJJRccbkh7dwFj8UPAbNlsTj+YU=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH2PR12MB3990.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(376014)(7416014)(366016)(10070799003)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SHZiTFNrZTZFT1l5WnBpQXhTZk1INDZmY0IvdzRLaU1LZVlRS2UyYUJOaWhU?= =?utf-8?B?QXlZZnRxZHNyY3FvN2dmRHpoQmc2bTkwOGlzUkJpb1pRc1ZJeG5Vajc2L1FP?= =?utf-8?B?YS9tSHY3d0xjMTQwQklGODlQOWszQlFWdmlVVGRKMDFzMUxjWEQ3RnZuYWhy?= =?utf-8?B?OE9aUFllOEVucXVXT3REcTFjVXVBTjhFZkgzSUgvbWo4S1VueTVXS0FvSDZK?= =?utf-8?B?TnhkY29XMzFyd1lQejFRZTNLUHBKWUF1NXlBandJbGdYUldrRmc2NWd3Wk0z?= =?utf-8?B?MTdrS2k2NU9DcDZBdkJKdHlxUUlYQVBvTi9DdEVxbFdpZG1pbmNtbnVDVURG?= =?utf-8?B?anJLVkw2ZWxUaEh4VGx5WEtRRVc5ODZkTGoxT0piZ3RJdjZqcTJCN0N4S0g4?= =?utf-8?B?YlIwcm5WZTVLT3FEMVNLelhVN0xSOU5SaHJucGFsYWhicHZlYkdqcTF4aTE3?= =?utf-8?B?SjhTeDVXTWVnYkx1elNXaTEyWmdZTSs5QllDRHg0NzcyODZ1bSs1TU9Cb0o2?= =?utf-8?B?TVlOMFYwTVV1V2RQdnUrMTY1WTk5NzIxU3MyRUY4VnJZWEVSbzhkT2ZQZUVZ?= =?utf-8?B?UFB6b05GTURyc0NEcUlDTGZHNGZ6ME1nWWhkTTZDcXc2eCs2K204MmVnMHhY?= =?utf-8?B?d0lGejc3MEFvaXlYemxyblBoeGxubitlaGcvWU1aMS9oT2w3M1Exc1JHMndK?= =?utf-8?B?ZUthTlRubWxlQlN0U0RkZVdYRk5NeFBya3pXNjNjOUdKTytVT3ZKVi96ZUcz?= =?utf-8?B?VFprR1QxNnk1dEcwZ2dXdERkazhTSWRDN0lKbUNLSlQ2eGpEZTgzUUQwR0Vv?= =?utf-8?B?dUVFYlZqYWJXRVZDREROc3N4RERWTFBnQk5WUGpHSHVjNmxZV216dDgzTHlM?= =?utf-8?B?RHVBelNmRHBkUXlsdmtWd2xZQVd5NE8vSFBacEdrNlVYOGZDTmFqZlZLY0VD?= =?utf-8?B?b1VEc0ZJMWZadVdKRE1xcEZBcFBLNU95ZkVMenpVTm03R0U4N3BGMEthNlJq?= =?utf-8?B?WkZuRUdmV3NVVzA0ekJCdlNIdi9NQTg0bnFsVTVVWWt2REs1NTlEWk0wOGd3?= =?utf-8?B?Y2IyS2hodUpJYnovVXJvWFZ5RkQ0N0N0Z3BtMjg2TmowZEtJenB2alBLNDZE?= =?utf-8?B?YlhsdDhOUkxGWHUwMTVRNU1BcWg3WHhETkpuUWJKL3VBSXFiQTdMaUNCNDdW?= =?utf-8?B?UmhtbnpwRTJoNEpxaUh4TlNtSHJJMlRIMlRmV3JOVTF2QWtBbHErUHc5K2h5?= =?utf-8?B?M3VHK2ZPUjZiRXBGNWp4ZWpjbjRqZzlOYmR4ODZtbkphMEQzcU0vRFFnMTBF?= =?utf-8?B?RURPcE5iUmh3TUtqekNudzJFaVd5MGVZZ3FvVHR1c1J1RVE4SHV3M3doZ2Nq?= =?utf-8?B?WWVkSnZaSmZ0eFFaRTA5eWZrT0xKdGg4YWNINnlDM2R0WFArNmFGK2QwYXlI?= =?utf-8?B?Z1Y1WHlWU0xFVWVJMlVXWkJnOGIwZmVYNVd2SmdtRTBIUkdzS1V5bTRHVVN2?= =?utf-8?B?aEpKbktUbXdud2U0dHpQempZbDZMNG1hTmdKZ0RXWjFhdVBRaGZrek1oTnJE?= =?utf-8?B?SkFLSzA2VFkvUjVPT1FncC80Y2p3aWVyK0ZHd04rNmxHUFRHTTRHMThOeEI0?= =?utf-8?B?TDgvckZ2WkZ4UWhjR2FCS1ArV2NsNDZnQWlHK0F3cWh5VXB0blNGVHNkT0Rm?= =?utf-8?B?bEFoejN6MzcyUkNEeCtzNlZpbUFldVIwWjY5T05kY1BIQS9lM3djS3dRVllL?= =?utf-8?B?dnNIUzZvMXZtQWU2K1FTckFNbVA2akxMd1FNTE93Q1pURG90UEhjNVJhY1Nj?= =?utf-8?B?ZGpHL0JrSVJxNWZGZkFKLzJ6ejlrbFJ1YnUrQmQ5WWVDOUFSVHpnZ0ZUWUhW?= =?utf-8?B?RXh2bW41NXJsY3VuR3gxNmpHVkxCcXdaaTVDTCt3M3B6dnR0WjZQQlM2Z2k0?= =?utf-8?B?bXRRVzErMVIxT0J1RStqc0E2a2c5ODN2cm1PMDhVRkhDWW1PQmpDV2pDbXlE?= =?utf-8?B?RGlCVCtZNko5Y0JVdHJxMk9aVXVQc0g4MEdXaWpPN2JHeDFHOTFzcEV5YXdR?= =?utf-8?B?bWVoajlzSGR3S0MyTFBIUmJKUmVLdlJ1Mm1KOXlnT2pueW5DVjkxS3UvWDFa?= =?utf-8?B?ditsTEpRK1RKYXFnZng5Mys3S1RZclBMbDBSeHBtQzNJUVg4SVBUclJORFMz?= =?utf-8?Q?U6WEdVHRHAACTSjeyuvgHCGFQrv9koDWth1RsNw84xpJ?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: c0bcd419-d89d-4f87-14ce-08de2e237f7c X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB3990.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Nov 2025 02:11:53.1858 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: pFlzCnJyd8bbyGw7d1IK+cH2M2ejuGCMbfABy8/WkjBaBCEKb/RHIHWiMez6xkIxej6Q6jm6e6y3XRogh2P9Sg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR12MB6617 `build_assert` relies on the compiler to optimize out its error path, lest build fails with the dreaded error: ERROR: modpost: "rust_build_error" [path/to/module.ko] undefined! It has been observed that very trivial code performing I/O accesses (sometimes even using an immediate value) would seemingly randomly fail with this error whenever `CLIPPY=3D1` was set. The same behavior was also observed until different, very similar conditions [1][2]. The cause appears to be that the failing function is eventually using `build_assert` with its argument, but is only annotated with `#[inline]`. This gives the compiler freedom to not inline the function, which it notably did when Clippy was active, triggering the error. The fix is to annotate functions passing their argument to `build_assert` with `#[inline(always)]`, telling the compiler to be as aggressive as possible with their inlining. This is also the correct behavior as inlining is mandatory for correct behavior in these cases. Add a paragraph instructing to annotate such functions with `#[inline(always)]` in `build_assert`'s documentation, and split its example to illustrate. Signed-off-by: Alexandre Courbot Reviewed-by: Daniel Almeida --- rust/kernel/build_assert.rs | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/rust/kernel/build_assert.rs b/rust/kernel/build_assert.rs index 6331b15d7c4d..f8124dbc663f 100644 --- a/rust/kernel/build_assert.rs +++ b/rust/kernel/build_assert.rs @@ -61,8 +61,13 @@ macro_rules! build_error { /// build_assert!(N > 1); // Build-time check /// assert!(N > 1); // Run-time check /// } +/// ``` /// -/// #[inline] +/// When a condition depends on a function argument, the function must be = annotated with +/// `#[inline(always)]`. Without this attribute, the compiler may choose t= o not inline the +/// function, preventing it from optimizing out the error path. +/// ``` +/// #[inline(always)] /// fn bar(n: usize) { /// // `static_assert!(n > 1);` is not allowed /// build_assert!(n > 1); // Build-time check --=20 2.52.0 From nobody Mon Dec 1 21:31:22 2025 Received: from DM5PR21CU001.outbound.protection.outlook.com (mail-centralusazon11011052.outbound.protection.outlook.com [52.101.62.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 68A6726CE3F; Fri, 28 Nov 2025 02:12:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.62.52 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764295926; cv=fail; b=KlKmutag7BYtlcCG7WGx+SymyhKUO0ofEwWs394ZjyhG0DuaXaiETHFfj/u/drtkfYGweGVLGe34NMCa1wzLYw4gZ/EEjL738AfnCmtPkhUCsXH0iFZhKrdnfONxKUEbmGk7yxguOEFThWKJ2pqqOK+IsAeTHsHWquJkqKMElV4= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764295926; c=relaxed/simple; bh=cFssExtbUkGZXAtxBcxSqFSWHyMjZGWi92N+j3tA76U=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=FA6WcqRrhbWrZ3OJ0vgHpDNXZ5BRVR9FbnEPQ3bOOUa3stu6r5lrXnaBd7SL/VctM1nxtvZ7TNzgh1D2DyYfhLNJ3adGQ0c1Ouc5voRyIbN7m8kydM/Uff81PntgYh2Y6X2H/xMBssU2WCKPZMGCTP5PP7B1zcz69gaAqKS8QOc= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=MMvkkd6h; arc=fail smtp.client-ip=52.101.62.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="MMvkkd6h" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=FIuRZpSsCgOBensj/Iz9o7HpM+yLVfaPWEONUXq1dhG2YK2jmqA3v+WoSCGPPm8kErOIOY0XKSn7L78J95ZyduHjgqLbSZsgu9uFLCVjaQQLrkOYS29wNJfH2quNmcCTKKT2oQO+P09A4RG1uhC64xYY4A9gp9xuCI98W21u++oYDtoBWyyEyyw6/GM5PWrTS+p1LZ6WlPXQ8XwnVm7t7YKsfRlCOs+Ij9JSixzha+KpNvEep8RAGMPimaCoBmWkL5RiTu+T/Wgo5p4goh9oLPiDTKcTsasVRfEA7mbCa8/gZpZlb77WhBkCO22UmCpnJ3rr2QqgyF5MqR1MpD1Egg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kYIjmbfc2zLoa5LWK2EuzGrhkBxvq/L8BcWUi4+CVik=; b=CKV5r+q6bXrlB7mKnoEtIp4Nfk5lSvR1j8rnDLlHh8F0Hb6z+5nWPhI4yU1OBfPb+6O82xeK3gZeBinuKGTnTsqP8F0dOWBnaZoKJdNY+jREx514a5pKjf7b3zqRw5tMOTaJzLl4Z6VJSo18zmFw5MH+nNs7drTV1SaCuyrLohP7xbLhoKyH1v2/eUZlhZa9p65RN5aj95dBCrDJhViw+CtAsF8IntcDGl1wHLT+LKrN5PM/VyqpRzwxRjAfYUORHwc5zZMinfatL22ylJfq4vptAgPb5kTsLzZp+1hNrtVJsZ8H89qvjXK7fmCBLtEHzrOvrJfa2IQnMeLlhSlYbQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kYIjmbfc2zLoa5LWK2EuzGrhkBxvq/L8BcWUi4+CVik=; b=MMvkkd6hv64Lv+kx2Snem8ZW2+S2QjP6URyUSFDc90b06Hf13oggKCNGDdZMS4iYWxawsh3vkfB5Q3HmOBrrgMKyP2R71oaXokgzrAfBm8/Ta4/tswUF5nyY7EbG2f16VW/ajq4GwZZuTKspvw8rn7HCGQaaZnECn1UQ33gORNEsftR5c1aN08b7kgSY5JQb8Je5SFsTpbo/JmIhPPQb6WGvOXKbqhnqjv4kUMw4IoOFv98mbCt1TXrpEgZ7s7tsUpmdDW36rrVk8jI4ld3tLBv//dat/0BiACvCnSYRjcyEYcJca6WVETfC6lzjBO6YANFJoP9CAPuz0dEMVWwwQg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from CH2PR12MB3990.namprd12.prod.outlook.com (2603:10b6:610:28::18) by BL3PR12MB6617.namprd12.prod.outlook.com (2603:10b6:208:38c::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9366.14; Fri, 28 Nov 2025 02:12:00 +0000 Received: from CH2PR12MB3990.namprd12.prod.outlook.com ([fe80::7de1:4fe5:8ead:5989]) by CH2PR12MB3990.namprd12.prod.outlook.com ([fe80::7de1:4fe5:8ead:5989%6]) with mapi id 15.20.9366.012; Fri, 28 Nov 2025 02:11:58 +0000 From: Alexandre Courbot Date: Fri, 28 Nov 2025 11:11:38 +0900 Subject: [PATCH v2 2/7] rust: io: always inline functions using build_assert with arguments Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251128-io-build-assert-v2-2-a9ea9ce7d45d@nvidia.com> References: <20251128-io-build-assert-v2-0-a9ea9ce7d45d@nvidia.com> In-Reply-To: <20251128-io-build-assert-v2-0-a9ea9ce7d45d@nvidia.com> To: Danilo Krummrich , Alice Ryhl , Daniel Almeida , Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Trevor Gross , "Rafael J. Wysocki" , Viresh Kumar , Will Deacon , Peter Zijlstra , Mark Rutland Cc: rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Alexandre Courbot X-Mailer: b4 0.14.3 X-ClientProxiedBy: TYCP286CA0182.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:382::9) To CH2PR12MB3990.namprd12.prod.outlook.com (2603:10b6:610:28::18) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB3990:EE_|BL3PR12MB6617:EE_ X-MS-Office365-Filtering-Correlation-Id: 51cf0744-f482-4e48-2e1c-08de2e238283 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|7416014|366016|10070799003|921020; X-Microsoft-Antispam-Message-Info: =?utf-8?B?OFBNaDVVWTdtWm85YlBRQ1pQclkwa25Pa1JQcmE1L2tnbmZ2M3Z2K29EU0lZ?= =?utf-8?B?YnlWVWpwOHNHYjRia3pnZTI3U1VYNm5ubHFJWm1zZ1Vjb1JwRmpxQ3d4YytE?= =?utf-8?B?aVNBRE56MjhSK0t5d25UMnBVUFVBSzlWbSt2KzlZUGo5eFBHcENFdzVKSUxh?= =?utf-8?B?R25CdWNBZU90LzdUZjIrTC95a3AxS2Y1UlNJT3FsK0J5cWM3RHM0TG1JV3lw?= =?utf-8?B?RWhOTVdza1MvVkRSNlRyclJDN1YzVlFXamNHRGdaWDB1dlRxWWx5RWErazVL?= =?utf-8?B?K2FHZC91Wk5pc29QWHE0SmpINGVKWWV4SDlJeDAwQjAxSzFhRWgwNGh6T3Va?= =?utf-8?B?SENlNHo4MmNCdnVCQmlWdVdYUE1XRXVxaHg5aGUrY0JZT3l2US9qazZoeGcv?= =?utf-8?B?MVF2UDRBL0Y0enhKQVJwL2xWaDNTMWJTQlZTd1JWYXZaa3owOWNtVmJ5TGkz?= =?utf-8?B?WUdBTnhIbXdFMjloM0JseTk1enVJM0tQNDVXS3JITURmQ1Bla01rcHN3VHBZ?= =?utf-8?B?RHIxOGxucU92Ym9DUFdwNkt0VGZ0bm51TzdQTXhLNGpSYVFNZXFVOVU2ZHp2?= =?utf-8?B?TXFpVGNRa25rWHBtZTVuUzJJYzFWdWE5ekdidnRlTFJBSUdaS3FEOVg3bFZ2?= =?utf-8?B?WGlXTnovemgwcjkwR1J5ZVB0cEw5cm51ODFNR1F0eUlMYnZTaXQ1SnNXQzk1?= =?utf-8?B?T1F2aThOMFJacmNkT2xjVmhXTWdGT05MSVliaGJJdzRxUWdWeXJVT2x5SFlF?= =?utf-8?B?K0tySUdMZWQ3bEx4NVdQb04xcDBaNTNWTFVmelhFSzZLdjBGMW9XS0Q3M0E0?= =?utf-8?B?eVF6WUt2SUFYK2hxUXBhMnZWa0o4M1NoZ2t5cFNpNURZSkRBVmJMUU5UaXdR?= =?utf-8?B?c0dIMVBuSmFyT0dtRjdoVy9OdEJybXJ1em9Ha0wvN3ZnaDJVVWtidVd0a21N?= =?utf-8?B?NzZyM3NUZXRteVZ2SzVWZ2xOTUp4anJpZlJvWFBxSVJFWTZBdHJqZG1Ndjgx?= =?utf-8?B?RkZ6Y2U2dENHak9YKzFYUGh3dFU0STFUOGxjSTNlYzBSemNWdzJNTWRpMlF1?= =?utf-8?B?UHovY25GVnpkNDBSZXdPYWd5WTl6Z1dKQWlNMUo5UmFYZ0FVUFYrUVlhTmpm?= =?utf-8?B?TjMyd09pMVIwMDczR1h3ZnZNMnd6SDBkY3lGRHUzK2xYRDYvN2lFekNMdDJv?= =?utf-8?B?TkNxd1FPQzJTQWVXSzk4b0tBQ2RFQUhsN2hORm1ONkZBb01TNldPb3k5UTJ0?= =?utf-8?B?VVphUGI2U2RtSk5udDZIN3hMVEYra2Q5dWdhd2hlSEVqQ3RNS3pSbXo1YmYr?= =?utf-8?B?MVBtS09sTnhKZHVQTVN0S3ZuTWs5cjlrSHh6TUU3Nm5peENua1ZKZ2hrYU1i?= =?utf-8?B?Wng5SGZmTWlTRzFzS0hUdkxhRDB5RnlaZmwrVndFcGU5UDFVR0NxcitrelRT?= =?utf-8?B?ck5McUlpQXFPUzlmd29lNGh6aGgzMk9EeGxKT0NJYmlSVnVVcVBTU3BSNjli?= =?utf-8?B?UFd3K2lDUlBCbkFsWCtrQW9EVW15elQ5a0VwUC9sd1A0RnpLYXRxZERYVzRN?= =?utf-8?B?T2s1RytvaHlMcTFRSEhSaVNSRjFMRUtCdjFrTEdVMFpxRU00cW5xTDZxUXFh?= =?utf-8?B?NEM4bCtSYUNYOHlXM2owYWpvU2tqVG5TKzdldWVpQ3A2aEtLTk1yV2VIbWQv?= =?utf-8?B?ZE5xRzd2K3lGTUdGQkR6aFpkbThGcy8zRTNNWk9iQlJnY09PZ05WVXFINk9I?= =?utf-8?B?UHV3K0ZPMVYwZXhGd0N2bjdHZ3YxNDRoOWpHRlQweUwzc2c0d3NKMWk1VXd4?= =?utf-8?B?NFo0Y2NpZDYrelM0Q2ZDOFR1dW9xM2Y3U09saFF4ZHNaS0N0WEgwOHF1aEE0?= =?utf-8?B?Uzg2TFFyVERHUkpCeEdhMU1sY01hTE9tM29XOW9iRDBPR1VKS24zQ0VJa1Fr?= =?utf-8?B?ZEFKWDd1K1puU0o2RDZXSTN0Z2pDWTBRalppTGs2bmx4dEJ2T1U1UTRxSVlM?= =?utf-8?Q?j0jy7ckXrmifjJaayhaO7nIPJbs6KU=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH2PR12MB3990.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(376014)(7416014)(366016)(10070799003)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ajlzbnJQZ3pOdTZ3WVFrN3hWdTc4d0ZGbk5Md1lWRFlHNnE4OXNUdzVnWFBK?= =?utf-8?B?cmNCYkgwMldmdW8yOG14ZCtuR2l4M0JWdEVxWFZNRUQveU9MM3kzRXdzWVBY?= =?utf-8?B?K2RkU21xb3RxbkxlV1kwT2h3Zi95QkFIUGxsWUNmVkNRYTZYTVptdFJkTWpu?= =?utf-8?B?R3FML1krRUhseTFCd29lZWpGeFVDRENJalhHT0pxOERYbnZZQmppTGlKWVJ4?= =?utf-8?B?dG5qVHBkQ2lsc0JwWU11a2p0QTM5VXZPdEFkNWVsbGp3SUIzcHd4bTl3anQx?= =?utf-8?B?OFRLR2lnKzFLSE5HYVpoVTBnOWRwUWNaV28yM3loK2JHNmd5TnkzellEVVJs?= =?utf-8?B?VVZJWDZRQ2VkSXg5SUJ6V3dGQ3lDVk4zQ3ZFK0UrczJzV01PUThVU203eVN6?= =?utf-8?B?V3RDWThhWHVoVUc3MjZ6SjB6dStSOGgxZ0lkSThSNmE2MTdmR1JCZGRhQmlG?= =?utf-8?B?NWpCSHprcjAzMVNtcUlQd2JTS2VtTStrbm9vQWxtTmQ1cWZUNHVCdmV0WVFF?= =?utf-8?B?dkZQeW5nR1VtZlFlTXpnOTM2Y2ZGV0tVTllBcmtPWGRwT1BJQzJVaFQ3QVlI?= =?utf-8?B?OE4zcE0xQmkwUFNNT0gxODVza0F0K1JUa240YjBHNWlkQy9xeVQ0VEwwQzZr?= =?utf-8?B?VTlSaDF6QlF4Szkzc1hRY3BJb0VnWURLOWt2U1VEWHFncVZQYVp2QVNZWWRQ?= =?utf-8?B?dktWQnJxRTZWd0dTOGl0M3Q3aTNRNnliVU5keGxSVHZzdUErVytXMXo2TTBs?= =?utf-8?B?Um1YTk1wd1pPRU9qU04wV1hlZ2hsYU02R2duMnJjY3VoeGowZitjWnl0dlNU?= =?utf-8?B?c2p2ZjJHNmgvZ1Zja3JyS1B5WEcrK3hXdUFBM0N4VXR6VVdia1N0aTlGcHh4?= =?utf-8?B?My9WcXhkYkpoU2ZEWmFnbWpCTUl3WlRGRDhOeUZXUFpQb2dmNTBsakhuNUlt?= =?utf-8?B?MUtyOGJWU081K3dkUmRwSUhpc1hhZUJxRGVRQTNFcVdQWThBdkFnNllWUlcz?= =?utf-8?B?NUN2Z283TWtNMnlMVkNFOGNJZXJPOURsSVU2Z21SVThNMklBd1pXaTBucUxD?= =?utf-8?B?NDJkV2F6Vy9hU0doMktWZ05GN3pHcjkwTzBRZ0ZOT2R3RFl0QjVKeDBFSWFy?= =?utf-8?B?YUhkZjRxMFBRNHJKYTV0dmpHWHpURDM5TFlXOWxmYm91RWl0bFpHWG9oZVdk?= =?utf-8?B?NXo0L2NxbXFkd1ZPVjhpampaNjc1aEhkb3BCUWpUMXgxbnBIYVI5cnRwNk9I?= =?utf-8?B?ZWU3OXdzaWNGaEZ1QzRLZHNhbnFGZk9TSWN5VUhGZTcyUlR4Y2lYUEIrWWVT?= =?utf-8?B?YjdzbXN3ckhXcXJEVzloeTk5UVVkd3FsUUVxWk0yVU1iOExRd1h5d2lPcUk4?= =?utf-8?B?eEtYZHVHRi9Ua1JOMTlNMWpLai9qczhEck5uaytOb3lwdllJN3NmK0d6MUtF?= =?utf-8?B?aVVxY0FiWnpMZU1mT2lBTU5reW9sZ2FHYzJRVzlPTWpvcU5Zdm5UL2NzTE5v?= =?utf-8?B?OU16M3hzUnk3TFBFQmRaUFl0cE5nWFhaR2I1bWdQRFdxT2Z2VmhsdmRwZVJs?= =?utf-8?B?ODZOcTBxMm1QNFJFZUFCQ0lmSVZxb0s4WTRiQkhJYWxndEsrZ21tcUlyYXlk?= =?utf-8?B?UkFoYkRNY2FDZ0pyUjFoaUxFRHMxTTRzcDdZUmd5NUNiajFIUnB1QnQwZkZu?= =?utf-8?B?c1FMc2d4ajhveFFLczNockVaNEM3MnBqWmJNOEprTzl0bzAxMjcxMHNyVXpF?= =?utf-8?B?dHI2dllFS3dsc2NGSSs2VFQ3ZUJJVFdrYXhsZkI5ZVgvREV3Vk56QmtMSHU1?= =?utf-8?B?Y2d6Zmo2YnZrb0tBQzVVZTFYcTNYOXVERko2VVRlUmVlYjRzZzBPZHdlUEQr?= =?utf-8?B?YUJwdUlDeWg4KzJBZnJjb0RvNHBWMXp1SEsxbkdTQWNHcDFrTmJ2SW4zbnNt?= =?utf-8?B?bEc3VU10R1RibkMzWkhOWmJaN2RMMlhzY0NtY3VVTCtMVWtWdSszcTBCckZ0?= =?utf-8?B?Y3VBQnhZUGtBS1pHemVQSUtDZzhKTXg4T0dlL1dXbFlzcWJOMlFrbDBvdDM5?= =?utf-8?B?NklvdlRIYlJtTk1hbjBvQnJELzJ1dzdOSEZrK2laT3M1VThzeHhrbTNUZE0w?= =?utf-8?B?cWRYdlFGeTJGV294RWVmS250NUptNWQ5Zk5SY0lRalFNUlNmc3dIbVZjdjhF?= =?utf-8?Q?4NfRCmH5werhc9B0MdGyW2OjDm993UHqC/bgR/CZMPuk?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 51cf0744-f482-4e48-2e1c-08de2e238283 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB3990.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Nov 2025 02:11:58.2857 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: xKIS0/UVpYWw9YjMgKFEkw5z5M+ZuiZDw1THhSV/4Jp1CaDfKpwdeROhUaNrzvgWYbJC+e234mk9w8HoF8SyKg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR12MB6617 `build_assert` relies on the compiler to optimize out its error path. Functions using it with its arguments must thus always be inlined, otherwise the error path of `build_assert` might not be optimized out, triggering a build error. Signed-off-by: Alexandre Courbot Reviewed-by: Daniel Almeida --- rust/kernel/io.rs | 9 ++++++--- rust/kernel/io/resource.rs | 2 ++ 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/rust/kernel/io.rs b/rust/kernel/io.rs index ee182b0b5452..ccdd394099cb 100644 --- a/rust/kernel/io.rs +++ b/rust/kernel/io.rs @@ -120,7 +120,8 @@ macro_rules! define_read { /// Bound checks are performed on compile time, hence if the offse= t is not known at compile /// time, the build will fail. $(#[$attr])* - #[inline] + // Always inline to optimize out error path of `io_addr_assert`. + #[inline(always)] pub fn $name(&self, offset: usize) -> $type_name { let addr =3D self.io_addr_assert::<$type_name>(offset); =20 @@ -149,7 +150,8 @@ macro_rules! define_write { /// Bound checks are performed on compile time, hence if the offse= t is not known at compile /// time, the build will fail. $(#[$attr])* - #[inline] + // Always inline to optimize out error path of `io_addr_assert`. + #[inline(always)] pub fn $name(&self, value: $type_name, offset: usize) { let addr =3D self.io_addr_assert::<$type_name>(offset); =20 @@ -217,7 +219,8 @@ fn io_addr(&self, offset: usize) -> Result { self.addr().checked_add(offset).ok_or(EINVAL) } =20 - #[inline] + // Always inline to optimize out error path of `build_assert`. + #[inline(always)] fn io_addr_assert(&self, offset: usize) -> usize { build_assert!(Self::offset_valid::(offset, SIZE)); =20 diff --git a/rust/kernel/io/resource.rs b/rust/kernel/io/resource.rs index bea3ee0ed87b..d9851923562c 100644 --- a/rust/kernel/io/resource.rs +++ b/rust/kernel/io/resource.rs @@ -223,6 +223,8 @@ impl Flags { /// Resource represents a memory region that must be ioremaped using `= ioremap_np`. pub const IORESOURCE_MEM_NONPOSTED: Flags =3D Flags::new(bindings::IOR= ESOURCE_MEM_NONPOSTED); =20 + // Always inline to optimize out error path of `build_assert`. + #[inline(always)] const fn new(value: u32) -> Self { crate::build_assert!(value as u64 <=3D c_ulong::MAX as u64); Flags(value as c_ulong) --=20 2.52.0 From nobody Mon Dec 1 21:31:22 2025 Received: from DM5PR21CU001.outbound.protection.outlook.com (mail-centralusazon11011052.outbound.protection.outlook.com [52.101.62.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3AC7226ED3E; Fri, 28 Nov 2025 02:12:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.62.52 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764295927; cv=fail; b=ZO5KJtkGCPTX5azRO1y7RVL/yEuu3N8QAX5Fsro89KZorWeILVpvb+pLn+ox7s9PzxDsr24ZdWb+yYv83DiXRBkqB4MVCVuUmPiP9fJWhsZZoE9cXfYLBNoR74V15JOGKqV7vUwMXrk++2Mkva1BDPcgb6CopXVrto2Z7xIb2uY= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764295927; c=relaxed/simple; bh=DftiHYY8mS9FWhvDsznQU1xP4KjJpgtjJVo640v3YPQ=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=ppgfPKp4ZVEiIMN1b6JccUJMh8aPR6rixavxhhl+H18XjMeuazgsf0vvLaHsuS+uPBrDhYJ9k+chQAiTd+TyuPLHoZUZc3Ts7bz2f1X8ilnHHIzK14rvGqsV+Ndc3FtZ8oldg0WigjrP/fFigK/EL4V4TtAMF12pe7ZjfM1U/2w= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=dItY50fu; arc=fail smtp.client-ip=52.101.62.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="dItY50fu" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=knx44pPfMRGa1GW4cYoIrQL57Nql0IL9dixCBPkeUmyPXlrt7b7Iwf56Mgid4WisS5ombgdMVRemWGr8O+5PvyL+STpF/SchvzfkbTJrGo4jES6c/vSYrb52RgStEwJPA+Ia65lBsXNnF7dSFxVKSpmwkPAGQkat4/D8qQWRTI/Zc8gUri+PJvdQhHsbouF4cJSTrfNj0UBDwGkFuaUYTszSPUM+VyVKAYQ3mdeLwF1A+tGUfpw+ABfmsSZV+dINJPWJWoMlGELNjMR8OHbdJMdgS6zrOWO4osJk03lg2v2jum8k/eM6uCXPb0/CPnU7WHGX8Vz0LPB/bVss8+adTA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Y1xR65r5KAp8bT9SYiNVtfqBpTbrHlYewRabA0Gs0F0=; b=YES5P39P+NSIwusMIvEJe0xhGY93FYoZUnWx+v1jPpXufFsbsJ5tf1w3iucJ36iXYH/IKODmTVmQE49zpzd0smTF932lxIjpLtatyiTQwi+Wb4BFGKCnxEKFH52ch+KQcgUWIUuCx35hMNqFxI5BDE4nldNghjI2JLWi0c3DUKsX7XY5DBjd23lh4e7b30knI2sYI1+Aew1nJDoBl9tcDKGbJB1gRsJwdSI03bq7FvIyxf/3w177A6cCXiYQcMI9tpF2EowqN3V4lxyIiMgESFu3BBW99uIK1RTPBZT/3GSGFyedhtawpclx1F68NNk/cSehAcFfKJuuYsXNdfjFjg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Y1xR65r5KAp8bT9SYiNVtfqBpTbrHlYewRabA0Gs0F0=; b=dItY50fuFADkb8Ek+R9J/xhrda2t/bGW76/Tg1NfY3PxV46d0Q9gwhKnhdqt2JewMU8aJmdS9BKnZr69XTJ8NtBHhnTZqTLaw/U6+uk2sEnNj941Aw/d+KtBW/I/y/M+VYWJsH5S28VVE7whpywqpY5qX63JUoWzear404pqEKsTmGWOh133kwlyxnEZkyIDPJFowbN9YtIn3djW35I+bdZj5CuAIDowlXoy2yDQaWNHC+v6anYxd5sHeq3x3Igc21CS+vjHmSGCA7Fa5qAS4+tLFPNydqvrg0aQ60NCHX1ce0R3FMAcnoNdVn2qQSHlhQ56BsdPD5UbPDibyCSaog== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from CH2PR12MB3990.namprd12.prod.outlook.com (2603:10b6:610:28::18) by BL3PR12MB6617.namprd12.prod.outlook.com (2603:10b6:208:38c::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9366.14; Fri, 28 Nov 2025 02:12:02 +0000 Received: from CH2PR12MB3990.namprd12.prod.outlook.com ([fe80::7de1:4fe5:8ead:5989]) by CH2PR12MB3990.namprd12.prod.outlook.com ([fe80::7de1:4fe5:8ead:5989%6]) with mapi id 15.20.9366.012; Fri, 28 Nov 2025 02:12:02 +0000 From: Alexandre Courbot Date: Fri, 28 Nov 2025 11:11:39 +0900 Subject: [PATCH v2 3/7] rust: cpufreq: always inline functions using build_assert with arguments Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251128-io-build-assert-v2-3-a9ea9ce7d45d@nvidia.com> References: <20251128-io-build-assert-v2-0-a9ea9ce7d45d@nvidia.com> In-Reply-To: <20251128-io-build-assert-v2-0-a9ea9ce7d45d@nvidia.com> To: Danilo Krummrich , Alice Ryhl , Daniel Almeida , Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Trevor Gross , "Rafael J. Wysocki" , Viresh Kumar , Will Deacon , Peter Zijlstra , Mark Rutland Cc: rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Alexandre Courbot X-Mailer: b4 0.14.3 X-ClientProxiedBy: TYCP286CA0224.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:3c5::8) To CH2PR12MB3990.namprd12.prod.outlook.com (2603:10b6:610:28::18) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB3990:EE_|BL3PR12MB6617:EE_ X-MS-Office365-Filtering-Correlation-Id: 370d74ba-4228-4237-0713-08de2e2384b7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|7416014|366016|10070799003|921020; X-Microsoft-Antispam-Message-Info: =?utf-8?B?OFZwbXNxWEpQVW42WEVPVEQwMm53QWdEQ0xwdjBMWUk2Z0U4SG4raWx1Smc5?= =?utf-8?B?bWxNTGhVRnNoRDBrWnlhVG8xRU5mbUF6R0lObktrOVhIeHhlLzJ4bS9WUjcy?= =?utf-8?B?c25kK1JyaHBmUmZKUGZwaUV5K3RzWGVaRU1jTW5uQ1VOTE1FaG5BYkQvdUMr?= =?utf-8?B?MENFcnZlUllRbWtVTG5LNEoyU0dUaURHczR1a2RmT2xxdDFXZW1NN2J0QlZM?= =?utf-8?B?WEw4SXcwR0ZPeUhsYzl2Wm9vTEdNNlovbytkMDlIVnRGNFZaQkNlSndEcjMz?= =?utf-8?B?dVJGMWZtMHdIWWFPRElhRlNQZGJoT1dYMHFLTVNVMUhKa0RLZkZyMFFBYWtG?= =?utf-8?B?ei9VbFdHQk1yMlAvTElNVlNtejdJUmYwVVlCWFg2d0svOHhNQ2l5ZXNHeVpv?= =?utf-8?B?S3RqSW5vWVVkcXgrQTJBTi8wZ1VNblY4WjJubHQ3cnNsdGlMekFVK2o2Z1FR?= =?utf-8?B?cDByR0gvY0J3azVKS2tSZVd6UjJUTks5MDF4MWUybWJFbUZsWHlEdHpTQytm?= =?utf-8?B?MmMwdFhsbVRxejRSU2ZsMk41cnNxK2ttbmFmU1NjN3lPSkt0dTA5eUNLWkRq?= =?utf-8?B?d2EwWHFEZ2NkRUJ1YXExUk90NVFpVXhXZFFHLzZDTDRFd2R5K3VkSVh0Ymdy?= =?utf-8?B?R2tPcDVJZHpEVURyT3U5WDFsS1dvd0RHQW16RkVuNG8xL3FjMWN6cEMrQlQ0?= =?utf-8?B?K2pHamNBZFlGU1ovYzlnVUkyN00zRm1zeWtDQURHdTU3azU2V21JcGY3RlJp?= =?utf-8?B?eG9BZGpSWUwzMDZiL2hKbFpOUHBvbmtmcHRkQTFoRjQxcFNqMGlsMStiSXJI?= =?utf-8?B?VDkxVFNGWVRRbXBGNUVjclFrVUVBR2svd1d2NVRmWHZ1QWtPbkVsZ0V4UVU3?= =?utf-8?B?UWtmcGpVNDA4L2pkeGwxdXkrNkRrNmFQQTZnMWpLdFprcGE0N1lNdWFZZ0Qv?= =?utf-8?B?SDZEZEQ3R3puWXlwV3BPM0JrNW5YdXB3ZkxUamhMaDZHS0lKQXRGOXEzQ0NC?= =?utf-8?B?QlNGUG5jeUZnTnlnSWJoMXhOVnh6RjJ6VHF5NFVhU21xeWpoa3JmT1JreElM?= =?utf-8?B?Q21mdnl6cHNIdFY3VFB0TzZSWTdGa2JEYitMQTJpQllMN3lSZkp0Q2hQb1pX?= =?utf-8?B?TkQ2RVIvV2R1SXVWdUxZWkRaZnFUdmVJbjJRampqckVlc3E4Q0c4K0trWmRC?= =?utf-8?B?K091RE1RQUE0V3NKNDkvdHpmUFZiQzM4SGFHZFBWcnQ0MHZaTlpnUU9CMXc5?= =?utf-8?B?NVhJWnRURlVlZGFYRHlpMkhkSVliWTBjbUtTdFBxQ3BJREFJRGVQYlR4Y1JZ?= =?utf-8?B?dG1lWjhMMHJHYzA2aGt4WlBsbTNRUUI2OENUTGsxWUpwYXBOcHZjWTdGczRC?= =?utf-8?B?TmQ4aVhqejBRTStaZ0d6L21XSUpqV1lLL1doV3l1eGxGaVZHN0xURXpxT2xo?= =?utf-8?B?MVZvZFFtLzRpUGdESyt5MkwwLzBUVmVRTzBISjJYcTNWcUVvWnJjR2dlekRu?= =?utf-8?B?bDRXeVN1c3NFdjNOL2x4c0xhb3psa0RSVHVTaW8xZWZVL1JVWGE4Nmx3M0VU?= =?utf-8?B?RHlGTmhWbVYxYmZ3RGZYL0piTUl0Unk2TlYyd3FIcFQ1VEFEVlk1bFZVRWlM?= =?utf-8?B?MkJtOGNmcTQzeTRDN3FQckRwYVNBeTNpYjhwMmhKQk5VbDU5OWV0RTlBK29B?= =?utf-8?B?K1RBNjVVaXMwWk1WQ3pUTkF0VUZZNmFJQWFYVDJ5bUkyMEh5WXdIN1d2SHRZ?= =?utf-8?B?ZmtEaTkrTThmdVN5QnVrYWZpM1pGNnZzSkt5ZGI1eGNiSTVKMUpXcE5MS0lN?= =?utf-8?B?QWVFK3FINHJ1YUtna1ZlbXY2MkFkK3RlNFEvM1hQbFFpZGNTSzR0UWx3bmpz?= =?utf-8?B?OVhTc2RER1VnSG9makhCN1NiK3hnRkNaUTRrWEVSRTE0Z2tPWDJQc0xiVU40?= =?utf-8?B?L0xJaUM2TlQ5YlRIY0RpWDZ6U01LK0RtMVlhZTJrSERQR0FGNjY5S0s0Z2xZ?= =?utf-8?Q?orsGTavcxuaUbZZTwvCu2ZIovnEJ64=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH2PR12MB3990.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(376014)(7416014)(366016)(10070799003)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Z25XbGJxbWRMdkhJdTFWM3VjMndTOERDaDZjTEZQNDZpN2RBK0sxWnpMRkJ4?= =?utf-8?B?N044cDd2VTNsVktyUzhvalVvMWVhR2xOMzBPZnRZekFva3R2NGlkRGdITitu?= =?utf-8?B?MkVHTUV0ZWlpUG1taGNEQlVLZDN4aFBiZ1RNZEIrYkN0RmtOOE10Qm5YTjZ5?= =?utf-8?B?bFRTcjNBcFR2dEtzeGJBL1pvWlFtT1RkSFN1V0V5Q21yUVlSVWdxM0k3Znhw?= =?utf-8?B?bnV3eUF4SktvQ2tEM2ViS3h3NWpXbXNwQTVTMUpTTGV2M1dkWk9Eb3JWT1ls?= =?utf-8?B?RnNXUncyRGZ0NDlEVUFjUlpONHVOeXIvRFFzN0NOVTF0b1RTZHNxSDFCbFlG?= =?utf-8?B?OEdZMWlJL0krM3owMlVyRkFzQ1I1MlVITE9FRTJ1N2ZWUTIvSVZMcW54STFl?= =?utf-8?B?NWlWS2k1RHhHUDJ3ckJsZXFNdnoydWNGRGRmWHVXS0ZwVndzQy9lR25Xa25t?= =?utf-8?B?ZUpKTkNxLzJLQ0VtRVR5SGVpR0hsR2hQcXBZcy8zeDhEWXlLanZYcWdUNWdq?= =?utf-8?B?dGwvT2RmUkhpenI3bzBSUUZTcnJGYzFMYWh3ODJLei9KaHhLOU1qRlI1U2ht?= =?utf-8?B?OGowRGczQWxEQWFNUWlvQ1lxZmYwYlhyWnpuMjlKYWIxbUZpdGRXYjlKamVz?= =?utf-8?B?VXE0TEJTYXRyckRuV3FrODAzT3R6eXZBYXdQNDAzbFE5dzFleFNWK1pJU0g5?= =?utf-8?B?WGQwS0prRG1yTERaOFJSUDRKalFaR2lVaUtFN3RWVHkrZFErWGJtRWE0K2pH?= =?utf-8?B?cnZ5Q1R0ZjVGZyt6TnRZeHJHOG9MQ3NXa2VjSTRhNEFDRndZY3E4L29DWGNZ?= =?utf-8?B?YmtpRVFKMkJkWkpiYkc2SWUxcTRnM1oyYUpCdEx1Z3pyODZWcnNreVYram9m?= =?utf-8?B?bi8zaGl3dXMwZGRYR21pQzBCYSs1S0ZNME1FWkhxMlVueGV3UUwvSlRGZ0t3?= =?utf-8?B?VGV3K3UveXVxcFdBZy9SbUpXQW91SFNvNXI5OFVGSWpNMzVHTG9MdWZQWHA0?= =?utf-8?B?S2c5U2RVb2p0VXNFU3l5czluWWJnNCtqMGFzM1dmVnY4cnBjYlhuQUJybkRh?= =?utf-8?B?S3VMakl6RkZaaXVaYmF3dTNPVC8zcjdZMGpPenZicWhnVGVNYW9yLzlZNHQz?= =?utf-8?B?dzUyWEF3RlZ0bGEwMUo0b3lKUkVEZ3U2SG9mSXZTejN3K1Y2Z042K1NNNlZF?= =?utf-8?B?dGxzODFYT0dmNGJFZFBoYmFvZXIrKzBBbWRuNUl4NnBLNjlGMDJiNHE4RmY0?= =?utf-8?B?QThINmtuSDJVK0JuNWVWd2xvY1AzNVBiUERUdGUrWXVRK2Y1Q1F1KzZwM3pi?= =?utf-8?B?ZHRVWUU1NVd0dkFrQ1FuV2RMRHBDWFhXcXB4aWJ6N2dGYm1IeHJyREdOQXJx?= =?utf-8?B?dFFLSlhvMFN1YUtjWGhhQ0dZMlM3a0ZGOFNGai9VOXVyMVBLOGNNekpxOGFq?= =?utf-8?B?clVZNmg4eVAvdkJmV0x0dEhQSTI4MFpRNnlwYnE2VEwyTUpUK0ZHSjcrWjIz?= =?utf-8?B?bXJwb3pHTVA4U0t4cE5nOFBNZ1k3VlY2VGNvZUZhZ25kUnkrUTFNaXFtMXBC?= =?utf-8?B?ZE5NYjFBY1luU0w2eUQrdmlGd3g0Vm0wcStjcDVmb2grZ3gvVzNXZFJDRDc5?= =?utf-8?B?RXBUNlZURng4NlFCM0JFbm92Rm1oMmNwRVY4TjZmMExQbmhMRWp2WjRjeDA1?= =?utf-8?B?TkI4MDdxYjR0dkFGMTdSTFo5Tm1MVnN2bEk3WFVKblNSMkRKcEw0NGo0N0hY?= =?utf-8?B?UXVvVm8wQVg4VzJjcUVlcUsvSXJKOHdLZXB3K0dQV0tBRGcwNEVKT2Zsd2da?= =?utf-8?B?YnJGeTgrb1QvMktZb280Z2xiMXZQUWdXWFZOWmFVa083U3FSalFjb01id0xs?= =?utf-8?B?NkswUlpiVzNaSFJUbkwxZDVxNFhKdjR0MkR5TE4wNGFpKy9ybDVULy9QenJs?= =?utf-8?B?K2phOS8xUGl1WEtKNW9Jem9VN0wxSk5nL0p6aHFSelBKTElqQUlQWXBWeVY2?= =?utf-8?B?VVJhdlhpMzVwTTRFelNOb2JhTlpYdkJOUWViM21LeWxYT0pzdmNEVnl0dkRT?= =?utf-8?B?TUg1TEY5VW5CS05MMVdaZ3FQdW5QbTNZdXRNeGlKenJ5bFl5OEk3bmtVMnZ5?= =?utf-8?B?VWRkWW9FTzFGWkZ0V21zaHJ5REFtRy9FWnRpZDZVWnB3VU5KMERGQldXZng4?= =?utf-8?Q?Q+vP4GwfAl9WLv2Ajd2L81QUDmUiG7v/hy5Rex1sys1Q?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 370d74ba-4228-4237-0713-08de2e2384b7 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB3990.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Nov 2025 02:12:01.9482 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /4QJL1UIt02IkAIUtyn43d2+M6zqwCrVFxVNLLdRKT44Gg8o29FB1X1rqyKRTlE/FIfRNpArCtyCc/wdeEQseQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR12MB6617 `build_assert` relies on the compiler to optimize out its error path. Functions using it with its arguments must thus always be inlined, otherwise the error path of `build_assert` might not be optimized out, triggering a build error. Signed-off-by: Alexandre Courbot Acked-by: Viresh Kumar Reviewed-by: Daniel Almeida --- rust/kernel/cpufreq.rs | 2 ++ 1 file changed, 2 insertions(+) diff --git a/rust/kernel/cpufreq.rs b/rust/kernel/cpufreq.rs index 1a555fcb120a..df5d9f6f43f3 100644 --- a/rust/kernel/cpufreq.rs +++ b/rust/kernel/cpufreq.rs @@ -1015,6 +1015,8 @@ impl Registration { ..pin_init::zeroed() }; =20 + // Always inline to optimize out error path of `build_assert`. + #[inline(always)] const fn copy_name(name: &'static CStr) -> [c_char; CPUFREQ_NAME_LEN] { let src =3D name.to_bytes_with_nul(); let mut dst =3D [0; CPUFREQ_NAME_LEN]; --=20 2.52.0 From nobody Mon Dec 1 21:31:22 2025 Received: from DM5PR21CU001.outbound.protection.outlook.com (mail-centralusazon11011052.outbound.protection.outlook.com [52.101.62.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E75C227B4E1; Fri, 28 Nov 2025 02:12:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.62.52 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764295929; cv=fail; b=uooHaG/fsmZdGq0E4da9ssoQfazKK5t8KYrjDxtjj3usluljo5bL+y8pFnkBiYWbjc2+ABsXTubCHtDCNrYSR9k9qc+cOW0bvt3Ja3mJP07E8wyxaf5SAGVK/w80iWc7643YWjzSsSP81kD4E++I2Hf4G2RA2vnCKzZ7/+Wdpf4= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764295929; c=relaxed/simple; bh=LqnDyUwRyE59XZ0gnX3DXLwKYZEqUHZoil6JKBqyzI8=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=SkKV4C/61SIY8pJ+RWE3Szyp5WYBQHi8PIdYb6Ggo6Mh2rf5SzQtmgZGmhfLTQWZKTrazxeQGVTRVckD+xiD6mxZ83t5hbD0bXhn01CMgo2zUcfvTi0l2ObYkvuHzx13ee6FKhv6T4sZLx/GzSRgtqs0i7uax/BQwR/6zuM7UeI= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=IIBuLek0; arc=fail smtp.client-ip=52.101.62.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="IIBuLek0" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=YovREMAE6/lM/nW62iT81YeAoGM54lTr2vbrhHPjPAp+XKdhL77PFuSCVuL5rDTilEMaXaP7fpV6gLKO9Rv+XhCEQAYgYSqLQPiu3NKaMDy+nCnx48xLzQZIHlzIT0nAurzPn+uP1EBjLbeYwxZH1UCEL35OTgUZ9iR7d+0dhRr9beFGF8Zj/Q+5bTD7hKxQIITUqEv/LFOb2oNsI8ez+mGqOsm9p4vD7TJdeE/hBlX0KO/yiV8KsgbGRjB9qsUrvkGWw6+yWbTGFXRMNyrTy8zaaKzKQeZEqlv8OGrKxZjUJsiKfCPkG9K3LXov4E88ZtgPAmZpnb7t/AWQdKjmNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zQlCJ0J2DCrdj5qMzeWx4FxqBPyHQBqbG9rONOnNDRo=; b=h4NxjvOq1p1Gb9QvkTf3q/+pCVIIhKDkdmkaaJs/pRSwU1gpMpRKcojjIrva4Zt2jcWnGCT/K/+mQNMd+EjeiLUbPSvSG4YmZk0EsD8IcANTgRTM8Aq9s3tqJ5JjONjkv9wjGcw+CwssBn9OZQKpSnB1L9J37eYOJhq6A7DU+zger315+O7X/v/5WJyrGVKojyWW61P5Qy9LoeHhNe7lJThbgib9wuFQGMlMRNxNuEcWdNfh6Kmsk4HNn52xD6uLh0iNbQgKlBceDhHjw9XJlyqyjd01EL2xPBRLoMdR7ggMmLAhGUg5Qzal+YNk0Ej5/gRjDFKbVq0asQkov9bP0w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zQlCJ0J2DCrdj5qMzeWx4FxqBPyHQBqbG9rONOnNDRo=; b=IIBuLek0TLSGpB0W5cJKu7iIp3ohRgA2kU36LiUDsGV1alrgSbjsgnmgPY16oIdI2FBHLgfJL4e692vavP++jM3rZQsQQMLzKt2LrYUXqDsHlGx3vUfTGBz9NvHof+PltE4i/qAQTwyyo0ofz6lFh6c/IgQfTAXVBU74RFFgE8ACx5ImhTuYE8H4BLuVRQLNvD5xOUdqDLOyx20HoCU+ih8g6wrxefa0Dep59+6nnxIpmCBIwD4TCeYpdku3Tk5HDkZQ782GzFJAkTDptYgmELtJddRYFqo9IrU2+k5BiLRRe7jypWwep538OPivDdhHOreNP7IcbusPh7pFuHGoRA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from CH2PR12MB3990.namprd12.prod.outlook.com (2603:10b6:610:28::18) by BL3PR12MB6617.namprd12.prod.outlook.com (2603:10b6:208:38c::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9366.14; Fri, 28 Nov 2025 02:12:05 +0000 Received: from CH2PR12MB3990.namprd12.prod.outlook.com ([fe80::7de1:4fe5:8ead:5989]) by CH2PR12MB3990.namprd12.prod.outlook.com ([fe80::7de1:4fe5:8ead:5989%6]) with mapi id 15.20.9366.012; Fri, 28 Nov 2025 02:12:05 +0000 From: Alexandre Courbot Date: Fri, 28 Nov 2025 11:11:40 +0900 Subject: [PATCH v2 4/7] rust: bits: always inline functions using build_assert with arguments Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251128-io-build-assert-v2-4-a9ea9ce7d45d@nvidia.com> References: <20251128-io-build-assert-v2-0-a9ea9ce7d45d@nvidia.com> In-Reply-To: <20251128-io-build-assert-v2-0-a9ea9ce7d45d@nvidia.com> To: Danilo Krummrich , Alice Ryhl , Daniel Almeida , Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Trevor Gross , "Rafael J. Wysocki" , Viresh Kumar , Will Deacon , Peter Zijlstra , Mark Rutland Cc: rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Alexandre Courbot X-Mailer: b4 0.14.3 X-ClientProxiedBy: TY4P301CA0004.JPNP301.PROD.OUTLOOK.COM (2603:1096:405:26f::13) To CH2PR12MB3990.namprd12.prod.outlook.com (2603:10b6:610:28::18) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB3990:EE_|BL3PR12MB6617:EE_ X-MS-Office365-Filtering-Correlation-Id: d4590ae1-61b5-4477-49ab-08de2e2386f4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|7416014|366016|10070799003|921020; X-Microsoft-Antispam-Message-Info: =?utf-8?B?SmI3MDM2T291bWxJUW9vQkpIdTFjZGVJNkhvdjVobWhiREhPNy8za1BTN2Ez?= =?utf-8?B?Q1piZlVITHl2dEdndTRTUWhsYnhUL1FzdmNlVjMxUDROS0tYc0xsaTYwZnox?= =?utf-8?B?VGRZS21xTU1ITk1vMTd0R1pma2VjL3VuVjJuZ1VBY2txQ1lCVk1xQzRhQmNS?= =?utf-8?B?UGdHQVpwVnB5Vzk4cFc2clg1YU5idFRUWHFIK0hOWTlaQjhMTUsxTmF2NlFL?= =?utf-8?B?VkVBRjFWMVdRMlFJVEdZaGZ0eTFLTFJ0bW9sMWppNngrTGxsRFowYi9JUlNp?= =?utf-8?B?cVB3RVVxRThHVnphTmlkRmp6QWJxeGRtRDFyRXJMNEZRR2F0eVlmR2pYTEc1?= =?utf-8?B?NjhJU1VXTUtPeTRjTXkrRVBXRW5IK010YzdpZmpRejkzMDAvckt5cFk5cHRO?= =?utf-8?B?Ymk0QlY5d28zYTRqNUhpcjZxMXIvYStFLzZMa0dSZGluWlNxeWVTRm94bklR?= =?utf-8?B?UUZYdnFCR3p0MUxad2pnOExLNGtJazZGNFRMUFBSS0xQWWFRMFlCQXNsNklI?= =?utf-8?B?N3VXaklMZGhEd3QzUERtTkdITVdlaEZGZnlaRHhYUkZ6Q3E3MVhsdmh2SDhU?= =?utf-8?B?bVVONjJRU0hDNEdkdFA0eEk3MjlMSkZWTjY2a0twSUJIYWxLMnpTd3Rhd0RS?= =?utf-8?B?TXpwZmRRZHdVemJVSGdHOU13T05TOXpaZ0lrcHpURXVHUW5UQm9HQWlYcW1X?= =?utf-8?B?UjlNNnhzZ252Slgzekw2Q2Rhbnk4cUlrUnRQRzRUTzJ4QmNLdUpHZGg4cyt1?= =?utf-8?B?bG1tOW1kbCtqdFhrM1lCb0tRVVZvVWhvVStWeDZkSlY0enkzV3pUQzV1enpU?= =?utf-8?B?NlRLNVdRYXIyVVVoZzRVZXJPM1NMaWduUHJVbUVKS2RwU28zcnQwMVBLQ0pT?= =?utf-8?B?aVEyVS9pL3NNTW9ha0JKck04OWdTRXp5bElyaE1PUzd2S0pXdEhwaVpoKzlQ?= =?utf-8?B?ck1xZG9JNUpCUzRSZ3J3MWN1Z2w1WEZ1V0R0WTVSdWxMTW9YaDVEbzBaUE0z?= =?utf-8?B?d3UyZ0RSVEtQZXFuRUVQeFN0eWxNVkc1dlR6RnVlRHdPRi9xdTNqTVZQaGk1?= =?utf-8?B?aG81bUM4L3B1dkUrcjNjc0RXSU0zMEViOGlONEFsblY2TDdKSzdqcXMybE9l?= =?utf-8?B?SkVHdEdEa3lzQnl6Y2tzYUx3OThRU0pwTTFSaVl6QnBsMDNuN2ZObVhtcDUx?= =?utf-8?B?ZHBIc1gxUFo4RmNFSlZhRU15ZnUvcVVaMk04aGFlRjlqRGJTcXVXbXFOR2pL?= =?utf-8?B?WnNEVDFuMlhlU2J3czlURkFKVGpWMUtxOXlyS0VzK0ZSaHlVeDZXUnhOMjVx?= =?utf-8?B?K2EydE9GQ28yN1A4NWR1bWlINEk5K2FXYkVzaEljQkNGN0lmMk9VV1FMNnR4?= =?utf-8?B?eUxSN3E3SGlFdkJXaEY0ZmMvSFJCbUYrMnFSQlJ4dXg1RTE1UWJ0M21sdzVz?= =?utf-8?B?bnpPaWUxODhuZzc1ai9jSnhBZHlEVFR6VmpXbVhZditva2h4RjhkVzBBRStV?= =?utf-8?B?RGs1YTBLRUovdm5yYVEzQlc1VDVXOVM0dG50RFo3Yi92RzBiRWY4cXAxUTh1?= =?utf-8?B?a2FoMGpxQ2orbUFJMUdTZmFJQTAyTTFnaDgybFJjOXl0Z3NLdGU5K28wUEhB?= =?utf-8?B?SHBtS1FiNXJKa3l0b2d5aHd1eDM4ajZGa2I5dlQxaHBuaGtFalVvV3M3RjlX?= =?utf-8?B?NTJsMGt5RHdHTnNMR3FtUHpXNkFETWpKSEo3WGZhdCtablQyOStwbFJ4cGQv?= =?utf-8?B?TWdhbm1MSVptdFBvVkwzS1NPUUFSdGk0OFU4ZUZlZGl5ZVpHUHIwV2ZQSFo4?= =?utf-8?B?ZGVFMCsrNFZ6UG1XQkFYOEFyNUpwMDZEeEdQRjQ5enZocnlYUWdzZlAyaHp0?= =?utf-8?B?anFsUGFVSXhiSjdnZUdITlBMbDFaMWhZU2wya3QvdEc5SXQrYXljandmcDMw?= =?utf-8?B?VkFiQmpGdklGd09tRHc2R3loUXNwaEdSZUg5ejVibjhCOEwzSUNHTEdlWnFH?= =?utf-8?Q?+SyNaNyV3P58eV8G6GsEvS6yZ/brxs=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH2PR12MB3990.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(376014)(7416014)(366016)(10070799003)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MlVwQXdOWXZaaWkzb2RCbUw0NmxYVU5Dc1NScXBRY0wzMytpSlZPM2hkaUl2?= =?utf-8?B?YnQ0Vk52cEJQbVlZd1BTYXJac3IzQnA4Ry9GdDFwUjBvKzNPN3lIQkE3NzdT?= =?utf-8?B?MFhjZmtNNU43WU5KVktwSXBOMktnZ0pMbWtya1NZZExwTnpaRktXS3lNaDRo?= =?utf-8?B?QnE5ZlNzbVlCTW1CWHIxNXdFVWxQbTFjcTdyb3lqaHNYN2dNSzdKYjNZdDVl?= =?utf-8?B?KzdCMktHOE1oQzBLOHQwRHFxWUVRRDZoWWtXZjJONEpTc3kyeDM1TmpUYVdB?= =?utf-8?B?WmN0VWFvSnJnZzg3RmRTRHE0b3lxQStmRGFoc2krUkFkeEZtL01QOG5NdDlh?= =?utf-8?B?NVliM2p1YXlFb1VxOGlNS2s2WWROM3ZZb2lvTVlVbGUzczFBbUowbjJFcEtq?= =?utf-8?B?T0pOejlwc3kzS2kwZkV1ZnFOTm5wVXdLd0QxTWgvWWwzeWVmK054Y1hnbk1t?= =?utf-8?B?S3gwZ1U1NGJEYUlEWHZERmxDOUFmaVpqTXZ3MlptaTRleHJweTNiR09kbUll?= =?utf-8?B?ZFB3bHdDVnhiUHRxSHMrRDZWenR1U1ZkWmpxVC9XbFVQNHZ5dXpReDRnUkNh?= =?utf-8?B?aTlZYzNlTWJIVW4xdS9HTVllaGt3emp3U2FXbmxXZFYzTExjRFQ2OFZmY0pB?= =?utf-8?B?VURJdUdSRENHSjRFKzRTalpTd2pON0NIN2dNUFZYZnhBKzVMVVlxbkdzU2pa?= =?utf-8?B?ZkFobkpwcjU1Vkhtcmg5SWZvSmdiSmxvaERGbVVUKys5RFhmZllwV3ZHZFVW?= =?utf-8?B?RlRVeFRRSTNVc1NyN1Jud0IvOXpIQVdGQ05MWldEWU9UQlhTSzFXdFFidVVZ?= =?utf-8?B?cDlaMG9nYnJuZDgzOUZyTm4ya01iRkg1RzdGV29kS3ZURjNuOHBJSnBrT0dT?= =?utf-8?B?NHdrcU5MY2VFaVVUSS9OTlQvdDRscHpaeHVQdmhPREo0MUZDVm9JcTZCdHJQ?= =?utf-8?B?cE1SSUd5WGJGZHZNU3VaanI5dTg3eU9JTkd5N0l3QjVsUmZxWksyTDZaVWZk?= =?utf-8?B?U25XUUNkWDNJdjlXWlhpVWFoek9PNk1ML3ZHb2J4THNyUzdYZWtMUWtGdlA0?= =?utf-8?B?ZEJvRnV3SUx5NHFZdVp3c3MzRGZBdThNWDhTcE1pcVZ2Y1IyMEdDYllTM0ZF?= =?utf-8?B?bk1vR2J1aWZpTmt1UGNGTXlMRmxCSm50bUFNRDVydWRmcmFYZVdwM0hTUTF2?= =?utf-8?B?OW05ck91RWRvbm80TXVMa0ExZkt0OWl4dFJ1NkJ2TnV2VVpPMDBtMU9JNHFr?= =?utf-8?B?SUtZeUpjMG1VcmtCUkYzT1NTQ2RWclM3TncxVk5QUUQzUmx3MUxIcG51NkdW?= =?utf-8?B?NktOUE5wOXRFZGVrMFBnZmJxWUpsaXpQcmE3MkR1T0trSnZJMGlLY1hZNmhz?= =?utf-8?B?UDBxQzNuMlpjaWtZYkZRVDZ0dGJlQ2lVWlIzUGRNbXlUOEVxU0dsV0w1M2t1?= =?utf-8?B?b0c3QzUrTGdPYlBnVjdlWDJsZks4blJJS0pYRlE4T1FsRTF3SjBKdzdLWUFp?= =?utf-8?B?SmdtQStKVUptY3VrTXNDUk9QMjRMNlh6UWNzL2N0WS82NHhDOTkxQjJJRmhN?= =?utf-8?B?clgya1dQbzNkK2d3RGZSTEd0d1AvU0JndEhWWUI2WFRjN2hZdFFadmRXUnBH?= =?utf-8?B?YzRxdk9vMk8vQ055aHhiV3JEYmVBNVpQUC9WaldYSVArbkJaQnlBR3pDQStC?= =?utf-8?B?NlhsTklDTkp4RGJMMWRrZmcyWUp4cE9lbjZKNDFWVWM5bklrOW5Sdk52MFQz?= =?utf-8?B?V0tiYXhra01ZU2hjZVUxSjZRaXFQaTBtTGlCVmZsbFlDQkRKN0x2OHptNFhv?= =?utf-8?B?ZmFWUW9jTFRkT3dOSEVna28zd1BBdnZ6THBYNytwMDUzbWhYWGNWY3c3bEU1?= =?utf-8?B?U2dKUVY4TkxjaDZXbmpWTTU3NUViMG95K0Y0dC91SXNGS1pNWGJmTTgvbHVI?= =?utf-8?B?OERmSGtIZm1lR2g0eW9JLzZ0T3FmaHVsMHBldWw1bE45QkdWZ3dJUW9qTmI4?= =?utf-8?B?T1E3ZHRLeUt4Z3BObXJVaFRCQnY0LzVmbzBUdytTN1Q3N1pVZ2JMYzhTQ2N2?= =?utf-8?B?TFRPdzBVM0IySDV2K0FtdlNEQ3dsSnQ3MFJKNDBUcTVsNGFpS0hIRjk5TnJS?= =?utf-8?B?QzdVbTZtQzRXd0I2V3F4Y2pKWVdFb1Z2UGZpRFdNV1l0VXpzY0pZcS9kZ0Ft?= =?utf-8?Q?cT0B7zKjKC6X8kWGgY3LW6g+5UFIeJcF1A/sYkPazFBu?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: d4590ae1-61b5-4477-49ab-08de2e2386f4 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB3990.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Nov 2025 02:12:05.7444 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: fP+MzWUAzMdSPueQZS3mKYoLcjTo0rXZ3gkD5SQJ/Dadj4yYe+oWvn9RzfGPmXpxqhov/uKELFQ7f8VvYifrKw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR12MB6617 `build_assert` relies on the compiler to optimize out its error path. Functions using it with its arguments must thus always be inlined, otherwise the error path of `build_assert` might not be optimized out, triggering a build error. Signed-off-by: Alexandre Courbot Reviewed-by: Daniel Almeida --- rust/kernel/bits.rs | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/rust/kernel/bits.rs b/rust/kernel/bits.rs index 553d50265883..2daead125626 100644 --- a/rust/kernel/bits.rs +++ b/rust/kernel/bits.rs @@ -27,7 +27,8 @@ pub fn [](n: u32) -> Option<$ty> { /// /// This version is the default and should be used if `n` is k= nown at /// compile time. - #[inline] + // Always inline to optimize out error path of `build_assert`. + #[inline(always)] pub const fn [](n: u32) -> $ty { build_assert!(n < <$ty>::BITS); (1 as $ty) << n @@ -75,7 +76,8 @@ pub fn [](range: RangeInclusive) -> Option<$ty> { /// This version is the default and should be used if the rang= e is known /// at compile time. $(#[$genmask_ex])* - #[inline] + // Always inline to optimize out error path of `build_assert`. + #[inline(always)] pub const fn [](range: RangeInclusive) -> $= ty { let start =3D *range.start(); let end =3D *range.end(); --=20 2.52.0 From nobody Mon Dec 1 21:31:22 2025 Received: from BN1PR04CU002.outbound.protection.outlook.com (mail-eastus2azon11010016.outbound.protection.outlook.com [52.101.56.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 11FB3285058; Fri, 28 Nov 2025 02:12:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.56.16 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764295933; cv=fail; b=GxHfXRnNWTP23oE6oZw9gfjiLFgsRS3WYznz8eT/lU8xHAb9ypBa+xzWzVZ0//aH71ff3HqF4JFGOTnavXyY3J8JkUyo/o0MC1Ae2+xAqJt00TuLpNOJmSsjo4Cfczc5pcfbAkmjcnyC539JNaRO8N5u1cZtu2oadtbp/IadiLE= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764295933; c=relaxed/simple; bh=hmrpWSgGkWcg/2un9r5d9OUvwyfKWSzPhBH6244TLhE=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=GDZhOYGkk9o9Z4MXftBLh3HkDeADEffbBhOsOoyW0vAV3b/wijEHmNw99VJGI7QznNEHCUjPrJlBZlkA2sbPgtXhFO32zdxwRnouxjkjqF6o9rgf9FEamQxRz2LZZWmsw13D+n22+djOeYmQws3ZfiT6GOcQfkQDlLoMwCqnXus= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=NwC1jOi4; arc=fail smtp.client-ip=52.101.56.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="NwC1jOi4" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=AMsJHpcCcDafU1tX5OdiitkVtUpaGLDL2S3l/TnVxJqDmbrFyZbJ8jE088Mr/Dt8RoSKQWWDu44u20b4zrb2ODiVOhR7rKzfdoxmTr8MgNHqI3YVzz00e+h0tzekJ5WsYGIEMFZT7kIJIOOfAxyHhInxsm2rKCfV57p/dk9gHckM2W+G9/Ta73P/kpsIl08xqv/AE9b2dZ21K+5585r6AhF/8NVMSGhJb0dYo7gklHv6gaI4Slqn2zQLau+/TH2dTB2+lsKvKVkbvuRJ/SX0CCHgR4yz9kQXRhribOvvMpwaAeuU3Q5RUKFlLfWE3GxZJaW7tvV2wcb6iaXD+6gCcw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aZIU58KwQva30PEjmwxY1XEMHhv//O2Yd2NRdCdgaKs=; b=Bolv4xFCptxA1eTZPay0giqkIENHtdvfSIoPMyc6mhH9M48ySPNXhxKty6/V2Ux88OeRzqU6EDTwSPDo/NOWPrChNOja3IIsBeI+rqtRiqmlX05UcqmMWbD7LHXPYSsY0uv2OHhsvJUuH7v6mM0236+WvbW2up+okMzsCX+/V7HAmtoQ7h437+WZWlzdqg/0mwCQjKOALArSd7k32X5hegOBpqgwsYY0io4689x/jPMApf4B255SVOil/cPVLRs+We6avuiWUPxrDzVkfbr0bEXzU83TywzNQjg4tORPeBzKr6W2dFPowp8GeReYLw81UHZdC5eNizwMqT/NGyFoeA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aZIU58KwQva30PEjmwxY1XEMHhv//O2Yd2NRdCdgaKs=; b=NwC1jOi4El9XLM85Y8WqsFabzCOarqKikzIMY8ZmxVbKK/65d1GEP8D433CBb9tzBSJ5rUlX7ZGgFviwntxIPkLqLvpsV607fxUz3TLi260wdtzGUVJxAOsgnm6lloLATIgl4kIQrhRIslFqm0CXKZ2uS/nWFiwTKk/xsfPmJC7DlfKBlL/q/jXIVRicwkB1M+FP884itP8agY3zw3phK+5J0L6g4Yl4wLzlU2jr/N3NnwcBvZDN9anQD24H6PlVy+bTRCPwX9sg9+aKSrElthr7s7RdbE4Wdb00Fp/L6ZIVfkuedlJBwe5wp9cnmcw9NopwVr7xhEQH6xTNVSjhWQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from CH2PR12MB3990.namprd12.prod.outlook.com (2603:10b6:610:28::18) by BL3PR12MB6617.namprd12.prod.outlook.com (2603:10b6:208:38c::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9366.14; Fri, 28 Nov 2025 02:12:09 +0000 Received: from CH2PR12MB3990.namprd12.prod.outlook.com ([fe80::7de1:4fe5:8ead:5989]) by CH2PR12MB3990.namprd12.prod.outlook.com ([fe80::7de1:4fe5:8ead:5989%6]) with mapi id 15.20.9366.012; Fri, 28 Nov 2025 02:12:09 +0000 From: Alexandre Courbot Date: Fri, 28 Nov 2025 11:11:41 +0900 Subject: [PATCH v2 5/7] rust: sync: refcount: always inline functions using build_assert with arguments Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251128-io-build-assert-v2-5-a9ea9ce7d45d@nvidia.com> References: <20251128-io-build-assert-v2-0-a9ea9ce7d45d@nvidia.com> In-Reply-To: <20251128-io-build-assert-v2-0-a9ea9ce7d45d@nvidia.com> To: Danilo Krummrich , Alice Ryhl , Daniel Almeida , Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Trevor Gross , "Rafael J. Wysocki" , Viresh Kumar , Will Deacon , Peter Zijlstra , Mark Rutland Cc: rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Alexandre Courbot X-Mailer: b4 0.14.3 X-ClientProxiedBy: TYWP286CA0013.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:178::9) To CH2PR12MB3990.namprd12.prod.outlook.com (2603:10b6:610:28::18) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB3990:EE_|BL3PR12MB6617:EE_ X-MS-Office365-Filtering-Correlation-Id: 0dc05930-8368-4ed7-9667-08de2e238911 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|7416014|366016|10070799003|921020; X-Microsoft-Antispam-Message-Info: =?utf-8?B?aitXMGVBQlFtL1MrMEtYTFI3YlovVmtiZ2Q5L0FZMVU4LzBsUllMWHNMUkJ4?= =?utf-8?B?SGN4YnFMVlRwNUpaTC9aYlVER2tJT0RYendLQlhtL2xkMjlFQmUzWVJ1ZFVv?= =?utf-8?B?NUdqNnpDZHRqNFJZWHYrdW1QYUtwdFZVVGtGMDExSllJNVh5WHJQUkh3ekMv?= =?utf-8?B?Yk4remVJQTd6Sk9xbm9nTkJmR2ZiV2J0UmcvTUozcVYxQTJxSlArREo5cTFl?= =?utf-8?B?bCt4ZmxXd3RYdzN2UXBlTERwRHQ5ZUpJU2c1bGVQUnRVbkFpamNncFZSUVZj?= =?utf-8?B?M1J6NzdIbllpWTZaVE1ZTFM5bHBGVEU4YVhjV0hXTDdyZ3ZTckgyak00aVQz?= =?utf-8?B?WTMxSEo2NUh1eUZmSGlIN2o5N3p6WkQyTURoaVZaeWZrbnk1Mk0zeUgvTnN3?= =?utf-8?B?ck9nVnJ2Rm5Xd252aFBYWmM5M3J4WkFOclNibENlMGFxZ0JhaEo3R3ZzN2hO?= =?utf-8?B?QXdpTklQOHBoZHBGUnlmTjBmdDYrZUxiTS9rVW8zeGU4VERzZ1ZKc2lOb21r?= =?utf-8?B?TGNvb29kU1hCemZhMk5tUlZDRHZPNXhHQ1dVYVNMZzI2Mm8zbkwrOWFvQXg0?= =?utf-8?B?QUVzZitrN3hXRHBPNEJEWlllczcwTUFHV3gySDdscnR3aHNlbkd0SnFSZGZN?= =?utf-8?B?bldUNFlXVUNLdzA5RXM5dlhjVUxNazJ4ZlE1b2JXUmRHdUZ4c0h3VWoyT1kz?= =?utf-8?B?TFhYeXhaMzZwM3dKamxSSmdCZUR2dGtRSldTZHZGZVdXUzRWOG1VZFd0RHNV?= =?utf-8?B?TGRMMVNxZWcxaXFyWk9lbzNNVC9HcUEyYjdNa0dYNkRlSk1WMkNzLzFLdTlS?= =?utf-8?B?YmswVkY1Z1UwRzAwR2xPNkhxWE01c1RBd1BCb0I1Y0t2VGV6VVhpUUZGNDgx?= =?utf-8?B?QmVqQjg4ZjRSaXp0ZFIxZjFHMmhSL3BBRis3a0VFQmxzQUdka1VkRTBDUUg5?= =?utf-8?B?bTNvaWdXZlpnMEJnVjV3cTZseGxCSERqNDd0aFREV2oyeVM3V2g3TFV3blVF?= =?utf-8?B?V2gxZ0lXcTRUdmNDdmtpekVpaE0wdEs2blp1cytJQzVxU1R0L3VINW9RRVFQ?= =?utf-8?B?Q3VUM3R3WHNKekFIMW45TzlnVWxXK0szVHQvSnNNN0wrUHluV1RsVlZpOWFl?= =?utf-8?B?T0hYQ2lTOHhSWWhuSWdEU2k3cGNTYWoySHpKSzJjZ0wxdG5XZ1haZlQzaEti?= =?utf-8?B?OVRLVUUxOExETk5MVmNDYkF1aElwQnVvN1A4bWhURGtGREJVYzl0K1VHRWdm?= =?utf-8?B?Q0dxVTg5bUxaN2xSTGtpNGtCdXJSVFRpQ1B0cHJ6VVNDWWx4Z0xUTXdpT3Y1?= =?utf-8?B?T1UrUDRPQWR2dGVVdW9QcW1NYjc2RlVacmJtZTRISXRRQThrdjdNWE42cWh3?= =?utf-8?B?d3ZUZjV2dXM0VUQ1ZEh0U1BkUVFBZ0ZjRWtmZEI4ZlFWVWxIMnZjcGo5bUVv?= =?utf-8?B?RkZ0VkZ0allWaVhWNmNsd0w1VHJWYnF3SFV6M1cydEtIbUFZbnhGSWJsSzVs?= =?utf-8?B?TDZ5Z1VqQWp6OUxvdlB6c3I4WFNMT1owdUJ3ajBEdy9uaWZFYnJYcDNTbGND?= =?utf-8?B?bDQzc1JaTDlDUDFNTVJBSUlOSTlDVnlsTTB6SzV5Y2M2V0lkdWovOTNsMWxP?= =?utf-8?B?bGhpRmdKRDJKaUFPZ0dZQzhnMnc5NUE0dzEvamtPNHFaOGVrM2E2c01yMWtm?= =?utf-8?B?ZHpEald3dEZlUTYxN3RiL29UcTVYRXlFZWNUQ2VRU0pkZ0RiNXJUdjI0QzF2?= =?utf-8?B?SXcrLzFzUmZaMGZUdmFOL1o2dVd3UFhCQlZjcElGd1N2a3JtRnhIb2c1MHJW?= =?utf-8?B?N094Rm5qZkFPMjlQcXcyYm1vQVRXdUNxL1I2QnJ5eHBjMGpxaVkwOHJyRUN0?= =?utf-8?B?WUZwSzNKcVdEdXpQVVRKdEZHZmU3R1VUMkpOdlB2TVdRbzQwL00xOEF3MWpY?= =?utf-8?B?cGVuTHNmSXFTZkhhOEk3WW9WUnMzemRiN0xJNUgxSnh4Mk5PMGQ5aTdFNE8v?= =?utf-8?Q?6Gvmm49HAod3xRpmXpGaS01NfvUwsU=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH2PR12MB3990.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(376014)(7416014)(366016)(10070799003)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cUZzOUJRK2NESTlYOW9xQXQ2azQ4dzNCc1NHWEtJb2ZHWlZUcktSSUlGUUZV?= =?utf-8?B?WGV0U0dKVVRaallKdDlzN2pNcFZrVzNaWHJkTDFJRDhmNmdCRWRvQ29lQ09Q?= =?utf-8?B?Y2FrL214bzNuZnhiQjZsYWJrK3dyaW1XaEd1NUlQRVkyQkZjMDNSUWYvM0ZR?= =?utf-8?B?dnFWNytKYnlBZkoxT2Q2RUpYMXgvNXBRY0F4SDBXcytkMTQ5YWd5aVlqTk1L?= =?utf-8?B?OEhPd1llQm9aY3p5Qml2VURnOGxjNUthZHdIblJvTGJDK0lUQmlidDJEMVhD?= =?utf-8?B?a2MzT1JkYko5VU5FRzBhRUFJYXEycFNVRDlVcWlxazdtVzdKa3lvTGFYZWZw?= =?utf-8?B?enU3aE8xVStKUzFvWG54ZFd6VkVTYkdqR2paNlJiYkpDR3kzd0ppOThZVTVJ?= =?utf-8?B?cFdTR3A3dkhYY3AzNHBGcW9IOHF0cXRjT1NXcUtCSzVtMHBBOC9IRjhkeHY4?= =?utf-8?B?Vi81cVNjRUZ2TG5zOTFhbXhhQ0lkd0ZlSXRUZGhyNXhuNGJnc2x0YllzdDV4?= =?utf-8?B?NGFuMkFmME9FL1JTcml5M001K21UTjBBT09qTXNPZk42aDBaVjdzc2pOWUFw?= =?utf-8?B?WFFMUU5xOURZU2pMUFE5N3ZvWUV1WHA3WGpWSU13Q3BuVGJSTklQQmg4d2NF?= =?utf-8?B?V0VkcVNtWGw2YXl5anVwaDhOYTV4cHBtOWxqanNSWFlRVjAyTElrQzl1SHBi?= =?utf-8?B?QUM2L291aXFSZHFOY2JuVUVnRjlpY25JV2dIcjVyRUtXNFQ1bFNvKy9yOW5q?= =?utf-8?B?OEI2T3RmYy9XT2Rub3psbXdnMytwSmlUMzdtdW1aLzVMV013SjBrSWw5aDFz?= =?utf-8?B?OCtFaU5rQlkzbE5NMXI3QTZ4dVBTWlV3enpIUHl0Q3dzajEwS2J4TWxlWXVu?= =?utf-8?B?QnQvbThaTThMTHpUQVZZTVk4aVNnWTlIVHNkVzMvUHpoY0pqekRVV3JzcVpN?= =?utf-8?B?azJxMm8wa2QxNG1xN0ZTWmdhb2dlTkJWRHlPZjd1TmI2dTZac1ZvaHZXOWtq?= =?utf-8?B?WGFFK2doaFdOVWNaUDlWNU0wbE5pQXQxbkJyTS9naGNGSHNIQ2dtOGJ5OFRz?= =?utf-8?B?cFoza0VTbVI5MkF5WmY1SkdLTVZZTmNMc1pLeitOaDZuRFNsK0tZMXVaVjcz?= =?utf-8?B?bG5tSVJwTis0dXVOVHNnQ3NLa21MUHB0c0NuVUtxTXpOanFRdG5PUzFSTm50?= =?utf-8?B?eG93c0RVRVFRMHJia2J0MHNZeVIrMzFXWWdQMWRNZlpKSC9aSitFVkpCdHo0?= =?utf-8?B?b1gyTWoyT0YrYTljTVhXUGl1c0VWT0JNb2thRkozZTZBbStUZ1Qxb0xNV0kr?= =?utf-8?B?dXQyS24rWHFrZ1o0OWlXY3k5R1V1MytFM2VJOFpFMVpLSkhkVW5icmZEM3Nq?= =?utf-8?B?RDVoTGFpUDlCaFZEZmp0MGJJRm1sYVBsZGZBRk1YVFZRdisyaERSMzU1OWVk?= =?utf-8?B?ZWh3NnBvVlhIKzQ2RkpMR1VnMThZcDkyUThHNXhPa1QrQWhQT0JjaWZuVy9M?= =?utf-8?B?MW1lM0VpOENNQTkvRVRCaHViOVBTd0VWaUozQ1JrZURPZi9ObGdDZG9mZVE4?= =?utf-8?B?TU9vMmk3L0NrZnpsQm9DT2JyUVI0VXZhQ2lKZzA3bFM4b0psUTlXenpTakJG?= =?utf-8?B?alU3QUMyNDF1eWUxeUFGVmdrS1hFY003S1ZoRUhiMEIwQXdHTHJRQkNJbURW?= =?utf-8?B?eS9tYXVtQXB0SmRLRlNxNHlaV29CK3VyeUE2YlhtNUZuekxoazJQZHd3QWFK?= =?utf-8?B?K0VlK2EzRERTVVJpMFFkcURIcWNYaTY0dG42RE1LZmtGTko2QVhGS1pPSkVM?= =?utf-8?B?ZjAxdXI3N2FpbEZhLzlVZ3FBQVZMdmUwVUYzdjlPMmVEM2hLeTJPeVpucERC?= =?utf-8?B?c2lsSFpZWnV3L0YwTzZaZXk1alF2SW5NZ091SmFHeG5XSTlieWNxWTdiMmZs?= =?utf-8?B?RS9zL0s4SEVMRkhIUEliRWRiWFhGWUNhd2JhRFU2aWhoZzNLZGxjS1dReEtF?= =?utf-8?B?K3Q1Q1ZRUDhJcXE0aDBuTDN1Y1Ewd3NoK1BRSnh1aDVKL3hKaEZlQ0N1RS9T?= =?utf-8?B?dUFGMVBFaDhzeWhCVDhaSisyZ3Z2UHd6NUl4RU1jV3dDekpRaXBHeHUwUitO?= =?utf-8?B?NDVaZ2RHZUZBSGRXNkQ5YjloNFIxSi9URUZIeTNaSlFQVnBsbFIwWmIrblNZ?= =?utf-8?Q?kAIbFZQCneyIDCLKgdLlYqSSWI5AH38D5BuDwZVTd2GM?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0dc05930-8368-4ed7-9667-08de2e238911 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB3990.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Nov 2025 02:12:09.2926 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /FlZRtdjBfsGjgPzpMCwvGXGvFs8zMmyUiU6Rdb9773PMu2wpUmR6UKAF1qzeRy/7srEyOwUA/bZybrWi7nkyg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR12MB6617 `build_assert` relies on the compiler to optimize out its error path. Functions using it with its arguments must thus always be inlined, otherwise the error path of `build_assert` might not be optimized out, triggering a build error. Signed-off-by: Alexandre Courbot Reviewed-by: Daniel Almeida --- rust/kernel/sync/refcount.rs | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/rust/kernel/sync/refcount.rs b/rust/kernel/sync/refcount.rs index 19236a5bccde..6c7ae8b05a0b 100644 --- a/rust/kernel/sync/refcount.rs +++ b/rust/kernel/sync/refcount.rs @@ -23,7 +23,8 @@ impl Refcount { /// Construct a new [`Refcount`] from an initial value. /// /// The initial value should be non-saturated. - #[inline] + // Always inline to optimize out error path of `build_assert`. + #[inline(always)] pub fn new(value: i32) -> Self { build_assert!(value >=3D 0, "initial value saturated"); // SAFETY: There are no safety requirements for this FFI call. --=20 2.52.0 From nobody Mon Dec 1 21:31:22 2025 Received: from BL2PR02CU003.outbound.protection.outlook.com (mail-eastusazon11011055.outbound.protection.outlook.com [52.101.52.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6FF47275AE3; Fri, 28 Nov 2025 02:12:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.52.55 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764295938; cv=fail; b=CtXfiOrz57oWi+6fwhApUMmLMQloGGAny4sb57A+9nYNezvZsNqiV2x9XTmEcd0WNZztQ0rrcCkAaiw6xKc/RxHRBbrkiiOW0h7sfxTMuNk/bMv87tX8UbBSKg3LxdsCov98sMsHwAvvyYd4udgGkyDn1/puIa6OHMMawIDGs+E= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764295938; c=relaxed/simple; bh=k1Tq2b8UMcbC/FhWncSwlXREffeopTkT/lsmDNsaIo8=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=noo6NwJLiXL/5vuaN+DxyzX0HiDyp9Ufly6AMcWKtr/lxaEDc8aQQqECXGUFCNQaGyRKLzkSRL05Du7bv9+IpIFRh7QFC6KnyuGAo3z1r4DpPqrfhs7ktt7HsJFWEuXc02qzSqfieIHo0FKpM5sv9AeEO5OcVZDlwihGtflzV2k= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=KRft4C05; arc=fail smtp.client-ip=52.101.52.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="KRft4C05" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=dA2HsDLtlmMk9yooJrpAl0UOekpWo3G3ZQSfYKsTraYfovD7b8wBQrm6lPga+hM8nikX9qH5tg2kZbU5hpxJk1CEfLSfA+pvrKIEybL+MNO1tko+DJEMfqboZBoQiAqBBqPJWjvTnZny0w3yx/RiEj57DAotKMwzsRxO2icR1Skq9haG/OzANuENtSX0qMNihW+Aj3rAk0XTzHVrVpunKCq4mC1PcWP49CG14sN11WBrLfs9erptP4fBjjpmvBujyjybDuKGrjDhDAY38I2Ko5nJQpC7AMDWbXIzPltaqtMxs38/uExm+TTj4Jgdqhb56ib0VTAVD1T8uVM5K3AIpQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MZfkWDB4X0ZVHJPctaFOSUbLLlKf/345cKFY5Oiu8Cs=; b=xteuKzmoaPDvhukkqm4yYcbk9kpuRMTiQYD9/j7XkunyTDFcLwrMGaaschs/Bm8M/4DGJ/0+VBihdCQHe1HLT78XmEn1jqw6GIaLq4HwBpsbkM5OEK7FD/cMUgHgt6XK3r0I/nhVGwuXS/eyMd8VHlIbbPTF6usOzn/7sCtTVNTc4eCQjBlriQS11gknyAVbmi/1pUDTzr/VbFdOKKJvaiq19BNaHGRA+OhJbVQlSpg5X56Kgo8DdJ2btLnI9JHOK2QZ2DRG1Q0g+3rLgNg03UzH5+dnkiXZp1IZfHcnS7ClmsQjXMZwK3T6JFS60n/PUtU++vcPE7UECMZzyoHPaQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MZfkWDB4X0ZVHJPctaFOSUbLLlKf/345cKFY5Oiu8Cs=; b=KRft4C059DQv38gi70ssZTzDI89X0BfYYfg9U8fiEZ/HxunDGe3BIuJ1hCJuHiqM+XJcfWx5xLex3tuuQ+BGvhgpcV/cBoabTsIH0E6KQvZLR0nU8WsLlLKu5HZoDVI2S0UROmj+Qmn1cN2yDACeaC0cEkHbhJ/alhxAaPL7TkV5TZTQ8I+B3dI8Isez2nYMpDjYACX6w6q/+EkHfSyNNQKLxau04AXfqj5enemkJteI1TC85vYfrNNp29MbDU6NaqaEKd/gC3rr90b2pRMN8aMeRo1xjilArh+iABHaBsXaKzyXwIiCpezW1Tnvcq7SJdP6g1EsMODmKPPhc32Cbg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from CH2PR12MB3990.namprd12.prod.outlook.com (2603:10b6:610:28::18) by BL3PR12MB6617.namprd12.prod.outlook.com (2603:10b6:208:38c::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9366.14; Fri, 28 Nov 2025 02:12:13 +0000 Received: from CH2PR12MB3990.namprd12.prod.outlook.com ([fe80::7de1:4fe5:8ead:5989]) by CH2PR12MB3990.namprd12.prod.outlook.com ([fe80::7de1:4fe5:8ead:5989%6]) with mapi id 15.20.9366.012; Fri, 28 Nov 2025 02:12:13 +0000 From: Alexandre Courbot Date: Fri, 28 Nov 2025 11:11:42 +0900 Subject: [PATCH v2 6/7] rust: irq: always inline functions using build_assert with arguments Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251128-io-build-assert-v2-6-a9ea9ce7d45d@nvidia.com> References: <20251128-io-build-assert-v2-0-a9ea9ce7d45d@nvidia.com> In-Reply-To: <20251128-io-build-assert-v2-0-a9ea9ce7d45d@nvidia.com> To: Danilo Krummrich , Alice Ryhl , Daniel Almeida , Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Trevor Gross , "Rafael J. Wysocki" , Viresh Kumar , Will Deacon , Peter Zijlstra , Mark Rutland Cc: rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Alexandre Courbot X-Mailer: b4 0.14.3 X-ClientProxiedBy: TY4P301CA0011.JPNP301.PROD.OUTLOOK.COM (2603:1096:405:26f::11) To CH2PR12MB3990.namprd12.prod.outlook.com (2603:10b6:610:28::18) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB3990:EE_|BL3PR12MB6617:EE_ X-MS-Office365-Filtering-Correlation-Id: fdde30cd-3d3f-476d-2966-08de2e238b42 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|7416014|366016|10070799003|921020; X-Microsoft-Antispam-Message-Info: =?utf-8?B?RUxSTlVMTWp0Rlp1NENPQ0RmSXk2WjJLYmJNbzdJZW84QTJNelBxSG5EZnZw?= =?utf-8?B?RGFjZDlvS0kyNmJad2dlMXUrS0ZyUGQ3cEhja1VvTUpVUjN5ekcwK1lnRytl?= =?utf-8?B?NEs3V0Y0Tm91N0xjd05tWlExamxWY2JBK0N1Y1FyMUZXeFJpK01IaVZXUHVw?= =?utf-8?B?eTRVZmlsbDZFMUxsVUZSYU1iUE1wTWo5Q2x1SEdWMEdVMVNrYlNzRVJQdDhT?= =?utf-8?B?bjFXdTJNUVBpMmdVOG9kWTRoY1E1STcrM0hUUmc0RDBKWjJKUVpraEhhTThP?= =?utf-8?B?OE5VWDdFdTEvdnNjSE1nOUlXTWNRL045S3Nva2VtNXBoMERvc1hWMGdRcDRO?= =?utf-8?B?MlpJZHN0WTF5eFNpR2FoUkZ5WGR1ZzFHZU11Rlc3TkhmVHVVWDE2YnRTS1FT?= =?utf-8?B?amdHdnZkd1lkcWd0ZlljK2NYL091RXJ3WFVTZXFNV3UxUGs5UVpMY0tyTk5C?= =?utf-8?B?WDhQUmRzQ2NnRWljdVpyWTdjSlJBM1VoM2g2bVlsNThFSXd2QWFmR3o0ZUdi?= =?utf-8?B?VDRhTlhJVE1UUEpCMWY0U3BLbFdGemE1QW9aOVBFc2VWam1KenI1RDdidnky?= =?utf-8?B?cWd4ZE5vbkV2a3FQcWNNbjcwVHNSQXFDdW82cGRLUkUzRHcxeUVJcDhESmg3?= =?utf-8?B?QkN3YkdtN3ZVdzVKaUNGSU5XcGJQM2U0NEJLczloUjduVTB0WjVvcUt6ZXpF?= =?utf-8?B?SytVSVlzRHdPRHplc3M4RnZsNEQrcHdFblVSTTV4ejJVWVdwQjJEdE96c3N5?= =?utf-8?B?N25IT0pMOFpEam1qUnFwWjRJbzdsZXIzdlExUDkyTHJ3MU5ZQWloK2wyZUFI?= =?utf-8?B?S0tPRnpucWFHNFZiejFwSzNlOTZiNGtkRzI0OW91WnZjUXJ4dVFKYi9iNXYx?= =?utf-8?B?T2hGV21KRk14cU11Y0s0RmFSYi9vTVJOWk1ZU1pMcHp0NVlmaHMxcW9Xa1dF?= =?utf-8?B?bUtvRjNuVDFCWWtROTJsUEtXeFpjS250MnAzNWl6UzFKZkRIa0FjN09Cc3Zp?= =?utf-8?B?VVo0cDJuSDl2VXZVVmhENTE3ZlBZTXBoVkcyMG1PV1czNDJOektKb2VPcHRm?= =?utf-8?B?Q2JnUGoxN0ZmRDV3MXNlck42QWJwUmp3MkUxL2h5cUZoUUlLWURIRHA1N1Vx?= =?utf-8?B?aTlmVUxwZERIWE1KaXBJdVYxeitCK29pL2FOa25qcWQ1dzJnbjFKV214U05X?= =?utf-8?B?Ny8wTGdQYjBIMXZxdC9YL0ZETlZGeVpGcVNLditwTDBBNHJIYmFjTmNEVDNk?= =?utf-8?B?dlFLcEYyMStHVkh0MDFuL1BSVXl6Q0wxVUhGMFRhSEhkdktYQU04WVhiTHRD?= =?utf-8?B?aGFpYnkreSs1OFd0djhpRjNLMjFIWE9ILy9JU01OTEtZa2RRMWFnOTE0c0tF?= =?utf-8?B?Mm9pODhVd1h4VTFMV1JLOFIxU21iSVZsSXA0YjZTK3c4WEpqZzFhQnJodTht?= =?utf-8?B?eFdtUUtjay8wWHZkWUhFK0dEY3JyeTJsSldNVXp1K0tic1hRYzdUelRXdThW?= =?utf-8?B?TkR5eGhQbGN1VlRXWmtORzJWYUxGR3RwbEpNWCtFaGhCdWRIZ1VpdlFzQnBS?= =?utf-8?B?OGdHS0VXbE45MjlkYWxxbGVxYjdUd0FSaXc0OWJpTWxoSFZJRkNMWEVGSHlz?= =?utf-8?B?SmNUZVoxc0JkUVFrMXRrOWtadVp3YzdqZi9NS1UvdmxUZXhCWVVrUlY1YnVx?= =?utf-8?B?ZkxlOEVBNFdkbGlMNml6Vld6MGdrT3dVMTZ1MWk4akRBTmNtdWNIVU1LRFdV?= =?utf-8?B?MXd6T1FDMHVQMk1hMFcvMUNxK1Fua1VDM0NmUjFxZlRvZkR4ay9PME5kY1Nm?= =?utf-8?B?MVR4dEZMaEdwTEZRNGJsS0xaRU9acXZHb3dpRkNra3lSZXMycDUxNVdzZW91?= =?utf-8?B?K0tOSG44V3dWTG9ZVVVnSEtVWWtQUi9OU29DRXRiek5tdzUxVlgxOWt1UVZN?= =?utf-8?B?WDVHMG1xajhlNitMVmRaVDRyZVpzdHJwd3lzRkQ2SnM4a0x2MlpvSFZwZXYr?= =?utf-8?Q?T3uqkiXYUZaC0uybNTbLucb5qJ2els=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH2PR12MB3990.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(376014)(7416014)(366016)(10070799003)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WGIvYnZpaDVPb1p3TFpyS1RUOWhsN0RmaTlFeWoyRW9qRDF4K1l1V2xTRy85?= =?utf-8?B?MGFWN0MzNTZYQXlJQ3Z0c2c3eVZWa1Q4UmgzbTNaczhES2hvMi96RHJ0Z2Er?= =?utf-8?B?NXpNMjFQWjVYbUNPcEpCRURlWXhzVUVPQnVSeFg0TmhPcmNod3RhdW4reHJi?= =?utf-8?B?TkJGMTlGNDZPL01DQ0d0NUhURDVUeldMOTE0RGEvYnpWWEVqOE9ZWHZ4NlBW?= =?utf-8?B?cEtTaEJ0ajVFMStJTWtxeFRvdnlJRUJrZEIwM2Uzb29lOUJQd3JERmFZYjVp?= =?utf-8?B?c014ejdSdUtYM2hVY1AwTWxLSDA4anIyd0FnODgyelMxeXdMSWp5UGd1WTly?= =?utf-8?B?Z2RIcmhUalg5SE9BTnNUek9wMHUxZEJhSHNWZWt2cmROSlVJZmJmcDBlZFpU?= =?utf-8?B?M3ZGZ1pLT0RjVVFZbnZZaWdleitLbmh3cFNvUStRMHU0U3htL2g3VUhWM0lq?= =?utf-8?B?Ty9ZMlI0RGlNS3hvT2JrUXd0VkxEZWFKSmRSNnRONVFVcmcwTnE2d0l5S2VL?= =?utf-8?B?aFVmRjFNTjZEQlVhU0hTNG00dkYzdGtQZklNc2NkaWN2SWVxcWc2eDE1U0ZJ?= =?utf-8?B?bDAzR084RGkwUzZaMkNEZGIvdTZWdDRkOHNSRGhvMnljdFpjUUhMUXRRWHpN?= =?utf-8?B?c0poYjFZRUxLbFJjOU5TN0NKcVpwcytaRURzdmI0akRRS2lXTXRKZVYxLzVl?= =?utf-8?B?eE02c2g2MEFpQUdkSVBBUVR6cW85YkJUL1Fxa3kzZ0I4RjNJc2lZTUk1TlE3?= =?utf-8?B?UVFGT0tBMXRRYS8vSXZlZFpYZ21PaytMZHdBSDNYQWhVbjliK1hPQVNqRWR1?= =?utf-8?B?S3gvN1RRVFgzRGFZZEprbnpYYlZuam50d3ZoTDlLUk1GWmpVdStKS1NjeUZ0?= =?utf-8?B?dXpCeGFmbGlQendVTXNCaHBoYUFqUU9ucFN0T1JPaVVWcGdWNDJpRjdyQkti?= =?utf-8?B?MlI4ZzRVMUk2dUVhMGRrbVNJQ0d1MCtta1oxWUNmQ2d5U1h5Q09iWkRON0JY?= =?utf-8?B?T0VoaW42UE9CLy95aEhtM3hlOUJRMVZtb3BRSnZ0TmlYaG1sSjl2TnpCMk9r?= =?utf-8?B?QS96bUdCUncyWGN3eDduNUxHNlFFUXQrVmsxeWRpVCt5VjdwL20yT0Z5Y3dR?= =?utf-8?B?dnZmSjlyNWl6QWNOVVZ2Wktva2V6eXVweTR2V3BWT2IrNm1KWVpCdDlGb0xt?= =?utf-8?B?VXVSZGFoeS9rMUQ2SE1valBEUG5YcnlQV1MvOFprYng3ZCtRYUxsT0M1WlB3?= =?utf-8?B?cWdrRG5ZYmtUWGFWVzk0VGQ3QTBhWVRWWExEOE42UzNPZFFFVFEwRjZnVHdD?= =?utf-8?B?MDF3cGd3VDJqUjkyOFB4SXJHVDA3U1VTVkxzbXpDRFFzTTREa28vMlZTOVN1?= =?utf-8?B?ZDYwaUhLSWY4WFp4N0t0NE9kSmJqTllKQmtPQlB3bnN1Qzd0Rit3azdkYTBQ?= =?utf-8?B?b1VmR2hwTU5MWHVoRkFVY2MrWi8xSXVQUXhSSTlsVVpwY2drLzNyclVBMnk1?= =?utf-8?B?SGwxMW9GbjhBWXVQcXRGWHNyeFVJejBlbDhJRkZPVDVlSjMwK3NiRmtuaUE4?= =?utf-8?B?N3FvOEJDSXlqK1BWMEd0Wll2bFdVQjhaTU9uNzQzSWF6c3ozcVZBaTdSK0Z4?= =?utf-8?B?ZXNzM0JZc3hPcU50Z21CdkozRU8yVUNDM3FXVldRYlg0dWZieWhEcjl5K3pl?= =?utf-8?B?d0swYUI0b2o4bWRuSEZnU2NDZXlBYTg3TEo0azhQa2ZNd1A4ZG5NYWNhK0NC?= =?utf-8?B?UlloWU9hdWtiSHJ3MldON09lcDVkK3ZMaGMrQzJaaGF5UjJiR1RTRkI2SVFj?= =?utf-8?B?Q2Q5dGJYUXRteXZaaFJaWGhNWElIcW5PT25LV1p5VjJ1VlJ0S3NtVTl2S3Y2?= =?utf-8?B?MUNiSDlRcTlTK2tLNUR2TmlJVUhBTncxSVNDNWFSNXFJTmhaNkhUWHpEZWkr?= =?utf-8?B?eS9FbXVnM01Oc3hkVzlEemJJZS9KdmxndEpPS1RDY3l2Tko1bE9kQzNpTXRQ?= =?utf-8?B?VzZBNzh4eFJBVXBRTmtXeTR6aGltYS9EYVE5QmhwYXhOcVVQS2pEN2l4d3pC?= =?utf-8?B?bDIwQisySjFiOWpObnhtRlF5K05QcEgvbENqTUZTRGE3Z09XOVZ1Zk9yVUts?= =?utf-8?B?WnB3SVZsZVpSVXFqUXBxdVdqNnNldDlCem9id0xrVG1iYTlJZUF6Nlh3bnh6?= =?utf-8?Q?M6Zcf2wgBMcIqZOEpfxJrrRL3HbQrDbRmIB9MoUPbQ4N?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: fdde30cd-3d3f-476d-2966-08de2e238b42 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB3990.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Nov 2025 02:12:12.9362 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: aCOGg0/64P39BysIbpBNiWbOKwmxzzzSNWMzkiKxLLCqOSiqtR+pmzUGl2aMzxF969tEBkzNa+6r+5Dc0PKWig== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR12MB6617 `build_assert` relies on the compiler to optimize out its error path. Functions using it with its arguments must thus always be inlined, otherwise the error path of `build_assert` might not be optimized out, triggering a build error. Signed-off-by: Alexandre Courbot Reviewed-by: Daniel Almeida --- rust/kernel/irq/flags.rs | 2 ++ 1 file changed, 2 insertions(+) diff --git a/rust/kernel/irq/flags.rs b/rust/kernel/irq/flags.rs index adfde96ec47c..d26e25af06ee 100644 --- a/rust/kernel/irq/flags.rs +++ b/rust/kernel/irq/flags.rs @@ -96,6 +96,8 @@ pub(crate) fn into_inner(self) -> c_ulong { self.0 } =20 + // Always inline to optimize out error path of `build_assert`. + #[inline(always)] const fn new(value: u32) -> Self { build_assert!(value as u64 <=3D c_ulong::MAX as u64); Self(value as c_ulong) --=20 2.52.0 From nobody Mon Dec 1 21:31:22 2025 Received: from BL2PR02CU003.outbound.protection.outlook.com (mail-eastusazon11011055.outbound.protection.outlook.com [52.101.52.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 25996288C22; Fri, 28 Nov 2025 02:12:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.52.55 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764295941; cv=fail; b=BkfhS13kmflIyqH8L9NrFjgndxSg0im1NgrUbIMmBOQGv6dLN8RKXCG0HC+FQpsUE1hy2NiBVo0XBjnRkEM/uY2EGMW+ic+sJ0oyjGtcaTn/K4CbvCp4KR0h0jUyRcDabMWhd6XPCqRGca5tliKLmF1iicY2p3m7XipuRPrgiSU= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764295941; c=relaxed/simple; bh=zehF8VCpzf3Iqux5VaRwCklmOI+AgJpuK2LSFVLa6HI=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=szeyKWEWWmWORXgxvjVOurHq+GLxpW/O796rvpYHKxZZMZifYsSxC2gFB9hoWKmrPoKuzDCjN5hxTNTwQ887RdD1RHYmLfg/lnrDA5HBrYzsyTGvNelPCe2I1ESsBRQYED+qw2sgiO86HczsxYzyf3rt1qt1H3J4uJc2C0TS2FA= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=GXtedSbh; arc=fail smtp.client-ip=52.101.52.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="GXtedSbh" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=xb0XhLHxlnqPz006CxIB6OAajDaYtzWub6MRQ6i03+nMsSlj+WaelpM09tlmnnAO/e1C66IlqE8/QtbPUFCK8koRzqBe+2FIlp/8JzFhNvRstfwWVCESUJOCUbDuKMHVjXNF543lyrIAK5fEXD9PH6fTqwzmp8TLqLC6AGz7CA24mjPbSLGnF037sMjp1HnAJk4MCdPi94JmvcNcNJz6taLHkD2Dy9k70/D9y5TqxkYcez0Vs2Tts1HqzVVENnHOSaZ9v63tyCdRc9L8bdWKnqrVYSyEzaCuQ0aL4QXVvJLKWhkJGKTzRtYXnj4swCBCyctQOKFZFCgiueeM5E4JmQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9muJdHVxe7Yozouz4JFkjmrgdh/pzFJFa75Jenn2hY8=; b=Lo4pRP2HPw5vTVyvdXv3FTBU7c8AvrFWshHp34Z1uiQaGBjsEOHYIed4c59Fc5rDQKnuwYK03gbmj7PbHsHE+B80hgzCyG6XxUomBmuKZTEg6I4mGg1mwC8nzarTYqb30xCwCf3MFA196Opxt9Pfjxda5UdJ5tG9K2ezWTT0yOv3pcXb3vmeNZXXc1GQLTe+QEx6sHXEWjItowjp11uLPOwHN0aeCIxYnODi2wEbxo5L7H9MfhBb/j5Mw/D8gE7L8NtwWjfT8gvUzLYQ6A5/eCuNrU6U4Q7tFTppLcKZGg0LcaT3eXaSQxWl/+cnpH3I6/y3lfJIkWltdI+PEK3v9A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9muJdHVxe7Yozouz4JFkjmrgdh/pzFJFa75Jenn2hY8=; b=GXtedSbhmsup1P9WCTlmCIcunCukgs+ZzAyL6PwYdwJC9aSUVBXQCIV8MT2ZlNxt4i7fbNeR0rk0fcPaGSZ71xDpjiaxrz1/q0wEZpk19UjxOKttsUS8WK0YO9Q1pFEucqVQMWJ4funCusxI2six5NaC8rsHogvZVPoXQctrnqoI3KROvVItJ/v8HaXwDiQ1KQowYaX0PeIEJ04s9nGUrGg5TVXT+VjlPgBqOygtIKUPXn7xziAD68yVtNjQpvzFKw/HO1Q8Jmmd3OryOC2Kz/jKx6E3/hp6+GKZUk7DwJhaenvKLs1enhXVy+U2l0555UN0U1IxWXgQMceinnM+oA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from CH2PR12MB3990.namprd12.prod.outlook.com (2603:10b6:610:28::18) by BL3PR12MB6617.namprd12.prod.outlook.com (2603:10b6:208:38c::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9366.14; Fri, 28 Nov 2025 02:12:16 +0000 Received: from CH2PR12MB3990.namprd12.prod.outlook.com ([fe80::7de1:4fe5:8ead:5989]) by CH2PR12MB3990.namprd12.prod.outlook.com ([fe80::7de1:4fe5:8ead:5989%6]) with mapi id 15.20.9366.012; Fri, 28 Nov 2025 02:12:16 +0000 From: Alexandre Courbot Date: Fri, 28 Nov 2025 11:11:43 +0900 Subject: [PATCH v2 7/7] rust: num: bounded: add missing comment for always inlined function Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251128-io-build-assert-v2-7-a9ea9ce7d45d@nvidia.com> References: <20251128-io-build-assert-v2-0-a9ea9ce7d45d@nvidia.com> In-Reply-To: <20251128-io-build-assert-v2-0-a9ea9ce7d45d@nvidia.com> To: Danilo Krummrich , Alice Ryhl , Daniel Almeida , Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Trevor Gross , "Rafael J. Wysocki" , Viresh Kumar , Will Deacon , Peter Zijlstra , Mark Rutland Cc: rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Alexandre Courbot X-Mailer: b4 0.14.3 X-ClientProxiedBy: TY4P286CA0024.JPNP286.PROD.OUTLOOK.COM (2603:1096:405:2b0::8) To CH2PR12MB3990.namprd12.prod.outlook.com (2603:10b6:610:28::18) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB3990:EE_|BL3PR12MB6617:EE_ X-MS-Office365-Filtering-Correlation-Id: e4edaa59-1896-4a9a-daf6-08de2e238d51 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|7416014|366016|10070799003|921020; X-Microsoft-Antispam-Message-Info: =?utf-8?B?SE9OSXRiSERneTZXMElYM3l2VjMvcWFvd0poSk5QcThTQkxiWUlsdnYrNktr?= =?utf-8?B?T05Ba3hQS2krUC9jeVFIUU1Ta1RLR3o0SUNPOXJkZkFwV2JSYkdRWE5jTERF?= =?utf-8?B?KzA1dGlEcTFiVmRJai9mQkNkWmpqT2FSSDhNUDZPMStvUFlQRGNVK1RHK3Nw?= =?utf-8?B?endUYmhBbk9zWlF6MTZOVklDb0YwTW50RjhuVVJlUmtvdUgxNzBVSGJuWXZx?= =?utf-8?B?dUJhRHpvMmJMc1hvU3RCcyt1OGRmSWdHK2hZemEydkJRZWw4dGNDSUdYQk5Z?= =?utf-8?B?eXU1am0yRXRZak0xRlJwZlVJaVRDdTJYMWhVZ2VQN0o3eUtVamRoREdlYlVM?= =?utf-8?B?MXVKRk5aV0ZkZUxrdVl5bWlKa2FkREtUUjQ3T2NLVnVvTlg3V1k3MWxwNWha?= =?utf-8?B?OW9XWGFYT0RPV0JaM2RSS0JIYTJnY2dEamlxWFpkanVWenJJTXZZZG5ZdGM0?= =?utf-8?B?MUxqa1VOaEZvakZtS29TSlhLT3lGZXBWR1Z0K0Y2OGphMzg5Sy8zWlJzQ2dv?= =?utf-8?B?dlBTVWZtSjVSWWdTV3hTUHFQVldlK2pROFlpcDdBTzY5ZytuTnVuaWpxVXpt?= =?utf-8?B?ZklEK1ArV2RCY3d2cVd1WGZUTnpoRjJtMVpoYzdQdkN3U1VCbzlBVnhzVG5y?= =?utf-8?B?aHBvVUdDRUVoWUFVY1BpWjVXd2cra0NjbmRHMUVEN3JQL1lzeTJHaXdYRWc5?= =?utf-8?B?Y1NlenhrUTJQRU1EM1d5eGhxTUVUTFh2emt5WG5vVkl3WjdNcjNkRlZVQkNl?= =?utf-8?B?RGJ4N3plSTNJQm9TenVBTE5FYk8wTFlXN1d5cVFGTCtuT01DTEdiclVhaG5s?= =?utf-8?B?Q3Q3ZDYrbC9rMStIR1hYUUhIb3ZYcXdFYWFESWkwVDMrY29SODVhZGRXYldt?= =?utf-8?B?eVZyYnhlcXgvaGl3ZlhMTFNpTzhwQzduVXplQ0NNOStIY1c5MHpHVDlQbS8w?= =?utf-8?B?T2x2NSs2RnU4NDNXRVNabU85eS9wR0N0b3dMOG1SMHhocFEzaVFTMnNRcHVV?= =?utf-8?B?bVkyL2hqL3MwYzljVkFxZnNNNnZ4QTA2Nzc2Nko5OWh0Q0lDR2oya2c4TTBh?= =?utf-8?B?d1Y3Umw0c2xRU01HcXB4WndvZkIzVUZ5YVdEOTkycFJ3WG5weTBpSmlXZHQ0?= =?utf-8?B?WU1BYUpMaDdEbmNJZWt3ODVsbVczRFE3NVROQzllZDZkVDdCNmJsRnRET0lh?= =?utf-8?B?MkZRd3kwdHN4Q2k1RklhVFRRN2g1c1UxUDlVbW16S3ZTZkNJd2hvZVJ5MGhN?= =?utf-8?B?R3cvV0xhcWFDSXFNN01td2dPZDB0NW5TN0VBcXVjZWhBUFRncDNRa0tXVUZQ?= =?utf-8?B?S1lnN3JxR3N3KzhubkJMbit0T1pmQzJ0WW1tRTFScWVLek13dXNBNTYvU2tt?= =?utf-8?B?cUs4aWIwT2YyTjFVV1NkbU54azZHa2RtdzZPMzFjb3JvRFk5TENMZDNxSHAv?= =?utf-8?B?aytwQnc1a0VjeFJmMkEvTktpMnVvekxKN3QvKzIxYTc0RXpybUNIMFk2ZCtQ?= =?utf-8?B?VGFNNGluVWVpR3YrRE9YZjF0SEs1N1FsR0JEQVp0c24wWFFFWUdrdFR0TzBE?= =?utf-8?B?OEVzdFAxKzFjNUczSjZKNTlVMnpDT3dmWG5scDFtbUYwT0N1RlI0aUtadVlK?= =?utf-8?B?TTQ5S1doR3MxVmZMUGN5WXByeFdGL2cxdGdpbnM2bXdlSVFXQVh3ek5Ud3VH?= =?utf-8?B?dThrdzlzVHVISng3dGVURE5RWHZiUytwR05rcUtYOGhOVFZtTzJjb1VYcllI?= =?utf-8?B?WS8weXBCa2dhRzl3OFFDRHNDaExuRjN6eEdYVmxaN3NtbEJlYVBEWGdYRXIw?= =?utf-8?B?UFh3bk1YNU5nSVJrWHlySFlYbmt4eWpnUXdNY3NEdWtwNENnR0Z1dlBZY3B4?= =?utf-8?B?LzMwUVp3Zlpwb0loOXNRTTJqQUUwbFdCT2ExRlBjL1BGZUpqLzFGZXFRU25i?= =?utf-8?B?R2swTVpPOEdBbk1kcnVMdHBSTmVFK0ZMTXNLYWliZGdPN2cvMVF3ZnFUSWxW?= =?utf-8?Q?9CuBrbWZxStI+BQG+fc6fZORRq0tx0=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH2PR12MB3990.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(376014)(7416014)(366016)(10070799003)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bjYremtXNFRaQUlOb3o0ZzVFR2EzWDc0cHR2NGtaRVBhVFc2aVpIZW1zUXEx?= =?utf-8?B?Uk8wV25rbmNuWEJBcFljOXY5OVVWUW9EbnhsSEJnRUI4SGV1ZEJPWHBEL0tI?= =?utf-8?B?QWZuODRKTElxT1R1ZTdTZUE1VXQ4VjB4eEdGcXYydVVtZ25oMGQ0WGd0cHhq?= =?utf-8?B?aWpQQlZaamNTR0k2eUdlY3hrVTdrN01YbkpkaTY1azhRMmxZTzA4K2djTXM3?= =?utf-8?B?OGdTMzFHcVRKeWJhWFFLdGxSMWdrdm5EZmtJYnJCODdPbmdHcHUzZGJNYzhB?= =?utf-8?B?WlF5YWc1aGhMaVpwUnA0T0NnMkNvYmliaWswemdwY3VOWGdNY3QvdEhEN1Y0?= =?utf-8?B?a1QxQjVnZ05aWmJTWENGNFlTTE1QMkcyQ0d6TmZvRkFnQlNmQVVZQSs0bXlO?= =?utf-8?B?QWZpMG1iQUpqMlY0bjhtRTZONnJsSy9TWDdhajBSYmtscGhrbGdJc1NHalhE?= =?utf-8?B?clFHT1pWSFJYRVlDdG12RGFCQlE1SFpNOEcwZGQrME1PdlNpcUF3aWlTdUQ5?= =?utf-8?B?dE15SVpHYktBQU5Vc3BTVER3aUJMNVNycmF4WjNhWDdaSVd3cmNzdkx4Q0dN?= =?utf-8?B?Yms0Y1RIZkFrUXdZRGRObEFDM1hxejlCWjZFVkQ0a0hJcmhlM2UxeVZKWEFW?= =?utf-8?B?M0NYSU1vOWhOMnpkKzFTNkpCZC9FaGJrYnJoblZUbnpwN3lqUzU0eUo5Nzg2?= =?utf-8?B?S2RweUZTZmlLdWozaGpHNXowaGRvcnFWN2QrZHE3VTNZS1FaR1EzVDVyYVkz?= =?utf-8?B?TWZxQktWdlYwRFJmR1hzOVRGTXByaEUzRVpSZFJKRHRVM1FzeWF6OGdXVEFZ?= =?utf-8?B?WFB1a1lvbjZ3QUY1M1J3M1ZWZ0FNL0U4S2d3KzJQUktGTzUzdzRCRVo5ZVh4?= =?utf-8?B?VThOUkIzU1lsWElNa25pK2NKMmNLZERVR3YwL0k0N24wN2YwdnFROVc3TnFJ?= =?utf-8?B?MDFOb2h2a1d0ZUx4RmY3UUtOTWNFU0NZbG9YbTMwVmNsbTlicUhNcDFDREhH?= =?utf-8?B?SGhwTm9iWG15ZmdlUEhWT0lBSE5ZRjhSM1l3MUtRanBMTVFYSlo3VURjVWs2?= =?utf-8?B?Q0k5Rmh4VThaZWVUcHZtWmFRaUw3K0cwSHdWQVdwMUIycGx3YUNQdGt0OFlO?= =?utf-8?B?cVJVZjhRSW9VUkRGTlNmSWhGS2huUW1uNUhQUFVTeFdSd295Rnp6MGVPWFpX?= =?utf-8?B?VEtZUEgyR3duVGtPQnJ2L1EvNDZLbUpEYk9NQ2NUMWEwUEV1bGVYTktKcjNn?= =?utf-8?B?ZzJ4blFhdFU5QnY3OFByTHRRaUoyaXdkZkk1NnhkUUFDT2NkSXJsTTRpZjBB?= =?utf-8?B?RGhROU1TRUdhdU0xRjBoSHFhQk1pMk5LQnpkOHM1VDlXMHZjUVhrL04yd3BH?= =?utf-8?B?dEpudDlpU0NrZENUWWRoMDBZWUpacjMzL2ZQZzBTV0tsbnBZdXExb2gyYXdD?= =?utf-8?B?a1BKOFAxUTZwc3NGSlRhSG1VSkhxVmMwZXpoOXAvZ3p1TWxtSGlqUzJ5NUUr?= =?utf-8?B?K29WajZjd2o5MkM4REJVSUhaVkVSZm40MXdRQVZzS3lpR2F4UWROWGpvODNk?= =?utf-8?B?VWRJbU1tZXZYYzh5MENUbElCaUhYVHFBZnliK01JVG0zU1NUalBtV1l6SXhB?= =?utf-8?B?OElNQVVpdnNPb2lQTjM0TjhqTlNlL1pDRlF4ZWp4UmFGeWFmb3JhTVJKbUh2?= =?utf-8?B?Z3J6SnFDeG14UHJRWk1jTVRtcGVYQVlNVFYxMElpcEwxM3k3b20rVGZweTFY?= =?utf-8?B?bUZlMVRDYjk3Qm5MdytBRE5paGUrd0EveGRuajNZVG04K1V4OGZZcytyNCs1?= =?utf-8?B?aDM4U0srbko1Sm1YaXAxbWtxaFZSWkJtT2thYlhaK2N6OCtONEE2SDlmZ3Zo?= =?utf-8?B?bmdPcXZPWEhaQzV6Q3pySkhKaXNOR0U1bzNPV3ZOVnRuVXdNQnc4eGtsNHJ3?= =?utf-8?B?alpHZEJvWUdQRDIxa0dvM2NzYnhBZ0pxN2FabHpjSnc2OE81Y3ZUZ2dqV05L?= =?utf-8?B?RUNBRm1USzhJaE9LRFh5WCtBYm5lVDNWM3M5UmF5dVNmRnkyU21jenlETTgv?= =?utf-8?B?S3BVN2VhMmxpSUVCMlFyMmQvNnJObGFLTnluNGxKN0JuRC9DNmk1VkpPdGI0?= =?utf-8?B?eGFEc1luaVp1VUV2cnVQNndVamRvTTkwS2JIOTd0dElTYTZ0djFqOWxiY2dk?= =?utf-8?Q?I14uyJVknZaZam8gkDNpbezNJa/PJF/XDYUYCuyG7wYq?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: e4edaa59-1896-4a9a-daf6-08de2e238d51 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB3990.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Nov 2025 02:12:16.5513 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: OwldoXcFCp8LFKEOpb3en/qSKSvNG9BpU+3SgsKVC1FyD9Bd3zErpxRUMejUDsJfZrweqYLkxfOQUcKu9Wk0qg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR12MB6617 This code is always inlined to avoid a build error if the error path of `build_assert` cannot be optimized out. Add a comment justifying the `#[inline(always)]` property to avoid it being taken away by mistake. Signed-off-by: Alexandre Courbot Reviewed-by: Daniel Almeida --- rust/kernel/num/bounded.rs | 1 + 1 file changed, 1 insertion(+) diff --git a/rust/kernel/num/bounded.rs b/rust/kernel/num/bounded.rs index f870080af8ac..6dfcf9c1a55a 100644 --- a/rust/kernel/num/bounded.rs +++ b/rust/kernel/num/bounded.rs @@ -363,6 +363,7 @@ pub fn try_new(value: T) -> Option { /// assert_eq!(Bounded::::from_expr(1).get(), 1); /// assert_eq!(Bounded::::from_expr(0xff).get(), 0xff); /// ``` + // Always inline to optimize out error path of `build_assert`. #[inline(always)] pub fn from_expr(expr: T) -> Self { crate::build_assert!( --=20 2.52.0