From nobody Mon Dec 1 22:36:22 2025 Received: from sender3-pp-f112.zoho.com (sender3-pp-f112.zoho.com [136.143.184.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5126C2DEA72 for ; Fri, 28 Nov 2025 21:07:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.184.112 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764364047; cv=pass; b=fqheHHfPArHq4rIZdcANftEyl5HOAzIeVzZLaYGXyHetMvDrJyrzhTFY7t4sxTeEUETVldmd+5y7yOH9V3PLHNi+vga/1Ppb8H2vP9ddWmdjBpJO9mbAcYKftu79U2o0ZUCm9PXuHUH45Tl7OgqZsIty0TkXjZq0l7AGg1Rs2/4= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764364047; c=relaxed/simple; bh=3ukvQskUWajzqLux6am4gjAJOHswXNPFom7JkCbS6WE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=RXlJduHGeuF2k2NjaSNeNRG0sX+YBC0eadsgjDxgxH58pYgcTkJoY0XzZCT5HrtinSRfaRzB4Wd0nQMjYnx3joWn9TPvl7NIPcoDfEXpMJ9cCcsA0tHNoP+WvsVurE4YyVk9OmMYhqQu7llnq2cxw4KvrF1bCRseNHxpEmuwZ9Y= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=nicolas.frattaroli@collabora.com header.b=YRUeWAHT; arc=pass smtp.client-ip=136.143.184.112 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=nicolas.frattaroli@collabora.com header.b="YRUeWAHT" ARC-Seal: i=1; a=rsa-sha256; t=1764364003; cv=none; d=zohomail.com; s=zohoarc; b=ZRZKyGIAohl6AiHLz+Z1Jaie2XFzIkaBqcGOMMFNsP6MEzT/ERdfTjqU3RH9uyBI/53wpkh0xDj2SObm5ea8oS+8yLlWI8hUgIgmRc94FQg846UrsQgCh5TkOALkHNaAcGnnUlYSeC81J9ALd+WmgTNvM8c1+CuLepQe7CAjvFM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1764364003; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=HuuEqm/VM8Z9sKdKKwEgeX6ClWHBKU/5BuknVOHkhMU=; b=LcLzeLuW0/vmYpS5B/sUkhJijZYajuislfZLc6Uz5836uLHf8jb5UQVrJiUEu5BUXNcn058E8iwdCfCS2Aewq1Z1G6x/8Xvq7Fv98/Yv6Uf+S5k8jpHjqVKqk2jM4RmXcd8cKwa91FugFqLkiPe2eXfrkNKkKLIL5Lb/TZyTU50= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=nicolas.frattaroli@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1764364003; s=zohomail; d=collabora.com; i=nicolas.frattaroli@collabora.com; h=From:From:Date:Date:Subject:Subject:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Message-Id:References:In-Reply-To:To:To:Cc:Cc:Reply-To; bh=HuuEqm/VM8Z9sKdKKwEgeX6ClWHBKU/5BuknVOHkhMU=; b=YRUeWAHTr0ytDCeq8Czhp2rruQDGKby5gl2vs3aCqSXmVIpfVDYjRr4YwHoILd8j 5oO6CL8EYGUDEQUO1pByPZn1BVjS1FJQdx/P5Fb25Q7KJDYPANmIPf0a3XfCMjtCt5V g6wnHeXZ9hahin9xCAnEXD2kznvIOfA3kFSNCDWA= Received: by mx.zohomail.com with SMTPS id 1764364001462814.7343165114526; Fri, 28 Nov 2025 13:06:41 -0800 (PST) From: Nicolas Frattaroli Date: Fri, 28 Nov 2025 22:05:42 +0100 Subject: [PATCH v5 06/17] drm/display: hdmi-state-helper: Try subsampling in mode_valid Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251128-color-format-v5-6-63e82f1db1e1@collabora.com> References: <20251128-color-format-v5-0-63e82f1db1e1@collabora.com> In-Reply-To: <20251128-color-format-v5-0-63e82f1db1e1@collabora.com> To: Harry Wentland , Leo Li , Rodrigo Siqueira , Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Sandy Huang , =?utf-8?q?Heiko_St=C3=BCbner?= , Andy Yan , Jani Nikula , Rodrigo Vivi , Joonas Lahtinen , Tvrtko Ursulin , Dmitry Baryshkov , Sascha Hauer , Rob Herring Cc: kernel@collabora.com, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, Nicolas Frattaroli X-Mailer: b4 0.14.3 drm_hdmi_connector_mode_valid assumes modes are only valid if they work with RGB. The reality is more complex however: YCbCr 4:2:0 chroma-subsampled modes only require half the pixel clock that the same mode would require in RGB. This leads to drm_hdmi_connector_mode_valid rejecting perfectly valid 420-only modes. Fix this by checking whether the mode is 420-only first. If so, then proceed by checking it with HDMI_COLORSPACE_YUV420 so long as the connector has legalized 420, otherwise error out. If the mode is not 420-only, check with RGB as was previously always the case. Fixes: 47368ab437fd ("drm/display: hdmi: add generic mode_valid helper") Signed-off-by: Nicolas Frattaroli --- drivers/gpu/drm/display/drm_hdmi_state_helper.c | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/display/drm_hdmi_state_helper.c b/drivers/gpu/= drm/display/drm_hdmi_state_helper.c index 5da956bdd68c..1800e00b30c5 100644 --- a/drivers/gpu/drm/display/drm_hdmi_state_helper.c +++ b/drivers/gpu/drm/display/drm_hdmi_state_helper.c @@ -892,8 +892,18 @@ drm_hdmi_connector_mode_valid(struct drm_connector *co= nnector, const struct drm_display_mode *mode) { unsigned long long clock; + enum hdmi_colorspace fmt; + + if (drm_mode_is_420_only(&connector->display_info, mode)) { + if (connector->ycbcr_420_allowed) + fmt =3D HDMI_COLORSPACE_YUV420; + else + return MODE_NO_420; + } else { + fmt =3D HDMI_COLORSPACE_RGB; + } =20 - clock =3D drm_hdmi_compute_mode_clock(mode, 8, HDMI_COLORSPACE_RGB); + clock =3D drm_hdmi_compute_mode_clock(mode, 8, fmt); if (!clock) return MODE_ERROR; =20 --=20 2.52.0