From nobody Mon Dec 1 22:36:25 2025 Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4335421C160 for ; Fri, 28 Nov 2025 21:07:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.112 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764364022; cv=pass; b=Ev5lvK9rrZbY27bQuLSV90gwWajS4TYBmVzJT1syAZOzdoI8M3npYBXuRZkFRI3j9hqOyCtNx3CcXZDlAEvzHMLJOTvU1leSxxcY75y/L1tPBfkM8KzLQgBA/VND0qIUm+BHjTe608jrohjdK/IMdp3CeVEKMi12qwbTdbZbCx0= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764364022; c=relaxed/simple; bh=l5/UrJTtUsfZOICeBM/TJFiF4zPpXimUGux4GPieTog=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=lPIMxYNZCS/Q4Jl/AqKBoy1Bw/Mb3++YQgNLCOhCz9n7TMVnB+5dEY22qSksLsqQzbN9o4w5oxLDARnV1N3MuP8uebD2MaYetgiJdZ7JwpxNr0dwsLA/hJrSBaVPyJF6O2DSiE6xYLZ/T9/HcU5xF/Y4bFIBfBIZXeH4/RUwVSw= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=nicolas.frattaroli@collabora.com header.b=cbQh+aWa; arc=pass smtp.client-ip=136.143.188.112 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=nicolas.frattaroli@collabora.com header.b="cbQh+aWa" ARC-Seal: i=1; a=rsa-sha256; t=1764363967; cv=none; d=zohomail.com; s=zohoarc; b=RpS9rnGExoFB+0vB67u9j9ggnFuNCQx2UVVTWAT64kP6NnU2wyytctV77Gegjr7AysOLGaWAMntnDPINpM2ZrS5WdpmLqkKVsyqCSBluIyFY8rFVWelIeDErL/IwJpXfu7gmxUsiHUtiJcWniSDXhmg/vI/i6JgoTS9WSlmYPn8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1764363967; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=BtaaxO1e7m0aR9ynlBXtH+b1A1iSo4+WilL52QbHmd4=; b=EpmlfIhTjW1ngPb9iNycGB2pksoIp2SUpKlgcDEbYokAT/IT2R4RafyZeBRToCk/BKCtLjTFucUiLIlR5SZcVsH5L9wke2wYC0izwNwYg73/rTzEzcscf4nJ2PFsWKCUnK3sHwnDcOniepMG0bxBh5HFUcWgPsGYYYrt6f7CwsU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=nicolas.frattaroli@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1764363967; s=zohomail; d=collabora.com; i=nicolas.frattaroli@collabora.com; h=From:From:Date:Date:Subject:Subject:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Message-Id:References:In-Reply-To:To:To:Cc:Cc:Reply-To; bh=BtaaxO1e7m0aR9ynlBXtH+b1A1iSo4+WilL52QbHmd4=; b=cbQh+aWaE2CGXpsQpgljbzMGbHY2fCfT45wbyajQeheP0VZCk23o/PL3Pn+AW4ye mzRPRpdNPfcmo5hlv+NqSw5ZFH2If1M7tCggLduD62OoFC6calPXkXo1qFME3Za8dxA rh1lIJeezRu1EZc2w5qraI4pRfp8YEKgZVcP+EuM= Received: by mx.zohomail.com with SMTPS id 1764363964727749.3717042138871; Fri, 28 Nov 2025 13:06:04 -0800 (PST) From: Nicolas Frattaroli Date: Fri, 28 Nov 2025 22:05:37 +0100 Subject: [PATCH v5 01/17] drm/amd/display: Remove unnecessary SIGNAL_TYPE_HDMI_TYPE_A check Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251128-color-format-v5-1-63e82f1db1e1@collabora.com> References: <20251128-color-format-v5-0-63e82f1db1e1@collabora.com> In-Reply-To: <20251128-color-format-v5-0-63e82f1db1e1@collabora.com> To: Harry Wentland , Leo Li , Rodrigo Siqueira , Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Sandy Huang , =?utf-8?q?Heiko_St=C3=BCbner?= , Andy Yan , Jani Nikula , Rodrigo Vivi , Joonas Lahtinen , Tvrtko Ursulin , Dmitry Baryshkov , Sascha Hauer , Rob Herring Cc: kernel@collabora.com, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, Nicolas Frattaroli , Werner Sembach , Andri Yngvason X-Mailer: b4 0.14.3 From: Werner Sembach Remove unnecessary SIGNAL_TYPE_HDMI_TYPE_A check that was performed in the drm_mode_is_420_only() case, but not in the drm_mode_is_420_also() && force_yuv420_output case. Without further knowledge if YCbCr 4:2:0 is supported outside of HDMI, there is no reason to use RGB when the display reports drm_mode_is_420_only() even on a non HDMI connection. This patch also moves both checks in the same if-case. This eliminates an extra else-if-case. Signed-off-by: Werner Sembach Signed-off-by: Andri Yngvason Tested-by: Andri Yngvason Signed-off-by: Nicolas Frattaroli --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gp= u/drm/amd/display/amdgpu_dm/amdgpu_dm.c index f02bcd108685..0b44bfe9e7e5 100644 --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c @@ -6668,12 +6668,8 @@ static void fill_stream_properties_from_drm_display_= mode( timing_out->v_border_top =3D 0; timing_out->v_border_bottom =3D 0; /* TODO: un-hardcode */ - if (drm_mode_is_420_only(info, mode_in) - && stream->signal =3D=3D SIGNAL_TYPE_HDMI_TYPE_A) - timing_out->pixel_encoding =3D PIXEL_ENCODING_YCBCR420; - else if (drm_mode_is_420_also(info, mode_in) - && aconnector - && aconnector->force_yuv420_output) + if (drm_mode_is_420_only(info, mode_in) || (drm_mode_is_420_also(info, mo= de_in) && + aconnector && aconnector->force_yuv420_output)) timing_out->pixel_encoding =3D PIXEL_ENCODING_YCBCR420; else if ((connector->display_info.color_formats & DRM_COLOR_FORMAT_YCBCR4= 22) && aconnector --=20 2.52.0