From nobody Mon Dec 1 22:04:05 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 93CA93195FB; Thu, 27 Nov 2025 13:51:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764251496; cv=none; b=NYro3Ew69vzGQbJCtPOMqHLYYbL0PKFjpYmQz/6z5pQ+ROv3N22QB322W9IZ8gZP5H6GQQMMyUt+ALFQvdBlLYdwzE+Swr6aI+sDA/ODbtuCAsqMxFPgoeyknYFsLM8Qe3RFaThmGZCLYIxNvE7y3OfZZuUns6OhC8NJvqiaDoY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764251496; c=relaxed/simple; bh=2grttM2+b+FCcMtYfwJ2Au6peSQXsKGtdcjJJ8wLerY=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=TPmRbWNjnFHiWXP++BKtwOk/VwLre6J2nEKxyGRAv5n6YFylBNhOhwjijGSNX0UcuIhgUWIDKcEb58phK72ChuvbNQYF9MGDNzASaYJBoJ+Aa7bv9MzYGXUOvBXDRmraKInGOgOqVZtBcxbGI12pVQem4rKEj40xgew3HqxUIxU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=EgktAKkD; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="EgktAKkD" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 24F4AC4CEF8; Thu, 27 Nov 2025 13:51:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1764251496; bh=2grttM2+b+FCcMtYfwJ2Au6peSQXsKGtdcjJJ8wLerY=; h=From:To:Cc:Subject:Date:From; b=EgktAKkDuxcpkbB99CLHNNUJNo8Vmpw7zG3ropuSNDZR59ai6mcEAZ7Hbx0lOO10t l2WVLsPKGCAns5OWaDmToHF8xcPke6Vay3hoIChQwfXSghn8+h2pGoHgOQE1qfUy0t mglyH7wviDGquIsjSHzW5hIP8cNpZasu7N+3BYBqHY6dWv1eRSvuG292veTRSFV/6s bpQxpysSbtQxWf12qxEha8c+XxCRmaOeWQ2cG3o1dcOj9CikEuSnWbzL37xWO31/br dyT66xbjlqsBTzXlUPpoZcxN/WO0vVKOIczpQ8iq0q9tn919h52vy/STq+VTyiyRIC A62jFEaY8dyhg== Received: from johan by xi.lan with local (Exim 4.98.2) (envelope-from ) id 1vOcPK-000000000aT-3sWa; Thu, 27 Nov 2025 14:51:38 +0100 From: Johan Hovold To: Srinivas Kandagatla , Mark Brown Cc: Liam Girdwood , linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold , stable@vger.kernel.org, Neil Armstrong Subject: [PATCH] ASoC: codecs: wcd939x: fix regmap leak on probe failure Date: Thu, 27 Nov 2025 14:50:57 +0100 Message-ID: <20251127135057.2216-1-johan@kernel.org> X-Mailer: git-send-email 2.51.2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The soundwire regmap that may be allocated during probe is not freed on late probe failures. Add the missing error handling. Fixes: be2af391cea0 ("ASoC: codecs: Add WCD939x Soundwire devices driver") Cc: stable@vger.kernel.org # 6.9 Cc: Neil Armstrong Signed-off-by: Johan Hovold --- sound/soc/codecs/wcd939x-sdw.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/sound/soc/codecs/wcd939x-sdw.c b/sound/soc/codecs/wcd939x-sdw.c index d369100a2457..da342a0c95a5 100644 --- a/sound/soc/codecs/wcd939x-sdw.c +++ b/sound/soc/codecs/wcd939x-sdw.c @@ -1400,12 +1400,18 @@ static int wcd9390_probe(struct sdw_slave *pdev, co= nst struct sdw_device_id *id) =20 ret =3D component_add(dev, &wcd_sdw_component_ops); if (ret) - return ret; + goto err_free_regmap; =20 /* Set suspended until aggregate device is bind */ pm_runtime_set_suspended(dev); =20 return 0; + +err_free_regmap: + if (wcd->regmap) + regmap_exit(wcd->regmap); + + return ret; } =20 static int wcd9390_remove(struct sdw_slave *pdev) --=20 2.51.2