From nobody Mon Dec 1 22:04:06 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3548D223DE8; Thu, 27 Nov 2025 13:48:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764251338; cv=none; b=QQc7AFkQukh9JUE02/sIuj7anVKrrMLI9NRQeWFQHWtFaq+gatskSSJe4Qq92KYRoXuN31gNVNtB6hmFgkwZNsLxJXAyQdnnJXbfC8J5Nr49rJ+TsdwIFBgBQmYNvR2gEPXMuYPzixH0o2LQSOLKbLSRBg8oCcUYdT9RAh0DRbk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764251338; c=relaxed/simple; bh=N2+IV1yRY0T/LRl/K2e/owyDnFap0O5LSqnWZ9obaNg=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=ADxjybLP6ULeazYJ6JKg3lg73z/cY8qqDtX8e578T3Bi6JxmSb9V55tguQqYK4vzuQR+Zgvm0XBbBSR6T1z+q7VVcKR0uh6SjkwYuSqTjse2G3KJrkz3xQfkVdQbR6oQv85FU4nXhGn6HXW4gRwHNEHxlaBA3tAlyI2h622Jo2E= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=r508GE7U; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="r508GE7U" Received: by smtp.kernel.org (Postfix) with ESMTPSA id BFA45C4CEF8; Thu, 27 Nov 2025 13:48:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1764251337; bh=N2+IV1yRY0T/LRl/K2e/owyDnFap0O5LSqnWZ9obaNg=; h=From:To:Cc:Subject:Date:From; b=r508GE7UTowlumnhCbER64bfwPrvcIIFZGX2rAoWGGErHMNURRoAItuSkCK+TUpdo 2inaOAv7ca1pUEAfyzDaNVNdNqiq563o093ZjdiLT48SHvXoLzRZ+pm+36czW8cT41 JpGe3DY05mgJOOQgdaTz6Ny6vMFFnr9NdhrA8Fx+arT1fR2FbvUm1I1MmfVy1ALmQ5 M7+Y88C1HHhYKwAMSrSezssUJfIuwLG7y0TZvZOvqpope8hPCpISqLwCvBjNMiHulC hgeeOpUHoqXPkGVUpVJ6jakPG2TAJAnaBqYpZK7l1x8Xby7QDa8HhNrKjzdiEesWOE XemmX0oycosvA== Received: from johan by xi.lan with local (Exim 4.98.2) (envelope-from ) id 1vOcMm-000000000XO-11gd; Thu, 27 Nov 2025 14:49:00 +0100 From: Johan Hovold To: Vinod Koul , Kishon Vijay Abraham I Cc: linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org, Johan Hovold , stable@vger.kernel.org, Andrew Davis Subject: [PATCH] phy: ti: gmii-sel: fix regmap leak on probe failure Date: Thu, 27 Nov 2025 14:48:34 +0100 Message-ID: <20251127134834.2030-1-johan@kernel.org> X-Mailer: git-send-email 2.51.2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The mmio regmap that may be allocated during probe is never freed. Switch to using the device managed allocator so that the regmap is released on probe failures (e.g. probe deferral) and on driver unbind. Fixes: 5ab90f40121a ("phy: ti: gmii-sel: Do not use syscon helper to build = regmap") Cc: stable@vger.kernel.org # 6.14 Cc: Andrew Davis Signed-off-by: Johan Hovold Acked-by: Andrew Davis --- drivers/phy/ti/phy-gmii-sel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/phy/ti/phy-gmii-sel.c b/drivers/phy/ti/phy-gmii-sel.c index 50adabb867cb..26209a89703a 100644 --- a/drivers/phy/ti/phy-gmii-sel.c +++ b/drivers/phy/ti/phy-gmii-sel.c @@ -512,7 +512,7 @@ static int phy_gmii_sel_probe(struct platform_device *p= dev) return dev_err_probe(dev, PTR_ERR(base), "failed to get base memory resource\n"); =20 - priv->regmap =3D regmap_init_mmio(dev, base, &phy_gmii_sel_regmap_cfg); + priv->regmap =3D devm_regmap_init_mmio(dev, base, &phy_gmii_sel_regmap_c= fg); if (IS_ERR(priv->regmap)) return dev_err_probe(dev, PTR_ERR(priv->regmap), "Failed to get syscon\n"); --=20 2.51.2