From nobody Mon Dec 1 22:04:07 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EFEFA1EB1A4; Thu, 27 Nov 2025 13:47:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764251242; cv=none; b=gNIeqr3CIoXzUR7H9vVs7teGd17T0VwkBIouPSJW0iWlXLxa+Vxnlsh3DUp+x81tuYfM4A5Li7XYfju6UacJbafDz33t8gfS1/nzlDff54DczeglHZhMKcPqorn87cULPQAyQfGxXv4x1jzVOnBUgUh4EFwy8PcLlXJ5Qfcrjqk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764251242; c=relaxed/simple; bh=WlaS2NiP9VyUK5RBnIDbkYPzn1Q+caa+OeUlNygoR4E=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=M+gVSQ++sk5O9I/0SD5qQPSs8hits+IUGvRYMM6IzpZ/nZ0KphpU6VgNVNhgOpB7MiVKZjO8yKTR2hgkfN6IdXQ+ArXzupHEZX3pm+C+B3m1/fUFAuU9z9JKytdYpCz142x2JMEdgC18h1B+OEWWAtgy7WukpQ0fYaw9OTiVt8Y= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=tdwWYaU8; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="tdwWYaU8" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7B28CC4CEF8; Thu, 27 Nov 2025 13:47:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1764251241; bh=WlaS2NiP9VyUK5RBnIDbkYPzn1Q+caa+OeUlNygoR4E=; h=From:To:Cc:Subject:Date:From; b=tdwWYaU8syHQMhF7AQZKvnoWjUjUta1B3rTVaCBc6qXGWE6fErjguuuywbXhpwfbr sRutUK7kndlgJg0HGRTwxF/dk5xv8jh/31aoMNspM09mupYvfeqjV8GRlbyXeZp1cQ E5F6EFW6TCYbgx58dpg855gDXis64jpvEdF6Ks8MZtwQP9gBTysZ+wq17TKtKJx7gg 4h5thC7fjd06gjpfueQYZKRX9n49NlcOh6zPc7W2kAWdQggiSZzpBmyVBlgFpvtRvi iNE72mUD0g3/gcmPHA4L6rxqp7beK9JfyWIaiwWDolblEItP3lsowvEUj8xv39um/M pAz91CLACJMsg== Received: from johan by xi.lan with local (Exim 4.98.2) (envelope-from ) id 1vOcLE-000000000VJ-1EFL; Thu, 27 Nov 2025 14:47:24 +0100 From: Johan Hovold To: Peter Rosin Cc: Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Johan Hovold , stable@vger.kernel.org, Andrew Davis Subject: [PATCH] mux: mmio: fix regmap leak on probe failure Date: Thu, 27 Nov 2025 14:47:02 +0100 Message-ID: <20251127134702.1915-1-johan@kernel.org> X-Mailer: git-send-email 2.51.2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The mmio regmap that may be allocated during probe is never freed. Switch to using the device managed allocator so that the regmap is released on probe failures (e.g. probe deferral) and on driver unbind. Fixes: 61de83fd8256 ("mux: mmio: Do not use syscon helper to build regmap") Cc: stable@vger.kernel.org # 6.16 Cc: Andrew Davis Signed-off-by: Johan Hovold Acked-by: Andrew Davis --- drivers/mux/mmio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mux/mmio.c b/drivers/mux/mmio.c index 9993ce38a818..5b0171d19d43 100644 --- a/drivers/mux/mmio.c +++ b/drivers/mux/mmio.c @@ -58,7 +58,7 @@ static int mux_mmio_probe(struct platform_device *pdev) if (IS_ERR(base)) regmap =3D ERR_PTR(-ENODEV); else - regmap =3D regmap_init_mmio(dev, base, &mux_mmio_regmap_cfg); + regmap =3D devm_regmap_init_mmio(dev, base, &mux_mmio_regmap_cfg); /* Fallback to checking the parent node on "real" errors. */ if (IS_ERR(regmap) && regmap !=3D ERR_PTR(-EPROBE_DEFER)) { regmap =3D dev_get_regmap(dev->parent, NULL); --=20 2.51.2