From nobody Mon Dec 1 22:38:58 2025 Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2FAD81DF994 for ; Thu, 27 Nov 2025 12:54:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764248067; cv=none; b=BE8mp0P4LMjl4wsaOjm3f/dbg15O0j1eBQbYwCbkojI6mxyJ3FsECZ1C11Et/H7dgXdKMv1+S2g6bQA+/b1cpHRjAsvBBBtuo1gmaiPtDTDXb0u6WkDW8RWWZMOeg9/S6VfCbRXSMo/Q7Ho2SYl4WlntAhzqV/HbAQAw7CiTPTg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764248067; c=relaxed/simple; bh=d/kl4UdVPgcHeGEXPdIBpKOIWrBIZrxIu9iOCmCrdOc=; h=From:To:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=W3a1Q01Wl/UpoURLH8Otk0fDTq93nJhlEGQSsDjCctU1gH7n+c7ROKY4d2ryQr5Qe2BXyDa2SK3IzwaaExPH7qRceE/hnCnkyXlrNNHgSnUGa1KWr+aQ/iUAOsIUGm4cR69ZxCF78ZfUgHBGOFXkwod/qT2MEKy3WvIBbJatAG0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=bytedance.com; spf=pass smtp.mailfrom=bytedance.com; dkim=pass (2048-bit key) header.d=bytedance.com header.i=@bytedance.com header.b=QAOxTFYF; arc=none smtp.client-ip=209.85.214.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=bytedance.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bytedance.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bytedance.com header.i=@bytedance.com header.b="QAOxTFYF" Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-29845b06dd2so11247645ad.2 for ; Thu, 27 Nov 2025 04:54:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1764248065; x=1764852865; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=Cn2qLDcM5Q0Hk7ii9P/KQYaMCaCobwGUqniWS6mOX/s=; b=QAOxTFYFYbmgxHjI2ZViGa7NaeMAXCgk0whsWjLEj8qZuu47YMG9gAXf1ujHnQukUq gHQ36TeyuqZ3TN6usJVL3YB8NTdAJWap3OpAaafYk0NefL/1XtTiOmXcUJdKd3ax01PW NSDSCQ3stnUEzT3MozCi/auLemq7QthFwUsB+y7ZSoU6BHErgnfuwzzfv0xDQ1Xr+pVn LjsqMBhpYLrV4a+0ITb3/hfbWh944kPLloEPiSqlf2KO51Rct0A72c0a/8Zm9Al6jsIR cXC7IsRSwUWcO7UaGDo4J6F+w0WKCkH5+9a3hGbFh8PO+K8Jm7cr+LHMKxGZKsEG6f7T EKYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764248065; x=1764852865; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=Cn2qLDcM5Q0Hk7ii9P/KQYaMCaCobwGUqniWS6mOX/s=; b=A7micVHtwNPiVdSVKdt4Jzd3iWCUY4v2LWfdJOm9r9l+c34R+GNTH43ET/JzIu273E 9N/r7oMmTkvDlmWwtPw4z/wZWu4i08dg2847JoImVMJf6NRvw8t9kJE5FurgQ9UXxCGC FuTJ4bSeb36LpT/Gsfs0n0pwUUCbud40UMxRTWFrx5a1M6TBRUfY1Mj3Hoy0GHbcEYev +xqqz4MCIbsbFrc5l8RqR/HgjXLDJI1K/s1JFG9sLja+pJinVijKPzUu0XWpE9dvzL75 hakb9F2/yVLJW7sr3ENw2tEkL9NfUal1B49+qCg6mNDFzDdP5HXWEF1n4/+V2xWQ2bm5 Iq5w== X-Forwarded-Encrypted: i=1; AJvYcCXboPKZq/5xhd9ffzROsuFWL+A8usAFsxq7NQ4Gmbk9UlNtTU88NaMRiBrz6V9+9ngaxIKRIwLpCftQ1gE=@vger.kernel.org X-Gm-Message-State: AOJu0YyNlClyf5cEZqL3DF56Xqp69FYRsh131k7mPeelc0kWSkzXUU6O RjzNg72BVlKc1cucp++3Hs96+yRE6QffBaF7e0EF+dn2QtRE+srHpfE+IkREz+1nLK4= X-Gm-Gg: ASbGncvMsH4v/X7Pvy7K98rqautRr8xBumIyTVpTSATIYGrulPVCKZ2G6L2g+p2CluV yCNYNEQlbvf83e07u+uZHPU6b/bksqF3b4AZZNwCC82td3Duozip6F/HO4CY+9jsCdFFHWA5F9V 1NshzbLvJ6knee2iDf7NlaTNWoEj98PKgPcdFHKQa4MEjB/LuCukPWOfr2QLB3H/XTJ8WE4CBqg ytlY5v7se7vySAao+nD56wlpXDWkTKJdEq+LjGDNh94HHHmnZ+zexwBPrywjF8+19O5GCGnOUvp Dyo+bsk571KQFMsCnExSxjiI2a1S8/bj4tpJCZ9TG+ONnXde1dnPF9pW0ozZqKTvJS/7uiibUYD cEEjPjzrHMURmrOcsVzU3iJlKzyGwjXDuFe6pL4+T4jzfcmcDeYjbxj5+ugdygjVGIeAfkKPzSi 0pvd+WWm2zzDsphxR1W9u+rZ2UPSPEhwZMr0FLq737e4I5 X-Google-Smtp-Source: AGHT+IEAZqTGZJVNP2wrNdlYDnUqTCKW3NgeNK+bqQtAShTypNyKnPlwOxZ/5vWOPg+U1HVeecPksQ== X-Received: by 2002:a17:902:e890:b0:295:9cb5:ae07 with SMTP id d9443c01a7336-29b6c574f95mr278040245ad.38.1764248065275; Thu, 27 Nov 2025 04:54:25 -0800 (PST) Received: from L6YN4KR4K9.bytedance.net ([139.177.225.225]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-29bce470347sm17771255ad.41.2025.11.27.04.54.17 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 27 Nov 2025 04:54:24 -0800 (PST) From: Yunhui Cui To: conor@kernel.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, alex@ghiti.fr, cuiyunhui@bytedance.com, luxu.kernel@bytedance.com, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, jassisinghbrar@gmail.com, conor.dooley@microchip.com, valentina.fernandezalanis@microchip.com, catalin.marinas@arm.com, will@kernel.org, maz@kernel.org, timothy.hayes@arm.com, lpieralisi@kernel.org, arnd@arndb.de, kees@kernel.org, tglx@linutronix.de, viresh.kumar@linaro.org, boqun.feng@gmail.com, linux-arm-kernel@lists.infradead.org, cleger@rivosinc.com, atishp@rivosinc.com, ajones@ventanamicro.com Subject: [PATCH v3 8/8] drivers: firmware: riscv: add unknown nmi support Date: Thu, 27 Nov 2025 20:53:05 +0800 Message-Id: <20251127125305.89961-9-cuiyunhui@bytedance.com> X-Mailer: git-send-email 2.39.2 (Apple Git-143) In-Reply-To: <20251127125305.89961-1-cuiyunhui@bytedance.com> References: <20251127125305.89961-1-cuiyunhui@bytedance.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Register unknown_nmi_handler() as the handler for the UNKNOWN_NMI event. When the system becomes unresponsive, unknown_nmi_handler() can be manually triggered, which in turn invokes nmi_panic() to collect vmcore for root cause analysis. Signed-off-by: Yunhui Cui --- arch/riscv/include/asm/sbi.h | 1 + drivers/firmware/riscv/riscv_sse_nmi.c | 68 ++++++++++++++++++++++++++ 2 files changed, 69 insertions(+) diff --git a/arch/riscv/include/asm/sbi.h b/arch/riscv/include/asm/sbi.h index 874cc1d7603a5..52d3fdf2d4cc1 100644 --- a/arch/riscv/include/asm/sbi.h +++ b/arch/riscv/include/asm/sbi.h @@ -486,6 +486,7 @@ enum sbi_sse_attr_id { #define SBI_SSE_EVENT_LOCAL_LOW_PRIO_RAS 0x00100000 #define SBI_SSE_EVENT_GLOBAL_LOW_PRIO_RAS 0x00108000 #define SBI_SSE_EVENT_LOCAL_SOFTWARE_INJECTED 0xffff0000 +#define SBI_SSE_EVENT_LOCAL_UNKNOWN_NMI 0xffff0001 #define SBI_SSE_EVENT_GLOBAL_SOFTWARE_INJECTED 0xffff8000 =20 #define SBI_SSE_EVENT_PLATFORM BIT(14) diff --git a/drivers/firmware/riscv/riscv_sse_nmi.c b/drivers/firmware/risc= v/riscv_sse_nmi.c index 85aa65f31943b..d98015d1cb893 100644 --- a/drivers/firmware/riscv/riscv_sse_nmi.c +++ b/drivers/firmware/riscv/riscv_sse_nmi.c @@ -7,6 +7,7 @@ #include #include #include +#include =20 #include #include @@ -16,7 +17,10 @@ do { if (type & (mask)) func(__VA_ARGS__); } while (0) =20 static bool nmi_available; +static int unknown_nmi_panic; static struct sse_event *local_nmi_evt; +static struct sse_event *unknown_nmi_evt; +static struct ctl_table_header *unknown_nmi_sysctl_header; static DEFINE_PER_CPU(atomic_t, local_nmi) =3D ATOMIC_INIT(LOCAL_NMI_NONE); =20 bool nmi_support(void) @@ -52,6 +56,35 @@ void send_nmi_mask(cpumask_t *mask, enum local_nmi_type = type) send_nmi_single(cpu, type); } =20 +static int __init setup_unknown_nmi_panic(char *str) +{ + unknown_nmi_panic =3D 1; + return 1; +} +__setup("unknown_nmi_panic", setup_unknown_nmi_panic); + +static const struct ctl_table unknown_nmi_table[] =3D { + { + .procname =3D "unknown_nmi_panic", + .data =3D &unknown_nmi_panic, + .maxlen =3D sizeof(bool), + .mode =3D 0644, + .proc_handler =3D proc_dobool, + }, +}; + +static int unknown_nmi_handler(u32 evt, void *arg, struct pt_regs *regs) +{ + pr_emerg("NMI received for unknown on CPU %d.\n", smp_processor_id()); + + if (unknown_nmi_panic) + nmi_panic(regs, "NMI: Not continuing"); + + pr_emerg("Dazed and confused, but trying to continue\n"); + + return 0; +} + static int local_nmi_handler(u32 evt, void *arg, struct pt_regs *regs) { enum local_nmi_type type; @@ -69,6 +102,35 @@ static int local_nmi_handler(u32 evt, void *arg, struct= pt_regs *regs) return 0; } =20 +static int unknown_nmi_init(void) +{ + int ret; + + unknown_nmi_evt =3D sse_event_register(SBI_SSE_EVENT_LOCAL_UNKNOWN_NMI, 0, + unknown_nmi_handler, NULL); + if (IS_ERR(unknown_nmi_evt)) + return PTR_ERR(unknown_nmi_evt); + + ret =3D sse_event_enable(unknown_nmi_evt); + if (ret) + goto err_unregister; + + unknown_nmi_sysctl_header =3D register_sysctl("kernel", unknown_nmi_table= ); + if (!unknown_nmi_sysctl_header) { + ret =3D -ENOMEM; + goto err_disable; + } + + pr_info("Using SSE for unknown NMI event delivery\n"); + return 0; + +err_disable: + sse_event_disable(unknown_nmi_evt); +err_unregister: + sse_event_unregister(unknown_nmi_evt); + return ret; +} + static int __init local_nmi_init(void) { int ret; @@ -101,6 +163,12 @@ static int __init sse_nmi_init(void) =20 WRITE_ONCE(nmi_available, true); =20 + ret =3D unknown_nmi_init(); + if (ret) { + pr_err("Unknown_nmi_init failed with error %d\n", ret); + return ret; + } + return 0; } =20 --=20 2.39.5