From nobody Mon Dec 1 22:07:39 2025 Received: from out30-111.freemail.mail.aliyun.com (out30-111.freemail.mail.aliyun.com [115.124.30.111]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E01603168E4 for ; Thu, 27 Nov 2025 08:08:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=115.124.30.111 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764230910; cv=none; b=u85GaQBOcNithb1wLL2ONh6K1wkQXbmGpHIV3GOzc66+hJuco/sbaPyVLUvvwLBTwGddtZJytl2iI0z2tjKAHwxG+LVmIdITjGfMhzZLI0G8hb6CG0ldnwTPo7qoed4KS5SMUuxSYw3ZEypkqDDwbMPkeZ6yL1H5h8q4UMNEyQo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764230910; c=relaxed/simple; bh=UjUKShlfQD6W6VxQk4ZDOAusnO2JcTXMZlTQcOZKpqM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=giefdXbQvoFsSoLcwg6udt+zZVNCdPy0zAO3xd8bLGqL3wdG2ZRLcGEez9Lqpem4/q5i44parTkQlWSPRQ5aVU2eS9Wf+zkHqsNSFwpys26z3IFig9vEG6WpmukPfT6bfPUwPGvbfTzfMc4vscgFotoMxKh9z+fiunr47btGwGY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.alibaba.com; spf=pass smtp.mailfrom=linux.alibaba.com; dkim=pass (1024-bit key) header.d=linux.alibaba.com header.i=@linux.alibaba.com header.b=o/ry/Za2; arc=none smtp.client-ip=115.124.30.111 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.alibaba.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.alibaba.com header.i=@linux.alibaba.com header.b="o/ry/Za2" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1764230900; h=From:To:Subject:Date:Message-ID:MIME-Version; bh=lg19gDerPYPrC9qzJjtNYK3ey/49Lb0mQIl5aO4blIE=; b=o/ry/Za2vZlz/p4DCwgE+1S6vUFkhj6UGjyZNsA0piF37uv+kGWZ9wPDv8ccVX8GVyoqzE8ui9ZWpV0/eAavGXSmmlxoMrxx9QfdzaFhAGSgz3tGzP/MKBfyx7Ce7UCgyKfjdhd1cHUvIlmq3lkhYa0O9yq5LeWi+dUIciEF5Rc= Received: from x31i01179.sqa.na131.tbsite.net(mailfrom:hsiangkao@linux.alibaba.com fp:SMTPD_---0WtWXY1i_1764230899 cluster:ay36) by smtp.aliyun-inc.com; Thu, 27 Nov 2025 16:08:19 +0800 From: Gao Xiang To: linux-erofs@lists.ozlabs.org Cc: LKML , Christoph Hellwig , Ming Lei , Stephen Zhang , Gao Xiang Subject: [PATCH v2] erofs: get rid of raw bi_end_io() usage Date: Thu, 27 Nov 2025 16:07:56 +0800 Message-ID: <20251127080756.2602939-1-hsiangkao@linux.alibaba.com> X-Mailer: git-send-email 2.43.5 In-Reply-To: <20251127080237.2589998-1-hsiangkao@linux.alibaba.com> References: <20251127080237.2589998-1-hsiangkao@linux.alibaba.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" These BIOs are actually harmless in practice, as they are all pseudo BIOs and do not use advanced features like chaining. Using the BIO interface is a more friendly and unified approach for both bdev and and file-backed I/Os. Let's use bio_endio() instead. Signed-off-by: Gao Xiang Reviewed-by: Chao Yu Reviewed-by: Christoph Hellwig Reviewed-by: Ming Lei --- v2: - call bio_endio() unconditionally in erofs_fileio_ki_complete(). fs/erofs/fileio.c | 2 +- fs/erofs/fscache.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/fs/erofs/fileio.c b/fs/erofs/fileio.c index b7b3432a9882..301647b84ca9 100644 --- a/fs/erofs/fileio.c +++ b/fs/erofs/fileio.c @@ -34,13 +34,13 @@ static void erofs_fileio_ki_complete(struct kiocb *iocb= , long ret) if (rq->bio.bi_end_io) { if (ret < 0 && !rq->bio.bi_status) rq->bio.bi_status =3D errno_to_blk_status(ret); - rq->bio.bi_end_io(&rq->bio); } else { bio_for_each_folio_all(fi, &rq->bio) { DBG_BUGON(folio_test_uptodate(fi.folio)); erofs_onlinefolio_end(fi.folio, ret, false); } } + bio_endio(&rq->bio); bio_uninit(&rq->bio); kfree(rq); } diff --git a/fs/erofs/fscache.c b/fs/erofs/fscache.c index 362acf828279..7a346e20f7b7 100644 --- a/fs/erofs/fscache.c +++ b/fs/erofs/fscache.c @@ -185,7 +185,7 @@ static void erofs_fscache_bio_endio(void *priv, ssize_t= transferred_or_error) =20 if (IS_ERR_VALUE(transferred_or_error)) io->bio.bi_status =3D errno_to_blk_status(transferred_or_error); - io->bio.bi_end_io(&io->bio); + bio_endio(&io->bio); BUILD_BUG_ON(offsetof(struct erofs_fscache_bio, io) !=3D 0); erofs_fscache_io_put(&io->io); } @@ -216,7 +216,7 @@ void erofs_fscache_submit_bio(struct bio *bio) if (!ret) return; bio->bi_status =3D errno_to_blk_status(ret); - bio->bi_end_io(bio); + bio_endio(bio); } =20 static int erofs_fscache_meta_read_folio(struct file *data, struct folio *= folio) --=20 2.43.5