From nobody Mon Dec 1 22:07:42 2025 Received: from out30-131.freemail.mail.aliyun.com (out30-131.freemail.mail.aliyun.com [115.124.30.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D06253C1F for ; Thu, 27 Nov 2025 08:02:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=115.124.30.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764230568; cv=none; b=pBImGpn0k/Vda/Zlf+nwE2zViWw5EUCl6FMSBcVKHEQsEdHTWMOE25rL444MkfeGtc+q83dqW2mO+DM7YUbTsL+u9WDvmCTMedpEm5xrm91WpBtc792YI7vjXA9PH4Ls3cyYrF55fIApKnUIIJ0t1yBmJBYRyaqGdUkJSP7UzQg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764230568; c=relaxed/simple; bh=dGYe6jM9thGKcjRLRyx3LrB+DA/qD/9ncxF1EZRON1k=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=IPeD0p9rYerJyOPyiHkiM/1GPa+Tc+zOHHClQDdwodpU2SrLqJUHe3zwrM68oC7Hqh/ZS6OcqS4TtSCbbUtWct7gu+U1s6dMA8FuGcloYF15yk530d08rOA4UDPcsEkS8VW0n0ZsIDBUDnaNAzWutW/V8zK63h0DfXL0wEN9WXw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.alibaba.com; spf=pass smtp.mailfrom=linux.alibaba.com; dkim=pass (1024-bit key) header.d=linux.alibaba.com header.i=@linux.alibaba.com header.b=B7tszqX3; arc=none smtp.client-ip=115.124.30.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.alibaba.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.alibaba.com header.i=@linux.alibaba.com header.b="B7tszqX3" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1764230562; h=From:To:Subject:Date:Message-ID:MIME-Version; bh=Qc9KRM73OWEhqOEmQa0INwKZygqVyMGwG+ycFVJCLGs=; b=B7tszqX3na90z6X8JHPcu7HSgw3B5YFpxW9xz8nZf24TFPkF5F2FsXcJV1M9unqL3pr/qLUrrLcziJk+gWSD4LHHoZq6q3cqlMsFz3QwLgux79MpaNi5qwFg9sv1G6ohHbNpJYqIEVPoStAKOIradXBVlZpE7LVvyWRQ7G17KjQ= Received: from x31i01179.sqa.na131.tbsite.net(mailfrom:hsiangkao@linux.alibaba.com fp:SMTPD_---0WtWMPOR_1764230557 cluster:ay36) by smtp.aliyun-inc.com; Thu, 27 Nov 2025 16:02:42 +0800 From: Gao Xiang To: linux-erofs@lists.ozlabs.org Cc: LKML , Christoph Hellwig , Ming Lei , Stephen Zhang , Gao Xiang Subject: [PATCH] erofs: get rid of raw bi_end_io() usage Date: Thu, 27 Nov 2025 16:02:37 +0800 Message-ID: <20251127080237.2589998-1-hsiangkao@linux.alibaba.com> X-Mailer: git-send-email 2.43.5 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" These BIOs are actually harmless in practice, as they are all pseudo BIOs and do not use advanced features like chaining. Using the BIO interface is a more friendly and unified approach for both bdev and and file-backed I/Os. Let's use bio_endio() instead. Signed-off-by: Gao Xiang --- fs/erofs/fileio.c | 2 +- fs/erofs/fscache.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/fs/erofs/fileio.c b/fs/erofs/fileio.c index b7b3432a9882..a65f86dc79b6 100644 --- a/fs/erofs/fileio.c +++ b/fs/erofs/fileio.c @@ -34,7 +34,7 @@ static void erofs_fileio_ki_complete(struct kiocb *iocb, = long ret) if (rq->bio.bi_end_io) { if (ret < 0 && !rq->bio.bi_status) rq->bio.bi_status =3D errno_to_blk_status(ret); - rq->bio.bi_end_io(&rq->bio); + bio_endio(&rq->bio); } else { bio_for_each_folio_all(fi, &rq->bio) { DBG_BUGON(folio_test_uptodate(fi.folio)); diff --git a/fs/erofs/fscache.c b/fs/erofs/fscache.c index 362acf828279..7a346e20f7b7 100644 --- a/fs/erofs/fscache.c +++ b/fs/erofs/fscache.c @@ -185,7 +185,7 @@ static void erofs_fscache_bio_endio(void *priv, ssize_t= transferred_or_error) =20 if (IS_ERR_VALUE(transferred_or_error)) io->bio.bi_status =3D errno_to_blk_status(transferred_or_error); - io->bio.bi_end_io(&io->bio); + bio_endio(&io->bio); BUILD_BUG_ON(offsetof(struct erofs_fscache_bio, io) !=3D 0); erofs_fscache_io_put(&io->io); } @@ -216,7 +216,7 @@ void erofs_fscache_submit_bio(struct bio *bio) if (!ret) return; bio->bi_status =3D errno_to_blk_status(ret); - bio->bi_end_io(bio); + bio_endio(bio); } =20 static int erofs_fscache_meta_read_folio(struct file *data, struct folio *= folio) --=20 2.43.5