From nobody Mon Dec 1 22:34:53 2025 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 45EB8313542 for ; Thu, 27 Nov 2025 07:10:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764227421; cv=none; b=bqXFOH8xC1nOM6Wt1a0mQpOae3zxaKLuPpn63lpZnOBrLhtIW+bOgXV+lKYRY1tAIBPd/KVCJF3ztETVUCqfh7fliDt4kjxRR2/nW7wPbF6TlTUg3rzA0FKc0nBPJRnOhI07MGl+IVMz+d43RwK+QNhrStOtC5F8ATvjIfIPZ/o= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764227421; c=relaxed/simple; bh=Rjo43mI0vz4cpD9hdnQuX/o0lEl8wBupwIAxIxrncqk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=JwUn+LEBqK87KzJ+ZQUe21A4/ItCM4D/Hp1nAll5Sp1HpWYmcCqjMmfFQByDwbRBkWS2JAa0ljuncDwmKZMiPIHqTb40bTbViVcDVSnk1HbdGdJ2R+KIYjqzmnqc8SNzFphAEx2Drrs2i23+k/Mx7yaBdl9XLonAxQ5pJTSSzj8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (1024-bit key) header.d=suse.com header.i=@suse.com header.b=gWsIkR9Y; dkim=pass (1024-bit key) header.d=suse.com header.i=@suse.com header.b=gWsIkR9Y; arc=none smtp.client-ip=195.135.223.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.com header.i=@suse.com header.b="gWsIkR9Y"; dkim=pass (1024-bit key) header.d=suse.com header.i=@suse.com header.b="gWsIkR9Y" Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 748E85BCC4; Thu, 27 Nov 2025 07:10:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1764227417; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+ZD0gHfZEAZt38+vBUmam6fB85ZjKlj3yVqOSUwfE0Y=; b=gWsIkR9Y7z8FVayWaep4mo1zZytSyxXgt93U6ANX/FSM+kmKiHujplZRaytePOGoCIsy2A wfCpqyYgzoWf7+1PXp9jKgjYTDtbyNBVfpjKAR32x12s5Q8BhAAIqLNM314ZBfbAoy+WA/ N+qRNAh+6SCRHPtzLRxjSWYJ4mW7kiI= Authentication-Results: smtp-out2.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1764227417; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+ZD0gHfZEAZt38+vBUmam6fB85ZjKlj3yVqOSUwfE0Y=; b=gWsIkR9Y7z8FVayWaep4mo1zZytSyxXgt93U6ANX/FSM+kmKiHujplZRaytePOGoCIsy2A wfCpqyYgzoWf7+1PXp9jKgjYTDtbyNBVfpjKAR32x12s5Q8BhAAIqLNM314ZBfbAoy+WA/ N+qRNAh+6SCRHPtzLRxjSWYJ4mW7kiI= Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 1B4313EA63; Thu, 27 Nov 2025 07:10:17 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id Jv5CBVn5J2nlXQAAD6G6ig (envelope-from ); Thu, 27 Nov 2025 07:10:17 +0000 From: Juergen Gross To: linux-kernel@vger.kernel.org, x86@kernel.org Cc: Juergen Gross , Boris Ostrovsky , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Josh Poimboeuf , Peter Zijlstra , xen-devel@lists.xenproject.org Subject: [PATCH v4 15/21] x86/xen: Drop xen_irq_ops Date: Thu, 27 Nov 2025 08:08:38 +0100 Message-ID: <20251127070844.21919-16-jgross@suse.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251127070844.21919-1-jgross@suse.com> References: <20251127070844.21919-1-jgross@suse.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Spamd-Result: default: False [-6.80 / 50.00]; REPLY(-4.00)[]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; MID_CONTAINS_FROM(1.00)[]; R_MISSING_CHARSET(0.50)[]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; RCVD_COUNT_TWO(0.00)[2]; MIME_TRACE(0.00)[0:+]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_TWELVE(0.00)[12]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; ARC_NA(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; DKIM_SIGNED(0.00)[suse.com:s=susede1]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_RATELIMIT(0.00)[to_ip_from(RLfdszjqhz8kzzb9uwpzdm8png)]; FROM_EQ_ENVFROM(0.00)[]; RCVD_TLS_ALL(0.00)[] X-Spam-Level: X-Spam-Score: -6.80 X-Spam-Flag: NO Content-Type: text/plain; charset="utf-8" Instead of having a pre-filled array xen_irq_ops for Xen PV paravirt functions, drop the array and assign each element individually. This is in preparation of reducing the paravirt include hell by splitting paravirt.h into multiple more fine grained header files, which will in turn require to split up the pv_ops vector as well. Dropping the pre-filled array makes life easier for objtool to detect missing initializers in multiple pv_ops_ arrays. Signed-off-by: Juergen Gross --- V2: - new patch --- arch/x86/xen/irq.c | 20 +++++++------------- tools/objtool/check.c | 1 - 2 files changed, 7 insertions(+), 14 deletions(-) diff --git a/arch/x86/xen/irq.c b/arch/x86/xen/irq.c index 39982f955cfe..d8678c3d3971 100644 --- a/arch/x86/xen/irq.c +++ b/arch/x86/xen/irq.c @@ -40,20 +40,14 @@ static void xen_halt(void) xen_safe_halt(); } =20 -static const typeof(pv_ops) xen_irq_ops __initconst =3D { - .irq =3D { - /* Initial interrupt flag handling only called while interrupts off. */ - .save_fl =3D __PV_IS_CALLEE_SAVE(paravirt_ret0), - .irq_disable =3D __PV_IS_CALLEE_SAVE(paravirt_nop), - .irq_enable =3D __PV_IS_CALLEE_SAVE(BUG_func), - - .safe_halt =3D xen_safe_halt, - .halt =3D xen_halt, - }, -}; - void __init xen_init_irq_ops(void) { - pv_ops.irq =3D xen_irq_ops.irq; + /* Initial interrupt flag handling only called while interrupts off. */ + pv_ops.irq.save_fl =3D __PV_IS_CALLEE_SAVE(paravirt_ret0); + pv_ops.irq.irq_disable =3D __PV_IS_CALLEE_SAVE(paravirt_nop); + pv_ops.irq.irq_enable =3D __PV_IS_CALLEE_SAVE(BUG_func); + pv_ops.irq.safe_halt =3D xen_safe_halt; + pv_ops.irq.halt =3D xen_halt; + x86_init.irqs.intr_init =3D xen_init_IRQ; } diff --git a/tools/objtool/check.c b/tools/objtool/check.c index 9004fbc06769..3fd551c080ee 100644 --- a/tools/objtool/check.c +++ b/tools/objtool/check.c @@ -594,7 +594,6 @@ static int init_pv_ops(struct objtool_file *file) static const char *pv_ops_tables[] =3D { "pv_ops", "xen_cpu_ops", - "xen_irq_ops", "xen_mmu_ops", NULL, }; --=20 2.51.0