From nobody Mon Dec 1 22:35:45 2025 Received: from DM1PR04CU001.outbound.protection.outlook.com (mail-centralusazon11020128.outbound.protection.outlook.com [52.101.61.128]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D3D1F30F95F for ; Thu, 27 Nov 2025 05:06:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.61.128 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764219973; cv=fail; b=gXn2xlFhI6LAhyTKZAlFzciAQnN3g969a5zvO29uiJGDoxotmpRYgyQl76vu+EPvYgh441+0hVCXWWH8xTihuy7vqBO4kOCiceEP0WnIPIx6pT2FiSWLP2594D4VaWa4e7yiY43H+QlC476FUmgLMWCho5a5aji1hmRbenp9r7A= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764219973; c=relaxed/simple; bh=s6KddVXtoK1I5xxFaWnADOzpiJhtDnUQ4g/Js9iF/54=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=P2ds6CLPrDLNT/lCuLNTDkPaa97EU+YReRHcNMr/d8PP4caflupIv3tHjouuALs92wve14g9Qg5XXCKerAVL09YsvmNhBYj0cSKQEsQuKh7F+iezhJxYaWtM+dJtbF6jEvR1HqdTjWnkqCc0Zfdo97IJijsPzXIn2pqJmJwbOoo= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=os.amperecomputing.com; spf=pass smtp.mailfrom=os.amperecomputing.com; dkim=pass (1024-bit key) header.d=os.amperecomputing.com header.i=@os.amperecomputing.com header.b=XO+N9ZS2; arc=fail smtp.client-ip=52.101.61.128 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=os.amperecomputing.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=os.amperecomputing.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=os.amperecomputing.com header.i=@os.amperecomputing.com header.b="XO+N9ZS2" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=jwGpoN2hz0Jm0JX3BV5tl4Y7wj9WWaBnwphSVjvb3wZsfFZ8QuicW7Y23DXHQrAAiZZLAf0QKjEemG3mu0mmlJNpy39DbMFiYuMtTx1GTn9SpmZDzDgwTDqR8r8GCZ6mSo0fypR7iZydBtSOs9v8FMAdcZezw2UhjjiBt5RU2zmNLlnM43ExmLzx3DE6V/kX6xH8cehLQ63KxMdmd8IrrVTomx7fyre1dmpCrD2MOpOrFHaLqvxf0cfy16WmT0b5sBcvEyOKRGnAxuykNaS8kA13DQqM3ohNdUxaYnuL5J2+g67tw3RIzQU+1NqOZHtgMTwWHHwYjyof1I12JzgFqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lsNEkpa3tbi5Yr/LALcFR83PloNzs9jggJkBhYphaC8=; b=cvYPFVQA7NsJAWynnjNVIiOFFte/cQ5he9i1zNZsURMvJ0mQ1gCgW21ads4yp3J4IRq5g2PrROY35plLTyKOcmnjn1fYkOmeQFBGKHAsnTq/0mlDr/jIM3SmN7EMmk7P8MOKtUU0q1zDFZNe63XhAhjbOcGboazNcKLqAE1p85Nm89BZdhMQToM8NDmyRxTZjhFZ+pNemNRiJnAZ6Vjme1l6QLhfaLckC8ZgQibbojjZmGnCI2tXjGjre/6q8wr3Z0zbJIt/EPXFkhOpfHt8Lw1tdVZD3gY4z92cQBGQJuNCgzp+YJ3BZIPp7u8zrYbcSCrFUb20H+iOhif6pRmM3Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=os.amperecomputing.com; dkim=pass header.d=os.amperecomputing.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=os.amperecomputing.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lsNEkpa3tbi5Yr/LALcFR83PloNzs9jggJkBhYphaC8=; b=XO+N9ZS2BgvT90BZ7+lRNnDrchGiTLks38ormkH02+XgQx+wB5MW1EcTVyIj3m5NCJWcJsXtx09fghrxSqBRX7TIQOrxr2kdgWIfFHtcwJ1tXvZPHNreANS19DuK5A+lKPSRp4pi5p441ZGrxx9eRdUh4YaomiA8yXcIayzZ3MQ= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=os.amperecomputing.com; Received: from SN7PR01MB7969.prod.exchangelabs.com (2603:10b6:806:34a::19) by DS7PR01MB9363.prod.exchangelabs.com (2603:10b6:8:24f::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9366.14; Thu, 27 Nov 2025 05:06:09 +0000 Received: from SN7PR01MB7969.prod.exchangelabs.com ([fe80::5ca3:a44a:c242:d9eb]) by SN7PR01MB7969.prod.exchangelabs.com ([fe80::5ca3:a44a:c242:d9eb%5]) with mapi id 15.20.9366.009; Thu, 27 Nov 2025 05:06:09 +0000 From: Huang Shijie To: mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org Cc: patches@amperecomputing.com, cl@linux.com, Shubhang@os.amperecomputing.com, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, linux-kernel@vger.kernel.org, vschneid@redhat.com, vineethr@linux.ibm.com, Huang Shijie Subject: [PATCH v2 1/3] sched/fair: set rq->idle_stamp at the end of the sched_balance_newidle Date: Thu, 27 Nov 2025 13:03:51 +0800 Message-Id: <20251127050353.1089724-2-shijie@os.amperecomputing.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20251127050353.1089724-1-shijie@os.amperecomputing.com> References: <20251127050353.1089724-1-shijie@os.amperecomputing.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: KL1PR01CA0019.apcprd01.prod.exchangelabs.com (2603:1096:820::31) To SN7PR01MB7969.prod.exchangelabs.com (2603:10b6:806:34a::19) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN7PR01MB7969:EE_|DS7PR01MB9363:EE_ X-MS-Office365-Filtering-Correlation-Id: 7cb36884-a889-4fcd-78c3-08de2d72ad1a X-MS-Exchange-AtpMessageProperties: SA X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|7416014|376014|52116014|38350700014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?1DVmpaGH9fQsvIk0gPWMJaefmkQJk7O8c446ZnysPNIfdqBF2bjftxYBvxKd?= =?us-ascii?Q?RlRzEa1TEzHPA/b/5bzraG5PewRXICXz+oB+qHDu6sihlESjgitCQdncFiln?= =?us-ascii?Q?7LV8i2KdGJoAzLwV4hkdV4cbchDuKSIvKJVwhJNz0hFV+bqbHab86yonHz9b?= =?us-ascii?Q?56PE+inOZx3z0kcnBd75M8Jmq3BxI5bfaVseY5ZcCWyHe9xIFRUxYtQB86zh?= =?us-ascii?Q?aDyn1vjicBes6yQatWlFu+M9VRQLwwcf//Qo7i5vACPIpDbqrDb3jxvQ/0Ih?= =?us-ascii?Q?074Es/rkz7KaoCG4CMmbQVx6M+TrCjzJTug4ZXCv8bs6yrRTzvH3kTc4HjJ6?= =?us-ascii?Q?rqtXJx3M+Lusykl949dk+M0Z+11GdNC1WS+CSWtW4BA3STn8/FzUJYnXkb6s?= =?us-ascii?Q?MhCkgbLSUIs2H2Ig8JW0yL1LefJFfu0FWviZHaQJ08S6mbIC7ygX4xYYVjQp?= =?us-ascii?Q?bseeeY37gxmBU5m9Rj2x8Bzb+goay4eP90Y7sllm7ViiKr0vJL760j+El81Z?= =?us-ascii?Q?8As/4ocwgtVCJMd5iMdnBSCAZ8zpt6gUoocjBpe8YKS3Wm5U2bwbrEj0t/DG?= =?us-ascii?Q?BIPka1H9W0dGJ46kSvl3z91zoT2JyiRtFxH/ZCixU9iIoZbZN7fPMEYnT3ft?= =?us-ascii?Q?s0MP0GJatqjc/ihD6Ct+f5peObbwwjXTC0GITNhpsyDrB7PeTDk3NW7dyAJf?= =?us-ascii?Q?D5r5/enPGkLrJsaRZ9Qwk7qz+QLieGofpEVVgoknIUOeR3pnvYDim0BCqEaD?= =?us-ascii?Q?ws7o4p2a+cw1MJeuczC2WpFCPtp5zZnL6dLr/wX3teHYID5rDs+HPMqqAwMl?= =?us-ascii?Q?cYoGDJIpv/H//0k0n9Wyb+gmD8Qbzc2pyB3A7cCkZM3EQUpZ+O6/y80xwItW?= =?us-ascii?Q?b/cc9dedgq+OaJXuKPurxngMTRpeYVOUsYcWPpGwI7fFo9Dg6xBKJMt5hEmP?= =?us-ascii?Q?iUo1qHeZqE42MId70KUw5XzcHEy+YxQEv2oB4sGjfWOabfD4sN1kQwS2X9o7?= =?us-ascii?Q?IgoZT9zHPPfJBVKcFz1c0WbV+N/AtY3eoYVNxWOqRjufL1/Mpy5C+N5Pucv2?= =?us-ascii?Q?Y8QdAUCpTo38G+TdcEGgnJWPaJ6IH+WDwC/iBWoB1dQeC2rmGJ1IrnoOj/ip?= =?us-ascii?Q?NqzRCx4rW3aHx+42Gxhh3yxXYEqq13tyMyvXw533BdsCeaQMVThIsI1oECby?= =?us-ascii?Q?rpa4AU5NwOJJYlNDVjuT+7jGbjDyPcW6ftrbBBumIhSOtPkfEg6siitTKnHh?= =?us-ascii?Q?DMN8Oll8OCSe9Ow9Sm9bt4+7Z1HR8LcUHIop5wdPV6nO4gbyrYTKNUOyfY6p?= =?us-ascii?Q?Zrkq4KFIJ+HB0TTNO8Xv3HQDCMzmX3vJ3O+apB7w3dFnrIY8+hbKttnQeVxU?= =?us-ascii?Q?SbiqeQ/yriGZO19evEW/RdICRcsU8A0rfYyylZOkn3cM6m89zI26W9i6uVLz?= =?us-ascii?Q?D+9+L+w3D0lb22bKwd5UKviHqeLPS6+ZBdVUoHwqPEKdb/ugiVng66p0y/kn?= =?us-ascii?Q?n4dD1pf7FNN4otqi0c1S4TlcyItzHEJqW2Vi?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN7PR01MB7969.prod.exchangelabs.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(7416014)(376014)(52116014)(38350700014);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ObRaf+5/eyJesFZBLYnclgmsbWLOPb5l6sPxhCAuVPhDcoDaB+vVFIT0fMgd?= =?us-ascii?Q?QuINdSF6FA1vYmpWL+CyVk7RIMTzCwxFVx/VMPydHS8W49YslUA72u0Rsa13?= =?us-ascii?Q?Y2EJnWI5TavlmfNh4iAWSzQNqLnnnuGCjhMj+QMcFr2XtgCoxI/xZRhOl8gR?= =?us-ascii?Q?MVuusHp5KCq5G1osVaiUneKMZpf67AtLgsXObi9Uk0fFD+urFuDml9IR1CeV?= =?us-ascii?Q?sJ6OxM/7qFm/K/PeqCdaAYpeC+KPgRp0MPerkVYsYfXl/JFKwTgFXXtoymih?= =?us-ascii?Q?uMrVp3lGFOdVvSi5Vl364CXNAHb+dxkmaiAygz8vek6vbyZlJU2ous+ZbDvv?= =?us-ascii?Q?goj8/2gQM6ISW5nsG/txZFhvWwbybsZzEpDlc9XKkx9/fZSGmJZdibKmnHkw?= =?us-ascii?Q?XzIs1z1EcdmWqNaWZmpRRbUCJNAG8kGkhKRbn8JBnWLIQmqdwkPNU7JacYBd?= =?us-ascii?Q?sZ92zjFcCV7Y7guKUDSlK+stJ5CwxHJJj4glNEkZMf3bSlRqzK3aDSXwRoVG?= =?us-ascii?Q?pABQmPBleM+oNLifWtxeAZ58MB2uDloomK6Q1lUaS9Rh3Fy1UFcwBMuKY9gw?= =?us-ascii?Q?d//iOUR6WOELbVJ8XI5kRqSo2iobhImeOjN7zG8gr6WmIsKv5mMmoOlmC7F6?= =?us-ascii?Q?FXNWDNlZSJ+tiQzJFeKtwWCKJHTlYMp+PfyA6U7JhT9MUgQucMnCjHgrWnKj?= =?us-ascii?Q?gco06T9Cq/QLuEMVGGSlXBlBmBQ/UMkq9kGcPen0wBeTMr7NMngYbfEhlI+f?= =?us-ascii?Q?KPE7vVF8n9w9sQXkuu/Tv0q4eyU2ROcLEfnUEVNGismeXPdeG0sDy0jzRF8Y?= =?us-ascii?Q?/i30aTLXWQ3QQsSunVWFBqyYw3VLFBiOdZC5NcEFRXL+mjtpY0i3Ujou8+Bh?= =?us-ascii?Q?jqGcJFLHd077YonDLff13QryYwW/SOg1oMtkGM2E2OIhGXAIhUOap55N/WMF?= =?us-ascii?Q?Iz6J3JCKdRKlStDhoDBeDz6Eg5fY4fTMHDwc7s30GCgqEh9nDiMv7zKMpH7I?= =?us-ascii?Q?3E60wMbqaIcSzLUM2WzmdE2A8Kps7IRrKZlS3ojV9oXynuIzD8MiPNEIg6qs?= =?us-ascii?Q?DfMdFUZH09Vr/WK6g/hkNClpcB5kI7+VUM5uy01wMz0raL0W6sW1NDDpmfo3?= =?us-ascii?Q?sVw3OyU78UxW84Wzb19fjPqF8excJHx9jFnqzxJx7hQjn4yE2GcNH7WqMedh?= =?us-ascii?Q?qL7LCs/FdksooOJIB/+otoh7Xq1kEBDcaPRoCV0MVWUR1Yjxruegig13iiFY?= =?us-ascii?Q?Y0dTwpDEd35BM71B6YU/RT1UhLxYdHB1n0JEaWQhAiMshzcghqT0swG4XAXj?= =?us-ascii?Q?hN1x6uDjewr51HwXXCoTd6IShyb1mC+Yj5nXGZFit4/t1SYNbpOTNddnRwol?= =?us-ascii?Q?lbHD5CHsAzLyAAQNQPAL2N4P30B8NX12RRZEWysOCpLO8lO0yvFsa4LGtD8D?= =?us-ascii?Q?J/YluJlzOO5gwfkeEm3VFL7I1xz+dUuOBx0vYLeGIXoT2TdZiejoYkPnTZUB?= =?us-ascii?Q?V5+m1HKCTW1vyVfi9caTYFKDjUGO09NN+iFsmnv8srGxVd4Cyq14HC/OW2FG?= =?us-ascii?Q?nxlAft50LChsrNL70M7jx05UXjcUWjhqx+arR67OjTxEzC5IzXnGsCMsDEio?= =?us-ascii?Q?/1HGmUl/pz2FXUzGPcKCXn4=3D?= X-OriginatorOrg: os.amperecomputing.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7cb36884-a889-4fcd-78c3-08de2d72ad1a X-MS-Exchange-CrossTenant-AuthSource: SN7PR01MB7969.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Nov 2025 05:06:09.2365 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 9gOtCllchBjZDdtwwWBOLUitIfox/mOp7/Rfai42zus6/RGMct8RhnDF6rYNIhfSamiaTS23RMcKZsMPUnomehNLM9msCRekS4mOxaN4eRsXYv0Cft4/6rPaIFA/CGWR X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR01MB9363 Content-Type: text/plain; charset="utf-8" Save the idle_stamp at the beginning of sched_balance_newidle(), if it cannot pull any task, set it for rq->idle_stamp. This patch does not change the logic of rq->idle_stamp. Signed-off-by: Huang Shijie --- kernel/sched/fair.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 769d7b7990df..c1a8fa043156 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -12862,6 +12862,7 @@ static int sched_balance_newidle(struct rq *this_rq= , struct rq_flags *rf) u64 t0, t1, curr_cost =3D 0; struct sched_domain *sd; int pulled_task =3D 0; + u64 idle_stamp; =20 update_misfit_status(NULL, this_rq); =20 @@ -12877,7 +12878,9 @@ static int sched_balance_newidle(struct rq *this_rq= , struct rq_flags *rf) * for CPU_NEWLY_IDLE, such that we measure the this duration * as idle time. */ - this_rq->idle_stamp =3D rq_clock(this_rq); + idle_stamp =3D rq_clock(this_rq); + + this_rq->idle_stamp =3D 0; =20 /* * Do not pull tasks towards !active CPUs... @@ -12989,10 +12992,11 @@ static int sched_balance_newidle(struct rq *this_= rq, struct rq_flags *rf) if (time_after(this_rq->next_balance, next_balance)) this_rq->next_balance =3D next_balance; =20 - if (pulled_task) - this_rq->idle_stamp =3D 0; - else + if (!pulled_task) { + /* Set it here on purpose. */ + this_rq->idle_stamp =3D idle_stamp; nohz_newidle_balance(this_rq); + } =20 rq_repin_lock(this_rq, rf); =20 --=20 2.40.1