From nobody Mon Dec 1 22:03:24 2025 Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com [209.85.210.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6B95B2FC862 for ; Thu, 27 Nov 2025 04:45:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764218731; cv=none; b=hyvxnjdiftswsRKSFMXySkwYh/Z6hdA43r9rfc91ItJejv2+emyuLQ/+1FfEWTScffFw18XFAMR9baro6l3dy271zNhDcmmrpYvVVm1qShffoKDJBtFCHWT7U47C0rfDJcRZveTMLfUfu5C45bDAGgmzwLy2yZPOCoh/m6u8zXg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764218731; c=relaxed/simple; bh=j7cerwznDoCb24+oeW5oLFTJoYeT3BSUCAiyERN4XiY=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=CK/p7iCIIE4l4kfaGY7W+ze0j3sVTtIvPO7xh0lu8pY8kgBsMBAp5jFkvLoSVzrBOgm0IkO3F2duvmyIujQ6glC/hvXxI7+Q3HlGcCeASesNNRhN3ecfsqZP5pLT+KXfsPTRFUJG97qe+ZMh1Pw6MvKrQqQdhFc8ioc9nlO+YPo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cse.iitm.ac.in; spf=pass smtp.mailfrom=cse.iitm.ac.in; dkim=pass (2048-bit key) header.d=cse-iitm-ac-in.20230601.gappssmtp.com header.i=@cse-iitm-ac-in.20230601.gappssmtp.com header.b=caCMfT4R; arc=none smtp.client-ip=209.85.210.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cse.iitm.ac.in Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cse.iitm.ac.in Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cse-iitm-ac-in.20230601.gappssmtp.com header.i=@cse-iitm-ac-in.20230601.gappssmtp.com header.b="caCMfT4R" Received: by mail-pf1-f176.google.com with SMTP id d2e1a72fcca58-7b86e0d9615so559749b3a.0 for ; Wed, 26 Nov 2025 20:45:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cse-iitm-ac-in.20230601.gappssmtp.com; s=20230601; t=1764218720; x=1764823520; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=FNCSG6O0y1XUCsyPyiWxsEZL+WxWduKpe4ikxYEUYkY=; b=caCMfT4RuEaCiPLp/Yd8Kx6ih49A41CAtmlaICxyULH/IDgCoojaJrncv4TT4y5jTe K71B/uqJDrSiRIG0d7gnq8vB1O/mWbbHnjToQgvlxqal2N7eAcZXJ/p52/Q4txIFTHQa qpv3SlmNZgO6q8WaxKpue4zp345ZGbQG4Pev50kNRlIr3mA53KeC8mLTBQQgBMBMXmMi vZG9wbYf63rfMJEqbHsq+/2U60L2znFRbzvsFOpvjw87YZRF9CpxQsl/D0UZ848cEdh7 mJxG1KI+MeFxKv3yfNpmLlBj1LqypSdmjzbKXomwNpN4adoy2J1+zF62fVKnO4TNJQ1K tzmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764218720; x=1764823520; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=FNCSG6O0y1XUCsyPyiWxsEZL+WxWduKpe4ikxYEUYkY=; b=upk4pitll2uoELNQckdWMckZZ8giDl/+IGGw7SkhOvciono0LgI7z+dcaVNFKioIkW QGaFZcqhPMJzDqF0eyTDHcy4ECrN7wd2VdjLfh4CWRIZWcBBT/L8364sacdXQaBBRd50 JMy5CqAqIyZoB+5/epcEjR/vp3Sn/ZeKQ63SITxT3mbWo4MPewEOdm0Yy0L8YZA/dJYT X4nii1WgHnEysoJpyrDvi64m4VlkipBMBgKbQo9p6/KaLJ+hgVCxT/sR7ddUUCt3swQX XGKguj2Kfk6LAKv3fv3G355iHll899WdOhmKo0zEq0MdVJd+dxRdAoRJI/usTCTRX4ZI NnHg== X-Forwarded-Encrypted: i=1; AJvYcCXa4fyV6eIazNej4zO1VQVkMjK3gSjOU4W0ZkNqcZRdHFI1QFXpscaNBkAGQXQfw3O5hRM0ZSL1dtll4Tc=@vger.kernel.org X-Gm-Message-State: AOJu0YzonMVeq9ybeiIf/cvu7ExCF3KS7YeMatHauZNei0tXincOTT8+ lSbwlEHsnctbu2EmgcEmboWtHklAXQHGdiKuUYkypm2va6P3DLJjrOD6qhlhbBdugpICnvh2tF5 vtMJG X-Gm-Gg: ASbGncuwOZf4+abyDbVQ5V89P6cj496Pxihc/A9Tfb7QznGubWOqfjw3R0YZ+YWfmyT HFsPS8ucS8nQVYE5Nkr/zMoNcDLiu34jG8og90rTf6PElKbbydOv19O/E8L+WV58Bsk3KAY3+yK e2SkktqacL884CZobQPXEjaoXUbvtm7TXmneIUPrmvDzMBezuxGLEZa/TaH9lhnplA7hUeFmQZQ 4AgB3WzIziw1g0AGegmE6U6a2zOqVxqmuLLSK6jmGf7U469fgmEnV1FpQ0pr2q4uqlElr/47Axj f+1rljS2JaDgdi3TZQiHl8bxPReGGZ23HtxobCdAWG4DYIM5DgWaCrvGs4/VvzIknZfwyVk7cu/ Awtaof/+4KLWexbiDa2XJXXXt3RaFyKm0wi12t0RQJDCve2auxliYuIap8e2ADo7piJd0ln6xkg CwnXuJyVren7tfWxYHeZ76pMN0 X-Google-Smtp-Source: AGHT+IF2t3h2Ts6cqs4KwnXFUBEb019eDEfa5tu4lft7y2LjQjbYFe2PGGQ6RSbTPbTRDqfPZFcTdQ== X-Received: by 2002:a05:6a00:22ce:b0:7ab:4106:8508 with SMTP id d2e1a72fcca58-7c58ec0c216mr24115968b3a.28.1764218720340; Wed, 26 Nov 2025 20:45:20 -0800 (PST) Received: from localhost.localdomain ([103.158.43.19]) by smtp.googlemail.com with ESMTPSA id d2e1a72fcca58-7d15e6e6e06sm267385b3a.43.2025.11.26.20.45.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Nov 2025 20:45:19 -0800 (PST) From: Abdun Nihaal To: lee@kernel.org Cc: Abdun Nihaal , linux-kernel@vger.kernel.org Subject: [PATCH v2] mfd: mc13xxx-core: Fix memory leak in mc13xxx_add_subdevice_pdata() Date: Thu, 27 Nov 2025 10:14:56 +0530 Message-ID: <20251127044500.44820-1-nihaal@cse.iitm.ac.in> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The memory allocated for cell.name using kmemdup() is not freed when mfd_add_devices() fails. Fix that by checking return code and freeing. Fixes: 8e00593557c3 ("mfd: Add mc13892 support to mc13xxx") Signed-off-by: Abdun Nihaal --- v1->v2: - Added the include of slab.h to ensure kfree is declared before use, to fix the compiler warning pointed out by kernel test robot. drivers/mfd/mc13xxx-core.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/mfd/mc13xxx-core.c b/drivers/mfd/mc13xxx-core.c index 920797b806ce..a6eebad16026 100644 --- a/drivers/mfd/mc13xxx-core.c +++ b/drivers/mfd/mc13xxx-core.c @@ -13,6 +13,7 @@ #include #include #include +#include =20 #include "mc13xxx.h" =20 @@ -365,6 +366,7 @@ EXPORT_SYMBOL_GPL(mc13xxx_adc_do_conversion); static int mc13xxx_add_subdevice_pdata(struct mc13xxx *mc13xxx, const char *format, void *pdata, size_t pdata_size) { + int ret; char buf[30]; const char *name =3D mc13xxx_get_chipname(mc13xxx); =20 @@ -381,8 +383,11 @@ static int mc13xxx_add_subdevice_pdata(struct mc13xxx = *mc13xxx, if (!cell.name) return -ENOMEM; =20 - return mfd_add_devices(mc13xxx->dev, -1, &cell, 1, NULL, 0, + ret =3D mfd_add_devices(mc13xxx->dev, -1, &cell, 1, NULL, 0, regmap_irq_get_domain(mc13xxx->irq_data)); + if (ret) + kfree(cell.name); + return ret; } =20 static int mc13xxx_add_subdevice(struct mc13xxx *mc13xxx, const char *form= at) --=20 2.43.0