From nobody Mon Dec 1 21:30:05 2025 Received: from smtpout-03.galae.net (smtpout-03.galae.net [185.246.85.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 66FA53375DF for ; Thu, 27 Nov 2025 15:58:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.85.4 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764259138; cv=none; b=eNWAS+HZrLi3SPpxR6G/zMxZpW0JGTHc4M+OYWv6/j8ySBihzv/hQeWHDuGEYOKO+fD4KhAM0lYTJmWhSF89/I5FJ0EILbM+LFuCWzMxRgTBCNPWCx3drBpyzsX/u92IyxQb9+oeSf0iV21p3umXDRGUnwm0g2GTYeg28pReaXE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764259138; c=relaxed/simple; bh=OTsahi+laEV7d8DYR8KjywBeR3QzPhQyNE6ESIy9KZk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=VNMyZs2lrF/Log6GjL2cqRCl0Ia3HMPvT8IxvXBHe5Q/iPwvZym62+DpFQHIX3bj9WkeKmOlOsSqb/e2ZPMVhWMnNB9lZ6xGdW9RQaki6aMlhYKw+7ze5hInuWgRVjZbH57EUW6RCaB3J00eCVXG/PxM5jpPMT8inP97bfK3FP4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=BS8FldK6; arc=none smtp.client-ip=185.246.85.4 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="BS8FldK6" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-03.galae.net (Postfix) with ESMTPS id CA4844E41921; Thu, 27 Nov 2025 15:58:54 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id A003060722; Thu, 27 Nov 2025 15:58:54 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id B8489102F2ABC; Thu, 27 Nov 2025 16:58:52 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1764259134; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding; bh=eufNWz7IvSjdBi+UEIltwBbYJ3dz5TGUDVoHWNsh1yA=; b=BS8FldK6/4NVoM9rFvFQs/4IOhkeQmHxnNSNEAdcoNocZeaqdy8JRO6By3bJHiRVlCvUUm nRL+mpTYUlG1uH2WE6RctxETmi4E/4RIF122VXhS9+hMyH0PUdvyGfa76Or48GjqDqPwlp /QkqXZHQUa3bXqHp6smjLX3shtzBLDzG/xfbFysb72rM6t0nUOwNIHg3AIwD7xFRuOsBJB DZ6LzHJiy5Tu7X64T6ijseLLkbMMNTFeT1o8x/ER3tTnB+qFG74tMT4cTBH9Virwh8SJQI nDtX9yiP5qHGEn+uRHR2T/CNE9T9v+7DpuEvMkZZCcZSLXBMW37oHFR6fKpXUg== From: Romain Gantois Date: Thu, 27 Nov 2025 16:58:48 +0100 Subject: [PATCH] fpga: of-fpga-region: Fail if any bridge is missing Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251127-of-fpga-region-fail-if-bridges-not-found-v1-1-ca674f8d07eb@bootlin.com> X-B4-Tracking: v=1; b=H4sIADh1KGkC/x2NwQrCMBAFf6Xs2QdNak31V8RDNLtxQZKSVCmU/ nuDx4FhZqPKRbnSrduo8E+r5tTAnDp6vX2KDA2NyfZ2NMY6ZIHM0aNwbCrE6wcqeBYNkStSXiD 5mwLclcfL5M5DP0zUcnNh0fW/uj/2/QC8sdJuegAAAA== X-Change-ID: 20251127-of-fpga-region-fail-if-bridges-not-found-79e568743038 To: Moritz Fischer , Xu Yilun , Tom Rix Cc: Thomas Petazzoni , linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org, Romain Gantois X-Mailer: b4 0.14.3 X-Last-TLS-Session-Version: TLSv1.3 When parsing the region bridge list from the "fpga-bridges" device tree property, the of-fpga-region driver will silently ignore bridges which fail to be obtained, for example due to a missing bridge driver or invalid phandle. This can lead to hardware issues if a region bridge stays coupled when partial programming is performed. Fail if any of the bridges specified in "fpga-bridges" cannot be obtained. Signed-off-by: Romain Gantois --- drivers/fpga/of-fpga-region.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/fpga/of-fpga-region.c b/drivers/fpga/of-fpga-region.c index 43db4bb77138..caa091224dc5 100644 --- a/drivers/fpga/of-fpga-region.c +++ b/drivers/fpga/of-fpga-region.c @@ -83,7 +83,7 @@ static struct fpga_manager *of_fpga_region_get_mgr(struct= device_node *np) * done with the bridges. * * Return: 0 for success (even if there are no bridges specified) - * or -EBUSY if any of the bridges are in use. + * or an error code if any of the bridges are not available. */ static int of_fpga_region_get_bridges(struct fpga_region *region) { @@ -130,10 +130,10 @@ static int of_fpga_region_get_bridges(struct fpga_reg= ion *region) ®ion->bridge_list); of_node_put(br); =20 - /* If any of the bridges are in use, give up */ - if (ret =3D=3D -EBUSY) { + /* If any of the bridges are not available, give up */ + if (ret) { fpga_bridges_put(®ion->bridge_list); - return -EBUSY; + return ret; } } =20 --- base-commit: c9243d6df0d617535e842aa4c3d1d7dfdb91d07b change-id: 20251127-of-fpga-region-fail-if-bridges-not-found-79e568743038 Best regards, --=20 Romain Gantois