From nobody Mon Dec 1 22:36:59 2025 Received: from mail-oa1-f41.google.com (mail-oa1-f41.google.com [209.85.160.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 04C192BE7AA for ; Thu, 27 Nov 2025 15:30:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764257446; cv=none; b=QRN2rfksM57cL0XcsPbPZTc38RYkigl0CxGqsN1zrT1Uio4qkpo5bb1926XM34+AWz02+9tJeBHSxPWP+pDhrptyIdxFrpF6BDsiqCam4Zv8EmvmNp4LG4amqayzIOebkPKVyGDEp/PrO1rHj5iC95YWTyPsiSL1/6MvQdsOfTA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764257446; c=relaxed/simple; bh=QxWXz8I2QLGbWNLfwE68rNFGhHNA5j7MyCQzwVPeZ0M=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=DzBJHdQ9roCH7HN5na1/WOtJaRW3GgTno6dyuSbpFmAiP7sj6b0ljLeOdFMHJlmBWrpd6F57ulJ6YX30j2Y/gMJ34erQGKpphQMR9QuxTDqIst2Ui+bi6s52OKj2asAXHilZe63ykiR/wR71CdkdlzE66oxhWO8FgIQTX9niHzM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=debian.org; spf=pass smtp.mailfrom=gmail.com; arc=none smtp.client-ip=209.85.160.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=debian.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-oa1-f41.google.com with SMTP id 586e51a60fabf-3ec6c10a295so232229fac.0 for ; Thu, 27 Nov 2025 07:30:44 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764257444; x=1764862244; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=W8Qg3/vkOFUP1Lt1PguyJULS0qEUFEpw0xRXueJJTxk=; b=qTqoVX548lhzTikeed9PYBVRsaA4hu6oSsWHVTxx/Yy18EHY0JwHgk834jI0fzPmes +SPMmX7CE+NDS0cv/7mnlDiEoylc1UuE17kE9kH8qbpNm5S18iGFXlbwqeaG3ICq78yR 4ASX8MldH+5AET0ckb3lTZUyEDvVrUTf7JXgf20fEq6AAhbFSWKLI7g1vdBZ9j9vS9ul IE+72CgHira7PqcjO6YEV5/wj99j+AY5/MkMTu26WLcpaw2oMchqwVriEdjOb2f8m/NL T7/eLvzUShJzpz427B77mtKbR8WjM2iunocBMqpmHoChINuqfpEskSAmTpOmzld1B8qA v0bQ== X-Forwarded-Encrypted: i=1; AJvYcCXoCJi636bqwc4own4aU5J9CBbzt2zGXP+LZ4M0w/X4J6ga5x6mostueNaZNEZ5MkCa6sc5UjUKK9WDidc=@vger.kernel.org X-Gm-Message-State: AOJu0Yw3AyXJ9NcvrMo+SpQQbRPb8/Yhg78EX5tfVaZAHbSTIw3IviGd omSOWa9bzT7EML/pQp+AQ99V7gkPeKCvnmPryXI9YyVIRDB2isnyZxrx X-Gm-Gg: ASbGncuIG5HW+tFnEMkz3ggQciPuKaPMWzxj/7eAJRZ7Db8YSL7sIVb5UkAVJ4vBnD+ pQykJHjKr4M6/i+udvzxRXNa+pZph6LqXEBHvi1ST5r9g/pRm2L4T9awKoQP2/wJgnbRcty455n Sj493VZkV4nIzMHekQcAXH37m1nwcyiOXxt5bvOdfX14O0aan+3QXp+QhfPNMnGkpSSGAS9OarH XAFuF6IRAelWYR+wxIZlMk+WQZvKXJY+UXOHq/aHJY6tx3cq9NZxWXmGfnTh8q7TtvAoqmmjmY8 UZCuslgtrYglmZ16FOjqgJ2n23iZk1ZIZ9HgtZqM2qlxkBzafW24XHxDz6Wz7luj06svpD3fNau hoHwlsSd2tRsU7Wn5GQguU6U5yoR3OiAYPU8sv9rzfurH2oyMJ/KKJP2tvivjPs6CLx28u0X6R+ M9pheAaxUELgOQug== X-Google-Smtp-Source: AGHT+IE1IykwWNaeiEry9VhtjSQOXUoWbhcJ5famo3M5NrucKs2+1V7YLL+7MzjnA8KRYH24RuRu1Q== X-Received: by 2002:a05:6870:e189:b0:3e7:eee7:948f with SMTP id 586e51a60fabf-3ecbe28c234mr10135629fac.9.1764257444028; Thu, 27 Nov 2025 07:30:44 -0800 (PST) Received: from localhost ([2a03:2880:10ff:70::]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-3f0dca01676sm681892fac.5.2025.11.27.07.30.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Nov 2025 07:30:43 -0800 (PST) From: Breno Leitao Date: Thu, 27 Nov 2025 07:30:15 -0800 Subject: [PATCH net] net: netpoll: initialize work queue before error checks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251127-netpoll_fix_init_work-v1-1-65c07806d736@debian.org> X-B4-Tracking: v=1; b=H4sIAIduKGkC/x3MUQrDIBAFwKss7ztCldiAVylFilnbpWENKmkg5 O6BzgHmQOMq3BDoQOVNmhRFIDsQ0uelbzYyIxDczXlr3WSU+1qWJWbZo6j0+Cv1azyPc74nP6X sMBDWyln2//uAcsfzPC8HDLrPbAAAAA== X-Change-ID: 20251127-netpoll_fix_init_work-5e4df6c57cf2 To: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, gustavold@gmail.com, asantostc@gmail.com, kernel-team@meta.com, Breno Leitao X-Mailer: b4 0.15-dev-a6db3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1874; i=leitao@debian.org; h=from:subject:message-id; bh=QxWXz8I2QLGbWNLfwE68rNFGhHNA5j7MyCQzwVPeZ0M=; b=owEBbQKS/ZANAwAIATWjk5/8eHdtAcsmYgBpKG6iG0QG4IzWJfv7r7dibnjvjdDNxCeej7eHY NEmqg2RiteJAjMEAAEIAB0WIQSshTmm6PRnAspKQ5s1o5Of/Hh3bQUCaShuogAKCRA1o5Of/Hh3 beR4EACHVJ6a2Qdwmvsswtj8ylfPoezGyaIkHootvPBqM9calNRGBPjHRVM1qiqUWPaUBxbetVx rwVX7xpgbJXhyzL1NMsxaL4Gvfzyy/LdoUWdk7epv34GHXnGJyy0zZlDHr/67WvoMDbvRJqDdmE ZL2ZXw/uI4UbG57BCBl7MQb7w2QECbDiY8aUNKia0/dWTkgGDCCF/ck3W8X0zC+doVZgpDVzeaA idwra4nyB//J84l7UWkxKCrs1br/CStPjX9dzkl6JKMV3LcVR4RG72x/M17YXcMyktchjw1C1vv ZTmWF8dnHxCIPRqlw/y48y7a4DqQFZpE0VnxWZOeiRiUIMeX1zG2xEdsHe9G1Uv4XJ3yjc2S7Rt VOB7Zjhd6T0U2hZ7aHvzXdGrfG2wvmANEbSgE/JourJJkPIGaGdJOX3RW0bKLKhfWeZFqx2KA34 lg09MwIqd2ZF2XP8mOT2BnWDtSrIF3M8aw4kKWgMmxRTznd24SeT1SadHUlf3XR1jQ8Gts7QeIX QEqJc8uo1PDpNeAzu49CQ+kXuMpqtYf0DcXVxVfoh4x2bAihiY3Bb8jSX9gxhhPF6fevhPdcJwi AFIVj8h3irSnLTsL6cgdrTboMRGI46p4oe9tLjgpr98OOLFs/HRKe+xgcJHn00m4Anfz48ZqSYg ZJp3Ys5d4nGP79A== X-Developer-Key: i=leitao@debian.org; a=openpgp; fpr=AC8539A6E8F46702CA4A439B35A3939FFC78776D Prevent a kernel warning when netconsole setup fails on devices with IFF_DISABLE_NETPOLL flag. The warning (at kernel/workqueue.c:4242 in __flush_work) occurs because the cleanup path tries to cancel an uninitialized work queue. When __netpoll_setup() encounters a device with IFF_DISABLE_NETPOLL, it fails early and calls skb_pool_flush() for cleanup. This function calls cancel_work_sync(&np->refill_wq), but refill_wq hasn't been initialized yet, triggering the warning. Move INIT_WORK() to the beginning of __netpoll_setup(), ensuring the work queue is properly initialized before any potential failure points. This allows the cleanup path to safely cancel the work queue regardless of where the setup fails. Fixes: 248f6571fd4c5 ("netpoll: Optimize skb refilling on critical path") Signed-off-by: Breno Leitao --- net/core/netpoll.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/core/netpoll.c b/net/core/netpoll.c index 331764845e8f..09f72f10813c 100644 --- a/net/core/netpoll.c +++ b/net/core/netpoll.c @@ -554,6 +554,7 @@ int __netpoll_setup(struct netpoll *np, struct net_devi= ce *ndev) int err; =20 skb_queue_head_init(&np->skb_pool); + INIT_WORK(&np->refill_wq, refill_skbs_work_handler); =20 if (ndev->priv_flags & IFF_DISABLE_NETPOLL) { np_err(np, "%s doesn't support polling, aborting\n", @@ -591,7 +592,6 @@ int __netpoll_setup(struct netpoll *np, struct net_devi= ce *ndev) =20 /* fill up the skb queue */ refill_skbs(np); - INIT_WORK(&np->refill_wq, refill_skbs_work_handler); =20 /* last thing to do is link it to the net device structure */ rcu_assign_pointer(ndev->npinfo, npinfo); --- base-commit: f07f4ea53e22429c84b20832fa098b5ecc0d4e35 change-id: 20251127-netpoll_fix_init_work-5e4df6c57cf2 Best regards, -- =20 Breno Leitao