From nobody Tue Dec 16 21:27:05 2025 Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com [209.85.216.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5CF2F2E88BB for ; Wed, 26 Nov 2025 22:09:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764194959; cv=none; b=Ph+5qznw4ME73+TafA4qErlnfMu545h599Fq387PjWwFzFRC8MoCJ2VPjVqVd0/+pxxTw6k6I8vKXIgniwDkHDMRapBKIVi+P5gY0zD/ipuhNdk1ks9pYeGVI7V3GNrbWlKT9LTH/Dl4XCRhAZP676Ca7rNY0PxJpvUWy8avSsk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764194959; c=relaxed/simple; bh=fFJ4O8O+iumC0sGJhycYMA5SybmSXTx9sGfajEwyps4=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=BRO12W9MdcIAle8rwfTx1xDQmt3WuuguWoS1a+O7AWJDFt92HsBtLUhuY/UH3TIle0th7X0tKXesBXBdYXDLZFZhgKuPlMlOnaACQahwduQB0HIHOH98Hkb7MpBGnDT8xwJ+agJUDstwbUxR9SkzcvXmcV+U1GX2FAWvjqmn5Qk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=XTVvm5tq; arc=none smtp.client-ip=209.85.216.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XTVvm5tq" Received: by mail-pj1-f41.google.com with SMTP id 98e67ed59e1d1-340e525487eso187313a91.3 for ; Wed, 26 Nov 2025 14:09:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764194958; x=1764799758; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Pgycfg1lCnydPSo8irrQPUUm5jQlUHWZIzj/hIxjmeg=; b=XTVvm5tqZRQEJ5YUv8RN705Lpx0brI3PxJL5FUoh3pZOO+aL4j8Qi9IcnWhbphcujV xxLP7cL9BmyMzGtckuD6EcME1SS/JUgpxKTuJaKPyYsMk+luEnVToPs8VUFgvLmoY20+ Z3iBrN2WSLpKOliCUPGpI0Kg4aZmlbBhloo5n+wPlB9jl/LdkM986KeDQUp+T/waTMg3 Z839JMl1sNeIZ66D+/Mu3HTT0cdtefraVJAGharBNTs2HSgToj1oAC/xoOlK8DiPuFmv /NicyDp7SEtKYgdxEzhzuKiWmbBGDTyjSDXEOKQWloOVwPVZ4xgul3i2BkxT9S3EUPaQ kC8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764194958; x=1764799758; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Pgycfg1lCnydPSo8irrQPUUm5jQlUHWZIzj/hIxjmeg=; b=pWYv91e84jpxu8q1e90/P5yxlC0qsioP/4vI1S49xezOddpbFUvxU98m7ivvxOMJHM vNbWeIhzULVR4WMrMUs0ARFuPk/V6GAGQKlriW7pRgkjYmSSLFINwRuz8OJ6Aa/YXCew FSvJiL/1QKqBlr7ltTC6kvbgFl3h4dA5ct56u8oGU6PWgddZnt/mXaBJYzc/zrh9K7xI nzWZruwoYSiAJp47USEjz7YIOKL+boIsidiosaxQqF3fh5BMLUji/pyNB/jAGYGDUReu 6LmmkFuhKD5ZWQCXQQb/sxMJ1gLYKbLI+inkdu5JC3563al0eXrkqchpb2x07AdWA2/4 aF6Q== X-Forwarded-Encrypted: i=1; AJvYcCWYEjzKp5rp5SD1UXeLLd8A0JgirxeEsTSO4l2JRT5NN5VymDf8knYsfNxfMpAvESlWNU0QR+chvxmYGA0=@vger.kernel.org X-Gm-Message-State: AOJu0YwRY0qbs3iEfIYsgI9FUxW7ojRC12fgnYlJhDB1fML4FopTZdwt uYZoB/oC5OmXoOUDvYKf+fbBE7a8Na6wUoSMN1fCFvOw19OGf82N4j5nqdLR0+rnAYQ= X-Gm-Gg: ASbGncuFDeV7GSASbCqU5wb6tlO98HjoEbr2okyazsQ9p3wwKP61LNaCccG+e3yzUS6 LAnBNbFC3FVCOakN2eYgucSj5CQYclnjKt3KRECTQP4iX1Qc4mQyBByKb0qFpkeKiXa+vAU5tHQ crOZe4NrGNsn0EIzHxxZwUeyac8s+OirVn3ynQtBcTIvRLaO5NEilZSPoElbWOW9/HLLdTyO95v W6JJ7DgS0l3rNFJ0n/s3sYmDwheon7bwNDTqz/iDvZHQ+oCLHi3Zf/6psC6lPwxI0AklkS47K2+ hWyxs2clqAwyybdOHM/5nUDRFYLLoWo//XI4o+9dBR2bQla4xFxqWOUHuBzdqGQj2t28+0gHk6V IZvkDh79sAjR4tP3X9Ia2c1jFtG2NoYLttRoab49vmcX83f8K8VGLTfxVBSi/DW+859D1La6wwi 0AkM71URUjrgxPz7+jzqDM7ATgD/tQc4BKexaBnimknv3k0xqoPaGEKvGNuIksKFLTg1fSuhGlt xngP50ocwHEClVhj849eSPEnqDobFfUvOhh5meKpKYafoQwzN20SEb7tOdY3RtE2FoGBOwZbEUo BVfRY5nTDx0F5U8yG6/A+Ag8XbiLrda9Aw== X-Google-Smtp-Source: AGHT+IFtiRLP0ykw3vTEjN2HS8jH7oS9eKLxTNJM8TEYHICm80ZVMAQHCwxZRDjeWAHj+umd/hLZQg== X-Received: by 2002:a17:90a:d606:b0:343:b610:901c with SMTP id 98e67ed59e1d1-34733f3e4ddmr20870809a91.26.1764194957695; Wed, 26 Nov 2025 14:09:17 -0800 (PST) Received: from cyberkunju.asia-south1-c.c.gen-lang-client-0196962068.internal (125.31.93.34.bc.googleusercontent.com. [34.93.31.125]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7c3f174d2c0sm22443347b3a.66.2025.11.26.14.09.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Nov 2025 14:09:17 -0800 (PST) From: Navaneeth K To: parthiban.veerasooran@microchip.com, christian.gromm@microchip.com, gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, abdun.nihaal@gmail.com, Navaneeth K Subject: [PATCH v3] most: core: fix resource leak in most_register_interface error paths Date: Wed, 26 Nov 2025 22:08:56 +0000 Message-ID: <20251126220856.3918-1-knavaneeth786@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The function most_register_interface() did not correctly release resources if it failed early (before device_register). In these cases, it returned an error code immediately, leaking the memory allocated for the interface. Fix this by initializing the device early via device_initialize() and calling put_device() on all error paths. This ensures the release callback is triggered to free memory. Switch to using device_add() instead of device_register() to handle the split initialization. Acked-by: Abdun Nihaal Signed-off-by: Navaneeth K --- Changes in v3: - Dropped the USB cleanup patch as it was already applied upstream. - Added Reported-by and Acked-by tags. drivers/most/core.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/most/core.c b/drivers/most/core.c index da319d108ea1d..8635fd08035e9 100644 --- a/drivers/most/core.c +++ b/drivers/most/core.c @@ -1283,18 +1283,23 @@ int most_register_interface(struct most_interface *= iface) struct most_channel *c; =20 if (!iface || !iface->enqueue || !iface->configure || - !iface->poison_channel || (iface->num_channels > MAX_CHANNELS)) + !iface->poison_channel || (iface->num_channels > MAX_CHANNELS) || + !iface->dev) return -EINVAL; =20 + device_initialize(iface->dev); + id =3D ida_alloc(&mdev_id, GFP_KERNEL); if (id < 0) { dev_err(iface->dev, "Failed to allocate device ID\n"); + put_device(iface->dev); return id; } =20 iface->p =3D kzalloc(sizeof(*iface->p), GFP_KERNEL); if (!iface->p) { ida_free(&mdev_id, id); + put_device(iface->dev); return -ENOMEM; } =20 @@ -1304,7 +1309,7 @@ int most_register_interface(struct most_interface *if= ace) iface->dev->bus =3D &mostbus; iface->dev->groups =3D interface_attr_groups; dev_set_drvdata(iface->dev, iface); - if (device_register(iface->dev)) { + if (device_add(iface->dev)) { dev_err(iface->dev, "Failed to register interface device\n"); kfree(iface->p); put_device(iface->dev); --=20 2.43.0