From nobody Mon Dec 1 22:03:54 2025 Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CD14F2264C7 for ; Thu, 27 Nov 2025 01:36:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=216.40.44.12 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764207414; cv=none; b=VddDfk95jmllarrZbR9WCXcXmUVzaTRBtCvBly06VXY2UbBrTYB9yBaaoZIpWogZGqe7FrRkJ8FxeoV5O0JJqPQNGyYPbyixdHgQT2XV22acaDPn9AGGu7lr/BIADpBtipJW7LqIikCv/Ro6hTCn3TteTFUFynELxO9NBaIr6sU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764207414; c=relaxed/simple; bh=FwLJ1SjKHIhy3fHn/vSDgufCt+WcvlpqOrgEwFcCjWw=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type; b=iutF4/v+bzDoYSN0AkawWDbcfH1evOUsSPndQvCftw6IxiPZApFoliOC20M1UkmK+O5USSXslOKbGJrbYtBSm6z+/HcaISe/0AlgntIfsLURUf16LqhzP5aR2ufkc+UpVmXpL1uQyGeswhXtWTONMVCzGMyQLMvC75VFXC7/64A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=goodmis.org; spf=pass smtp.mailfrom=goodmis.org; arc=none smtp.client-ip=216.40.44.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=goodmis.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=goodmis.org Received: from omf05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 2B5748A462; Thu, 27 Nov 2025 01:36:50 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: rostedt@goodmis.org) by omf05.hostedemail.com (Postfix) with ESMTPA id 7B0BB20015; Thu, 27 Nov 2025 01:36:48 +0000 (UTC) Date: Wed, 26 Nov 2025 20:37:35 -0500 From: Steven Rostedt To: LKML Cc: Masami Hiramatsu , Mathieu Desnoyers , Mark Rutland , Andrew Morton , Shengming Hu Subject: [for-next][PATCH] fgraph: Remove coarse PID filtering from graph_entry() Message-ID: <20251126203735.5775bfb3@gandalf.local.home> X-Mailer: Claws Mail 3.20.0git84 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspamout07 X-Rspamd-Queue-Id: 7B0BB20015 X-Stat-Signature: dsbpyoiufrnhx83fxo5duhj1xrfs3mnj X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Session-ID: U2FsdGVkX19/M0ujjBhyPU696gdnwBM4ThcXxD7lvLY= X-HE-Tag: 1764207408-705496 X-HE-Meta: U2FsdGVkX19fi1GznlMnRZNAz+x+6TIrytmK291Cnds/ldCxbU79Y3cqsN7Wc30QfNWzIU7K68dEn5P3vxt2SWKIu/o3tyIWvmJO6c8q2kBDkweQHYOetm4gpphqt/Epu/7GRUqe2ZM7edNGl9kvovhhhWaLpZU12BquGnkPb9LpWBleKYDSb86cmAVnm8PAnWGwkCJn9cKtQiBlpJsscnNsUeQ25DDwKtd7anh45ZVNhJwnCAgWqj+CpnMeAaTqc7Hko7vfFUAQn3yhWOGclmI9OP83GMji9+NuYoAW7qc7kY4nINM2oPMfgtrNG34iv7EiDH7g3dy5P05CP3yl/FrldLYa1yGzfaeRWcN7aYltsvzBgT53UoJ+5Yee3Gei61osEJcuuHLgX/x2OjcIwccYuPsbJhQFw/n1IjDyWookHXuaCMzuHudUj6CyGXA2eDMC6xdzYLqcGfhsjkGvaz5z29CubgI9Xi6cWE48fQZXDVk8cVMGuAERDsInWpVbB03B9bWtLDNvkTWm7T7pnRbGb5PihiByR5J7568mAg91yNlZuTl+rDzxnTghunhRBsnZgglVfrPwxRVqgmzeayEZLkGgnpyPUiAicd6ZqliH/DKUJu0rQuN50ZL3mh12RhExnsW5Uly330iyy33oF1xre0EfSyLi Content-Type: text/plain; charset="utf-8" git://git.kernel.org/pub/scm/linux/kernel/git/trace/linux-trace.git ftrace/for-next Head SHA1: c264534c394a291495168dbf70094a89717e9023 Shengming Hu (1): fgraph: Remove coarse PID filtering from graph_entry() ---- kernel/trace/trace.h | 9 --------- kernel/trace/trace_functions_graph.c | 3 --- 2 files changed, 12 deletions(-) --------------------------- commit c264534c394a291495168dbf70094a89717e9023 Author: Shengming Hu Date: Wed Nov 26 17:35:52 2025 +0800 fgraph: Remove coarse PID filtering from graph_entry() =20 With PID filtering working via ftrace_pids_enabled() and fgraph_pid_fun= c, the coarse-grained ftrace_trace_task() check in graph_entry() is obsole= te. =20 It was only a fallback for uninitialized op->private (now fixed), and i= ts removal ensures consistent PID filtering with standard function tracing. =20 Also remove unused ftrace_trace_task() definition from trace.h. =20 Cc: Cc: Cc: Cc: Cc: Cc: Link: https://patch.msgid.link/20251126173552333XoJZN20143fWbsdTEtWoU@z= te.com.cn Signed-off-by: Shengming Hu Signed-off-by: Steven Rostedt (Google) diff --git a/kernel/trace/trace.h b/kernel/trace/trace.h index 85eabb454bee..b2b6a9775b44 100644 --- a/kernel/trace/trace.h +++ b/kernel/trace/trace.h @@ -1154,11 +1154,6 @@ struct ftrace_func_command { char *params, int enable); }; extern bool ftrace_filter_param __initdata; -static inline int ftrace_trace_task(struct trace_array *tr) -{ - return this_cpu_read(tr->array_buffer.data->ftrace_ignore_pid) !=3D - FTRACE_PID_IGNORE; -} extern int ftrace_is_dead(void); int ftrace_create_function_files(struct trace_array *tr, struct dentry *parent); @@ -1176,10 +1171,6 @@ void ftrace_clear_pids(struct trace_array *tr); int init_function_trace(void); void ftrace_pid_follow_fork(struct trace_array *tr, bool enable); #else -static inline int ftrace_trace_task(struct trace_array *tr) -{ - return 1; -} static inline int ftrace_is_dead(void) { return 0; } static inline int ftrace_create_function_files(struct trace_array *tr, diff --git a/kernel/trace/trace_functions_graph.c b/kernel/trace/trace_func= tions_graph.c index a7f4b9a47a71..75ef660e2ed5 100644 --- a/kernel/trace/trace_functions_graph.c +++ b/kernel/trace/trace_functions_graph.c @@ -232,9 +232,6 @@ static int graph_entry(struct ftrace_graph_ent *trace, return 1; } =20 - if (!ftrace_trace_task(tr)) - return 0; - if (ftrace_graph_ignore_func(gops, trace)) return 0;