From nobody Mon Dec 1 23:06:21 2025 Received: from mail-qv1-f98.google.com (mail-qv1-f98.google.com [209.85.219.98]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3318E340A5A for ; Wed, 26 Nov 2025 19:50:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.98 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764186624; cv=none; b=P+8pqmkCJ+TM0DcDAlK1yXGcZ5QWP5+zop+nDjKbdJ1ws84D4IlDyPuw8whx0Tek47TUHA/FNPy36KY2WXna+UlMIfUObsBxXvXXr+qHd0RyCkoxB+cjNsEFDOA55nYz8/mzCERXOMAIY0xGi/dTvyTh8B7D5Jws/9wKacXnHPs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764186624; c=relaxed/simple; bh=fjEmRoB9hUx/yTwurdRWTC5wYfnnnQ1F55aOcDeaZLA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=l+Sy+8nkThmgdkody4GryoldAIhm4sBDiGe8e+U+2QhYSIEp+uVsP1A5MCUrhasnUvmxGvhNpmjnnevOM9QVMtcnjMa3nlg02w5b6/ytapaPj/nZoX5GpKTlrv/lu6vPAD+g9zq9imF5bDytoj75ajOVvpakMi9dJfm44V2jg/M= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=QxLyMBqy; arc=none smtp.client-ip=209.85.219.98 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="QxLyMBqy" Received: by mail-qv1-f98.google.com with SMTP id 6a1803df08f44-882451b353fso776196d6.1 for ; Wed, 26 Nov 2025 11:50:21 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764186621; x=1764791421; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=j/O6TymoVT0YLWv0CCYV9EkHA+o+pWNxKmyURfVFr0c=; b=AeWqnovYDkVceZGnzRAYo2fxbC1BObWm+ncZb+KTYDYQXbzu3KCUtoMZGrXw7MGoOo H1citNhKsm0QNRG6lFy1JetM2Buh2BLQcLCrkjvOi8OXKbr4Z0q2CSpbbVRojqrxKqYR dNBleKchUc/OUm0zccHFKNdn14YeZ+xWtx576Rt4NQ6WoEVkUHmwtjKKDYNYaWky2uSK 9cIVf1HkykOHWGoV0sfPPoPBZcDLI31YWdEPLJ7ZmjRIbLw6stNmuB5Hj52Q2Qj08SMi oqg3dZU8XXf8xPtmA79Swwj1Qd1kYOizW4ihPbxIcQulF59cVYWhWK3BHCh4M7uKXAHA gFew== X-Forwarded-Encrypted: i=1; AJvYcCWFH3UE+rATngEI3KxGkB3YHptixOmJWWwobJ3gFJbqtkcJAD72ixW3Q18MzFOoosw89Kti5vj4Z9U3QnQ=@vger.kernel.org X-Gm-Message-State: AOJu0YyW1opapB/TjWpZ2R517pBkXNec+NFqCedT0SXyIgZy+6xXB8JE kKPJxGUL3UPDIgDyoisPDi1MKkbAANi4Mr218I2IBWBZaboQlRVv5msfEjiTgzE4xfLoqw/PWYc 5gBmYWdCOw0EjeajVrKGHHzAfDBeDZcrbuUBL0dbVZPRUPDWpLlJ6QDwX2YT18w75JrjoVAuhLp heIh3xMaZaYiusr//rA7mW2Q4cdQ91/edp/kBvkoYNigzculT+WW8ze3iODrvOjDrbCOIZWbsS6 3CRpO+fRYnPCykKQWXNOB39Di4L X-Gm-Gg: ASbGnctVA9iUKdImncxoLEXHgCRDypjeDOmQ0ief9MbFv0rxU6UANmy1y9/Jlp3fNec yD+3KOmVZUIFjdz154GmOqZUZquuRCQbYpfgoPXCj0dfv+9xO9ri4MVQARwCu4hg+N7INn0aAWd LEuT0/7hCZiPhDbyhiRJw8dZZ0P9b4fK/48RF9G5vKOxuVY0SL8yFlZgpgLlJZMQRhiSHi5ygG9 NI6Tlc+U7hZ0/+1CEPUoQKira0Xn31iXadM49mBN4n/dOqmLXSDKuKQepArqfYUX0/nl78xDYnI cIm0aDWuwPW5vG64WkigmBXTDAd3ONFdjGeGqxhOgys/sxcpAIeGGbmRQa+tH/lHsD4mL6g40cJ T3S/rU8sxBiRv8LZPrnSnX/aC3rGj7Y2XG+lFiQaPNdLfUtki1G6kT6a1eRjIlTZfHPyjiJV+H6 ZHRr9aPV+GWNonbb2atYT5AANfkbmthfwSXKI5kvCdqLHsNviZQIE= X-Google-Smtp-Source: AGHT+IHic71/FFzKYEZVJElfwk6p2cQ2hiPr1C8RbXw+pFASoeCgvhqo2PHadQYlmQLR+WKAkd+SZ8eoN1JL X-Received: by 2002:a05:6214:240a:b0:880:4b29:d96f with SMTP id 6a1803df08f44-8863af9e2femr125051506d6.39.1764186620974; Wed, 26 Nov 2025 11:50:20 -0800 (PST) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-11.dlp.protect.broadcom.com. [144.49.247.11]) by smtp-relay.gmail.com with ESMTPS id 6a1803df08f44-8846e457e7csm23358586d6.7.2025.11.26.11.50.20 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 26 Nov 2025 11:50:20 -0800 (PST) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-297e66542afso3559725ad.3 for ; Wed, 26 Nov 2025 11:50:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1764186620; x=1764791420; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=j/O6TymoVT0YLWv0CCYV9EkHA+o+pWNxKmyURfVFr0c=; b=QxLyMBqyHYHo6fnFL8Re4JuZPo+G+i4mbooIMTp2xD2S4CRQTW2RR6kJO0vQTGbISM mDfybrlZdzjsvnNgMhHukfsxArc1j1pCaNji7za5tgvUOdncqtpCihYY+RfmrH7bNlDq JWMcHpRa4xXOsrzUiNIdQr72yx0yEZHFhxORU= X-Forwarded-Encrypted: i=1; AJvYcCXJwJY/akCj6KMoY6NTDIjnx54vCcUmCElY+zlpY906k4nB0m01hPA3Wo16/JzPXR/HyEOB2jsOzjVFVaM=@vger.kernel.org X-Received: by 2002:a17:903:2f07:b0:298:2cdf:56c8 with SMTP id d9443c01a7336-29bab300f4dmr79404275ad.60.1764186619736; Wed, 26 Nov 2025 11:50:19 -0800 (PST) X-Received: by 2002:a17:903:2f07:b0:298:2cdf:56c8 with SMTP id d9443c01a7336-29bab300f4dmr79404015ad.60.1764186619349; Wed, 26 Nov 2025 11:50:19 -0800 (PST) Received: from localhost.localdomain ([192.19.203.250]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-29b5b25e638sm206782375ad.58.2025.11.26.11.50.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Nov 2025 11:50:18 -0800 (PST) From: Bhargava Marreddy To: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, michael.chan@broadcom.com, pavan.chebbi@broadcom.com, vsrama-krishna.nemani@broadcom.com, vikas.gupta@broadcom.com, Bhargava Marreddy , Rajashekar Hudumula Subject: [v3, net-next 04/12] bng_en: Handle an HWRM completion request Date: Thu, 27 Nov 2025 01:19:23 +0530 Message-ID: <20251126194931.455830-5-bhargava.marreddy@broadcom.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20251126194931.455830-1-bhargava.marreddy@broadcom.com> References: <20251126194931.455830-1-bhargava.marreddy@broadcom.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e Content-Type: text/plain; charset="utf-8" Since the HWRM completion for a sent request lands on the NQ, add functions to handle the HWRM completion event. Signed-off-by: Bhargava Marreddy Reviewed-by: Vikas Gupta Reviewed-by: Rajashekar Hudumula --- .../net/ethernet/broadcom/bnge/bnge_netdev.c | 4 +- .../net/ethernet/broadcom/bnge/bnge_netdev.h | 1 + .../net/ethernet/broadcom/bnge/bnge_txrx.c | 44 ++++++++++++++++++- 3 files changed, 46 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c b/drivers/net= /ethernet/broadcom/bnge/bnge_netdev.c index c43b729e23c..bb9223a00b5 100644 --- a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c +++ b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c @@ -18,6 +18,7 @@ #include =20 #include "bnge.h" +#include "bnge_hwrm.h" #include "bnge_hwrm_lib.h" #include "bnge_ethtool.h" #include "bnge_rmem.h" @@ -2315,8 +2316,7 @@ static int bnge_open(struct net_device *dev) =20 static int bnge_shutdown_nic(struct bnge_net *bn) { - /* TODO: close_path =3D 0 until we make NAPI functional */ - bnge_hwrm_resource_free(bn, 0); + bnge_hwrm_resource_free(bn, 1); return 0; } =20 diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h b/drivers/net= /ethernet/broadcom/bnge/bnge_netdev.h index 41af5827a25..3c8fffb5e2d 100644 --- a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h +++ b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h @@ -78,6 +78,7 @@ struct tx_cmp { #define CMPL_BASE_TYPE_HWRM_FWD_REQ 0x22UL #define CMPL_BASE_TYPE_HWRM_FWD_RESP 0x24UL #define CMPL_BASE_TYPE_HWRM_ASYNC_EVENT 0x2eUL + #define CMPL_BA_TY_HWRM_ASY_EVT CMPL_BASE_TYPE_HWRM_ASYNC_EVENT #define TX_CMP_FLAGS_ERROR (1 << 6) #define TX_CMP_FLAGS_PUSH (1 << 7) u32 tx_cmp_opaque; diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_txrx.c b/drivers/net/e= thernet/broadcom/bnge/bnge_txrx.c index f4168729c7d..c8e9b96aa1c 100644 --- a/drivers/net/ethernet/broadcom/bnge/bnge_txrx.c +++ b/drivers/net/ethernet/broadcom/bnge/bnge_txrx.c @@ -397,6 +397,43 @@ static void __bnge_poll_work_done(struct bnge_net *bn,= struct bnge_napi *bnapi, } } =20 +static void +bnge_hwrm_update_token(struct bnge_dev *bd, u16 seq_id, + enum bnge_hwrm_wait_state state) +{ + struct bnge_hwrm_wait_token *token; + + rcu_read_lock(); + hlist_for_each_entry_rcu(token, &bd->hwrm_pending_list, node) { + if (token->seq_id =3D=3D seq_id) { + WRITE_ONCE(token->state, state); + rcu_read_unlock(); + return; + } + } + rcu_read_unlock(); + dev_err(bd->dev, "Invalid hwrm seq id %d\n", seq_id); +} + +static int bnge_hwrm_handler(struct bnge_dev *bd, struct tx_cmp *txcmp) +{ + struct hwrm_cmpl *h_cmpl =3D (struct hwrm_cmpl *)txcmp; + u16 cmpl_type =3D TX_CMP_TYPE(txcmp), seq_id; + + switch (cmpl_type) { + case CMPL_BASE_TYPE_HWRM_DONE: + seq_id =3D le16_to_cpu(h_cmpl->sequence_id); + bnge_hwrm_update_token(bd, seq_id, BNGE_HWRM_COMPLETE); + break; + + case CMPL_BASE_TYPE_HWRM_ASYNC_EVENT: + default: + break; + } + + return 0; +} + static int __bnge_poll_work(struct bnge_net *bn, struct bnge_cp_ring_info = *cpr, int budget) { @@ -447,8 +484,11 @@ static int __bnge_poll_work(struct bnge_net *bn, struc= t bnge_cp_ring_info *cpr, rx_pkts++; else if (rc =3D=3D -EBUSY) /* partial completion */ break; + } else if (unlikely(cmp_type =3D=3D CMPL_BASE_TYPE_HWRM_DONE || + cmp_type =3D=3D CMPL_BASE_TYPE_HWRM_FWD_REQ || + cmp_type =3D=3D CMPL_BA_TY_HWRM_ASY_EVT)) { + bnge_hwrm_handler(bn->bd, txcmp); } - raw_cons =3D NEXT_RAW_CMP(raw_cons); =20 if (rx_pkts && rx_pkts =3D=3D budget) { @@ -565,6 +605,8 @@ int bnge_napi_poll(struct napi_struct *napi, int budget) work_done +=3D __bnge_poll_work(bn, cpr, budget - work_done); nqr->has_more_work |=3D cpr->has_more_work; + } else { + bnge_hwrm_handler(bn->bd, (struct tx_cmp *)nqcmp); } raw_cons =3D NEXT_RAW_CMP(raw_cons); } --=20 2.47.3