From nobody Mon Dec 1 23:06:22 2025 Received: from mail-yx1-f97.google.com (mail-yx1-f97.google.com [74.125.224.97]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EC41A340283 for ; Wed, 26 Nov 2025 19:50:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.224.97 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764186615; cv=none; b=dWfVs6NQofMoGrjBivfpyL1tzdfgvJpuwQsUuo4ei1KSpwE1b+nTNYAVFCFLh2RgmhAoBbn9wXiqe0rgfGkxW10bQW7OMgCgpVVajJQch5bCFSpjxHp11FpxYWJZ1rTXrdHQudtaLDx1YcriZN7HfbI9hOyAi5+Br4jcsgJT1Vk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764186615; c=relaxed/simple; bh=hk0dXykGCmNbrFeThn9+TK9B/my7uHNR3BCQlXSq/ms=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=lg2+uKy7Y64/1yEZ1UIFSabSLl11EG7Uqpdvcw92gE+Di8dEk/roCI5SDq9xo2rxmPKNrLuJTWJ7/TvS60l5+Ey+61ZwSVBm0ublola3Nmlk65fHDm3nBytXgGT/9/hi0jmegui/nJXL6g3c/TJ66zE6lRe+hBRX9UQFkjJtgCY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=Zsjbv/6v; arc=none smtp.client-ip=74.125.224.97 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="Zsjbv/6v" Received: by mail-yx1-f97.google.com with SMTP id 956f58d0204a3-640daf41b19so259313d50.0 for ; Wed, 26 Nov 2025 11:50:13 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764186613; x=1764791413; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=lolwq9gTk1seDw4oQyBfgaM19vDbI49PtwNcLlnVu/g=; b=Z9ciEQsqzRar/RVNz0drA5YAMjrT+bhCl2LExEnCWzO4SAjtoDs9d9IwHN2G6Dt1ZP YebuzgxaZM84G5PjuEOIpn9zucZxEQ0QoOA1D74hLinu8wAkGLu6EXVmak4sE6yBDGjg 62vm/nKd4+EevASEBylKVbvU2XU5+vSfgXKfuh9M3DqE4TwlqR1d01Xh9ZfPsvUfUYOv h4cgllzU+nk1J98TFCoCbpjpx2ismCdRR2S1f6JTqAhCUkJFy10uZH1sUm+Of9FBQVTl mp0KUdqw+hU00cqOlPlBCcM2/Rg1iELYFdOQcBO12opcwt/rsaHAI2+uaEO6CrR+H8D0 Smkw== X-Forwarded-Encrypted: i=1; AJvYcCVsAIEsGhDCzeCwczpSjc+J75h2VMH1IdXRlodWk4SbmbS3+XOYxfLFmItx7WC2Y5Yeg8TkF1F3F5oRhLU=@vger.kernel.org X-Gm-Message-State: AOJu0YzYhGAMHOK/dznCjBDc/hVJS1VrL25NRGpZaK8FHm7PRZjxiPTo fl706xFWDwxgFMo4iRyos5ePkBMlB5Gro0ccPdQdLYBHhL0j56hltJ7VBsjQltYQKzrz9w0qXaU WZSl2AFl8P6EPhO98km99hn+Xt9ebIhTDJRtFYmJht9QhAo9tRakxzMbLWsun8ADXZrI7iGZBfG NREqmLuL+8HeBGXecDL6ecKtbrrOlWbiIbpMEqVBJm3+D4jk+BxiE2WfnnlgZBsW+xOfLSE54YS ll1W7v+V475amrmnfkuVfnHNpl1 X-Gm-Gg: ASbGnctQGlqjq746K6vt3KGQ+xbfy+qXZdXxxsu9WtyNPdvWipiXKjMlyqirg4yCmho ENrUbepDa4cxmJEq99WEhoVlPBboM7gGaqRaphb33gxW2+deLTG8KqxDhwdYO06yYqpBNU6Wqi/ zAvg19+Dx9Tjd0FFnMrtbZGRxMhywF/ADM0OPhNvYugCx0nZuHR0xgR78ozXZkmMXjjOFT65IBq GLb6vlO3cg9NjT6yJKSxK9vgeII+EvpUVY2ZQe0VeK9vTKG+Upx4GWiGYrokscojgy1U2/HrU/6 tWq9pgwW4AmBUrSmrgC+/jkpkeBM3YCFc2g26mPEpBVtidJZCfG++udaaQo2XLHO6LHATHEP0P3 yvmtVyU+4lj0ejymIYF5yu3flzN2UCB2RX1gOXKusMHhjEoofPiUX/6uukykEYzNQQcKl3w0RwJ XfoQQJHtGGXmhWxluwxncrtf4e60jr+w77Vste+Q4F2ylYZeani8s= X-Google-Smtp-Source: AGHT+IF7jrX7sM9p2JhjPdUB4oo5bwlOjc3wUVomdHYQUF1GGdaai447fPtcdUyqGAWZ77cXzufF4Pthruay X-Received: by 2002:a05:690e:1c1a:b0:63f:b985:66b5 with SMTP id 956f58d0204a3-64302592bf6mr13454564d50.6.1764186612651; Wed, 26 Nov 2025 11:50:12 -0800 (PST) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-77.dlp.protect.broadcom.com. [144.49.247.77]) by smtp-relay.gmail.com with ESMTPS id 956f58d0204a3-642f70cf301sm1786957d50.7.2025.11.26.11.50.12 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 26 Nov 2025 11:50:12 -0800 (PST) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-pg1-f200.google.com with SMTP id 41be03b00d2f7-bd74e95f05aso752155a12.1 for ; Wed, 26 Nov 2025 11:50:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1764186610; x=1764791410; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=lolwq9gTk1seDw4oQyBfgaM19vDbI49PtwNcLlnVu/g=; b=Zsjbv/6vyIoaHUJokIehU4X0px4LHVkMKeUw3RbDPiYNqcKVM7hDpG0qRlz9sYCJP8 9FvecrqNhUufb0hJxJ1VF+kYLUpVxDp26yDuDI04e9XhKpXi/nkxOJrfeRgAMnHPWB7v aKdXzbyKf1j8uNTrDaVJNdcf7oONK+W8Yw/50= X-Forwarded-Encrypted: i=1; AJvYcCWDg0SrPiXojtIZ/YNBZAyaC5FHXA2LoENpL3Ua9xVRTFEHswuZa7xuLGTK+8o5v8Z7wbMENGb3ZxL5Mco=@vger.kernel.org X-Received: by 2002:a17:902:ea0e:b0:295:5898:ff5c with SMTP id d9443c01a7336-29b6bfa9738mr273543195ad.16.1764186610639; Wed, 26 Nov 2025 11:50:10 -0800 (PST) X-Received: by 2002:a17:902:ea0e:b0:295:5898:ff5c with SMTP id d9443c01a7336-29b6bfa9738mr273542975ad.16.1764186610174; Wed, 26 Nov 2025 11:50:10 -0800 (PST) Received: from localhost.localdomain ([192.19.203.250]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-29b5b25e638sm206782375ad.58.2025.11.26.11.50.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Nov 2025 11:50:09 -0800 (PST) From: Bhargava Marreddy To: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, michael.chan@broadcom.com, pavan.chebbi@broadcom.com, vsrama-krishna.nemani@broadcom.com, vikas.gupta@broadcom.com, Bhargava Marreddy , Rajashekar Hudumula Subject: [v3, net-next 02/12] bng_en: Extend bnge_set_ring_params() for rx-copybreak Date: Thu, 27 Nov 2025 01:19:21 +0530 Message-ID: <20251126194931.455830-3-bhargava.marreddy@broadcom.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20251126194931.455830-1-bhargava.marreddy@broadcom.com> References: <20251126194931.455830-1-bhargava.marreddy@broadcom.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e Content-Type: text/plain; charset="utf-8" Add rx-copybreak support in bnge_set_ring_params() Signed-off-by: Bhargava Marreddy Reviewed-by: Vikas Gupta Reviewed-by: Rajashekar Hudumula --- .../net/ethernet/broadcom/bnge/bnge_netdev.c | 19 +++++++++++++++++-- .../net/ethernet/broadcom/bnge/bnge_netdev.h | 5 +++-- 2 files changed, 20 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c b/drivers/net= /ethernet/broadcom/bnge/bnge_netdev.c index 4172278900b..d0462bd1db0 100644 --- a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c +++ b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c @@ -13,6 +13,7 @@ #include #include #include +#include #include #include =20 @@ -2313,7 +2314,6 @@ void bnge_set_ring_params(struct bnge_dev *bd) rx_space =3D rx_size + ALIGN(NET_SKB_PAD, 8) + SKB_DATA_ALIGN(sizeof(struct skb_shared_info)); =20 - bn->rx_copy_thresh =3D BNGE_RX_COPY_THRESH; ring_size =3D bn->rx_ring_size; bn->rx_agg_ring_size =3D 0; bn->rx_agg_nr_pages =3D 0; @@ -2352,7 +2352,10 @@ void bnge_set_ring_params(struct bnge_dev *bd) bn->rx_agg_ring_size =3D agg_ring_size; bn->rx_agg_ring_mask =3D (bn->rx_agg_nr_pages * RX_DESC_CNT) - 1; =20 - rx_size =3D SKB_DATA_ALIGN(BNGE_RX_COPY_THRESH + NET_IP_ALIGN); + rx_size =3D max3(BNGE_DEFAULT_RX_COPYBREAK, + bn->rx_copybreak, + bn->netdev->cfg_pending->hds_thresh); + rx_size =3D SKB_DATA_ALIGN(rx_size + NET_IP_ALIGN); rx_space =3D rx_size + NET_SKB_PAD + SKB_DATA_ALIGN(sizeof(struct skb_shared_info)); } @@ -2385,6 +2388,17 @@ void bnge_set_ring_params(struct bnge_dev *bd) bn->cp_ring_mask =3D bn->cp_bit - 1; } =20 +static void bnge_init_ring_params(struct bnge_net *bn) +{ + u32 rx_size; + + bn->rx_copybreak =3D BNGE_DEFAULT_RX_COPYBREAK; + /* Try to fit 4 chunks into a 4k page */ + rx_size =3D SZ_1K - + NET_SKB_PAD - SKB_DATA_ALIGN(sizeof(struct skb_shared_info)); + bn->netdev->cfg->hds_thresh =3D max(BNGE_DEFAULT_RX_COPYBREAK, rx_size); +} + int bnge_netdev_alloc(struct bnge_dev *bd, int max_irqs) { struct net_device *netdev; @@ -2474,6 +2488,7 @@ int bnge_netdev_alloc(struct bnge_dev *bd, int max_ir= qs) bn->rx_dir =3D DMA_FROM_DEVICE; =20 bnge_set_tpa_flags(bd); + bnge_init_ring_params(bn); bnge_set_ring_params(bd); =20 bnge_init_l2_fltr_tbl(bn); diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h b/drivers/net= /ethernet/broadcom/bnge/bnge_netdev.h index 85c4f6f5371..b267f0b14c1 100644 --- a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h +++ b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h @@ -136,7 +136,8 @@ struct bnge_ring_grp_info { u16 nq_fw_ring_id; }; =20 -#define BNGE_RX_COPY_THRESH 256 +#define BNGE_DEFAULT_RX_COPYBREAK 256 +#define BNGE_MAX_RX_COPYBREAK 1024 =20 #define BNGE_HW_FEATURE_VLAN_ALL_RX \ (NETIF_F_HW_VLAN_CTAG_RX | NETIF_F_HW_VLAN_STAG_RX) @@ -187,7 +188,7 @@ struct bnge_net { u32 rx_buf_size; u32 rx_buf_use_size; /* usable size */ u32 rx_agg_ring_size; - u32 rx_copy_thresh; + u32 rx_copybreak; u32 rx_ring_mask; u32 rx_agg_ring_mask; u16 rx_nr_pages; --=20 2.47.3