From nobody Mon Dec 1 23:06:21 2025 Received: from mail-ua1-f97.google.com (mail-ua1-f97.google.com [209.85.222.97]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2F006346A08 for ; Wed, 26 Nov 2025 19:50:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.97 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764186662; cv=none; b=gGPVfLyfTFmgQZ3xjPfE4Cwt3cF35H/MQa9cG60jkwq5SN4rSyhqzq6MEaSptbJQoeuWSdrGTvMk9x+aXEmDQl62jISLTYaDz6vCHpfwCOugq1WfzMbB7bAo+GEql4Ud4Upate2aS3i1i1lxCq0YSU9Z36tJMMihA/MwDcqCwxY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764186662; c=relaxed/simple; bh=mOMNgsdaJGLje42JWqQX6EDqvamZOoQqsVrpT5JU02Q=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=jIrvq640NpmNbZWEsGPXm7GFkEUpeJudOb1txqOz+JTELNFZ/+7N4XVt4X61Uwv8heXxvKQe7IkHEyBCw9SodcznhmyEaN/fOeJR+2B8iiDl/bPr8vti3+z09H8inQ8rr6CU3Yy1FnYMjYgnQgn7XZnUp6icSchQpDa3ZjZ0ZCE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=MwFzhtE/; arc=none smtp.client-ip=209.85.222.97 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="MwFzhtE/" Received: by mail-ua1-f97.google.com with SMTP id a1e0cc1a2514c-9372149216bso72695241.3 for ; Wed, 26 Nov 2025 11:50:58 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764186658; x=1764791458; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=m5S4fHoRERV2MSCcvgLtmo8rkmlmMx1nGkGx6XewVPE=; b=an0TQ63KMexyeLD6nKCsKlxBH5JJGrWoVUUWc4ecWxAdQ6sqd1bfAhODzXGh7XlnDX ey1FaV4MjbL2hQuwmkX9svqSkFMI48t/+IiMPdhV1UX6NWMgLLmrwkkeL0yxpbnB8iIQ OHvjl8JUZyS9fLyA6763uFkl5+hU8wlEUWZZJz3BY6OUwb9vqwmTG3dh1Qmio67OU08T BXykG2v/HBZtw3VbQY1XQqhnomQIuDW6kU4IHxkcOZOAd2RL/yWWhQHi8aEA21L9vP9R t2TgttLP5KuD0CfmcN8/1ZH9agUVu/pHuoygy3rg4bOoHu4gOaB/An1IfnW4Nc2RAneJ /QHg== X-Forwarded-Encrypted: i=1; AJvYcCWuWQz0vG7cN5TCmqRMmyUW/HUzI4FMODxWY1CN+So1CzgUGj9iWBv1GCW1kHu2X3HtD33HiqzJb2d8Pao=@vger.kernel.org X-Gm-Message-State: AOJu0YyQREPStCDrqaPFeMkMOCR0bVpgIg0u+seoWYIlMO4I5Ft0GE5V V1HItehyU+cU5ljINiaprdi7gTg5lhGT0L2OJcdupGt41O3y811l/hfG6t5hvi+HuFe/GrQ70d+ 1tRo3nO+qmYdmzYu8QSSvJNkuB/j08rfjUyZR0AsPxzLwawUT19Q42Ux95VnMc6OR7keXAf3ZHZ wBvNkPP4dE+77uXcZS/26sei1BEy3IVZMHJnA7u9MEPKGiyfFU8zboCYKXQr9OT9nkCI7W5r1q7 6MnOy+rX8iduAM1YHCKji6ZlerJ X-Gm-Gg: ASbGncuOOm0mHB0WS3i27MUrG4g7/DrKtYbC6OexwmSOGWPHQhQrqcVHOunS8hyweX4 xJxryVptYmdRHwd1Na0IIkrILxsxMpVPt5M0snAQaBw9PGclr3k6HMHxy4WajxbI4S2hiCOJxS0 USx30E3BV9yQvr326F0kDsiDHVhY0aHudS13tFKjCakqzaE7D0dPOui6tUpz1m7YZ1mkDFLY57y uXylkf3eVhvuz+ZMyV6E2ge+Lo3PHw0nCteAABAKZgZboCWq21biwnThqiZr3OUhTZ4GEgvBprT JckRNfwBhEKMZythwMRINkT+GRsjiLN0AdJk8QaHKzPr1bgaRsNTXvOR3zi61Jn5Um6L/BDj4WO oJGhVzCd8PAePipOkpudHkiZCk6dF3R1z4FEDhuMsNoMCPDlDXI5ggOuew2l0beRalUcd2zY10S ojBYcIygkYrd36aXtP+VYaKHWSq+0hdqEXB28/Fmizv+kLHtLO4So= X-Google-Smtp-Source: AGHT+IEt4BIf4MjyRo/VwlO1ZW+YSl+hDiDM1xRVOZd/hTBRtSgiV1kq3/z7xjyueRIJ4CdqOA4E6kGXytnC X-Received: by 2002:a05:6102:4189:b0:5d6:254f:4e24 with SMTP id ada2fe7eead31-5e2243dd64amr3109567137.32.1764186657968; Wed, 26 Nov 2025 11:50:57 -0800 (PST) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-11.dlp.protect.broadcom.com. [144.49.247.11]) by smtp-relay.gmail.com with ESMTPS id ada2fe7eead31-5e1bd92ec2bsm2521201137.1.2025.11.26.11.50.57 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 26 Nov 2025 11:50:57 -0800 (PST) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-297ddb3c707so826405ad.2 for ; Wed, 26 Nov 2025 11:50:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1764186656; x=1764791456; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=m5S4fHoRERV2MSCcvgLtmo8rkmlmMx1nGkGx6XewVPE=; b=MwFzhtE/VriYPuHpEZa6jVOQAF9NjGgw/LgMP4GKlnA3isBG04z3FVfyHQlelBWC3Z SAMrWuvlvA2+ziKqBY8UlRqUWRSSkPXid3hC7TlMjInqDY7OeK0TayIvrYTVRvgGLEAe ORToP9iIcZlhdckWKRX0Nvx8WdsHOsdqVRk00= X-Forwarded-Encrypted: i=1; AJvYcCVyZgt1VJP99E6CF0t2wNfP4JNJbQh4FtLkzfaRaJGlo+GejfEqHgUOtolgR+8DiBMQ0hrUkmPq7yScZHw=@vger.kernel.org X-Received: by 2002:a17:902:d58c:b0:294:fcae:826 with SMTP id d9443c01a7336-29bab2fa50bmr91295875ad.59.1764186656361; Wed, 26 Nov 2025 11:50:56 -0800 (PST) X-Received: by 2002:a17:902:d58c:b0:294:fcae:826 with SMTP id d9443c01a7336-29bab2fa50bmr91295605ad.59.1764186655972; Wed, 26 Nov 2025 11:50:55 -0800 (PST) Received: from localhost.localdomain ([192.19.203.250]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-29b5b25e638sm206782375ad.58.2025.11.26.11.50.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Nov 2025 11:50:55 -0800 (PST) From: Bhargava Marreddy To: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, michael.chan@broadcom.com, pavan.chebbi@broadcom.com, vsrama-krishna.nemani@broadcom.com, vikas.gupta@broadcom.com, Bhargava Marreddy , Rajashekar Hudumula Subject: [v3, net-next 12/12] bng_en: Query firmware for statistics and accumulate Date: Thu, 27 Nov 2025 01:19:31 +0530 Message-ID: <20251126194931.455830-13-bhargava.marreddy@broadcom.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20251126194931.455830-1-bhargava.marreddy@broadcom.com> References: <20251126194931.455830-1-bhargava.marreddy@broadcom.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e Content-Type: text/plain; charset="utf-8" Use the per-PF workqueue and timer infrastructure to asynchronously fetch statistics from firmware and accumulate them in the PF context. With this patch, ethtool -S exposes all hardware stats. Signed-off-by: Bhargava Marreddy Reviewed-by: Vikas Gupta Reviewed-by: Rajashekar Hudumula --- .../net/ethernet/broadcom/bnge/bnge_netdev.c | 95 +++++++++++++++++++ 1 file changed, 95 insertions(+) diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c b/drivers/net= /ethernet/broadcom/bnge/bnge_netdev.c index 824374c1d9c..262713260a4 100644 --- a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c +++ b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c @@ -253,6 +253,17 @@ static int bnge_alloc_ring_stats(struct bnge_net *bn) return rc; } =20 +static void __bnge_queue_sp_work(struct bnge_dev *bd) +{ + queue_work(bd->bnge_pf_wq, &bd->sp_task); +} + +static void bnge_queue_sp_work(struct bnge_dev *bd, unsigned int event) +{ + set_bit(event, &bd->sp_event); + __bnge_queue_sp_work(bd); +} + void bnge_timer(struct timer_list *t) { struct bnge_dev *bd =3D timer_container_of(bd, t, timer); @@ -265,16 +276,100 @@ void bnge_timer(struct timer_list *t) if (atomic_read(&bn->intr_sem) !=3D 0) goto bnge_restart_timer; =20 + if (BNGE_LINK_IS_UP(bd) && bn->stats_coal_ticks) + bnge_queue_sp_work(bd, BNGE_PERIODIC_STATS_SP_EVENT); + bnge_restart_timer: mod_timer(&bd->timer, jiffies + bd->current_interval); } =20 +static void bnge_add_one_ctr(u64 hw, u64 *sw, u64 mask) +{ + u64 sw_tmp; + + hw &=3D mask; + sw_tmp =3D (*sw & ~mask) | hw; + if (hw < (*sw & mask)) + sw_tmp +=3D mask + 1; + WRITE_ONCE(*sw, sw_tmp); +} + +static void __bnge_accumulate_stats(__le64 *hw_stats, u64 *sw_stats, u64 *= masks, + int count) +{ + int i; + + for (i =3D 0; i < count; i++) { + u64 hw =3D le64_to_cpu(READ_ONCE(hw_stats[i])); + + if (masks[i] =3D=3D -1ULL) + sw_stats[i] =3D hw; + else + bnge_add_one_ctr(hw, &sw_stats[i], masks[i]); + } +} + +static void bnge_accumulate_stats(struct bnge_stats_mem *stats) +{ + if (!stats->hw_stats) + return; + + __bnge_accumulate_stats(stats->hw_stats, stats->sw_stats, + stats->hw_masks, stats->len / 8); +} + +static void bnge_accumulate_all_stats(struct bnge_dev *bd) +{ + struct bnge_net *bn =3D netdev_priv(bd->netdev); + struct bnge_stats_mem *ring0_stats; + int i; + + for (i =3D 0; i < bd->nq_nr_rings; i++) { + struct bnge_napi *bnapi =3D bn->bnapi[i]; + struct bnge_nq_ring_info *nqr; + struct bnge_stats_mem *stats; + + nqr =3D &bnapi->nq_ring; + stats =3D &nqr->stats; + if (!i) + ring0_stats =3D stats; + __bnge_accumulate_stats(stats->hw_stats, stats->sw_stats, + ring0_stats->hw_masks, + ring0_stats->len / 8); + } + if (bn->flags & BNGE_FLAG_PORT_STATS) { + struct bnge_stats_mem *stats =3D &bn->port_stats; + __le64 *hw_stats =3D stats->hw_stats; + u64 *sw_stats =3D stats->sw_stats; + u64 *masks =3D stats->hw_masks; + int cnt; + + cnt =3D sizeof(struct rx_port_stats) / 8; + __bnge_accumulate_stats(hw_stats, sw_stats, masks, cnt); + + hw_stats +=3D BNGE_TX_PORT_STATS_BYTE_OFFSET / 8; + sw_stats +=3D BNGE_TX_PORT_STATS_BYTE_OFFSET / 8; + masks +=3D BNGE_TX_PORT_STATS_BYTE_OFFSET / 8; + cnt =3D sizeof(struct tx_port_stats) / 8; + __bnge_accumulate_stats(hw_stats, sw_stats, masks, cnt); + } + if (bn->flags & BNGE_FLAG_PORT_STATS_EXT) { + bnge_accumulate_stats(&bn->rx_port_stats_ext); + bnge_accumulate_stats(&bn->tx_port_stats_ext); + } +} + void bnge_sp_task(struct work_struct *work) { struct bnge_dev *bd =3D container_of(work, struct bnge_dev, sp_task); =20 set_bit(BNGE_STATE_IN_SP_TASK, &bd->state); smp_mb__after_atomic(); + if (test_and_clear_bit(BNGE_PERIODIC_STATS_SP_EVENT, &bd->sp_event)) { + bnge_hwrm_port_qstats(bd, 0); + bnge_hwrm_port_qstats_ext(bd, 0); + bnge_accumulate_all_stats(bd); + } =20 smp_mb__before_atomic(); clear_bit(BNGE_STATE_IN_SP_TASK, &bd->state); --=20 2.47.3