From nobody Mon Dec 1 23:06:49 2025 Received: from mail-il1-f225.google.com (mail-il1-f225.google.com [209.85.166.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3E982346775 for ; Wed, 26 Nov 2025 19:50:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.225 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764186656; cv=none; b=n+gNHK4ku3vDXzHRkwQGslTlhdJrTy3nAyXrYkBhsKsBVa2PMn5Un+7h8GhXWrIumDIyqQM8nqD8hu33jdeXCCE4yP86l/w1xyP61x1pg+IxjOM4dZuI/olYI5rQ8OkdhrB6+OYcPqdQIt+QODhljQwTP6DNZ6xlC/Db1LG+W74= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764186656; c=relaxed/simple; bh=BdToKwzhHDUrBZibBWqCuDSMZ+L/D7pPWXii5IIWxJs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=r8332oYZfsVD4w9wV0h29ME4NWki8WI07z65gM3I0g6UD3SfdnL+TzT0dH4yxS0o5UvYdwbMxtubTLnUTzRYiuMwZr/TH2aFJB6oPJAeNzBS6Ke2KaraG2ZD4G8mqYgfuzmUV+CztiWq3mvXsjopgFy8mHxvEUo6YeSyRxzgLfo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=IIFWL6zU; arc=none smtp.client-ip=209.85.166.225 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="IIFWL6zU" Received: by mail-il1-f225.google.com with SMTP id e9e14a558f8ab-4336f492d75so999065ab.1 for ; Wed, 26 Nov 2025 11:50:54 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764186653; x=1764791453; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=JbNNdnMVfUObfWb7xsLH9p8NbtGDNVo859r7X/oBhzg=; b=l6HSLtatZ113qCJ/r9VFj6A4tjfNVde09U6cttyI62yBXOV/vy2/gtAW3nYgFgi7at l+3SlQnmTtvBKRVfSHwa0Q2hTWx4ZtXPExvysYKcvInTPBld0Mg/DVOSM2DG2DsPfRvc sXg8Mh3V+xCOyOEXcN51jLsMkMGhhG08FYAl6J96cN9+MxjhQ4cbRYCN0jp7FuYcwfCX wlyBtBzFz+xe9pr2HsIhEhbARzWKq0P3+RgjdBZ6kprtfVEgzsBKZitfpHWRE4sC20AX tOOEk961J7XxJpnPvSsaaVJ8JPmLCpcuXnsZq9hEBBCBJDJURDAUp3gdJf9Eb2sodO71 87ig== X-Forwarded-Encrypted: i=1; AJvYcCV4BBFgOCgRwsml96XIKYN0WjWqM2d9OUtN45NstTloZVbiNAoKdxwyIZT+g+wio2KYWV8QD7eZqD19bbQ=@vger.kernel.org X-Gm-Message-State: AOJu0YyptUoJN1ZcpHtbKYfTtXtUcn3pBmqmPLTNFzC74Tg/VkrA4hEx OE6yHvxB5patsEalafjhMk76vFKuf0G7s6EpUS6LiRnwbAM4tXJ/WqJeNyKz5u19yj2eHZotQ6e T+zyuVhbOAtnSJhL4SuA4JCeHlnc+xzjiktx/cFD1UOGEoW84ybnH7Ijs1YdlEMHsZdrdWKlJYf O+t8qIgYXn2Ddr3qZcIaQhwbi4xH+/8/r6vzm/N1mbho+iljbWHLkTYXdz6X9CnO5fMJDcXkJms HR1glS/0y0vTnYQMIa4/o/d6Q== X-Gm-Gg: ASbGncv+WvavBBZK1oYYc9UxS2cGvx4oH1+aRNeizR/joGdmH8pvoZEt+jjrLESEuzN UNe+u3ZvxEypAzrSQ+DmEQnt3dpbigagu6eGnd0uAfMCTicbAfcG7XeuFKxgMm3hjZNdok4O9H8 4NbqBXhLG+UtlDvHPnbeR/X0sAWexKoyMRc7B0x5XINJvYXtVn8by0WPxLh7dkxe0ONGgJlh9cS fG7Rlf/C7AAvOvMh7ld0pCXJz5A7dyCHq0wfOyiHuQkM9PaGHThGi3b3qoht7AWYvIFS578hgZ0 QZeldVNOqNEMw1elQ0kOgOwRtTCDWXPmKp4LD5ErxTlz7za9s5fIvIcLLeRPHnhWzaTaKPYeAHJ g+idNehj+DQKqpXqkL8rszWJG163dQ8FfevhvTGDh0Sx4tbsavqGLPNhTUwJZHDTN+clFek8c9W Crbz91ceEht4SMaBiExAelLKK3LAH/qoVgeq1ysAB2FApxRFGG9ns= X-Google-Smtp-Source: AGHT+IHbEH2nFDYMapuxOXQkYueqdpbCMD0/e/gLp6LnojgoPPSB/uze5/K6D8izQWjyBMOvRDqXOn/k8S++ X-Received: by 2002:a05:6e02:b4c:b0:433:7900:f1b6 with SMTP id e9e14a558f8ab-435b9842e5emr173349995ab.7.1764186653398; Wed, 26 Nov 2025 11:50:53 -0800 (PST) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-11.dlp.protect.broadcom.com. [144.49.247.11]) by smtp-relay.gmail.com with ESMTPS id 8926c6da1cb9f-5b954b2dfb2sm1830113173.36.2025.11.26.11.50.53 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 26 Nov 2025 11:50:53 -0800 (PST) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2956cdcdc17so1159025ad.3 for ; Wed, 26 Nov 2025 11:50:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1764186652; x=1764791452; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=JbNNdnMVfUObfWb7xsLH9p8NbtGDNVo859r7X/oBhzg=; b=IIFWL6zU0gIW5esnhSta1CTmxMA13CgQ/RdEEqy+rA5NqNN+YRvpRFtc/ZgDkNnMCb o3ACoKMERI/rmcCbHHG13x2vR1Q6CCAMtehR3T5bftR3yq84cQw+lZ/B6t++3VAiQfVN BbGuav9tHDDVqTX2UCax4vx/tR6Jl9e6jF5g8= X-Forwarded-Encrypted: i=1; AJvYcCXImDLTWIRMiLLF5LkSst947QwQ5Z7u0IUQfnWRVzXCk6Bg79R+1eewxLmPo+PQGD1QAhYAELi5B1/599k=@vger.kernel.org X-Received: by 2002:a17:902:ef51:b0:295:9b39:4533 with SMTP id d9443c01a7336-29b6c57210emr239858105ad.30.1764186651886; Wed, 26 Nov 2025 11:50:51 -0800 (PST) X-Received: by 2002:a17:902:ef51:b0:295:9b39:4533 with SMTP id d9443c01a7336-29b6c57210emr239857815ad.30.1764186651480; Wed, 26 Nov 2025 11:50:51 -0800 (PST) Received: from localhost.localdomain ([192.19.203.250]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-29b5b25e638sm206782375ad.58.2025.11.26.11.50.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Nov 2025 11:50:51 -0800 (PST) From: Bhargava Marreddy To: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, michael.chan@broadcom.com, pavan.chebbi@broadcom.com, vsrama-krishna.nemani@broadcom.com, vikas.gupta@broadcom.com, Bhargava Marreddy , Rajashekar Hudumula Subject: [v3, net-next 11/12] bng_en: Create per-PF workqueue and timer for asynchronous events Date: Thu, 27 Nov 2025 01:19:30 +0530 Message-ID: <20251126194931.455830-12-bhargava.marreddy@broadcom.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20251126194931.455830-1-bhargava.marreddy@broadcom.com> References: <20251126194931.455830-1-bhargava.marreddy@broadcom.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e Content-Type: text/plain; charset="utf-8" Use a dedicated workqueue and timer for each PF to handle events. This sets up the infrastructure for the next patch, which will implement the event handling logic. Signed-off-by: Bhargava Marreddy Reviewed-by: Vikas Gupta Reviewed-by: Rajashekar Hudumula --- drivers/net/ethernet/broadcom/bnge/bnge.h | 10 ++++++ .../net/ethernet/broadcom/bnge/bnge_core.c | 35 ++++++++++++++++++- .../net/ethernet/broadcom/bnge/bnge_netdev.c | 31 ++++++++++++++++ .../net/ethernet/broadcom/bnge/bnge_netdev.h | 3 ++ 4 files changed, 78 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/broadcom/bnge/bnge.h b/drivers/net/ethern= et/broadcom/bnge/bnge.h index 72d9865ba7b..0b75d6139b1 100644 --- a/drivers/net/ethernet/broadcom/bnge/bnge.h +++ b/drivers/net/ethernet/broadcom/bnge/bnge.h @@ -136,6 +136,7 @@ struct bnge_dev { unsigned long state; #define BNGE_STATE_DRV_REGISTERED 0 #define BNGE_STATE_OPEN 1 +#define BNGE_STATE_IN_SP_TASK 2 =20 u64 fw_cap; =20 @@ -208,9 +209,18 @@ struct bnge_dev { u8 max_q; u8 port_count; =20 + unsigned int current_interval; +#define BNGE_TIMER_INTERVAL HZ + + struct timer_list timer; struct bnge_irq *irq_tbl; u16 irqs_acquired; =20 + struct workqueue_struct *bnge_pf_wq; + struct work_struct sp_task; + unsigned long sp_event; +#define BNGE_PERIODIC_STATS_SP_EVENT 0 + /* To protect link related settings during link changes and * ethtool settings changes. */ diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_core.c b/drivers/net/e= thernet/broadcom/bnge/bnge_core.c index 2c72dd34d50..dfa501f912a 100644 --- a/drivers/net/ethernet/broadcom/bnge/bnge_core.c +++ b/drivers/net/ethernet/broadcom/bnge/bnge_core.c @@ -238,6 +238,23 @@ static int bnge_map_db_bar(struct bnge_dev *bd) return 0; } =20 +static struct workqueue_struct * +bnge_create_workqueue_thread(struct bnge_dev *bd, char thread_name[]) +{ + struct workqueue_struct *wq; + char *wq_name; + + wq_name =3D kasprintf(GFP_KERNEL, "%s-%s", thread_name, + dev_name(bd->dev)); + if (!wq_name) + return NULL; + + wq =3D create_singlethread_workqueue(wq_name); + + kfree(wq_name); + return wq; +} + static int bnge_probe_one(struct pci_dev *pdev, const struct pci_device_id= *ent) { unsigned int max_irqs; @@ -277,6 +294,10 @@ static int bnge_probe_one(struct pci_dev *pdev, const = struct pci_device_id *ent) goto err_devl_free; } =20 + INIT_WORK(&bd->sp_task, bnge_sp_task); + timer_setup(&bd->timer, bnge_timer, 0); + bd->current_interval =3D BNGE_TIMER_INTERVAL; + rc =3D bnge_init_hwrm_resources(bd); if (rc) goto err_bar_unmap; @@ -318,14 +339,24 @@ static int bnge_probe_one(struct pci_dev *pdev, const= struct pci_device_id *ent) goto err_config_uninit; } =20 + bd->bnge_pf_wq =3D bnge_create_workqueue_thread(bd, "bnge_pf_wq"); + if (!bd->bnge_pf_wq) { + dev_err(&pdev->dev, "Unable to create workqueue.\n"); + rc =3D -ENOMEM; + goto err_free_irq; + } + rc =3D bnge_netdev_alloc(bd, max_irqs); if (rc) - goto err_free_irq; + goto err_free_workq; =20 pci_save_state(pdev); =20 return 0; =20 +err_free_workq: + destroy_workqueue(bd->bnge_pf_wq); + err_free_irq: bnge_free_irqs(bd); =20 @@ -356,6 +387,8 @@ static void bnge_remove_one(struct pci_dev *pdev) =20 bnge_netdev_free(bd); =20 + destroy_workqueue(bd->bnge_pf_wq); + bnge_free_irqs(bd); =20 bnge_net_uninit_dflt_config(bd); diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c b/drivers/net= /ethernet/broadcom/bnge/bnge_netdev.c index f9d7f90a825..824374c1d9c 100644 --- a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c +++ b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c @@ -253,6 +253,33 @@ static int bnge_alloc_ring_stats(struct bnge_net *bn) return rc; } =20 +void bnge_timer(struct timer_list *t) +{ + struct bnge_dev *bd =3D timer_container_of(bd, t, timer); + struct bnge_net *bn =3D netdev_priv(bd->netdev); + struct net_device *dev =3D bd->netdev; + + if (!netif_running(dev) || !test_bit(BNGE_STATE_OPEN, &bd->state)) + return; + + if (atomic_read(&bn->intr_sem) !=3D 0) + goto bnge_restart_timer; + +bnge_restart_timer: + mod_timer(&bd->timer, jiffies + bd->current_interval); +} + +void bnge_sp_task(struct work_struct *work) +{ + struct bnge_dev *bd =3D container_of(work, struct bnge_dev, sp_task); + + set_bit(BNGE_STATE_IN_SP_TASK, &bd->state); + smp_mb__after_atomic(); + + smp_mb__before_atomic(); + clear_bit(BNGE_STATE_IN_SP_TASK, &bd->state); +} + static void bnge_free_nq_desc_arr(struct bnge_nq_ring_info *nqr) { struct bnge_ring_struct *ring =3D &nqr->ring_struct; @@ -2111,6 +2138,7 @@ static void bnge_disable_int_sync(struct bnge_net *bn) struct bnge_dev *bd =3D bn->bd; int i; =20 + atomic_inc(&bn->intr_sem); bnge_disable_int(bn); for (i =3D 0; i < bd->nq_nr_rings; i++) { int map_idx =3D bnge_cp_num_to_irq_num(bn, i); @@ -2124,6 +2152,7 @@ static void bnge_enable_int(struct bnge_net *bn) struct bnge_dev *bd =3D bn->bd; int i; =20 + atomic_set(&bn->intr_sem, 0); for (i =3D 0; i < bd->nq_nr_rings; i++) { struct bnge_napi *bnapi =3D bn->bnapi[i]; struct bnge_nq_ring_info *nqr =3D &bnapi->nq_ring; @@ -2677,6 +2706,7 @@ static int bnge_open_core(struct bnge_net *bn) =20 bnge_enable_int(bn); bnge_tx_enable(bn); + mod_timer(&bd->timer, jiffies + bd->current_interval); /* Poll link status and check for SFP+ module status */ mutex_lock(&bd->link_lock); bnge_get_port_module_status(bn); @@ -2718,6 +2748,7 @@ static void bnge_close_core(struct bnge_net *bn) clear_bit(BNGE_STATE_OPEN, &bd->state); bnge_shutdown_nic(bn); bnge_disable_napi(bn); + timer_delete_sync(&bd->timer); bnge_free_all_rings_bufs(bn); bnge_free_irq(bn); bnge_del_napi(bn); diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h b/drivers/net= /ethernet/broadcom/bnge/bnge_netdev.h index d7713bd57c6..9f5430d4180 100644 --- a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h +++ b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h @@ -352,6 +352,7 @@ struct bnge_net { =20 unsigned long state; #define BNGE_STATE_NAPI_DISABLED 0 + atomic_t intr_sem; =20 u32 msg_enable; u16 max_tpa; @@ -646,4 +647,6 @@ int bnge_alloc_rx_netmem(struct bnge_net *bn, struct bn= ge_rx_ring_info *rxr, void bnge_get_ring_err_stats(struct bnge_net *bn, struct bnge_total_ring_err_stats *stats); void bnge_copy_hw_masks(u64 *mask_arr, __le64 *hw_mask_arr, int count); +void bnge_timer(struct timer_list *t); +void bnge_sp_task(struct work_struct *work); #endif /* _BNGE_NETDEV_H_ */ --=20 2.47.3