From nobody Mon Dec 1 23:06:47 2025 Received: from mail-pl1-f202.google.com (mail-pl1-f202.google.com [209.85.214.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8016F341050 for ; Wed, 26 Nov 2025 19:36:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.202 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764185778; cv=none; b=mNGYBJKAE1Uj+PtRTLz+YVnYd5/IJ2UEO1i65VyMmR51Crxf8cywoaq0s/HbmaBPvCOAK/u4/vT6pHY9gE8rF5sRdyLpXttVfGlv/sdsZ4Ks1aiahOjQwyHQINOfpBT3EyCBHJBC/LU0FmLkU1gSsAGSFJ0Volvw0Ydfsd/VAJQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764185778; c=relaxed/simple; bh=DgrTkiwsj7G+kzAv5Mmspt4Q8NbY6RXRBJtrpMsEy5E=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=tw52kdUniYNj0BX/FcFVo0BOIcjl9FVnekxUmTEdXPxPBkZdJKWeiVBKz9lXyKDywbaq2OkI9PlNkFm7uYJy+Kbj8v/OboqU9O58hbQtQeBsrdiCWHt9WQPzzuKrNavOVC0GjqCRT/SDUAH0tEnWm9CG2gDP+7gphEmHsqSwTag= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--dmatlack.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=dbU6Adrw; arc=none smtp.client-ip=209.85.214.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--dmatlack.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="dbU6Adrw" Received: by mail-pl1-f202.google.com with SMTP id d9443c01a7336-297f8a2ba9eso1820345ad.3 for ; Wed, 26 Nov 2025 11:36:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1764185776; x=1764790576; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=G4W8jO8YwRXmYQwem/Oi26baRXbR//DiNTTxQHZyVKU=; b=dbU6Adrw/r4HbB2gp1axytAQ3o43CYiIxktTc1NaQUbbgieIqOqSyN5L8pEVth1EjJ F3b4+FXxQRnSrd1XwMjcNsmTfIsWkJgUX9+1PJ92FFNhD4SJ3SbeYKpNZXA++d90+Qn8 pPWLuJE005M8Mcnq/5AJppqd2ZQ8ix0Gj055ltkMvlss3XK+QHflkdaxzbiX1GRJkcBN 43HUbvtflmJJGE8XyGlFlpcLebVvL1NIhknhVDX0RaSiDIGy1BAeDGNVYh5DuQ9I8S3o Y+hYJ7aFFs7hR941kGZxxfOFA4W32vUZtMCkAHOjkAlfO8s+2qTXCQRpmBGjHL5S/06O WIjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764185776; x=1764790576; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=G4W8jO8YwRXmYQwem/Oi26baRXbR//DiNTTxQHZyVKU=; b=cOLCJ2WAv9oNB7HTtnO0wRC5sqxVCj4b05Wez7W07hhPWnVkts2QFjUTG5MzKAY2wR DVep+ox8cFRu9Zn9uGvFgUQ+DJLbbGyXg4ROqIEHgSviKj1q20eD/4oau0j8Dt2QIirG WQpMNn2lr1zZpamYSkupd9ju2q5pYd+77aZdkTL6kspcaZjQHMHaTlMxsvzWSZk7s2EL Kh31tY3tZbVuG6o8rc6tndKBfV4D+niXSdLWwKG70QmQb1rbJvnV0y7zahZgBWcSsWKw OE9u7dcfQUEQaOIOpvS4KcKB2Hd8MsvX3jhcD6oB1MqOh0cQMrjfeXSiEDg1JmcjCgfo lX6w== X-Forwarded-Encrypted: i=1; AJvYcCVtGepL2+KAQXCIvN9nOcfRmixOMGAkZ7siRBQz5RC4KmWbEFN3UzIpr/opNgkB2vyhcbweDua0u+3Eiy8=@vger.kernel.org X-Gm-Message-State: AOJu0Yy+ysEvFtcr8g3fyHgQwYaMOFVlTQFrOAL9sNw0EmMDc/DLy2fW VtI68osP7bpOBLeTlt6GQAcPHccNnQ0EyeWc7XlEjfl582kaqaap5BK0+I9AdPI6YqZr5yB4z5Q hY71VZgj10jUt6A== X-Google-Smtp-Source: AGHT+IH14W8+tVRPyICSHFhnhdie4VNOZ11aj2/eJVs/11OeDSQhWpHoOWodZE+UlFUV7qImHq1Artm+rlwecg== X-Received: from plbjn3.prod.google.com ([2002:a17:903:503:b0:293:e00:bb82]) (user=dmatlack job=prod-delivery.src-stubby-dispatcher) by 2002:a17:902:ce89:b0:298:485d:556b with SMTP id d9443c01a7336-29b6be8c617mr237546495ad.5.1764185775828; Wed, 26 Nov 2025 11:36:15 -0800 (PST) Date: Wed, 26 Nov 2025 19:35:50 +0000 In-Reply-To: <20251126193608.2678510-1-dmatlack@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20251126193608.2678510-1-dmatlack@google.com> X-Mailer: git-send-email 2.52.0.487.g5c8c507ade-goog Message-ID: <20251126193608.2678510-4-dmatlack@google.com> Subject: [PATCH 03/21] PCI: Require driver_override for incoming Live Update preserved devices From: David Matlack To: Alex Williamson Cc: Adithya Jayachandran , Alex Mastro , Alistair Popple , Andrew Morton , Bjorn Helgaas , Chris Li , David Matlack , David Rientjes , Jacob Pan , Jason Gunthorpe , Jason Gunthorpe , Josh Hilke , Kevin Tian , kvm@vger.kernel.org, Leon Romanovsky , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-pci@vger.kernel.org, Lukas Wunner , Mike Rapoport , Parav Pandit , Pasha Tatashin , Philipp Stanner , Pratyush Yadav , Saeed Mahameed , Samiullah Khawaja , Shuah Khan , Tomita Moeko , Vipin Sharma , William Tu , Yi Liu , Yunxiang Li , Zhu Yanjun Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Require driver_override to be set to bind an incoming Live Update preserved device to a driver. Auto-probing could lead to the device being bound to a different driver than what was bound to the device prior to Live Update. Delegate binding preserved devices to the right driver to userspace by requiring driver_override to be set on the device. This restriction is relaxed once a driver calls pci_liveupdate_incoming_finish(). Signed-off-by: David Matlack --- drivers/pci/pci-driver.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/pci/pci-driver.c b/drivers/pci/pci-driver.c index 302d61783f6c..294ce92331a8 100644 --- a/drivers/pci/pci-driver.c +++ b/drivers/pci/pci-driver.c @@ -420,18 +420,26 @@ static int __pci_device_probe(struct pci_driver *drv,= struct pci_dev *pci_dev) } =20 #ifdef CONFIG_PCI_IOV -static inline bool pci_device_can_probe(struct pci_dev *pdev) +static inline bool pci_iov_device_can_probe(struct pci_dev *pdev) { return (!pdev->is_virtfn || pdev->physfn->sriov->drivers_autoprobe || pdev->driver_override); } #else -static inline bool pci_device_can_probe(struct pci_dev *pdev) +static inline bool pci_iov_device_can_probe(struct pci_dev *pdev) { return true; } #endif =20 +static inline bool pci_device_can_probe(struct pci_dev *pdev) +{ + if (pci_liveupdate_incoming_is_preserved(pdev)) + return pdev->driver_override; + + return pci_iov_device_can_probe(pdev); +} + static int pci_device_probe(struct device *dev) { int error; --=20 2.52.0.487.g5c8c507ade-goog