From nobody Mon Dec 1 22:37:25 2025 Received: from mail-pf1-f195.google.com (mail-pf1-f195.google.com [209.85.210.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 37B5C331A58 for ; Wed, 26 Nov 2025 19:04:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.195 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764183868; cv=none; b=dK9h8UBqyVZLjdgoO88LO4I+TxOuE3fmPwkQyrHsJ+fPrNjHDHVrNWMPnJ3tqegxn3gcxO1EmlQ94BIvsaXM0n+a6TJLjmzthkwALwsAqKXjKtXIWeAQ5OJeMxqFGWBgo3iRqFEDKDRbyKGQ/dRblxPZ4jnM3pcmfw8PxJ5e6RY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764183868; c=relaxed/simple; bh=TZD2Ey6Z8WvlpW2dfjWUC5ho1c+Z3cypZpbXGhlo5HQ=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=hH98GpSEdEVc8hJ5fVXOpeEpfw4OKFcFe7t9egVae2rpb1gEQ0Vo3O6JQuL5dUmkzYuBkMqepzbHR5VP9/3QSVW128qh8eJxmhdkUbQAVwS8YF+se+DedethBLGaZQaAePsow75du3QDM5lE2TSFWbjC4dLQFyZE16HLRiRh29g= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ee.vjti.ac.in; spf=none smtp.mailfrom=ee.vjti.ac.in; dkim=pass (1024-bit key) header.d=vjti.ac.in header.i=@vjti.ac.in header.b=TXG6QltB; arc=none smtp.client-ip=209.85.210.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ee.vjti.ac.in Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=ee.vjti.ac.in Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=vjti.ac.in header.i=@vjti.ac.in header.b="TXG6QltB" Received: by mail-pf1-f195.google.com with SMTP id d2e1a72fcca58-7b9387df58cso64044b3a.3 for ; Wed, 26 Nov 2025 11:04:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vjti.ac.in; s=google; t=1764183865; x=1764788665; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=04+GJw/QeAhZXEl0aXKPi//aV7HxxJ1aVYtljym3uF0=; b=TXG6QltBQThwMSyXaeR3cKbGaPaPxcxaIQ9vV5gPV9aLv3gDlJ5LE616qZoBsGwtN1 gHf6jy2fUy3Y9WkGTRPu9wCC1ZmmrVFppBaTZ+lU4cg4yygkjoevMoWGI+N0+VOTpOt/ E5ZfHTi5hj3Pl73tQ6e/ViMZ9dypWq33o5pdU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764183865; x=1764788665; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=04+GJw/QeAhZXEl0aXKPi//aV7HxxJ1aVYtljym3uF0=; b=LHKjVaJsOyQy0osZnRVBE5JBKoD03qV18uk9skYmkIANK5NGQuVpyPz/1FS/oQDHYw 8ieoXvgJjY4oDvsExIOb5bU/HMkxUrzCpZAy0/iGYc4NZ1x6+cN5XCoMbzVHofWTAWBP wQmjvZFc79zksxR2aNNPt5UxGhJNaKW2WsGIY1SA1sRfeuxmzvdE4gnjs9eVPpojzEFe 6/YIyHDV85zjnVLIRuZDLlUnJkz9PrUDcv7GZ0PVPLuV3UGl47WjjBqPNEfgbwQTHI6q NDRvb2LTzAynf+i32bKw/oewK32b1mxD4YYlgHdXNeQOSIiLYecwb8iyk84A99IvEYXI +Mqg== X-Gm-Message-State: AOJu0YwCafzo4Z0oZj2hXdoMPk8j6NAIdURS6Mxzl4Z66mgQoZ9N2xXB D6n0puEpwJG0sF3SPdBeC/UvPNV5KqPg1jGATw1a6Hj7AHZTuikMuBpGHqsV2Q9G5bM= X-Gm-Gg: ASbGnctu9DOKpewJEtkhhLGD1USbzI17kZrAcKqcT5ySNeYC3VcE4Sw9PtcDCzt0DNo EF40WbBQYldF88J6cTDm+iU04ZDstuGkruOHndmrEXTY3YDHuudHO8JqW2JQg0h3aZFfn3OZ6oD +4u+pq4Qv4MEH1sHJx5Bs5LiLyV3pSUSd7meCbREqk18vFNX/sLnUyAEEBZ4tLpR/oWlQTLfPE2 wmXbld3Q1rOQBPX+VhTfDpYDyxafQTeZGoO9OzBUQqvellVkhKba5Blo6NDluijsYpkeSA+4MuH By5maAJ2fMGSKpwBcXKOP3NzdwxoP/uTy/55WIAchK3gFY9ZyBZ8sCg029r8c9xN1SflDuJc+N7 zVlR1PAjUNnXGw0LGENLCduFDP5MzIUcjafUqMyvhqP6nPOS/Q0SyBOQ/Z/niWVkY1FbkTZ8wKf mZIGjaZh00XnybZWOe4yP4EDo0ShFHSr3JCtbKXPTemwxALQgHbvHC1sqVUj00Q7Kwquv1yA== X-Google-Smtp-Source: AGHT+IFm+MfJvs/Wf+g788FjoV56T+TV2tLXBCMUGkU9nJcP6d6Kcmdlz0QOSTBOZdqGTzkoz5n/2A== X-Received: by 2002:a05:6a00:3a0b:b0:7b8:7c1a:7f68 with SMTP id d2e1a72fcca58-7ca8a1392b4mr8897925b3a.32.1764183865271; Wed, 26 Nov 2025 11:04:25 -0800 (PST) Received: from ranegod-HP-ENVY-x360-Convertible-13-bd0xxx.. ([2409:40c0:20:6a17:674c:cac:c69:59f5]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7c3ed471f80sm22541529b3a.24.2025.11.26.11.04.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Nov 2025 11:04:24 -0800 (PST) From: Shaurya Rane To: Hans Verkuil , Mauro Carvalho Chehab , linux-media@vger.kernel.org Cc: linux-kernel@vger.kernel.org, linux-kernel-mentees@lists.linux.dev, skhan@linuxfoundation.org, david.hunter.linux@gmail.com, khalid@kernel.org, Shaurya Rane , syzbot+a41b73dce23962a74c72@syzkaller.appspotmail.com Subject: [PATCH v3] media: radio-keene: fix memory leak in error path Date: Thu, 27 Nov 2025 00:34:10 +0530 Message-Id: <20251126190410.94933-1-ssrane_b23@ee.vjti.ac.in> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Fix a memory leak in usb_keene_probe(). The v4l2 control handler is initialized and controls are added, but if v4l2_device_register() or video_register_device() fails afterward, the handler was never freed, leaking memory. Add v4l2_ctrl_handler_free() call in the err_v4l2 error path to ensure the control handler is properly freed for all error paths after it is initialized. Reported-by: syzbot+a41b73dce23962a74c72@syzkaller.appspotmail.com Closes: https://syzkaller.appspot.com/bug?extid=3Da41b73dce23962a74c72 Fixes: 1bf20c3a0c61 ("[media] radio-keene: add a driver for the Keene FM Tr= ansmitter") Signed-off-by: Shaurya Rane --- v3: - Put v4l2_ctrl_handler_free() in err_v4l2 label covering all error paths with a single call. v2: - Simplified fix: call v4l2_ctrl_handler_free() inline before goto instead of adding a new error label. --- drivers/media/radio/radio-keene.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/radio/radio-keene.c b/drivers/media/radio/radio-= keene.c index f3b57f0cb1ec..c133305fd019 100644 --- a/drivers/media/radio/radio-keene.c +++ b/drivers/media/radio/radio-keene.c @@ -338,7 +338,6 @@ static int usb_keene_probe(struct usb_interface *intf, if (hdl->error) { retval =3D hdl->error; =20 - v4l2_ctrl_handler_free(hdl); goto err_v4l2; } retval =3D v4l2_device_register(&intf->dev, &radio->v4l2_dev); @@ -384,6 +383,7 @@ static int usb_keene_probe(struct usb_interface *intf, err_vdev: v4l2_device_unregister(&radio->v4l2_dev); err_v4l2: + v4l2_ctrl_handler_free(&radio->hdl); kfree(radio->buffer); kfree(radio); err: --=20 2.34.1