From nobody Mon Dec 1 22:34:54 2025 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0EC4B33B6DD for ; Wed, 26 Nov 2025 16:00:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764172845; cv=none; b=BThCPcrEMKrBNSIGwvisVy8qF8nfntgD9QL+p8IfViYQItKng5gyYM9zd1lq9IBHkah1hJtmwxnVFnkJcNssVcdGRRPWqJDjy0XS/i2wBc8IWa+n/kXhUoJDo2gdVnxFehANAaFQcFzldU/MD2lhRwMFnx2jK9xdmK3xX+WAqU0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764172845; c=relaxed/simple; bh=MdGNxCjsa59/ybuaVLZojL8l8CBMPbJpdyOoh0EJyQM=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=jgSGRPLlizLBdM8MQUWW50hQllTOdKx+JxCX5rNXkzM/sDNu8H0GmKMc1muBtCd5R7PrS0jIauIOla45KyHQQtBHm9QxMsvobH/KZxuhK1ZfY80PZ+SQqhOFH2EmolNbN/juw/bRLpGNzv1HABkp7JsJHgzYgFlpm5AAxbGyVMk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=SPIZyE2c; arc=none smtp.client-ip=209.85.214.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SPIZyE2c" Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-298145fe27eso107348825ad.1 for ; Wed, 26 Nov 2025 08:00:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764172843; x=1764777643; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=1+4LADSHuqIaRqoW7Bmje2BsQ6GKiSEPAqwYnkSnRb4=; b=SPIZyE2cpRGQXak0kU0nz18s2y0fMhKSnyTKJtvTJl6IDMWn3AnMWhUaJVSP7PsL9h roanK9x/UzAnKnkvULlnHC56N/GynI1BobrxNjOOuR6bDN1+py+T/5NPPxMMTk9vTxnh pnsPCSXjdJT2oEbqtBqKHZhccC+lp81CNWjL+ClzpBqPhuNkmJLpVWWrDdnhbAKFil9H MnYAhZrKxx++ajJSASj4lQy7UAGQfk6fWTPN8nL/9d1NRcCDRgrJTKz4TTVDmtGvOG9k zXtJI2rySiEvjjIUn+A0T9fILSKrcK9XPchoy+7gb33IcLaLfSfmLpUUBsRvThfc45Rc ZaKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764172843; x=1764777643; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=1+4LADSHuqIaRqoW7Bmje2BsQ6GKiSEPAqwYnkSnRb4=; b=gNB3Sl56rukhspIejc51ynt9QudW4qFz8HAFfPEsgS27uZk9aCfyGo36oUjMzNS6mk qDyt6rB9VbCjyXsdZkeryxtyX/xt5I3ICmNZxeBN5kwUrMtrdNiECN7wY3V/6dok7SJj aiCmYOhan/VGtt/7KuvlIZCUUIoSMoq0izTaeOEyvP7Lub3IruU16lt6BL5k8hz/Tvv/ HzUVWBjxJXkIZVOW51Q+TnYjrDLVY9n1Hl0ccNsPkAz/acWNKtmT+BPGGuBab7eXkCxy Eyk7BSKBi/NmDED7v/P6gL4caIIFgLWkynoIBXp6tiRj35avNKAa/U71HtImUr2Lvkqi FBLg== X-Gm-Message-State: AOJu0Yxt1+ybBubBN+sJEzrrUK/aiijaQdGBQI7RSHWzNxnsFmsWLCrg GF72wJvnWevvvMWbcbI2OZn5bZ3WZ04NP+l8HzscHz0QPDTtKIjbg1hLIAzpr+80 X-Gm-Gg: ASbGncsOT6rluL6kW3cDsEQL7XmYyUkSqZno8pyJZS+HWk13j+t1ZKxeIeDyIHyUgd/ NMvwofcTZY2w4X9itxFSC8Qi4Zs3UQBjpLPurd8nlktD8LFQYk2ffnKejtkGL1WdepdlNvGjcpr 6rmrDu0TyvqaVOBFdYmrGjb7AuKSSyQOlC8/KyZYxU73KVbjaY5UcqQoSgEU5ipxXNPYMYjjita 4EPD2kKhpDQIeWbs9ThOFRjJTR3muzgczrmGAhuayhdnR03PA0CWISm6rt+DzuS4DKqwX0sgNbP O39wUlZgl9XIoM/gjbF1/Ix4f0gmcG5/pSpuvet0LK7UjfT5KdXpaR98zuUs8Lg+1oawHFKCUmL X3ONe05hZFQGvRBmUbKv8KosGFO3Lu+0Ou5uwcMpZE9Uz0woUE4TAchNSg4U7moGH3xdiIGS3sO my6N6BvS6YYXQ0pT+QbQMQCQhNjmazrNKvPSRzzRxcwjebYhWmuwp9gVQOeM7ZUmN7rhkRpmoGW jkw/fVYlFizyGo= X-Google-Smtp-Source: AGHT+IFdFI7/XuPr3N8CCEeMXysqqX55mMwmcu7uuLV9wCZ/dfljsb1T5I//oEArHtE0Ev3496qMAQ== X-Received: by 2002:a17:903:b07:b0:297:e231:f40c with SMTP id d9443c01a7336-29baaf75e00mr80228405ad.19.1764172841481; Wed, 26 Nov 2025 08:00:41 -0800 (PST) Received: from 2045D.localdomain (128.sub-75-221-107.myvzw.com. [75.221.107.128]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-bd760fafe57sm19746809a12.33.2025.11.26.08.00.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Nov 2025 08:00:41 -0800 (PST) From: Gui-Dong Han To: gregkh@linuxfoundation.org, rafael@kernel.org, dakr@kernel.org Cc: linux-kernel@vger.kernel.org, baijiaju1990@gmail.com, Gui-Dong Han , Qiu-ji Chen Subject: [PATCH v2] driver core: fix use-after-free of driver_override via driver_match_device() Date: Thu, 27 Nov 2025 00:00:11 +0800 Message-ID: <20251126160011.11649-1-hanguidong02@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" driver_set_override() modifies and frees dev->driver_override while holding device_lock(dev). However, driver_match_device() reads dev->driver_override when calling bus match functions. Currently, driver_match_device() is called from three sites. One site (__device_attach_driver) holds device_lock(dev), but the other two (bind_store and __driver_attach) do not. This allows a concurrent driver_set_override() to free the string while driver_match_device() is using it, leading to a use-after-free (UAF). This issue affects at least 11 bus types (including PCI, AMBA, Platform) that rely on driver_override for matching. Fix this by holding device_lock(dev) around the driver_match_device() calls in bind_store() and __driver_attach(). This ensures all access to dev->driver_override via driver_match_device() is protected by the device lock. Also add a lock assertion to driver_match_device() to prevent future locking regressions. Tested with the PoCs from Bugzilla that trigger this UAF. Stress testing the two newly locked paths for 24 hours with CONFIG_PROVE_LOCKING and CONFIG_LOCKDEP enabled showed no UAF recurrence and no lockdep warnings. Closes: https://bugzilla.kernel.org/show_bug.cgi?id=3D220789 Suggested-by: Qiu-ji Chen Signed-off-by: Gui-Dong Han --- v2: * Add device_lock_assert() in driver_match_device() to enforce locking requirement, as suggested by Greg KH. v1: * The Bugzilla entry contains full KASAN reports and two PoCs that reliably reproduce the UAF on both unlocked paths using a standard QEMU setup (default e1000 device at 0000:00:03.0). I chose to fix this in the driver core for the following reasons: 1. Both racing functions are part of the driver core. 2. Fixing this per-driver/per-bus is tedious and would require careful ad-hoc locking that does not align with the existing device_lock(dev). 3. We cannot simply add device_lock(dev) inside bus match functions because one call path (__device_attach_driver) already holds this lock. Adding the lock inside the match callback would cause a deadlock on that path. --- drivers/base/base.h | 2 ++ drivers/base/bus.c | 17 ++++++++++++----- drivers/base/dd.c | 3 +++ 3 files changed, 17 insertions(+), 5 deletions(-) diff --git a/drivers/base/base.h b/drivers/base/base.h index 86fa7fbb3548..011e910a53f8 100644 --- a/drivers/base/base.h +++ b/drivers/base/base.h @@ -166,6 +166,8 @@ void device_set_deferred_probe_reason(const struct devi= ce *dev, struct va_format static inline int driver_match_device(const struct device_driver *drv, struct device *dev) { + /* Protects against driver_set_override() races */ + device_lock_assert(dev); return drv->bus->match ? drv->bus->match(dev, drv) : 1; } =20 diff --git a/drivers/base/bus.c b/drivers/base/bus.c index 5e75e1bce551..9e62d6009058 100644 --- a/drivers/base/bus.c +++ b/drivers/base/bus.c @@ -261,13 +261,20 @@ static ssize_t bind_store(struct device_driver *drv, = const char *buf, const struct bus_type *bus =3D bus_get(drv->bus); struct device *dev; int err =3D -ENODEV; + int ret; =20 dev =3D bus_find_device_by_name(bus, NULL, buf); - if (dev && driver_match_device(drv, dev)) { - err =3D device_driver_attach(drv, dev); - if (!err) { - /* success */ - err =3D count; + if (dev) { + /* Protects against driver_set_override() races */ + device_lock(dev); + ret =3D driver_match_device(drv, dev); + device_unlock(dev); + if (ret) { + err =3D device_driver_attach(drv, dev); + if (!err) { + /* success */ + err =3D count; + } } } put_device(dev); diff --git a/drivers/base/dd.c b/drivers/base/dd.c index 13ab98e033ea..db60b4500136 100644 --- a/drivers/base/dd.c +++ b/drivers/base/dd.c @@ -1170,7 +1170,10 @@ static int __driver_attach(struct device *dev, void = *data) * is an error. */ =20 + /* Protects against driver_set_override() races */ + device_lock(dev); ret =3D driver_match_device(drv, dev); + device_unlock(dev); if (ret =3D=3D 0) { /* no match */ return 0; --=20 2.43.0