From nobody Mon Dec 1 22:41:53 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4F052304BCA; Wed, 26 Nov 2025 14:54:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764168850; cv=none; b=Dr2lQtfYAvSw9nzFgHggSgy4w4oi3F1W/QJKqjg2bjo0eqV2JdD22/4Ky6Dl2op5cgToy1sfMSmRuIGLH6/JOdTVl4YJ5HNc/UMVIyy3CLgDh4MxfnuCgcYlXcDd6GX7ZpSJjN21Y+0Izon7MyX5jVkJ815VzNEVs5a0Y5EwAg8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764168850; c=relaxed/simple; bh=XPrBoIMoV/gub0WvLQa0dq6M5sXoUt8lsULGPBHQsC4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=HYldQKNL/dnMMEZ5tYC7HnZ1oaA+U59d9OBsyS90P+u0jdzPMDFyFNaIAxbUjGdggbGRHQm8XwlNZF1JH6hvKzygHp70JViwtZI9qTEPSOBZG0qbDTZFezBk188/L9BprDxC3CMnlUQLZR9HHxusnP6xtrl2OXow2k+kAVYJxoU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=f+4myihp; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="f+4myihp" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 01F3BC19422; Wed, 26 Nov 2025 14:54:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1764168850; bh=XPrBoIMoV/gub0WvLQa0dq6M5sXoUt8lsULGPBHQsC4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=f+4myihp6DNzi3sKOzkfZLCj2nLKZeVm+II2QzmB0I+j+sCyx23jhs6kxVN98HEnB M451SDGFVBBBZOTBxqyMhxLA6adLSDLMSe4D1Znh5qpXJtqlEdg/Evd1qKLxhC3jnP EGFxVDdWxo6Ba80MotaiaQo73VI5cy/zcb0plRyo2dSQWQrYNuf+KOMf/om3Vdibcw oO0SQmLpqr1eehMUY137S5bA+wso6fIH39nuMVohq3a3Psg10tVVjNjVRCq5y2GcrP gFJ85k7B4AurBn6I8LJ67PX3KEmbHVb66Y5nKSyhKc7kpK28mSARnK55nKqpztS4JR WN2Uh5Soqx6qg== Received: from johan by xi.lan with local (Exim 4.98.2) (envelope-from ) id 1vOGuJ-000000001Jy-1dqG; Wed, 26 Nov 2025 15:54:11 +0100 From: Johan Hovold To: Srinivas Kandagatla Cc: Greg Kroah-Hartman , linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold , Saravana Kannan Subject: [PATCH 1/6] slimbus: core: fix OF node leak on registration failure Date: Wed, 26 Nov 2025 15:53:24 +0100 Message-ID: <20251126145329.5022-2-johan@kernel.org> X-Mailer: git-send-email 2.51.2 In-Reply-To: <20251126145329.5022-1-johan@kernel.org> References: <20251126145329.5022-1-johan@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Make sure to drop the OF node reference taken when initialising and registering the slimbus device also on registration failure by releasing it in the destructor as expected. Fixes: 7588a511bdb4 ("slimbus: core: add support to device tree helper") Fixes: 01360857486c ("slimbus: core: Fix mismatch in of_node_get/put") Cc: Saravana Kannan Signed-off-by: Johan Hovold --- drivers/slimbus/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/slimbus/core.c b/drivers/slimbus/core.c index 005fa2ef100f..c808233692ee 100644 --- a/drivers/slimbus/core.c +++ b/drivers/slimbus/core.c @@ -146,6 +146,7 @@ static void slim_dev_release(struct device *dev) { struct slim_device *sbdev =3D to_slim_device(dev); =20 + of_node_put(sbdev->dev.of_node); kfree(sbdev); } =20 @@ -280,7 +281,6 @@ EXPORT_SYMBOL_GPL(slim_register_controller); /* slim_remove_device: Remove the effect of slim_add_device() */ static void slim_remove_device(struct slim_device *sbdev) { - of_node_put(sbdev->dev.of_node); device_unregister(&sbdev->dev); } =20 --=20 2.51.2 From nobody Mon Dec 1 22:41:53 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4F0CD305044; Wed, 26 Nov 2025 14:54:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764168850; cv=none; b=NqPIT7Yb4p2rXXgkwVckMaPi+t6zPVY8hbhN499xEQv0RJ5TIo+6ndd/o4mAd6W7QnVKEPtNUVRnnxS/hGhS4zb6d9a0iHoLnlekI0iNKoQPPjxc8kHG1RFg7Hur8A8KTC9NeOemgrRPmakoF9f/9uOsEetlU6Gvo7pPQPb0OJs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764168850; c=relaxed/simple; bh=/HqO8CnY5UMV9Gl7Pn58ZWgYc8wXVab/JhcP9CSjlqs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=D9fWzbJS/KxOMTPUUPGt68G/VEkbkvv1Gq3nfJ63uzv6+fV7I9QWR2svIkQoUvJyJoadJqFrMfnqlb2pFVbaXu8QM8Yoqzb7v9WNXjRWTdLFdgsNaypXd/I+Xr1vBe7O+p/3/oVoKsdcFJ3jVzcpGm+37nqg/kwLR4ejlGVDC3g= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=rpGprtZf; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="rpGprtZf" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E6DD5C113D0; Wed, 26 Nov 2025 14:54:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1764168849; bh=/HqO8CnY5UMV9Gl7Pn58ZWgYc8wXVab/JhcP9CSjlqs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=rpGprtZftYmevyQTc8OzK4vDcRmBrZDkOItw+AF2LcSqO/5G5PGgBFfi2bhf+Ug90 2Tai28k3+M/ff3OXnz9VkGAdvCow02vKGBpnsn2YuZIiXzRfvC4gLH2OqRvCkgWj93 xIGgysnGZTIURdFDrKNat2a6/uaWFNE+H1kMnR69xlj78AVAbg7Emo8r7xQEsDyf/M 9zQJa67Pn+iB1ZxIyeE/kn+7I/2/oRIJ2AnZX1nPxwzLNVlplmiGwSuPmIyKeUPlpt ka//p9xcNzhKmBvd99OqDvXysrVnw8Ui9prUgPXG3A7AyhYdp0JDFy2rnagkLl3Iji pTcHqFH/1vhFw== Received: from johan by xi.lan with local (Exim 4.98.2) (envelope-from ) id 1vOGuJ-000000001K0-1xsb; Wed, 26 Nov 2025 15:54:11 +0100 From: Johan Hovold To: Srinivas Kandagatla Cc: Greg Kroah-Hartman , linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold , stable@vger.kernel.org Subject: [PATCH 2/6] slimbus: core: fix runtime PM imbalance on report present Date: Wed, 26 Nov 2025 15:53:25 +0100 Message-ID: <20251126145329.5022-3-johan@kernel.org> X-Mailer: git-send-email 2.51.2 In-Reply-To: <20251126145329.5022-1-johan@kernel.org> References: <20251126145329.5022-1-johan@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Make sure to balance the runtime PM usage count in case slimbus device or address allocation fails on report present, which would otherwise prevent the controller from suspending. Fixes: 4b14e62ad3c9 ("slimbus: Add support for 'clock-pause' feature") Cc: stable@vger.kernel.org # 4.16 Signed-off-by: Johan Hovold --- drivers/slimbus/core.c | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/drivers/slimbus/core.c b/drivers/slimbus/core.c index c808233692ee..9f85c4280171 100644 --- a/drivers/slimbus/core.c +++ b/drivers/slimbus/core.c @@ -489,21 +489,23 @@ int slim_device_report_present(struct slim_controller= *ctrl, if (ctrl->sched.clk_state !=3D SLIM_CLK_ACTIVE) { dev_err(ctrl->dev, "slim ctrl not active,state:%d, ret:%d\n", ctrl->sched.clk_state, ret); - goto slimbus_not_active; + goto out_put_rpm; } =20 sbdev =3D slim_get_device(ctrl, e_addr); - if (IS_ERR(sbdev)) - return -ENODEV; + if (IS_ERR(sbdev)) { + ret =3D -ENODEV; + goto out_put_rpm; + } =20 if (sbdev->is_laddr_valid) { *laddr =3D sbdev->laddr; - return 0; + ret =3D 0; + } else { + ret =3D slim_device_alloc_laddr(sbdev, true); } =20 - ret =3D slim_device_alloc_laddr(sbdev, true); - -slimbus_not_active: +out_put_rpm: pm_runtime_mark_last_busy(ctrl->dev); pm_runtime_put_autosuspend(ctrl->dev); return ret; --=20 2.51.2 From nobody Mon Dec 1 22:41:53 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 577F0305054; Wed, 26 Nov 2025 14:54:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764168850; cv=none; b=AAHlcpOz9nl05+2B73o3FUpc3ql0VE5TSuWt3s+x7kff2rpFeiQKwXn2qyeGTI3zShfGBYl+InpS3XKLmlB1HcydjJ59zjlGgmMdA5E2HsgiOGXosyxcUZTRIkjSdpDd/DVIzuxku4TLjONO8XyTxD+1WOLemirICTREOL9bxrY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764168850; c=relaxed/simple; bh=RpHADdMaabfWP2N6LAPqW6uX7ikYAtv63iCYxtB/txE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=H4bkBkdlZQDKX7WiFEvtMewzOKd/5N6OOiKmR5IgGPGRUW0sTsJ6MpLpar4nHPpupH0uapgw8BAf1y9akZDmQvx3Hou2zo5bgnYj8yKQt7jQbMFm8HB3juE7Tc1mKvjizENqSfCUwbO20NKzF75oNscrZkMWVSs4YKkUlyVZHP0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=hCcdXyqd; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="hCcdXyqd" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 16994C116C6; Wed, 26 Nov 2025 14:54:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1764168850; bh=RpHADdMaabfWP2N6LAPqW6uX7ikYAtv63iCYxtB/txE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hCcdXyqd+XQLCbbgMwHojpkOG6pgK42ks6ynS3yiUWiAU8OUmA2jod02raOWjAP36 kCimN8lZCnRevW/uufkUeaUwBIZMGlTXWE3J44Dxmrxvs5bN0sod3P6yfwi0M8zqsO MnyUyDHThdpBWTiIIUwbXBAXf9DIMUjSaVIUUka3X7H29mWPX8fQAhWZUCkZZPIEkC y6DxkDc/zqFk8vQrvHHIz0XF5z04p5B4a6SpWDMXTwzEmU4OkgVpwT5ccy/IaUrMg8 Y6MCDMTj5MRVivR4Y8c8819t+COCPvbSWs7FY6uWFEMzpZVX2aahS0Kl+BYAFQ4YA3 csexvzL8j7aYg== Received: from johan by xi.lan with local (Exim 4.98.2) (envelope-from ) id 1vOGuJ-000000001K3-2L92; Wed, 26 Nov 2025 15:54:11 +0100 From: Johan Hovold To: Srinivas Kandagatla Cc: Greg Kroah-Hartman , linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold , stable@vger.kernel.org Subject: [PATCH 3/6] slimbus: core: fix device reference leak on report present Date: Wed, 26 Nov 2025 15:53:26 +0100 Message-ID: <20251126145329.5022-4-johan@kernel.org> X-Mailer: git-send-email 2.51.2 In-Reply-To: <20251126145329.5022-1-johan@kernel.org> References: <20251126145329.5022-1-johan@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Slimbus devices can be allocated dynamically upon reception of report-present messages. Make sure to drop the reference taken when looking up already registered devices. Note that this requires taking an extra reference in case the device has not yet been registered and has to be allocated. Fixes: 46a2bb5a7f7e ("slimbus: core: Add slim controllers support") Cc: stable@vger.kernel.org # 4.16 Signed-off-by: Johan Hovold --- drivers/slimbus/core.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/slimbus/core.c b/drivers/slimbus/core.c index 9f85c4280171..b4ab9a5d44b3 100644 --- a/drivers/slimbus/core.c +++ b/drivers/slimbus/core.c @@ -379,6 +379,8 @@ struct slim_device *slim_get_device(struct slim_control= ler *ctrl, sbdev =3D slim_alloc_device(ctrl, e_addr, NULL); if (!sbdev) return ERR_PTR(-ENOMEM); + + get_device(&sbdev->dev); } =20 return sbdev; @@ -505,6 +507,7 @@ int slim_device_report_present(struct slim_controller *= ctrl, ret =3D slim_device_alloc_laddr(sbdev, true); } =20 + put_device(&sbdev->dev); out_put_rpm: pm_runtime_mark_last_busy(ctrl->dev); pm_runtime_put_autosuspend(ctrl->dev); --=20 2.51.2 From nobody Mon Dec 1 22:41:53 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A97C63054C4; Wed, 26 Nov 2025 14:54:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764168850; cv=none; b=n6I7qaRnOoRPI2MXZlPc5+CaIYN41aGl5y8kBqbAu6ygaMXmVJ7cBpMLrvV9On9ZkuQy3O5cGj8zY9Qfjp7aYliGOXuE77YV9xfoGhAm8WXhyiroh1QID8MlYFEJgK+cD4EfY/JhazaRWggU7e+QO36itxUgU6Yn4R1zifRWZBc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764168850; c=relaxed/simple; bh=AZWuXSc30esnVPdOkSeXlsCxSpl4Af4MTwmXb70XTOA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=qBNvCBMgjzqcY5mj5qfrWas5XQcc5IiSCrMCX4yAeVj5rXOvh4tBakp1j8h9l/KZ7zTS1vv3EKDvNIiirm6QKzq07qS8YvARxr6NIR8/vgmac1SeIqMmzUPyRpI5nh2xnliuzwnCL1wqt4GIs9aBO7opZnPJy1wbqZipbm3K5xc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ns1+yJCg; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ns1+yJCg" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2D195C2BC86; Wed, 26 Nov 2025 14:54:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1764168850; bh=AZWuXSc30esnVPdOkSeXlsCxSpl4Af4MTwmXb70XTOA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ns1+yJCg4In+bqecbAcMXifS1Bc/g0EtMZj7k7f1znB46ZtI554hdH05gm9IC3ldx Jmv6dt/yF0sQGMOdjssEI1bNiJ2JNMNwXKGtBq4wnJoXx6zk5v+AjXoO0hvwcu0Z53 2QHFeT9LBZ3upnP8JJYDN+tvxxJPRtUWffnaKy3ld4HgPVDM7uiA3wMbypVaXHfHyG 6Rrz+oDu4f51R7ObYLQ48UjCEbXEOdN9y+3s3vH2NJgtc//N+n1HjP/Gt2AePxH/z/ 0WUqiELT2CR+auoxCa5TO03UNotmuwsAesFItrBICRYl3lRdugEmXN7zIeOv6daL17 n0LA1Rdl1vRsw== Received: from johan by xi.lan with local (Exim 4.98.2) (envelope-from ) id 1vOGuJ-000000001K6-2iVt; Wed, 26 Nov 2025 15:54:11 +0100 From: Johan Hovold To: Srinivas Kandagatla Cc: Greg Kroah-Hartman , linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH 4/6] slimbus: core: amend slim_get_device() kernel doc Date: Wed, 26 Nov 2025 15:53:27 +0100 Message-ID: <20251126145329.5022-5-johan@kernel.org> X-Mailer: git-send-email 2.51.2 In-Reply-To: <20251126145329.5022-1-johan@kernel.org> References: <20251126145329.5022-1-johan@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add a comment to clarify that slim_get_device() takes a reference to the embedded struct device of the returned slimbus device. Signed-off-by: Johan Hovold --- drivers/slimbus/core.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/slimbus/core.c b/drivers/slimbus/core.c index b4ab9a5d44b3..9402950e7ebd 100644 --- a/drivers/slimbus/core.c +++ b/drivers/slimbus/core.c @@ -366,6 +366,9 @@ static struct slim_device *find_slim_device(struct slim= _controller *ctrl, * @ctrl: Controller on which this device will be added/queried * @e_addr: Enumeration address of the device to be queried * + * Takes a reference to the embedded struct device which needs to be dropp= ed + * after use. + * * Return: pointer to a device if it has already reported. Creates a new * device and returns pointer to it if the device has not yet enumerated. */ --=20 2.51.2 From nobody Mon Dec 1 22:41:53 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5776F30504C; Wed, 26 Nov 2025 14:54:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764168850; cv=none; b=EbzYKyrFI68Y7affZhYbu454s+Obm0mUrTbcST4+YRhC+xWAn2a4Ejvz78kGWIzGgmLNtqrph4+Y7hdSEtxWUoSLB8xwhyVUB4YI6iOx2fLsVLPt8GpuIWmRz58nIyWjwGU9gjLaYS+UHbbrwwhB1L0QjHN5me+ytsl9MabV5Ww= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764168850; c=relaxed/simple; bh=GE9/tRQbAigOoX2Jm3C6MzvxaRrMJAsG2DD+F2OfW7w=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=nAqD8GNNuTstfmZwhOv2dmTj+DTYcfhwHkJboIbdem1trWZAWZkPiZH7Qj4gTLabLhJeZSzGgdDu05X3atGYdcpVwL/EOuPLEzZVJjXyG+X/q0jHg2jGeb995qljQ2XY/1qZDJg4E/H7M5A+LaDNOn5yqPm7Qjjro7S+Zbh+GZI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=qKgen2bu; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="qKgen2bu" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 188E7C116B1; Wed, 26 Nov 2025 14:54:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1764168850; bh=GE9/tRQbAigOoX2Jm3C6MzvxaRrMJAsG2DD+F2OfW7w=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=qKgen2bu1DVV7aGAC4WL4oifcatzx0KL0lFbbCsJgUMssT+cSTWyWPZWx1Jf3hTg+ 84badzTrqH8KbwBg9QS2JysHKBWNcrNCJEXRyJ0BG+ihfy0lA6S7NSbk3Bazg47aDM 0T+dAm03CXQbW1+URCOL1GDCuZnscZPNg8SPqEKDMrXyPtTpvMOk7gAwdo/Eodopfw RmyatbB3Wyqn+XzTpGTHvv+YYIgf/d7keXLuhitD9Xq6Jm1u1yEYRFK3MB9M5Ad32G xkK0ZByG5yUIvmM+7W3h5BnNrzR97PuP0MEJTXzNcHcm6A7FUaTYVKu7Lam1Jbspqw iDXW5p3+gviQA== Received: from johan by xi.lan with local (Exim 4.98.2) (envelope-from ) id 1vOGuJ-000000001K9-35rj; Wed, 26 Nov 2025 15:54:11 +0100 From: Johan Hovold To: Srinivas Kandagatla Cc: Greg Kroah-Hartman , linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH 5/6] slimbus: core: fix of_slim_get_device() kernel doc Date: Wed, 26 Nov 2025 15:53:28 +0100 Message-ID: <20251126145329.5022-6-johan@kernel.org> X-Mailer: git-send-email 2.51.2 In-Reply-To: <20251126145329.5022-1-johan@kernel.org> References: <20251126145329.5022-1-johan@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Unlike slim_get_device() the of_slim_get_device() helper does not allocate and register any slimbus devices in case lookup fails. Update the of_slim_get_device() kernel doc to reflect this and add a comment about the helper taking a reference to the returned device. Fixes: e0772de8a48b ("slimbus: core: add of_slim_device_get() helper") Signed-off-by: Johan Hovold --- drivers/slimbus/core.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/slimbus/core.c b/drivers/slimbus/core.c index 9402950e7ebd..a2c243e3ad52 100644 --- a/drivers/slimbus/core.c +++ b/drivers/slimbus/core.c @@ -408,11 +408,13 @@ static struct slim_device *of_find_slim_device(struct= slim_controller *ctrl, /** * of_slim_get_device() - get handle to a device using dt node. * - * @ctrl: Controller on which this device will be added/queried + * @ctrl: Controller on which this device will be queried * @np: node pointer to device * - * Return: pointer to a device if it has already reported. Creates a new - * device and returns pointer to it if the device has not yet enumerated. + * Takes a reference to the embedded struct device which needs to be dropp= ed + * after use. + * + * Return: pointer to a device if it has been registered, otherwise NULL. */ struct slim_device *of_slim_get_device(struct slim_controller *ctrl, struct device_node *np) --=20 2.51.2 From nobody Mon Dec 1 22:41:53 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A9846309DCD; Wed, 26 Nov 2025 14:54:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764168850; cv=none; b=ZoScgXGzEEn6ov8wl3WHcdaKQIW8av+Xp+qFR73lnpvtOTa97erZn+iEHhRK5e6c4Y1pKnv7dlW3xMA0JsQP5xdiJvaD/YfDVCTPiO050OEmvD4ujL9k6hyAYGQxv2My2+xOEfXs/F6FdQORhQqqIb1nDf0byL1hRFqLj2xyJ6c= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764168850; c=relaxed/simple; bh=slWTP5BAFKhmyOpFq6S8rFhHy+d8mlfbAi6/HHhx2J4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=KrDiMnBQrmt8U/Fmom7ilhBt+b2Hw+yzHWHrbxySH6GLzMuLbrJJZfIQKkhvToluahlxQMmsXmAX0WiS7NzrqsDzt61HyuMgAzLWHwPopgjYxqjTufjshxnnJKgEreS7B3WYnWzABStxTOcCEswQhelNy2qDpq9jj0gGW2MYgQM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=K7AG7O1O; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="K7AG7O1O" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2A66AC19425; Wed, 26 Nov 2025 14:54:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1764168850; bh=slWTP5BAFKhmyOpFq6S8rFhHy+d8mlfbAi6/HHhx2J4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=K7AG7O1O6IGebiP/OPFKOKrDeDLBH4g5Avbaa5qBuRHsqcGyhYc2k0v7pTWPhfIQe 8/SZl1RJ1Hmx7mK+/9SyUa54xtf8rYVlakVtXxlz3WMEAY7oeyhc23E2IsVcoZtN2C h+BzBhLm2fwdp+xCm1aPbjC8BpnCmonkrKczSbruqoWuMJFkKXIX7xotOf2/bBG9TX 9sOmQfoxnzZwwuOuytJRdtRoVm1XpnO2OCD4GMbcvPVeMWzh0Iakv79LvcU594C1iW KkyPIvXFH3Iu55hybxVOjL6R7a/6Qi7oegkwH/Hpa8rodunVGdLzQ9gMD0VHdl5jYl NC1+VsQarDqnQ== Received: from johan by xi.lan with local (Exim 4.98.2) (envelope-from ) id 1vOGuJ-000000001KE-3VcW; Wed, 26 Nov 2025 15:54:11 +0100 From: Johan Hovold To: Srinivas Kandagatla Cc: Greg Kroah-Hartman , linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH 6/6] slimbus: core: clean up of_slim_get_device() Date: Wed, 26 Nov 2025 15:53:29 +0100 Message-ID: <20251126145329.5022-7-johan@kernel.org> X-Mailer: git-send-email 2.51.2 In-Reply-To: <20251126145329.5022-1-johan@kernel.org> References: <20251126145329.5022-1-johan@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Clean up of_find_slim_device() by folding in the of_find_slim_device() helper. Signed-off-by: Johan Hovold --- drivers/slimbus/core.c | 26 ++++++++++---------------- 1 file changed, 10 insertions(+), 16 deletions(-) diff --git a/drivers/slimbus/core.c b/drivers/slimbus/core.c index a2c243e3ad52..5079d3271ee8 100644 --- a/drivers/slimbus/core.c +++ b/drivers/slimbus/core.c @@ -390,21 +390,6 @@ struct slim_device *slim_get_device(struct slim_contro= ller *ctrl, } EXPORT_SYMBOL_GPL(slim_get_device); =20 -static struct slim_device *of_find_slim_device(struct slim_controller *ctr= l, - struct device_node *np) -{ - struct slim_device *sbdev; - struct device *dev; - - dev =3D device_find_child(ctrl->dev, np, device_match_of_node); - if (dev) { - sbdev =3D to_slim_device(dev); - return sbdev; - } - - return NULL; -} - /** * of_slim_get_device() - get handle to a device using dt node. * @@ -419,7 +404,16 @@ static struct slim_device *of_find_slim_device(struct = slim_controller *ctrl, struct slim_device *of_slim_get_device(struct slim_controller *ctrl, struct device_node *np) { - return of_find_slim_device(ctrl, np); + struct slim_device *sbdev; + struct device *dev; + + dev =3D device_find_child(ctrl->dev, np, device_match_of_node); + if (dev) { + sbdev =3D to_slim_device(dev); + return sbdev; + } + + return NULL; } EXPORT_SYMBOL_GPL(of_slim_get_device); =20 --=20 2.51.2